volt 0.9.3.pre6 → 0.9.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6b47ed7510baf946cc2e65e7140be76022472b53
-  data.tar.gz: cf681b804b8609987671fbf2626aaf399d39bec0
+  metadata.gz: 73635c7ae6b384dcaecd996e5c28bd99773c508d
+  data.tar.gz: 73703d5c1aff47c1ac8d7cd2fa514da542b1ee28
 SHA512:
-  metadata.gz: ffcd6ef512a9b74b519b1b2ee294b8bef5d00075b8052ab6c4cee1375fac9662d2d2991024a469ccb7b8cf3c0e1d7388999dc6e5ff908f1b48a6705e8cef12df
-  data.tar.gz: 811b21c5c24ee684593c7069aba0cd68fad6480b22486c0646f34e67f365b8ab7e0ef36857c0defba4030fc9be243745f27c9a2e8930a7ba6fe58a29afc3dad0
+  metadata.gz: 6faeee73ca44c142b8c88264dd89599d0351a6638b962d5b127aa54656bec4549caa22ba753a3b506a634bb212e3d1ef46175ec68b63c0e21f1bd58b6ebf009d
+  data.tar.gz: 83ef2428fe1b75ae3e7140f0acbb3008a31c22c0643adacabe27844ab3921457eca5bbf7e6370cf5328cd9b113cd3c205266424b82cb9cf267d4cfcb2813f8b0

data/CHANGELOG.md

@@ -1,6 +1,7 @@
 # Change Log
 
-## 0.9.3.pre4
+## 0.9.3
+
 ### Added
 - Added validations block for conditional validation runs
 - you can now set the NO_FORKING=true ENV to prevent using the forking server in development.
@@ -17,6 +18,7 @@
 - You can now use .create to make a new item on a collection.
 - .inspect for models is now cleaner
 - Volt.current_user now works in HttpController's
+- HttpControllers now can take promises in render.
 - You can now add your own middleware to the middleware stack.  (see docs)
 - Added a threadpool for Tasks, and options to customize pool size in config/app.rb
 - Volt now handles Syntax errors much better, it will display an error message when your app does not compile, and can reload from that page when things change. (in development)
@@ -37,6 +39,7 @@
 - Each bindings now support promises.
 - Volt.fetch_current_user has been deprecated and Volt.current_user now returns a promise.
 - Volt.current_user? now returns a promise that yields a boolean
+- Lots of bug fixes. (see github)
 
 ## 0.9.2
 ### Changed

data/lib/volt/cli/generate.rb

@@ -54,7 +54,7 @@ class Generate < Thor
   method_option :name, type: :string, banner: 'The name of the HTTP Controller.'
   method_option :component, type: :string, default: 'main', banner: 'The component the http_controller should be created in.', required: false
   def http_controller(name, component = 'main')
-    name = name.underscore.pluralize + '_controller' unless name =~ /_controller$/
+    name = name.underscore + '_controller' unless name =~ /_controller$/
 
     output_file = Dir.pwd + "/app/#{component}/controllers/server/#{name.underscore}.rb"
     spec_file = Dir.pwd + "/spec/app/#{component.underscore}/controllers/server/#{name}_spec.rb"

data/lib/volt/controllers/http_controller.rb

@@ -22,7 +22,7 @@ module Volt
       @params = Volt::Model.new(request.params.symbolize_keys.merge(params), persistor: Volt::Persistors::Params)
     end
 
-    def perform(action)
+    def perform(action='index')
       filtered = run_actions(:before, action)
       send(action.to_sym) unless filtered
       run_actions(:after, action) unless filtered
@@ -55,6 +55,12 @@ module Volt
     end
 
     def respond
+      unless @response_status
+        # render was not called, show an error
+        @response_body = ['Error: render was not called in controller action']
+        @response_status = 500
+      end
+
       Rack::Response.new(response_body, response_status, response_headers)
     end
 

data/lib/volt/models/array_model.rb

@@ -6,6 +6,8 @@ require 'volt/models/state_helpers'
 require 'volt/data_stores/data_store'
 
 module Volt
+  class RecordNotFoundException < Exception ; end
+
   class ArrayModel < ReactiveArray
     include ModelWrapper
     include ModelHelpers
@@ -114,12 +116,10 @@ module Volt
             model
           end.fail do |err|
             # remove from the collection because it failed to save on the server
-            @array.delete(model)
+            # we don't need to call delete on the server.
+            index = @array.index(model)
+            delete_at(index, true)
 
-            # TODO: the model might be in at a different position already, so we should use a full delete
-            trigger_removed!(@array.size - 1)
-            trigger_size_change!
-            #
             # re-raise, err might not be an Error object, so we use a rejected promise to re-raise
             Promise.new.reject(err)
           end
@@ -161,6 +161,12 @@ module Volt
       end
     end
 
+    # Same as first, except it returns a promise (even on page collection), and
+    # it fails with a RecordNotFoundException if no result is found.
+    def first!
+      fail_not_found_if_nil(first)
+    end
+
     # Return the first item in the collection, or create one if one does not
     # exist yet.
     def first_or_create
@@ -256,7 +262,13 @@ module Volt
     end
 
     def to_json
-      to_a.to_json
+      array = to_a
+
+      if array.is_a?(Promise)
+        array.then(&:to_json)
+      else
+        array.to_json
+      end
     end
 
 
@@ -284,6 +296,17 @@ module Volt
       model
     end
 
+    # Raise a RecordNotFoundException if the promise returns a nil.
+    def fail_not_found_if_nil(promise)
+      promise.then do |val|
+        if val
+          val
+        else
+          raise RecordNotFoundException.new
+        end
+      end
+    end
+
     # We need to setup the proxy methods below where they are defined.
     proxy_with_load :[], :size, :last, :reverse, :all, :to_a
 

data/lib/volt/reactive/reactive_array.rb

@@ -122,7 +122,7 @@ module Volt
 
     alias_method :length, :size
 
-    def delete_at(index)
+    def delete_at(index, skip_persistor=false)
       size = @array.size
       # Handle a negative index
       index = size + index if index < 0
@@ -143,7 +143,7 @@ module Volt
 
       trigger_size_change!
 
-      @persistor.removed(model) if @persistor
+      @persistor.removed(model) if @persistor && !skip_persistor
 
       model
     end

data/lib/volt/server/rack/http_response_renderer.rb

@@ -30,12 +30,18 @@ module Volt
           renderer = self.class.renderers[renderer_name]
           to_render = content.delete(renderer_name)
           rendered = renderer[:proc].call(to_render)
+
+          # Unwrap a promise if we got one back
+          if rendered.is_a?(Promise)
+            rendered = rendered.sync
+          end
+
           return [rendered, content.merge(content_type: renderer[:content_type])]
         end
       end
 
       # If we couldn't find a renderer - just render an empty string
-      ['', content_type: 'text/plain']
+      ["Error: render only supports #{self.class.renderers.keys.join(', ')}", content_type: 'text/plain']
     end
   end
 end

data/lib/volt/server/rack/quiet_common_logger.rb

@@ -16,9 +16,11 @@ class QuietCommonLogger < Rack::CommonLogger
       ext = nil
     end
 
+    @logged = false
+
     body = BodyProxy.new(body) do
       # Don't log on ignored extensions
-      unless @@ignore_extensions.include?(ext)
+      if !@@ignore_extensions.include?(ext) && !@logged
         log(env, status, header, began_at)
       end
     end
@@ -26,6 +28,7 @@ class QuietCommonLogger < Rack::CommonLogger
     # Because of web sockets, the initial request doesn't finish, so we
     # can just trigger it now.
     unless ext || path.start_with?('/channel')
+      @logged = true
       log(env, status, header, began_at)
     end
 

data/lib/volt/utils/promise_extensions.rb

@@ -78,6 +78,11 @@ class Promise
     end
   end
 
+  # Forward to resolved value
+  def to_json(*args, &block)
+    self.then {|v| v.to_json(*args, &block) }
+  end
+
 
 
   # Waits for the promise to resolve (assuming it is blocking on

data/lib/volt/version.rb

@@ -1,5 +1,5 @@
 module Volt
   module Version
-    STRING = '0.9.3.pre6'
+    STRING = '0.9.3'
   end
 end

data/spec/server/rack/http_response_renderer_spec.rb

@@ -17,9 +17,9 @@ describe Volt::HttpResponseRenderer do
     expect(additional_headers[:content_type]).to eq('text/plain')
   end
 
-  it 'should default to text/plain if no suitable renderer could be found' do
+  it 'should give renderer error if no suitable renderer could be found' do
     body, additional_headers = renderer.render(some: 'text')
-    expect(body).to eq('')
+    expect(body).to eq('Error: render only supports json, text')
     expect(additional_headers[:content_type]).to eq('text/plain')
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: volt
 version: !ruby/object:Gem::Version
-  version: 0.9.3.pre6
+  version: 0.9.3
 platform: ruby
 authors:
 - Ryan Stout
@@ -828,9 +828,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '2.1'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.4.5