volt 0.9.2 → 0.9.3.pre1

data/spec/apps/kitchen_sink/app/main/views/main/bindings.html

@@ -113,6 +113,26 @@
     </tr>
   </table>
 
+  <h2>If Bindings</h2>
+  <p id='ifbinding'>
+    {{ if page._show && true }}
+    <span>If _show</span>
+    {{ else }}
+    <span>If false _show</span>
+    {{ end }}
+  </p>
+
+  <h2>Unless Bindings</h2>
+  <p id='unlessbinding'>
+    {{ unless page._show && true }}
+    <span>Unless _show</span>
+    {{ else }}
+    <span>Unless false _show</span>
+    {{ end }}
+  </p>
+
+  <a id='showtrue' e-click='set_show(true)'>set _show true</a>
+  <a id='showfalse' e-click='set_show(false)'>set _show false</a>
 
   <h2>Content</h2>
 

data/spec/apps/kitchen_sink/app/main/views/main/form.html

@@ -0,0 +1,73 @@
+<:Title>
+  Form
+
+<:Body>
+  <h1>Form Example</h1>
+  <h2 id='title'></h2>
+
+  <form role="form">
+    <div class="form-group">
+      <label>Name</label>
+      <span id='name-display'>{{ _name }}</span>
+      <label>Location</label>
+      <span id='location-display'>{{ _location }}</span>
+    </div>
+    <input class="form-control" id="name" type="hidden" value="{{ _name }}" />
+    <div class="form-group">
+      <label>Location</label>
+      <select id='location' value='{{ _location }}'>
+        <option value="">State</option>
+        <option value="AL">Alabama</option>
+        <option value="AK">Alaska</option>
+        <option value="AZ">Arizona</option>
+        <option value="AR">Arkansas</option>
+        <option value="CA">California</option>
+        <option value="CO">Colorado</option>
+        <option value="CT">Connecticut</option>
+        <option value="DE">Delaware</option>
+        <option value="DC">District Of Columbia</option>
+        <option value="FL">Florida</option>
+        <option value="GA">Georgia</option>
+        <option value="HI">Hawaii</option>
+        <option value="ID">Idaho</option>
+        <option value="IL">Illinois</option>
+        <option value="IN">Indiana</option>
+        <option value="IA">Iowa</option>
+        <option value="KS">Kansas</option>
+        <option value="KY">Kentucky</option>
+        <option value="LA">Louisiana</option>
+        <option value="ME">Maine</option>
+        <option value="MD">Maryland</option>
+        <option value="MA">Massachusetts</option>
+        <option value="MI">Michigan</option>
+        <option value="MN">Minnesota</option>
+        <option value="MS">Mississippi</option>
+        <option value="MO">Missouri</option>
+        <option value="MT">Montana</option>
+        <option value="NE">Nebraska</option>
+        <option value="NV">Nevada</option>
+        <option value="NH">New Hampshire</option>
+        <option value="NJ">New Jersey</option>
+        <option value="NM">New Mexico</option>
+        <option value="NY">New York</option>
+        <option value="NC">North Carolina</option>
+        <option value="ND">North Dakota</option>
+        <option value="OH">Ohio</option>
+        <option value="OK">Oklahoma</option>
+        <option value="OR">Oregon</option>
+        <option value="PA">Pennsylvania</option>
+        <option value="RI">Rhode Island</option>
+        <option value="SC">South Carolina</option>
+        <option value="SD">South Dakota</option>
+        <option value="TN">Tennessee</option>
+        <option value="TX">Texas</option>
+        <option value="UT">Utah</option>
+        <option value="VT">Vermont</option>
+        <option value="VA">Virginia</option>
+        <option value="WA">Washington</option>
+        <option value="WV">West Virginia</option>
+        <option value="WI">Wisconsin</option>
+        <option value="WY">Wyoming</option>
+      </select>
+    </div>
+  </form>

data/spec/apps/kitchen_sink/app/main/views/main/main.html

@@ -6,6 +6,7 @@
     <div class="header">
       <ul class="nav nav-pills pull-right">
         <:nav href="/" text="Home" />
+        <:nav href="/form" text="Form" />
         <:nav href="/bindings" text="Bindings" />
         <:nav href="/todos" text="Todos" />
         <:nav href="/flash" text="Flash" />

data/spec/integration/bindings_spec.rb

@@ -186,6 +186,24 @@ describe 'bindings test', type: :feature, sauce: true do
     end
   end
 
+  describe 'if/unless binding' do
+    it 'should show corret text' do
+      visit '/'
+
+      click_link 'Bindings'
+
+      click_on 'showtrue'
+
+      expect(find('#ifbinding')).to have_content('If _show')
+      expect(find('#unlessbinding')).to have_content('Unless false _show')
+
+      click_on 'showfalse'
+
+      expect(find('#ifbinding')).to have_content('If false _show')
+      expect(find('#unlessbinding')).to have_content('Unless _show')
+    end
+  end
+
   describe 'content escaping' do
     it 'should escape in a tripple stash' do
       visit '/'
@@ -195,4 +213,19 @@ describe 'bindings test', type: :feature, sauce: true do
       expect(find('#escapeContent')).to have_content('this is {{escaped}}')
     end
   end
+
+  if ENV['BROWSER'] != 'phantom'
+    describe 'input hidden and select' do
+      it 'should display binding value' do
+        visit '/'
+
+        click_link 'Form'
+
+        expect(find('body')).to have_content('Form Example')
+        expect(find('#title')).to have_content('form_ready')
+        expect(find('#name-display')).to have_content('Test')
+        expect(find('#location-display')).to have_content('AL')
+      end
+    end
+  end
 end

data/spec/integration/user_spec.rb

@@ -19,27 +19,6 @@ describe 'user accounts', type: :feature, sauce: true do
     expect(page).to have_content('Test Account 9550')
   end
 
-  it 'should login and logout' do
-    visit '/'
-
-    # Add the user
-    store._users! << { email: 'test@test.com', password: 'awes0mesEcRet', name: 'Test Account 9550' }
-
-    click_link 'Login'
-
-    fields = all(:css, 'form .form-control')
-    fields[0].set('test@test.com')
-    fields[1].set('awes0mesEcRet')
-    click_button 'Login'
-
-    expect(page).to have_content('Test Account 9550')
-
-    # Click the logout link
-    click_link 'Test Account 9550'
-    click_link 'Logout'
-
-    expect(page).to_not have_content('Test Account 9550')
-  end
 
   it 'should fail to create an account without a valid email and password' do
     visit '/'
@@ -60,4 +39,55 @@ describe 'user accounts', type: :feature, sauce: true do
 
     expect(page).to have_content('must be at least 8 characters')
   end
+
+  describe "with a user" do
+    before do
+        # Add the user
+        store._users! << { email: 'test@test.com', password: 'awes0mesEcRet', name: 'Test Account 9550' }
+    end
+
+    it 'should login and logout' do
+      visit '/'
+
+      click_link 'Login'
+
+      fields = all(:css, 'form .form-control')
+      fields[0].set('test@test.com')
+      fields[1].set('awes0mesEcRet')
+      click_button 'Login'
+
+      expect(page).to have_content('Test Account 9550')
+
+      # Click the logout link
+      click_link 'Test Account 9550'
+      click_link 'Logout'
+
+      expect(page).to_not have_content('Test Account 9550')
+    end
+
+    it 'should show an error for invalid email' do
+      visit '/'
+      click_link 'Login'
+
+      fields = all(:css, 'form .form-control')
+      fields[0].set('notausersemail@gmail.com')
+      fields[1].set('awes0mesEcRet')
+      click_button 'Login'
+
+      expect(page).to have_content('User could not be found')
+    end
+
+    it 'should show an error for an invalid password' do
+      visit '/'
+      click_link 'Login'
+
+      fields = all(:css, 'form .form-control')
+      fields[0].set('test@test.com')
+      fields[1].set('wrongpassword')
+      click_button 'Login'
+
+      expect(page).to have_content('Password did not match')
+    end
+  end
+
 end

data/spec/models/associations_spec.rb

@@ -30,5 +30,13 @@ describe Volt::Associations do
       expect(addresses.size).to eq(2)
       expect(addresses[0]._city).to eq('Bozeman')
     end
+
+    it 'warns users if persistor is not a ModelStore' do
+      store = Volt::Model.new({}, persistor: Volt::Persistors::Flash)
+      expect do
+        store.send(:association_with_root_model, :blah)
+      end.to raise_error("blah currently only works on the store collection "\
+                         "(support for other collections coming soon)")
+    end
   end
 end

data/spec/models/model_spec.rb

@@ -13,6 +13,13 @@ class TestAssignsMethod < Volt::Model
 end
 
 describe Volt::Model do
+  it 'delegates unary operator to its attributes' do
+    model = Volt::Model.new
+    expect(!model).to eq(!model.attributes)
+    model = Volt::Model.new(has: 'attrs')
+    expect(!model).to eq(!model.attributes)
+  end
+
   it 'should allow _ methods to be used to store values without predefining them' do
     a = Volt::Model.new
     a._stash = 'yes'

data/spec/models/user_spec.rb

@@ -60,8 +60,28 @@ describe Volt::User do
           expect(user._hashed_password).to eq 'hashed-password'
         end
       end
+
+      it 'should allow updates without validating the password' do
+        bob = store._users.buffer(name: 'Bob', email: 'bob@bob.com', password: '39sdjkdf932jklsd')
+        bob.save!
+
+        expect(bob._password).to eq(nil)
+
+        bob_buf = bob.buffer
+
+        bob_buf._name = 'Jimmy'
+
+        saved = false
+        bob_buf.save! do
+          saved = true
+        end
+
+        expect(saved).to eq(true)
+      end
     end
 
+
+
     describe 'when it is not a Volt server' do
       before do
         allow(Volt).to receive(:server?).and_return false

data/spec/models/validations_spec.rb

@@ -15,6 +15,7 @@ describe Volt::Model do
     end
   end
 
+
   let(:test_model_with_promises) do
     Class.new(Volt::Model) do
       attr_accessor :ran_promise
@@ -41,7 +42,6 @@ describe Volt::Model do
 
   it 'should show all fields in marked errors once saved' do
     buffer = model.buffer
-
     buffer.save!
 
     expect(buffer.marked_errors.keys).to eq(
@@ -164,4 +164,5 @@ describe Volt::Model do
     model._name = 'ok' # fails again
     expect(model._name).to eq('Jimmy')
   end
+
 end

data/spec/models/validators/block_validations_spec.rb

@@ -0,0 +1,53 @@
+require 'spec_helper'
+
+unless RUBY_PLATFORM == 'opal'
+  describe 'validations block' do
+    let(:model) { test_model_class.new }
+
+    let(:test_model_class) do
+      Class.new(Volt::Model) do
+        validations do
+          if _is_ready == true
+            validate :name, length: 5
+          end
+        end
+      end
+    end
+
+    let(:test_model_action_pass_class) do
+      Class.new(Volt::Model) do
+        validations do |action|
+          # Only validation the name on update
+          if action == :update
+            validate :name, length: 5
+          end
+        end
+      end
+    end
+
+    it 'should run conditional validations in the validations block' do
+      a = test_model_class.new(name: 'Jo')
+
+      a.validate!.sync
+      expect(a.errors.size).to eq(0)
+
+      a._is_ready = true
+      a.validate!.sync
+
+      expect(a.errors.size).to eq(1)
+    end
+
+    it 'should send the action name to the validations block' do
+      jo = test_model_action_pass_class.new(name: 'Jo')
+
+      jo.validate!.sync
+      expect(jo.errors.size).to eq(0)
+
+      store._people << jo
+
+      jo.validate!.sync
+      expect(jo.errors.size).to eq(1)
+
+    end
+  end
+end

data/spec/page/bindings/template_binding/view_lookup_for_path_spec.rb

@@ -140,4 +140,14 @@ describe Volt::ViewBinding do
 
     expect(@view_lookup.path_for_template('nav', 'title').first).to eq('nav/main/index/title')
   end
+
+  it 'should return nils when given a non-existant path' do
+    @templates = {
+      'nav/main/index/title' => '',
+      'auth/login/new/title' => ''
+    }
+
+    expect(@view_lookup.path_for_template('not/a/real/item/')).to eq([nil, nil])
+  end
+    
 end

data/spec/page/path_string_renderer_spec.rb

@@ -18,5 +18,11 @@ unless RUBY_PLATFORM == 'opal'
       html = Volt::PathStringRenderer.new('main/mailers/welcome/html', { name: 'Jimmy' }, @page).html
       expect(html).to eq("\n  <h1>Welcome Jimmy</h1>\n\n  <p>Glad you signed up!</p>\n\n")
     end
+
+    it 'Raises raises ViewLookupException if full_path is nil' do
+      expect do
+        Volt::PathStringRenderer.new('', { name: 'Jimmy' }, Volt::Page.new).html
+      end.to raise_error(Volt::ViewLookupException)
+    end
   end
 end

data/spec/reactive/eventable_spec.rb

@@ -3,6 +3,15 @@ require 'volt/reactive/eventable'
 
 class TestEventable
   include Volt::Eventable
+  attr_reader :events_removed
+
+  def initialize
+    @events_removed = []
+  end
+
+  def event_removed(event, last, last_for_event)
+    @events_removed.push(event => [last, last_for_event])
+  end
 
   def trigger_works_event!
     trigger!('works', 20)
@@ -10,9 +19,9 @@ class TestEventable
 end
 
 describe Volt::Eventable do
-  it 'should allow events to be bound with on' do
-    test_eventable = TestEventable.new
+  let(:test_eventable) { TestEventable.new }
 
+  it 'should allow events to be bound with on' do
     count = 0
     test_eventable.on('works') do |val|
       count += 1
@@ -25,8 +34,6 @@ describe Volt::Eventable do
   end
 
   it 'should allow events to be removed with .remove' do
-    test_eventable = TestEventable.new
-
     count = 0
     listener = test_eventable.on('works') do
       count += 1
@@ -47,8 +54,6 @@ describe Volt::Eventable do
   end
 
   it 'should allow multiple events' do
-    test_eventable = TestEventable.new
-
     called = false
     listener = test_eventable.on(:broken, :works) do |arg|
       expect(arg).to eq(20)
@@ -66,4 +71,17 @@ describe Volt::Eventable do
     test_eventable.trigger_works_event!
     expect(called).to eq(false)
   end
+
+  it 'Shows object ID and events when inspected' do
+    tested = TestEventable.new.on("test") { nil }
+    inspected = tested.inspect
+    expect(inspected).to include(tested.object_id.to_s)
+    expect(inspected).to include(tested.events.first.to_s)
+  end
+
+  it 'calls event_removed on the class included on removal of event' do
+    listener = test_eventable.on("test") { nil }
+    listener.remove
+    expect(test_eventable.events_removed).to include(test: [true, true])
+  end
 end