volt 0.9.1.pre2 → 0.9.1.pre3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ad2f798ba0d81a985f87b8ff96e53b84797644c8
-  data.tar.gz: 9b71d94cfc22e7ac63e51dfa0375d33759f5ecfd
+  metadata.gz: dc7e6af465488d4433ccb709514b3f805ad16cc7
+  data.tar.gz: 25cbe6bf32e904f35db51bd8d2b5b4822a1d81cd
 SHA512:
-  metadata.gz: 0ac6eadbc636ff75bf155cb6babf498499c70c81526b758a6028d8b2d315262e190bf7ddcd27d524c5bfa2f4b0d1205d7cfb85413436fa94862f40a33c7bdc99
-  data.tar.gz: d8cebc99bc26b65ecd9df5f5826f8d2d4e696f00e859f294db53510bbc4936436866f1a0b9d12f5f62dabf6adaa8a1da43691a80f54f18b7a96bf632b678e977
+  metadata.gz: f21a61b49bf832d0f234271dcaa247401c80e43d4754fed3fcc49b17cfb61bb68f5aa1283379256449a0f1c881b1f80a59f1709387acecb172443f45b16c9220
+  data.tar.gz: c51891e601da7711ebc8324fcfa5d89f2d5b5524017b09ceeab9fa20a44a7cec36a9b98af3e9d4bad380e6140c8e1b6cbd0bd7588ea91fbc002d84d86bfdab6d

data/CHANGELOG.md

@@ -2,11 +2,13 @@
 
 ## 0.9.1
 ### Changed
+- All code in ```app``` is now automatically reloaded when any files change.  This is done through a "preforking" server.  Before your apps code is loaded (and after Volt's is), the server forks a child process to handle the request (in dev and test mode).
 - Corrected the name of StringTemplateRender to StringTemplateRenderer
 - Volt now uses faye-websocket for socket connections.  This means we can run on any rack-hijack server supported by faye-websocket.  Currently Volt is tested with thin and puma.  (Note: Thin will probably have better performance since it is evented, which means it doesn't need a thread per connection)  More servers coming soon.
 - fixed issue with the unique validation.
 - made it so <:SectionName> can be accessed by <:section_name /> tag
 - fixed issue with if bindings not resolving some promises.
+- fixed issue with require's in controllers.
 
 ## 0.9.0
 ### Added

data/VERSION

@@ -1 +1 @@
-0.9.1.pre2
+0.9.1.pre3

data/lib/volt/cli/asset_compile.rb

@@ -16,6 +16,7 @@ module Volt
       require 'opal'
       require 'rack'
       require 'volt'
+      require 'volt/volt/core'
       require 'volt/boot'
 
 
@@ -71,7 +72,6 @@ module Volt
       path = "#{@root_path}/public/assets/#{logical_path}"
 
       begin
-        puts "LP: #{logical_path.inspect}"
         content = @opal_files.environment[logical_path].to_s
         write_file(path, content)
       rescue Sprockets::FileNotFound, SyntaxError => e

data/lib/volt/page/channel.rb

@@ -28,7 +28,13 @@ module Volt
 
     def connect!
       %x{
-        this.socket = new WebSocket('ws://' + document.location.host + '/socket');
+        if (document.location.protocol == 'https:') {
+          var wsProto = 'wss';
+        } else {
+          var wsProto = 'ws';
+        }
+
+        this.socket = new WebSocket(wsProto + '://' + document.location.host + '/socket');
 
         this.socket.onopen = function () {
           self.$opened();

data/lib/volt/server/forking_server.rb

@@ -142,8 +142,18 @@ module Volt
       end
     end
 
-    def reload
-      Volt.logger.log_with_color('file changed, sending reload', :light_blue)
+    def reload(changed_files)
+      # only reload the server code if a non-view file was changed
+      server_code_changed = changed_files.any? {|path| File.extname(path) == '.rb' }
+
+      msg = 'file changed, reloading'
+      if server_code_changed
+        msg << ' server and'
+      end
+      msg << ' client...'
+
+      Volt.logger.log_with_color(msg, :light_blue)
+
       begin
         SocketConnectionHandler.send_message_all(nil, 'reload')
       rescue => e
@@ -151,9 +161,11 @@ module Volt
         Volt.logger.error(e)
       end
 
-      @child_lock.with_write_lock do
-        stop_child
-        start_child
+      if server_code_changed
+        @child_lock.with_write_lock do
+          stop_child
+          start_child
+        end
       end
     end
 
@@ -162,7 +174,7 @@ module Volt
       @listener = Listen.to("#{@server.app_path}/") do |modified, added, removed|
         Thread.new do
           # Run the reload in a new thread
-          reload
+          reload(modified + added + removed)
         end
       end
       @listener.start

data/lib/volt/server.rb

@@ -76,7 +76,14 @@ module Volt
       # Handle websocket connections
       app.use WebsocketHandler
 
-      if Volt.env.production? || Volt.env.test?
+      can_fork = Process.respond_to?(:fork)
+
+      unless can_fork
+        Volt.logger.warn('Code reloading in Volt currently depends on `fork`.  Your environment does not support `fork`.  We\'re working on adding more reloading strategies.  For now though you\'ll need to restart the server manually on changes, which sucks.  Feel free to complain to the devs, we really let you down here. :-)')
+      end
+
+      # Only run ForkingServer if fork is supported in this env.
+      if !can_fork || Volt.env.production? || Volt.env.test?
         # In production/test, we boot the app and run the server
         #
         # Sometimes the app is already booted, so we can skip if it is

data/lib/volt/volt/app.rb

@@ -37,7 +37,7 @@ module Volt
           Dir["#{app_folder}/*/controllers/server/*.rb"].each do |ruby_file|
             #path = ruby_file.gsub(/^#{app_folder}\//, '')[0..-4]
             #require(path)
-            load ruby_file
+            require(ruby_file)
           end
         end
       end

data/spec/apps/kitchen_sink/app/main/config/routes.rb

@@ -10,6 +10,7 @@ client '/first_last', action: 'first_last'
 client '/todos', controller: 'todos'
 client '/html_safe', action: 'html_safe'
 client '/missing', action: 'missing'
+client '/require_test', action: 'require_test'
 
 # Signup/login routes
 client '/signup', component: 'user_templates', controller: 'signup'

data/spec/apps/kitchen_sink/app/main/controllers/main_controller.rb

@@ -1,3 +1,6 @@
+# Require date for require test
+require 'date'
+
 module Main
   class MainController < Volt::ModelController
     model :page

data/spec/apps/kitchen_sink/app/main/views/main/require_test.html

@@ -0,0 +1,7 @@
+<:Title>
+  Require Test
+
+<:Body>
+  <h1>Require Test</h1>
+
+  <p>Date Class: {{ Date.respond_to?(:today).inspect }}</p>

data/spec/integration/client_require_spec.rb

@@ -0,0 +1,9 @@
+require 'spec_helper'
+
+describe 'client require', type: :feature, sauce: true do
+  it 'should require code in controllers' do
+    visit '/require_test'
+
+    expect(page).to have_content('Date Class: true')
+  end
+end

data/spec/models/validators/unique_validator_spec.rb

@@ -0,0 +1,26 @@
+require 'spec_helper'
+
+unless RUBY_PLATFORM == 'opal'
+  class Fridge < Volt::Model
+    validate :name, unique: true
+  end
+
+
+  describe 'unique spec' do
+    it 'should reject save if there are records with existing attributes already' do
+      store._fridges << { name: 'swift' }
+      fridge = store._fridges.buffer name: 'swift'
+      fridge.save!.then do
+        expect(false).to be_true
+      end.fail do
+        expect(true).to be_true
+      end
+    end
+
+    it 'should not increase count of the total records in the store' do
+      store._fridges << { name: 'swift' }
+      store._fridges << { name: 'swift' }
+      expect(store._fridges.count).to eq(1)
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: volt
 version: !ruby/object:Gem::Version
-  version: 0.9.1.pre2
+  version: 0.9.1.pre3
 platform: ruby
 authors:
 - Ryan Stout
@@ -701,6 +701,7 @@ files:
 - spec/apps/kitchen_sink/app/main/views/main/index.html
 - spec/apps/kitchen_sink/app/main/views/main/main.html
 - spec/apps/kitchen_sink/app/main/views/main/missing.html
+- spec/apps/kitchen_sink/app/main/views/main/require_test.html
 - spec/apps/kitchen_sink/app/main/views/main/store.html
 - spec/apps/kitchen_sink/app/main/views/main/yield.html
 - spec/apps/kitchen_sink/app/main/views/todos/index.html
@@ -723,6 +724,7 @@ files:
 - spec/extra_core/string_transformations_spec.rb
 - spec/extra_core/symbol_spec.rb
 - spec/integration/bindings_spec.rb
+- spec/integration/client_require_spec.rb
 - spec/integration/cookies_spec.rb
 - spec/integration/first_last_spec.rb
 - spec/integration/flash_spec.rb
@@ -751,6 +753,7 @@ files:
 - spec/models/validators/length_validator_spec.rb
 - spec/models/validators/phone_number_validator_spec.rb
 - spec/models/validators/shared_examples_for_validators.rb
+- spec/models/validators/unique_validator_spec.rb
 - spec/page/bindings/content_binding_spec.rb
 - spec/page/bindings/template_binding/view_lookup_for_path_spec.rb
 - spec/page/bindings/template_binding_spec.rb
@@ -910,6 +913,7 @@ test_files:
 - spec/apps/kitchen_sink/app/main/views/main/index.html
 - spec/apps/kitchen_sink/app/main/views/main/main.html
 - spec/apps/kitchen_sink/app/main/views/main/missing.html
+- spec/apps/kitchen_sink/app/main/views/main/require_test.html
 - spec/apps/kitchen_sink/app/main/views/main/store.html
 - spec/apps/kitchen_sink/app/main/views/main/yield.html
 - spec/apps/kitchen_sink/app/main/views/todos/index.html
@@ -932,6 +936,7 @@ test_files:
 - spec/extra_core/string_transformations_spec.rb
 - spec/extra_core/symbol_spec.rb
 - spec/integration/bindings_spec.rb
+- spec/integration/client_require_spec.rb
 - spec/integration/cookies_spec.rb
 - spec/integration/first_last_spec.rb
 - spec/integration/flash_spec.rb
@@ -960,6 +965,7 @@ test_files:
 - spec/models/validators/length_validator_spec.rb
 - spec/models/validators/phone_number_validator_spec.rb
 - spec/models/validators/shared_examples_for_validators.rb
+- spec/models/validators/unique_validator_spec.rb
 - spec/page/bindings/content_binding_spec.rb
 - spec/page/bindings/template_binding/view_lookup_for_path_spec.rb
 - spec/page/bindings/template_binding_spec.rb