volksbanker 1.0.2 → 1.0.3

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 22e6e328e0bfa159540169e32d857c8fe5eb7f2c
+  data.tar.gz: 865a5875ad3f2a1f9fa324286acafba317a770e2
+SHA512:
+  metadata.gz: b790e95f650e592e63afd56f6bf705223962affa556484f4040450ec12f6fbb484dcfd0f8670fe3a2658fafd03eb8af9c5cf25b31953a4abb46d7745f013ebce
+  data.tar.gz: 938d92781e35c6a69cc0ed0fca1db533d087acbe0f3559bffba5dbfe28dd41d7f63305c7b36b37b17dae2f9a4273a037b416dcf110fc14f474c47ccb6564fa4e

data/.gitignore

@@ -2,3 +2,4 @@
 .bundle
 Gemfile.lock
 pkg/*
+TODO.md

data/bin/rake

@@ -0,0 +1,16 @@
+#!/usr/bin/env ruby
+#
+# This file was generated by Bundler.
+#
+# The application 'rake' is installed as part of a gem, and
+# this file is here to facilitate running it.
+#
+
+require 'pathname'
+ENV['BUNDLE_GEMFILE'] ||= File.expand_path("../../Gemfile",
+  Pathname.new(__FILE__).realpath)
+
+require 'rubygems'
+require 'bundler/setup'
+
+load Gem.bin_path('rake', 'rake')

data/bin/vb

@@ -1,4 +1,4 @@
-#!/usr/bin/env ruby-local-exec
+#!/usr/bin/env ruby
 
 lib_dir = File.join File.dirname(__FILE__), '..', 'lib'
 $LOAD_PATH.unshift lib_dir

data/lib/volksbanker/cli.rb

@@ -7,13 +7,16 @@ module Volksbanker
     def self.run(volksbank_file)
       reader = VolksbankFileReader.new volksbank_file
       reader.each_line_item do |vli|
-        unless vli.currency == 'EUR'
-          $stderr.puts "Skipping non-EUR currency line item: #{vli.inspect}"
-          next
-        end
         ali = AmexLineItem.new vli.posting_date, vli.value, description_for(vli)
-        CSV { |out| out << [ali.date, ali.amount, ali.description] }
+        case ali.description
+        when 'Anfangssaldo'; @opening_balance = pretty_amount(ali.amount, vli.currency)
+        when 'Endsaldo';     @closing_balance = pretty_amount(ali.amount, vli.currency)
+        else
+          CSV { |out| out << [ali.date, ali.amount, ali.description] }
+        end
       end
+      $stderr.puts "opening balance: #{@opening_balance}"
+      $stderr.puts "closing balance: #{@closing_balance}"
     end
 
     private
@@ -23,6 +26,10 @@ module Volksbanker
       desc += " (#{volksbank_line_item.recipient_or_payer})" unless volksbank_line_item.recipient_or_payer.nil?
       desc
     end
+
+    def self.pretty_amount(amount, currency)
+      "#{'%.2f' % amount} #{currency}"
+    end
   end
 
 end

data/lib/volksbanker/version.rb

@@ -1,3 +1,3 @@
 module Volksbanker
-  VERSION = '1.0.2'
+  VERSION = '1.0.3'
 end

data/lib/volksbanker/volksbank_file_reader.rb

@@ -40,9 +40,10 @@ module Volksbanker
         next if header
 
         line.chomp!
-        break if line.empty?  # stop before footer
 
-        yield VolksbankLineItem.new_from_csv line rescue $stderr.puts "Problem with #{line}: #{$!}"
+        unless line.empty?
+          yield VolksbankLineItem.new_from_csv line rescue $stderr.puts "Problem with #{line}: #{$!}"
+        end
       end
     end
 

data/lib/volksbanker/volksbank_line_item.rb

@@ -16,8 +16,15 @@ class VolksbankLineItem
     @recipient_or_payer = recipient_or_payer
     @account_number     = account_number
     @sort_code          = sort_code
+
     @description        = description
     @currency           = currency
+    # The opening and closing balance lines switch the currency and description fields.
+    if %w[ Anfangssaldo Endsaldo ].include? currency
+      @description = currency
+      @currency = description
+    end
+
     amt = parse_number amount
     @value = credit?(credit_or_debit) ? amt : (amt * -1)
   end
@@ -29,7 +36,7 @@ class VolksbankLineItem
   private
 
   def parse_date(str)
-    Date.strptime str, DATE_FORMAT
+    Date.strptime str, DATE_FORMAT if str
   end
 
   def parse_number(str)

data/test/cli_test.rb

@@ -5,29 +5,20 @@ require 'volksbanker/cli'
 class CliTest < MiniTest::Unit::TestCase
 
   def test_happy_path
-    expected_stdout = read_fixture 'result.csv'
-    expected_stderr = ''
+    expected_stdout = read_fixture 'result.stdout.csv'
+    expected_stderr = read_fixture 'result.stderr.csv'
 
     assert_output expected_stdout, expected_stderr do
       Volksbanker::Cli.run fixture('transactions.csv')
     end
   end
 
-  def test_skips_non_euro_line_items
-    out, err = capture_io do
-      Volksbanker::Cli.run fixture('transactions-with-non-euro.csv')
-    end
-
-    refute_match %r{30/07/2012}m, out
-    assert_match /Skipping/, err
-  end
-
   def test_handles_line_feed_shenanigans
     out, err = capture_io do
       Volksbanker::Cli.run fixture('newlines.csv')
     end
 
-    assert_equal '', err
+    assert_equal read_fixture('newlines.stderr.csv'), err
   end
 
 end

data/test/fixtures/newlines.stderr.csv

@@ -0,0 +1,2 @@
+opening balance: 1234.56 EUR
+closing balance: 3456.67 EUR

data/test/fixtures/result.stderr.csv

@@ -0,0 +1,2 @@
+opening balance: 0.00 EUR
+closing balance: 2729.50 EUR

metadata

@@ -1,40 +1,44 @@
 --- !ruby/object:Gem::Specification
 name: volksbanker
 version: !ruby/object:Gem::Version
-  version: 1.0.2
-  prerelease: 
+  version: 1.0.3
 platform: ruby
 authors:
 - Andy Stewart
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-10-08 00:00:00.000000000 Z
+date: 2014-10-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &2164669360 !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.9.2
   type: :development
   prerelease: false
-  version_requirements: *2164669360
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.9.2
 description: Prepares Volksbank's electronic statements for upload to Freeagent.
 email:
 - boss@airbladesoftware.com
 executables:
+- rake
 - vb
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
+- ".gitignore"
 - CHANGELOG.md
 - Gemfile
 - README.md
 - Rakefile
+- bin/rake
 - bin/vb
 - lib/volksbanker.rb
 - lib/volksbanker/amex_line_item.rb
@@ -44,45 +48,40 @@ files:
 - lib/volksbanker/volksbank_line_item.rb
 - test/cli_test.rb
 - test/fixtures/newlines.csv
-- test/fixtures/result.csv
-- test/fixtures/transactions-with-non-euro.csv
+- test/fixtures/newlines.stderr.csv
+- test/fixtures/result.stderr.csv
+- test/fixtures/result.stdout.csv
 - test/fixtures/transactions.csv
 - test/test_helper.rb
 - volksbanker.gemspec
 homepage: ''
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: -982126049656369425
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: -982126049656369425
 requirements: []
 rubyforge_project: volksbanker
-rubygems_version: 1.8.11
+rubygems_version: 2.2.2
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Prepares Volksbank's electronic statements for upload to Freeagent.
 test_files:
 - test/cli_test.rb
 - test/fixtures/newlines.csv
-- test/fixtures/result.csv
-- test/fixtures/transactions-with-non-euro.csv
+- test/fixtures/newlines.stderr.csv
+- test/fixtures/result.stderr.csv
+- test/fixtures/result.stdout.csv
 - test/fixtures/transactions.csv
 - test/test_helper.rb

data/test/fixtures/transactions-with-non-euro.csv

@@ -1,32 +0,0 @@
-"Volksbank Rhein-Wehra eG"
-
-"Umsatzanzeige"
-
-"BLZ:";"68490000";;"Datum:";"13.08.2012"
-"Konto:";"12345678";;"Uhrzeit:";"11:54:07"
-"Abfrage von:";"Joe Bloggs";;"Kontoinhaber:";"Foo GmbH"
-
-"Zeitraum:";"4 Wochen";"von:";;"bis:";
-"Betrag in EUR:";;"von:";" ";"bis:";" "
-"Sortiert nach:";"Buchungstag";"absteigend"
-
-"Buchungstag";"Valuta";"Auftraggeber/Zahlungsempf�nger";"Empf�nger/Zahlungspflichtiger";"Konto-Nr.";"BLZ";"Vorgang/Verwendungszweck";"W�hrung";"Umsatz";" "
-"08.08.2012";"08.08.2012";;"PREIS VR-BANKCARD";"1234500000";"12340000";"Bankcard-Geb�hr
-FOLGE-NR.   0 VERFALL 12.15
-PREIS BEZAHLT BIS 12.2012";"EUR";"7,50";"S"
-"08.08.2012";"08.08.2012";"Foo GmbH";"Jane Doe";"1234567890";"12345678";"Verg�tung
-INVOICE 7004";"EUR";"170,00";"H"
-"07.08.2012";"07.08.2012";"BarApp";"Sarah Smith";"123456789";"12345678";"Verg�tung
-INVOICE 7003
-Acme GmbH, JULY 2012";"EUR";"170,00";"H"
-"03.08.2012";"03.08.2012";"Foo GmbH";"Some Firm GmbH";"1234567";"12345678";"Verg�tung
-INVOICE 7002";"EUR";"2.023,00";"H"
-"31.07.2012";"31.07.2012";"Foo GmbH";"James Brown";"1234567890";"12345678";"Verg�tung
-RGNR. 2271";"EUR";"68,00";"H"
-"30.07.2012";"30.07.2012";"Foo GmbH";"Example.com";"123456789";"12345678";"Verg�tung
-INVOICE 7002";"GBP";"136,00";"H"
-"17.07.2012";"17.07.2012";"Foo GmbH";"Blah Inc GmbH";"1234567890";"12345678";"Verg�tung
-INVOICE 2264";"EUR";"170,00";"H"
-
-"17.07.2012";;;;;;"EUR";"Anfangssaldo";"0,00";"H"
-"08.08.2012";;;;;;"EUR";"Endsaldo";"2.729,50";"H"