voids 2.0.0

data/spec/voids/base_spec.rb

@@ -0,0 +1,361 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe Voids::Base do
+  describe '.attribute' do
+    it 'defines an attribute with a type' do
+      form_class = Class.new(described_class) do
+        attribute :title, :string
+      end
+
+      form = form_class.new(title: 'hello')
+
+      expect(form.title).to eq('hello')
+    end
+
+    it 'supports default values' do
+      form_class = Class.new(described_class) do
+        attribute :status, :string, default: 'draft'
+      end
+
+      form = form_class.new
+
+      expect(form.status).to eq('draft')
+    end
+
+    it 'supports default values from proc' do
+      form_class = Class.new(described_class) do
+        attribute :timestamp, :datetime, default: -> { Time.new(2025, 1, 1) }
+      end
+
+      form = form_class.new
+
+      expect(form.timestamp).to eq(Time.new(2025, 1, 1))
+    end
+  end
+
+  describe '#initialize' do
+    it 'accepts a hash of attributes' do
+      form_class = Class.new(described_class) do
+        attribute :title, :string
+        attribute :count, :integer
+      end
+
+      form = form_class.new(title: 'test', count: 5)
+
+      expect(form.title).to eq('test')
+    end
+
+    it 'accepts an empty hash' do
+      form_class = Class.new(described_class)
+
+      form = form_class.new({})
+
+      expect(form).to be_a(described_class)
+    end
+  end
+
+  describe '#assign_attributes' do
+    it 'assigns multiple attributes' do
+      form_class = Class.new(described_class) do
+        attribute :title, :string
+        attribute :content, :string
+      end
+
+      form = form_class.new
+      form.assign_attributes(title: 'new title', content: 'new content')
+
+      expect(form.title).to eq('new title')
+    end
+
+    it 'handles nested attributes with _attributes suffix' do
+      nested_class = Class.new(described_class) do
+        attribute :url, :string
+      end
+      stub_const('PhotoForm', nested_class)
+
+      form_class = Class.new(described_class) do
+        has_one :photo
+        attribute :title, :string
+      end
+
+      form = form_class.new
+      form.assign_attributes(photo_attributes: { url: 'https://example.com' })
+
+      expect(form.photo.url).to eq('https://example.com')
+    end
+  end
+
+  describe '.from_model' do
+    it 'creates new instance from model' do
+      model = Struct.new(:title, :content).new('model title', 'model content')
+
+      form_class = Class.new(described_class) do
+        attribute :title, :string
+        attribute :content, :string
+      end
+
+      form = form_class.from_model(model)
+
+      expect(form.title).to eq('model title')
+    end
+  end
+
+  describe '#from_model' do
+    it 'copies matching attributes from model' do
+      model = Struct.new(:title, :content).new('model title', 'model content')
+
+      form_class = Class.new(described_class) do
+        attribute :title, :string
+        attribute :content, :string
+      end
+
+      form = form_class.new
+      form.from_model(model)
+
+      expect(form.title).to eq('model title')
+    end
+
+    it 'returns self for chaining' do
+      model = Struct.new(:title).new('title')
+
+      form_class = Class.new(described_class) do
+        attribute :title, :string
+      end
+
+      form = form_class.new
+      result = form.from_model(model)
+
+      expect(result).to eq(form)
+    end
+
+    it 'ignores attributes not defined on form' do
+      model = Struct.new(:title, :extra).new('title', 'extra')
+
+      form_class = Class.new(described_class) do
+        attribute :title, :string
+      end
+
+      form = form_class.new
+      form.from_model(model)
+
+      expect(form.title).to eq('title')
+    end
+
+    it 'handles nil model' do
+      form_class = Class.new(described_class) do
+        attribute :title, :string
+      end
+
+      form = form_class.new
+      form.from_model(nil)
+
+      expect(form.title).to be_nil
+    end
+
+    it 'assigns has_one associations from model' do
+      model_photo = Struct.new(:url).new('https://example.com/photo.jpg')
+      model = Struct.new(:title, :photo).new('test', model_photo)
+
+      photo_form_class = Class.new(described_class) do
+        attribute :url, :string
+      end
+      stub_const('PhotoForm', photo_form_class)
+
+      form_class = Class.new(described_class) do
+        has_one :photo
+        attribute :title, :string
+      end
+
+      form = form_class.new
+      form.from_model(model)
+
+      expect(form.photo.url).to eq('https://example.com/photo.jpg')
+    end
+
+    it 'assigns has_many associations from model' do
+      model_image1 = Struct.new(:url).new('https://example.com/1.jpg')
+      model_image2 = Struct.new(:url).new('https://example.com/2.jpg')
+      model = Struct.new(:title, :images).new('test', [model_image1, model_image2])
+
+      image_form_class = Class.new(described_class) do
+        attribute :url, :string
+      end
+      stub_const('ImageForm', image_form_class)
+
+      form_class = Class.new(described_class) do
+        has_many :images
+        attribute :title, :string
+      end
+
+      form = form_class.new
+      form.from_model(model)
+
+      expect(form.images.count).to eq(2)
+    end
+  end
+
+  describe '#persisted?' do
+    it 'returns false when id is not present' do
+      form_class = Class.new(described_class) do
+        attribute :id, :integer
+      end
+
+      form = form_class.new
+
+      expect(form.persisted?).to be(false)
+    end
+
+    it 'returns true when id is present' do
+      form_class = Class.new(described_class) do
+        attribute :id, :integer
+      end
+
+      form = form_class.new(id: 123)
+
+      expect(form.persisted?).to be(true)
+    end
+
+    it 'returns false when id attribute is not defined' do
+      form_class = Class.new(described_class)
+
+      form = form_class.new
+
+      expect(form.persisted?).to be(false)
+    end
+  end
+
+  describe '#to_key' do
+    it 'returns nil when not persisted' do
+      form_class = Class.new(described_class) do
+        attribute :id, :integer
+      end
+
+      form = form_class.new
+
+      expect(form.to_key).to be_nil
+    end
+
+    it 'returns array with id when persisted' do
+      form_class = Class.new(described_class) do
+        attribute :id, :integer
+      end
+
+      form = form_class.new(id: 456)
+
+      expect(form.to_key).to eq([456])
+    end
+  end
+
+  describe '#to_param' do
+    it 'returns nil when not persisted' do
+      form_class = Class.new(described_class) do
+        attribute :id, :integer
+      end
+
+      form = form_class.new
+
+      expect(form.to_param).to be_nil
+    end
+
+    it 'returns id as string when persisted' do
+      form_class = Class.new(described_class) do
+        attribute :id, :integer
+      end
+
+      form = form_class.new(id: 789)
+
+      expect(form.to_param).to eq('789')
+    end
+  end
+
+  describe '#to_model' do
+    it 'returns self' do
+      form_class = Class.new(described_class)
+
+      form = form_class.new
+
+      expect(form.to_model).to eq(form)
+    end
+  end
+
+  describe '#valid?' do
+    it 'returns true when all validations pass' do
+      form_class = Class.new(described_class) do
+        attribute :title, :string
+        validates :title, presence: true
+      end
+
+      form = form_class.new(title: 'present')
+
+      expect(form.valid?).to be(true)
+    end
+
+    it 'returns false when validations fail' do
+      form_class = Class.new(described_class) do
+        attribute :title, :string
+        validates :title, presence: true
+      end
+
+      form = form_class.new
+
+      expect(form.valid?).to be(false)
+    end
+
+    it 'validates nested has_one forms' do
+      nested_class = Class.new(described_class) do
+        attribute :url, :string
+        validates :url, presence: true
+      end
+      stub_const('PhotoForm', nested_class)
+
+      form_class = Class.new(described_class) do
+        has_one :photo
+        attribute :title, :string
+      end
+
+      form = form_class.new(title: 'test')
+      form.build_photo
+
+      expect(form.valid?).to be(false)
+    end
+
+    it 'validates nested has_many forms' do
+      nested_class = Class.new(described_class) do
+        attribute :url, :string
+        validates :url, presence: true
+      end
+      stub_const('ImageForm', nested_class)
+
+      form_class = Class.new(described_class) do
+        has_many :images
+        attribute :title, :string
+      end
+
+      form = form_class.new(title: 'test')
+      form.images.new
+
+      expect(form.valid?).to be(false)
+    end
+
+    it 'includes nested form errors in parent errors' do
+      nested_class = Class.new(described_class) do
+        attribute :url, :string
+        validates :url, presence: true
+      end
+      stub_const('PhotoForm', nested_class)
+
+      form_class = Class.new(described_class) do
+        has_one :photo
+        attribute :title, :string
+      end
+
+      form = form_class.new(title: 'test')
+      form.build_photo
+      form.valid?
+
+      expect(form.errors.messages.keys).to include(:'photo.url')
+    end
+  end
+end

data/spec/voids/callbacks_spec.rb

@@ -0,0 +1,60 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe 'Callbacks' do
+  it 'runs before_validation callback' do
+    form_class = Class.new(Voids::Base) do
+      attribute :title, :string
+      before_validation :normalize_title
+
+      def normalize_title
+        self.title = title&.strip&.downcase
+      end
+    end
+
+    form = form_class.new(title: '  HELLO  ')
+    form.valid?
+
+    expect(form.title).to eq('hello')
+  end
+
+  it 'runs after_validation callback' do
+    callback_ran = false
+
+    form_class = Class.new(Voids::Base) do
+      attribute :title, :string
+      validates :title, presence: true
+
+      after_validation do
+        callback_ran = true
+      end
+
+      define_method(:callback_ran=) { |value| callback_ran = value }
+    end
+
+    form = form_class.new(title: 'test')
+    form.valid?
+
+    expect(callback_ran).to be(true)
+  end
+
+  it 'runs around_validation callback' do
+    form_class = Class.new(Voids::Base) do
+      attribute :title, :string
+      attribute :validated, :boolean, default: false
+
+      around_validation :mark_validated
+
+      def mark_validated
+        self.validated = true
+        yield
+      end
+    end
+
+    form = form_class.new(title: 'test')
+    form.valid?
+
+    expect(form.validated).to be(true)
+  end
+end

data/spec/voids/custom_primary_key_spec.rb

@@ -0,0 +1,168 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe 'Custom primary key for nested forms' do
+  before(:all) do
+    class CustomPrimaryKeyImageForm < Voids::Base
+      attribute :uuid, :string
+      attribute :url, :string
+    end
+
+    class CustomPrimaryKeyPostForm < Voids::Base
+      attribute :title, :string
+      has_many :images, class_name: 'CustomPrimaryKeyImageForm', primary_key: :uuid
+    end
+  end
+
+  after(:all) do
+    Object.send(:remove_const, :CustomPrimaryKeyImageForm)
+    Object.send(:remove_const, :CustomPrimaryKeyPostForm)
+  end
+
+  describe 'has_many with custom primary_key' do
+    it 'uses custom primary_key to find existing records' do
+      form = CustomPrimaryKeyPostForm.new
+      form.images.new(uuid: 'abc-123', url: 'original.jpg')
+
+      form.images_attributes = [
+        { uuid: 'abc-123', url: 'updated.jpg' }
+      ]
+
+      expect(form.images.count).to eq(1)
+      expect(form.images.first.url).to eq('updated.jpg')
+      expect(form.images.first.uuid).to eq('abc-123')
+    end
+
+    it 'creates new record when primary_key value not found' do
+      form = CustomPrimaryKeyPostForm.new
+      form.images.new(uuid: 'abc-123', url: 'original.jpg')
+
+      form.images_attributes = [
+        { uuid: 'def-456', url: 'new.jpg' }
+      ]
+
+      expect(form.images.count).to eq(2)
+      expect(form.images.map(&:uuid)).to contain_exactly('abc-123', 'def-456')
+    end
+
+    it 'excludes primary_key from updated attributes' do
+      form = CustomPrimaryKeyPostForm.new
+      form.images.new(uuid: 'abc-123', url: 'original.jpg')
+
+      form.images_attributes = [
+        { uuid: 'abc-123', url: 'updated.jpg' }
+      ]
+
+      image = form.images.first
+      expect(image.uuid).to eq('abc-123')
+      expect(image.url).to eq('updated.jpg')
+    end
+  end
+
+  describe 'has_many with custom primary_key and allow_destroy' do
+    before(:all) do
+      class DestroyableImageForm < Voids::Base
+        attribute :uuid, :string
+        attribute :url, :string
+      end
+
+      class DestroyablePostForm < Voids::Base
+        attribute :title, :string
+        has_many :images, class_name: 'DestroyableImageForm', primary_key: :uuid, allow_destroy: true
+      end
+    end
+
+    after(:all) do
+      Object.send(:remove_const, :DestroyableImageForm)
+      Object.send(:remove_const, :DestroyablePostForm)
+    end
+
+    it 'marks record for destruction using custom primary_key' do
+      form = DestroyablePostForm.new
+      form.images.new(uuid: 'abc-123', url: 'original.jpg')
+
+      form.images_attributes = [
+        { uuid: 'abc-123', _destroy: true }
+      ]
+
+      expect(form.images.first.marked_for_destruction?).to be true
+    end
+  end
+
+  describe 'has_many defaults to :id when no primary_key specified' do
+    before(:all) do
+      class DefaultIdImageForm < Voids::Base
+        attribute :id, :integer
+        attribute :url, :string
+      end
+
+      class DefaultIdPostForm < Voids::Base
+        attribute :title, :string
+        has_many :images, class_name: 'DefaultIdImageForm'
+      end
+    end
+
+    after(:all) do
+      Object.send(:remove_const, :DefaultIdImageForm)
+      Object.send(:remove_const, :DefaultIdPostForm)
+    end
+
+    it 'uses id as default primary_key' do
+      form = DefaultIdPostForm.new
+      form.images.new(id: 1, url: 'original.jpg')
+
+      form.images_attributes = [
+        { id: 1, url: 'updated.jpg' }
+      ]
+
+      expect(form.images.count).to eq(1)
+      expect(form.images.first.url).to eq('updated.jpg')
+      expect(form.images.first.id).to eq(1)
+    end
+  end
+
+  describe 'AssociationProxy#find_by' do
+    before(:all) do
+      class ProxyTestForm < Voids::Base
+        attribute :id, :integer
+        attribute :uuid, :string
+        attribute :url, :string
+      end
+    end
+
+    after(:all) do
+      Object.send(:remove_const, :ProxyTestForm)
+    end
+
+    it 'finds record by custom attribute' do
+      proxy = Voids::AssociationProxy.new('ProxyTestForm')
+      image = ProxyTestForm.new(uuid: 'abc-123', url: 'test.jpg')
+      proxy.push(image)
+
+      found = proxy.find_by(:uuid, 'abc-123')
+
+      expect(found).to eq(image)
+    end
+
+    it 'returns nil when attribute value not found' do
+      proxy = Voids::AssociationProxy.new('ProxyTestForm')
+      image = ProxyTestForm.new(uuid: 'abc-123', url: 'test.jpg')
+      proxy.push(image)
+
+      found = proxy.find_by(:uuid, 'not-found')
+
+      expect(found).to be_nil
+    end
+
+    it 'uses id cache when finding by id' do
+      proxy = Voids::AssociationProxy.new('ProxyTestForm')
+      image = ProxyTestForm.new(id: 1, url: 'test.jpg')
+      proxy.push(image)
+
+      found = proxy.find_by(:id, 1)
+
+      expect(found).to eq(image)
+    end
+  end
+end

data/spec/voids/dirty_tracking_spec.rb

@@ -0,0 +1,61 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe 'Dirty tracking' do
+  it 'tracks attribute changes' do
+    form_class = Class.new(Voids::Base) do
+      attribute :title, :string
+    end
+
+    form = form_class.new(title: 'original')
+    form.title = 'changed'
+
+    expect(form.title_changed?).to be(true)
+  end
+
+  it 'tracks previous value' do
+    form_class = Class.new(Voids::Base) do
+      attribute :title, :string
+    end
+
+    form = form_class.new(title: 'original')
+    form.title = 'changed'
+
+    expect(form.title_was).to eq('original')
+  end
+
+  it 'provides changes hash' do
+    form_class = Class.new(Voids::Base) do
+      attribute :title, :string
+      attribute :content, :string
+    end
+
+    form = form_class.new(title: 'original', content: 'original content')
+    form.title = 'changed'
+
+    expect(form.changes).to eq('title' => %w[original changed])
+  end
+
+  it 'clears changes after assign_attributes' do
+    form_class = Class.new(Voids::Base) do
+      attribute :title, :string
+    end
+
+    form = form_class.new(title: 'original')
+    form.title = 'changed'
+    form.assign_attributes(title: 'new')
+
+    expect(form.changed?).to be(false)
+  end
+
+  it 'detects if any attributes changed' do
+    form_class = Class.new(Voids::Base) do
+      attribute :title, :string
+    end
+
+    form = form_class.new(title: 'original')
+
+    expect(form.changed?).to be(false)
+  end
+end

data/spec/voids/i18n_spec.rb

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe 'I18n support' do
+  it 'provides human_attribute_name' do
+    form_class = Class.new(Voids::Base) do
+      attribute :title, :string
+    end
+    stub_const('PostForm', form_class)
+
+    expect(PostForm.human_attribute_name(:title)).to eq('Title')
+  end
+
+  it 'uses model_name for translation lookup' do
+    form_class = Class.new(Voids::Base) do
+      attribute :title, :string
+    end
+    stub_const('PostForm', form_class)
+
+    expect(PostForm.model_name.i18n_key).to eq(:post)
+  end
+
+  it 'supports custom translations via model_name_for' do
+    form_class = Class.new(Voids::Base) do
+      model_name_for :article
+      attribute :title, :string
+    end
+    stub_const('AdminPostForm', form_class)
+
+    expect(AdminPostForm.model_name.i18n_key).to eq(:article)
+  end
+end