voicecom_sms 4.0.0 → 4.1.0

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    NWQxNGQ1NWZmZWUyOWNiZTk2ZDEwYjlmZTVhODg5YmVkMTIyMTBiMg==
+    NWM4YjVlZWI5YzQ3YmI4MzlmMjgwZTE3YzQ4MmIxYjkyMGE4ODhkMA==
   data.tar.gz: !binary |-
-    Nzg1ZTdjMjE3YTk4MTc3ZGYwNGFmZjFhYjQ0MGNjZGYxYzE0YmVjYQ==
+    NjQzNWZhYzMxNjU5MjY2NmQyMmYxMDU1N2JiZjEyMzgxM2Y3YTRiNw==
 !binary "U0hBNTEy":
   metadata.gz: !binary |-
-    ZTY4NTJjYzc0ODhmYWVmNjY4OGY3YjQ1OGNjYTVkOTlmNjdmNTg2Y2U2NjI1
-    N2FhNzBlNzY3Njc5ZWZjMTI3ZjNjYTEwODIyOGU5ZjU4MmFlY2I5MzhiMmM1
-    MzFkYzA3ODA2Mzg0N2NiZDg2OGViNzVmYWFiZGJkMmEzMDg5Nzk=
+    ZWYyMTNmMTgzZTg2NWE0ZWYwM2UwY2YyZDBiZWQzM2VhMWE0YmZhYzAwMWNi
+    M2NjNmY3OWQ1Y2FiNjM0NjA5Mjg1MTlmNDRmMWIxZDlhYWI3YzNlMjAyNzE2
+    MWU2MjBiZDY5MTI5YTEwOGRlNjRkYzQ2MzVhYmNjYzNjNzMwYTI=
   data.tar.gz: !binary |-
-    YzQxOTViMGFmNGYxYTdlMTMzMzk4MzYwNmE0Y2Y4OTBiYTgwYTMxNGQ3NGJi
-    OWQ3ZjVmMThhNzIyOTYxYzdiZGM2OGRmYzg0M2I1OGM5NGViNWRlZmY5YzNk
-    ZWRkZGJmNGRjN2M2OGEyMTA2YWUxNGJhZThlNzczMDdmM2EzZDg=
+    NjQzZWYwMzdmZTRhNWM1YjBhYzJhODI3YWVjMWU2ZDBhZDZmYzc1NDE3NmNj
+    MDhjMjNmYjJkYjZkYjJjMDIyNGY2YjBhZTdlODA0ZmQ0NzQ2ZTFhNzNlNGJk
+    ZTgwZWVhNWE4ZmYyNDA0Y2IxOTZjOTY1ZWE3MGUzYzYwOWYyYjQ=

data/VERSION

@@ -1 +1 @@
-4.0.0
+4.1.0

data/lib/voicecom_sms/provider.rb

@@ -24,12 +24,22 @@ module VoicecomSms
     #                       example: for Bulgaria (+359) and mobile number 899947121 you should use '359899947121'
     # @param  text String No idea what characters is supported by voicecom - have to experiment. UTF-8 with latin works for sure.
     #
+    # @block  number it will yield the current message id if you want to process it. for exampel to add the environment
+    #         send_sms('123', 'hi') do |id|
+    #           "#{Rails.env}-#{id}"
+    #         end
+    #
     # @return VoicecomSms::Message - you can take the status field from there, and have the id of the transaction.
-    def send_sms(number, text)
+    def send_sms(number, text, &block)
       message = VoicecomSms::Message.create({text: text, number: normalize_number(number), status: STATUS[:undefined]})
 
-      make_request(message, number, text)
+      message_id = if block_given?
+        yield message.id
+      else
+        message_id
+      end
 
+      make_request(message, number, text, message_id)
 
       if @request.error or !@request.sent?
         message.update_attributes(response: @request.error, status: STATUS[:failure])
@@ -40,7 +50,7 @@ module VoicecomSms
         message.update_attributes(response: @response.inspect, status: status, response_received_at: Time.current)
       end
 
-      message.status
+      message
     end
 
     def normalize_number(number)
@@ -49,11 +59,11 @@ module VoicecomSms
     end
 
     private
-    def make_request(message, number, text)
+    def make_request(message, number, text, message_id)
 
       @request.params = {
         sid: VoicecomSms.config.client_id,
-        id: message.id,
+        id: message_id,
         msisdn: number,
         text: text,
         #priority: 2, # 1 - high priority, 2 - normal priority (default)

data/spec/voicecom_sms/provider_spec.rb

@@ -23,7 +23,7 @@ describe VoicecomSms::Provider do
   describe "#send_sms" do
     before(:each) do
       @provider = VoicecomSms::Provider.new
-      stub_request(:get, "https://localhost:8443/smsapi/bsms/index.php?sid=#{VoicecomSms.config.client_id}&id=1&msisdn=359899947329&text=some+message").
+      stub_request(:get, "https://localhost:8443/smsapi/bsms/index.php?id&msisdn=359899947329&sid=#{VoicecomSms.config.client_id}&text=some%20message").
         to_return(lambda { |request| File.new("request_stubs/success.curl")})
     end
 
@@ -59,7 +59,7 @@ describe VoicecomSms::Provider do
 
     it "should return the status" do
       result = @provider.send_sms(destination_mobile_number, 'some message')
-      result.should == VoicecomSms::Provider::STATUS[:success]
+      result.should be_an_instance_of VoicecomSms::Message
     end
   end
 

data/voicecom_sms.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = "voicecom_sms"
-  s.version = "4.0.0"
+  s.version = "4.1.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Empowerunited", "Evgenia Manolova", "Gudata"]

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: voicecom_sms
 version: !ruby/object:Gem::Version
-  version: 4.0.0
+  version: 4.1.0
 platform: ruby
 authors:
 - Empowerunited