vmware-vra 3.1.0 → 3.1.3

data/lib/vra/deployment.rb

@@ -22,7 +22,7 @@ require "ffi_yajl" unless defined?(FFI_Yajl)
 module Vra
   # Class that represents the Deployment Object
   class Deployment
-    INDEX_URL = '/deployment/api/deployments'
+    INDEX_URL = "/deployment/api/deployments"
 
     attr_reader :id
 
@@ -35,40 +35,40 @@ module Vra
       if @data.nil?
         refresh
       elsif @id.nil?
-        @id = @data['id']
+        @id = @data["id"]
       end
     end
 
     def name
-      @data['name']
+      @data["name"]
     end
 
     def description
-      @data['description']
+      @data["description"]
     end
 
     def org_id
-      @data['orgId']
+      @data["orgId"]
     end
 
     def blueprint_id
-      @data['blueprintId']
+      @data["blueprintId"]
     end
 
     def owner
-      @data['ownedBy']
+      @data["ownedBy"]
     end
 
     def status
-      @data['status']
+      @data["status"]
     end
 
     def successful?
-      status == 'CREATE_SUCCESSFUL'
+      status == "CREATE_SUCCESSFUL"
     end
 
     def failed?
-      status == 'CREATE_FAILED'
+      status == "CREATE_FAILED"
     end
 
     def completed?
@@ -80,16 +80,16 @@ module Vra
     end
 
     def action_id_by_name(action_name)
-      action = actions.find { |x| x['name'] == action_name}
+      action = actions.find { |x| x["name"] == action_name }
       return if action.nil?
 
-      action['id']
+      action["id"]
     end
 
     def resources
       response = client.get_parsed("/deployment/api/deployments/#{id}/resources")
 
-      response['content'].map! { |x| Vra::Resource.new(client, id, data: x) }
+      response["content"].map! { |x| Vra::Resource.new(client, id, data: x) }
     end
 
     def resource_by_id(res_id)
@@ -99,7 +99,7 @@ module Vra
     def requests
       response = client.get_parsed("/deployment/api/deployments/#{id}/requests")
 
-      response['content'].map! { |x| Vra::Request.new(client, id, id: x['id'], data: x) }
+      response["content"].map! { |x| Vra::Request.new(client, id, id: x["id"], data: x) }
     end
 
     def refresh
@@ -108,22 +108,22 @@ module Vra
       raise Vra::Exception::NotFound, "deployment with ID #{id} does not exist"
     end
 
-    def destroy(reason = '')
-      action_id = action_id_by_name('Delete')
+    def destroy(reason = "")
+      action_id = action_id_by_name("Delete")
       raise Vra::Exception::NotFound, "No destroy action found for resource #{@id}" if action_id.nil?
 
       submit_action_request(action_id, reason)
     end
 
-    def power_off(reason = '')
-      action_id = action_id_by_name('PowerOff')
+    def power_off(reason = "")
+      action_id = action_id_by_name("PowerOff")
       raise Vra::Exception::NotFound, "No power-off action found for resource #{@id}" if action_id.nil?
 
       submit_action_request(action_id, reason)
     end
 
     def power_on(reason = nil)
-      action_id = action_id_by_name('PowerOn')
+      action_id = action_id_by_name("PowerOn")
       raise Vra::Exception::NotFound, "No power-on action found for resource #{@id}" if action_id.nil?
 
       submit_action_request(action_id, reason)
@@ -134,7 +134,7 @@ module Vra
     attr_reader :client, :data
 
     def validate!
-      raise ArgumentError, 'must supply id or data hash' if @id.nil? && @data.nil?
+      raise ArgumentError, "must supply id or data hash" if @id.nil? && @data.nil?
     end
 
     def submit_action_request(action_id, reason)
@@ -148,7 +148,7 @@ module Vra
       {
         "actionId": action_id,
         "inputs": {},
-        "reason": reason
+        "reason": reason,
       }
     end
   end

data/lib/vra/deployment_request.rb

@@ -16,7 +16,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 #
-require 'ffi_yajl' unless defined?(FFI_Yajl)
+require "ffi_yajl" unless defined?(FFI_Yajl)
 
 # Overriding the hash object to add the deep_merge method
 class ::Hash
@@ -50,12 +50,12 @@ module Vra
       begin
         response = send_request!
       rescue Vra::Exception::HTTPError => e
-        raise Vra::Exception::RequestError, "Unable to submit request: #{e.message}, trace: #{e.errors.join(', ')}"
+        raise Vra::Exception::RequestError, "Unable to submit request: #{e.message}, trace: #{e.errors.join(", ")}"
       rescue StandardError => e
         raise e, e.message
       end
 
-      request_id = FFI_Yajl::Parser.parse(response)[0]['deploymentId']
+      request_id = FFI_Yajl::Parser.parse(response)[0]["deploymentId"]
       Vra::Deployment.new(client, id: request_id)
     end
 
@@ -85,21 +85,20 @@ module Vra
 
     def validate!
       missing_params = []
-      %i[image_mapping flavor_mapping name project_id].each do |arg|
+      %i{image_mapping flavor_mapping name project_id}.each do |arg|
         missing_params << arg if send(arg).nil?
       end
 
       unless missing_params.empty?
-        raise ArgumentError, "Unable to submit request, required param(s) missing => #{missing_params.join(', ')}"
+        raise ArgumentError, "Unable to submit request, required param(s) missing => #{missing_params.join(", ")}"
       end
 
       # If the user doesn't supply the catalog version, fetch the latest version and use it
       # and if the API was unable to find a valid version, alert the user.
       return unless @version.nil?
 
-
       @version = CatalogItem.fetch_latest_version(client, catalog_id)
-      raise ArgumentError, 'Unable to fetch a valid catalog version' if @version.nil?
+      raise ArgumentError, "Unable to fetch a valid catalog version" if @version.nil?
     end
 
     def send_request!
@@ -117,8 +116,8 @@ module Vra
         'inputs': {
           'count': count,
           'image': image_mapping,
-          'flavor': flavor_mapping
-        }
+          'flavor': flavor_mapping,
+        },
       }.deep_merge(parameters)
     end
   end

data/lib/vra/deployments.rb

@@ -47,7 +47,7 @@ module Vra
 
     def fetch_all_resources
       client
-        .http_get_paginated_array!('/deployment/api/deployments')
+        .http_get_paginated_array!("/deployment/api/deployments")
         .map! { |x| Vra::Deployment.new(client, data: x) }
     end
   end

data/lib/vra/http.rb

@@ -1,9 +1,9 @@
 # frozen_string_literal: true
 
-require 'net/http' unless defined?(Net::HTTP)
-require 'openssl' unless defined?(OpenSSL)
-require 'ffi_yajl' unless defined?(FFI_Yajl)
-require 'json'
+require "net/http" unless defined?(Net::HTTP)
+require "openssl" unless defined?(OpenSSL)
+require "ffi_yajl" unless defined?(FFI_Yajl)
+require "json" unless defined?(JSON)
 
 module Vra
   module Http
@@ -64,7 +64,7 @@ module Vra
           get: Net::HTTP::Get,
           head: Net::HTTP::Head,
           post: Net::HTTP::Post,
-          delete: Net::HTTP::Delete
+          delete: Net::HTTP::Delete,
         }.fetch(method, nil)
 
         raise "Unknown HTTP method #{method}!" unless type
@@ -150,7 +150,7 @@ module Vra
 
       def self.from_response(http_response)
         body = FFI_Yajl::Parser.parse(http_response.body) || {}
-        message = body['message'] || body['serverMessage']
+        message = body["message"] || body["serverMessage"]
         new(message, http_response.code, body)
       end
 

data/lib/vra/request.rb

@@ -31,16 +31,16 @@ module Vra
       if @request_data.nil?
         refresh
       else
-        @id = @request_data['id']
+        @id = @request_data["id"]
       end
     end
 
     def requested_by
-      request_data['requestedBy']
+      request_data["requestedBy"]
     end
 
     def name
-      request_data['name']
+      request_data["name"]
     end
 
     def refresh
@@ -61,7 +61,7 @@ module Vra
       refresh_if_empty
       return if request_empty?
 
-      request_data['status']
+      request_data["status"]
     end
 
     def completed?
@@ -69,11 +69,11 @@ module Vra
     end
 
     def successful?
-      status == 'SUCCESSFUL'
+      status == "SUCCESSFUL"
     end
 
     def failed?
-      status == 'FAILED'
+      status == "FAILED"
     end
 
     private

data/lib/vra/request_parameters.rb

@@ -93,7 +93,7 @@ module Vra
 
     def to_vra
       hash = {
-        'inputs': {}
+        'inputs': {},
       }
 
       @entries.each do |_, v|
@@ -120,7 +120,7 @@ module Vra
     def to_h
       hash = {}
 
-      if @children.count.positive?
+      if @children.count > 0
         hash[@key] = {}
 
         @children.each do |c|
@@ -135,13 +135,13 @@ module Vra
 
     def to_vra
       hash = {}
-      if @children.count.positive?
+      if @children.count > 0
         hash[@key] = {}
 
-        hash[@key]['inputs'] = {}
+        hash[@key]["inputs"] = {}
 
         @children.each do |c|
-          hash[@key]['inputs'].merge!(c.to_vra)
+          hash[@key]["inputs"].merge!(c.to_vra)
         end
       else
         hash[@key] = format_value
@@ -152,12 +152,12 @@ module Vra
 
     def format_value
       case @type
-      when 'integer'
+      when "integer"
         @value.to_i
-      when 'string'
+      when "string"
         @value
-      when 'boolean'
-        @value.to_s == 'true'
+      when "boolean"
+        @value.to_s == "true"
       else
         @value
       end

data/lib/vra/resource.rb

@@ -21,10 +21,10 @@ require "ffi_yajl" unless defined?(FFI_Yajl)
 
 module Vra
   class Resource
-    VM_TYPES = %w[
+    VM_TYPES = %w{
       Cloud.vSphere.Machine
       Cloud.Machine
-    ].freeze
+    }.freeze
 
     attr_reader :client, :deployment_id, :id, :resource_data
 
@@ -35,13 +35,13 @@ module Vra
       @resource_data    = opts[:data]
       @resource_actions = []
 
-      raise ArgumentError, 'must supply an id or a resource data hash' if @id.nil? && @resource_data.nil?
-      raise ArgumentError, 'must supply an id OR a resource data hash, not both' if !@id.nil? && !@resource_data.nil?
+      raise ArgumentError, "must supply an id or a resource data hash" if @id.nil? && @resource_data.nil?
+      raise ArgumentError, "must supply an id OR a resource data hash, not both" if !@id.nil? && !@resource_data.nil?
 
       if @resource_data.nil?
         fetch_resource_data
       else
-        @id = @resource_data['id']
+        @id = @resource_data["id"]
       end
     end
 
@@ -54,40 +54,40 @@ module Vra
     alias refresh fetch_resource_data
 
     def name
-      resource_data['name']
+      resource_data["name"]
     end
 
     def status
-      resource_data['syncStatus']
+      resource_data["syncStatus"]
     end
 
     def properties
-      resource_data['properties']
+      resource_data["properties"]
     end
 
     def vm?
-      VM_TYPES.include?(resource_data['type'])
+      VM_TYPES.include?(resource_data["type"])
     end
 
     def owner_names
-      properties['Owner']
+      properties["Owner"]
     end
 
     def project_id
-      properties['project']
+      properties["project"]
     end
 
     def network_interfaces
       return unless vm?
 
-      network_list = properties['networks']
+      network_list = properties["networks"]
       return if network_list.nil?
 
       network_list.each_with_object([]) do |item, nics|
         nics << {
-          'NETWORK_NAME' => item['name'],
-          'NETWORK_ADDRESS' => item['address'],
-          'NETWORK_MAC_ADDRESS' => item['mac_address']
+          "NETWORK_NAME" => item["name"],
+          "NETWORK_ADDRESS" => item["address"],
+          "NETWORK_MAC_ADDRESS" => item["mac_address"],
         }
       end
     end
@@ -95,7 +95,7 @@ module Vra
     def ip_address
       return if !vm? || network_interfaces.nil?
 
-      properties['address']
+      properties["address"]
     end
   end
 end

data/lib/vra/version.rb

@@ -18,5 +18,5 @@
 #
 
 module Vra
-  VERSION = "3.1.0"
+  VERSION = "3.1.3"
 end

data/lib/vra.rb

@@ -17,17 +17,17 @@
 # limitations under the License.
 #
 
-require 'vra/catalog_base'
-require 'vra/catalog'
-require 'vra/catalog_item'
-require 'vra/catalog_source'
-require 'vra/catalog_type'
-require 'vra/deployment_request'
-require 'vra/deployment'
-require 'vra/deployments'
-require 'vra/client'
-require 'vra/exceptions'
-require 'vra/request'
-require 'vra/request_parameters'
-require 'vra/resource'
-require 'vra/version'
+require "vra/catalog_base"
+require "vra/catalog"
+require "vra/catalog_item"
+require "vra/catalog_source"
+require "vra/catalog_type"
+require "vra/deployment_request"
+require "vra/deployment"
+require "vra/deployments"
+require "vra/client"
+require "vra/exceptions"
+require "vra/request"
+require "vra/request_parameters"
+require "vra/resource"
+require "vra/version"

data/spec/catalog_item_spec.rb

@@ -17,142 +17,142 @@
 # limitations under the License.
 #
 
-require 'spec_helper'
+require "spec_helper"
 
 describe Vra::CatalogItem do
   let(:client) do
     Vra::Client.new(
-      username: 'user@corp.local',
-      password: 'password',
-      tenant: 'tenant',
-      base_url: 'https://vra.corp.local'
+      username: "user@corp.local",
+      password: "password",
+      tenant: "tenant",
+      base_url: "https://vra.corp.local"
     )
   end
 
-  let(:catalog_id) { '123456' }
+  let(:catalog_id) { "123456" }
 
   let(:catalog_item_payload) do
-    JSON.parse(File.read('spec/fixtures/resource/sample_catalog_item.json'))
+    JSON.parse(File.read("spec/fixtures/resource/sample_catalog_item.json"))
   end
 
   let(:other_catalog_item_payload) do
-    JSON.parse(File.read('spec/fixtures/resource/sample_catalog_item_2.json'))
+    JSON.parse(File.read("spec/fixtures/resource/sample_catalog_item_2.json"))
   end
 
-  describe '#initialize' do
-    it 'raises an error if no ID or catalog item data have been provided' do
+  describe "#initialize" do
+    it "raises an error if no ID or catalog item data have been provided" do
       expect { Vra::CatalogItem.new(client) }.to raise_error(ArgumentError)
     end
 
-    it 'raises an error if an ID and catalog item data have both been provided' do
-      expect { Vra::CatalogItem.new(client, id: 123, data: 'foo') }.to raise_error(ArgumentError)
+    it "raises an error if an ID and catalog item data have both been provided" do
+      expect { Vra::CatalogItem.new(client, id: 123, data: "foo") }.to raise_error(ArgumentError)
     end
 
-    context 'when an ID is provided' do
-      it 'fetches the catalog_item record' do
+    context "when an ID is provided" do
+      it "fetches the catalog_item record" do
         catalog_item = Vra::CatalogItem.allocate
         expect(catalog_item).to receive(:fetch_catalog_item)
         catalog_item.send(:initialize, client, id: catalog_id)
       end
     end
 
-    context 'when catalog item data is provided' do
-      it 'populates the ID correctly' do
+    context "when catalog item data is provided" do
+      it "populates the ID correctly" do
         catalog_item = Vra::CatalogItem.new(client, data: catalog_item_payload)
         expect(catalog_item.id).to eq catalog_id
       end
     end
   end
 
-  describe '#fetch_catalog_item' do
-    context 'when the catalog item exists' do
-      let(:response) { double('response', code: 200, body: catalog_item_payload.to_json) }
+  describe "#fetch_catalog_item" do
+    context "when the catalog item exists" do
+      let(:response) { double("response", code: 200, body: catalog_item_payload.to_json) }
 
-      it 'calls http_get against the catalog_service' do
-        expect(client).to receive(:http_get).with('/catalog/api/admin/items/catalog-12345').and_return(response)
-        Vra::CatalogItem.new(client, id: 'catalog-12345')
+      it "calls http_get against the catalog_service" do
+        expect(client).to receive(:http_get).with("/catalog/api/items/catalog-12345").and_return(response)
+        Vra::CatalogItem.new(client, id: "catalog-12345")
       end
     end
 
-    context 'when the catalog item does not exist' do
-      it 'raises an exception' do
+    context "when the catalog item does not exist" do
+      it "raises an exception" do
         allow(client)
           .to receive(:http_get)
-          .with('/catalog/api/admin/items/catalog-12345')
+          .with("/catalog/api/items/catalog-12345")
           .and_raise(Vra::Exception::HTTPNotFound)
 
-        expect { Vra::CatalogItem.new(client, id: 'catalog-12345') }
+        expect { Vra::CatalogItem.new(client, id: "catalog-12345") }
           .to raise_error(Vra::Exception::NotFound)
-          .with_message('catalog ID catalog-12345 does not exist')
+          .with_message("catalog ID catalog-12345 does not exist")
       end
     end
   end
 
-  describe '#entitle!' do
-    it 'should entitle the catalog item' do
+  describe "#entitle!" do
+    it "should entitle the catalog item" do
       allow(client).to receive(:authorized?).and_return(true)
-      stub_request(:get, client.full_url('/catalog/api/admin/items/123456'))
+      stub_request(:get, client.full_url("/catalog/api/items/123456"))
         .to_return(status: 200, body: catalog_item_payload.to_json, headers: {})
 
-      response = double('response', body: '{"message": "success"}', success?: true)
+      response = double("response", body: '{"message": "success"}', success?: true)
       allow(client).to receive(:http_post).and_return(response)
 
-      entitle_response = described_class.entitle!(client, '123456')
+      entitle_response = described_class.entitle!(client, "123456")
       expect(entitle_response).not_to be_nil
     end
   end
 
-  describe '#attributes' do
-    it 'should have the correct attributes' do
+  describe "#attributes" do
+    it "should have the correct attributes" do
       allow(client).to receive(:authorized?).and_return(true)
-      stub_request(:get, client.full_url('/catalog/api/admin/sources/source-123456'))
+      stub_request(:get, client.full_url("/catalog/api/admin/sources/source-123456"))
         .to_return(
           status: 200,
-          body: File.read('spec/fixtures/resource/sample_catalog_source.json'),
+          body: File.read("spec/fixtures/resource/sample_catalog_source.json"),
           headers: {}
         )
       catalog_item = described_class.new(client, data: catalog_item_payload)
 
-      expect(catalog_item.name).to eq('centos')
-      expect(catalog_item.description).to eq('Centos Cat')
-      expect(catalog_item.source_id).to eq('source-123456')
-      expect(catalog_item.source_name).to eq('Source 123')
-      expect(catalog_item.icon_id).to eq('1495b8d9')
+      expect(catalog_item.name).to eq("centos")
+      expect(catalog_item.description).to eq("Centos Cat")
+      expect(catalog_item.source_id).to eq("source-123456")
+      expect(catalog_item.source_name).to eq("Source 123")
+      expect(catalog_item.icon_id).to eq("1495b8d9")
       expect(catalog_item.source).to be_a(Vra::CatalogSource)
       expect(catalog_item.type).to be_a(Vra::CatalogType)
     end
   end
 
-  describe '#versions' do
+  describe "#versions" do
     let(:versions_response) do
-      [{ id: '2', description: 'v2.0' }, { id: '1', description: 'v1.0' }]
+      [{ id: "2", description: "v2.0" }, { id: "1", description: "v1.0" }]
     end
 
     before do
       allow(client).to receive(:authorized?).and_return(true)
     end
 
-    it 'should call the api to fetch the versions' do
+    it "should call the api to fetch the versions" do
       expect(client)
         .to receive(:http_get_paginated_array!)
-        .with('/catalog/api/items/catalog-12345/versions')
+        .with("/catalog/api/items/catalog-12345/versions")
         .and_return(versions_response)
 
-      described_class.fetch_latest_version(client, 'catalog-12345')
+      described_class.fetch_latest_version(client, "catalog-12345")
     end
 
-    it 'should return the correct version' do
-      stub_request(:get, client.full_url('/catalog/api/items/catalog-12345/versions?$skip=0&$top=20'))
+    it "should return the correct version" do
+      stub_request(:get, client.full_url("/catalog/api/items/catalog-12345/versions?$skip=0&$top=20"))
         .to_return(
           status: 200,
           body: {
             content: versions_response,
-            totalPages: 1
+            totalPages: 1,
           }.to_json,
           headers: {}
         )
 
-      expect(described_class.fetch_latest_version(client, 'catalog-12345')).to eq('2')
+      expect(described_class.fetch_latest_version(client, "catalog-12345")).to eq("2")
     end
   end
 end