vmfloaty 1.2.0 → 1.6.0

data/spec/vmfloaty/utils_spec.rb

@@ -36,13 +36,14 @@ describe Utils do
 
     it 'formats a result from vmpooler into a hash of os to hostnames' do
       result = Utils.standardize_hostnames(JSON.parse(@vmpooler_response_body))
-      expect(result).to eq('centos-7-x86_64'    => ['dlgietfmgeegry2.delivery.mycompany.net'],
-                           'ubuntu-1610-x86_64' => ['gdoy8q3nckuob0i.delivery.mycompany.net', 'ctnktsd0u11p9tm.delivery.mycompany.net'])
+      expect(result).to eq('centos-7-x86_64' => ['dlgietfmgeegry2.delivery.mycompany.net'],
+                           'ubuntu-1610-x86_64' => ['gdoy8q3nckuob0i.delivery.mycompany.net',
+                                                    'ctnktsd0u11p9tm.delivery.mycompany.net'])
     end
 
     it 'formats a result from the nonstandard pooler into a hash of os to hostnames' do
       result = Utils.standardize_hostnames(JSON.parse(@nonstandard_response_body))
-      expect(result).to eq('solaris-10-sparc'    => ['sol10-10.delivery.mycompany.net', 'sol10-11.delivery.mycompany.net'],
+      expect(result).to eq('solaris-10-sparc' => ['sol10-10.delivery.mycompany.net', 'sol10-11.delivery.mycompany.net'],
                            'ubuntu-16.04-power8' => ['power8-ubuntu16.04-6.delivery.mycompany.net'])
     end
   end
@@ -50,12 +51,12 @@ describe Utils do
   describe '#format_host_output' do
     before :each do
       @vmpooler_results = {
-        'centos-7-x86_64'    => ['dlgietfmgeegry2.delivery.mycompany.net'],
-        'ubuntu-1610-x86_64' => ['gdoy8q3nckuob0i.delivery.mycompany.net', 'ctnktsd0u11p9tm.delivery.mycompany.net'],
+        'centos-7-x86_64' => ['dlgietfmgeegry2.delivery.mycompany.net'],
+        'ubuntu-1610-x86_64' => ['gdoy8q3nckuob0i.delivery.mycompany.net', 'ctnktsd0u11p9tm.delivery.mycompany.net']
       }
       @nonstandard_results = {
-        'solaris-10-sparc'    => ['sol10-10.delivery.mycompany.net', 'sol10-11.delivery.mycompany.net'],
-        'ubuntu-16.04-power8' => ['power8-ubuntu16.04-6.delivery.mycompany.net'],
+        'solaris-10-sparc' => ['sol10-10.delivery.mycompany.net', 'sol10-11.delivery.mycompany.net'],
+        'ubuntu-16.04-power8' => ['power8-ubuntu16.04-6.delivery.mycompany.net']
       }
       @vmpooler_output = <<~OUT.chomp
         - dlgietfmgeegry2.delivery.mycompany.net (centos-7-x86_64)
@@ -98,23 +99,23 @@ describe Utils do
   describe '#get_service_config' do
     before :each do
       @default_config = {
-        'url'   => 'http://default.url',
-        'user'  => 'first.last.default',
-        'token' => 'default-token',
+        'url' => 'http://default.url',
+        'user' => 'first.last.default',
+        'token' => 'default-token'
       }
       @services_config = {
         'services' => {
           'vm' => {
-            'url'   => 'http://vmpooler.url',
-            'user'  => 'first.last.vmpooler',
-            'token' => 'vmpooler-token',
+            'url' => 'http://vmpooler.url',
+            'user' => 'first.last.vmpooler',
+            'token' => 'vmpooler-token'
           },
           'ns' => {
-            'url'   => 'http://nspooler.url',
-            'user'  => 'first.last.nspooler',
-            'token' => 'nspooler-token',
-          },
-        },
+            'url' => 'http://nspooler.url',
+            'user' => 'first.last.nspooler',
+            'token' => 'nspooler-token'
+          }
+        }
       }
     end
 
@@ -126,26 +127,26 @@ describe Utils do
 
     it 'allows selection by configured service key' do
       config = @default_config.merge @services_config
-      options = MockOptions.new(:service => 'ns')
+      options = MockOptions.new(service: 'ns')
       expect(Utils.get_service_config(config, options)).to include @services_config['services']['ns']
     end
 
     it 'uses top-level service config values as defaults when configured service values are missing' do
       config = @default_config.merge @services_config
       config['services']['vm'].delete 'url'
-      options = MockOptions.new(:service => 'vm')
+      options = MockOptions.new(service: 'vm')
       expect(Utils.get_service_config(config, options)['url']).to eq 'http://default.url'
     end
 
     it "raises an error if passed a service name that hasn't been configured" do
       config = @default_config.merge @services_config
-      options = MockOptions.new(:service => 'none')
+      options = MockOptions.new(service: 'none')
       expect { Utils.get_service_config(config, options) }.to raise_error ArgumentError
     end
 
     it 'prioritizes values passed as command line options over configuration options' do
       config = @default_config
-      options = MockOptions.new(:url => 'http://alternate.url', :token => 'alternate-token')
+      options = MockOptions.new(url: 'http://alternate.url', token: 'alternate-token')
       expected = config.merge('url' => 'http://alternate.url', 'token' => 'alternate-token')
       expect(Utils.get_service_config(config, options)).to include expected
     end
@@ -182,15 +183,15 @@ describe Utils do
         {
           'template' => 'ubuntu-1604-x86_64',
           'lifetime' => 12,
-          'running'  => 9.66,
-          'state'    => 'running',
-          'ip'       => '127.0.0.1',
-          'domain'   => domain,
+          'running' => 9.66,
+          'state' => 'running',
+          'ip' => '127.0.0.1',
+          'domain' => domain
         }
       end
 
       it 'outputs fqdn for host' do
-        expect(STDOUT).to receive(:puts).with(fqdn)
+        expect($stdout).to receive(:puts).with(fqdn)
 
         subject
       end
@@ -201,17 +202,17 @@ describe Utils do
       let(:hostname) { 'sol11-9.delivery.mycompany.net' }
       let(:host_data) do
         {
-          'fqdn'                      => hostname,
-          'os_triple'                 => 'solaris-11-sparc',
-          'reserved_by_user'          => 'first.last',
-          'reserved_for_reason'       => '',
-          'hours_left_on_reservation' => 35.89,
+          'fqdn' => hostname,
+          'os_triple' => 'solaris-11-sparc',
+          'reserved_by_user' => 'first.last',
+          'reserved_for_reason' => '',
+          'hours_left_on_reservation' => 35.89
         }
       end
       let(:fqdn) { hostname } # for nspooler these are the same
 
       it 'outputs fqdn for host' do
-        expect(STDOUT).to receive(:puts).with(fqdn)
+        expect($stdout).to receive(:puts).with(fqdn)
 
         subject
       end
@@ -231,19 +232,19 @@ describe Utils do
             {
               'hostname' => fqdn,
               'type' => template,
-              'enging' => 'vmpooler',
-            },
+              'enging' => 'vmpooler'
+            }
           ],
           'request' => {
             'job' => {
-              'id' => hostname,
+              'id' => hostname
             }
-          },
+          }
         }
       end
 
       it 'outputs fqdn for host' do
-        expect(STDOUT).to receive(:puts).with(fqdn)
+        expect($stdout).to receive(:puts).with(fqdn)
 
         subject
       end
@@ -275,18 +276,18 @@ describe Utils do
           hostname => {
             'template' => 'ubuntu-1604-x86_64',
             'lifetime' => 12,
-            'running'  => 9.66,
-            'state'    => 'running',
-            'ip'       => '127.0.0.1',
-            'domain'   => domain,
+            'running' => 9.66,
+            'state' => 'running',
+            'ip' => '127.0.0.1',
+            'domain' => domain
           }
         }
       end
 
-      let(:default_output) { "- #{fqdn} (ubuntu-1604-x86_64, 9.66/12 hours)" }
+      let(:default_output) { "- #{fqdn} (running, ubuntu-1604-x86_64, 9.66/12 hours)" }
 
       it 'prints output with host fqdn, template and duration info' do
-        expect(STDOUT).to receive(:puts).with(default_output)
+        expect($stdout).to receive(:puts).with(default_output)
 
         subject
       end
@@ -298,22 +299,22 @@ describe Utils do
             hostname => {
               'template' => 'redhat-7-x86_64',
               'lifetime' => 48,
-              'running'  => 7.67,
-              'state'    => 'running',
-              'tags'     => {
+              'running' => 7.67,
+              'state' => 'running',
+              'tags' => {
                 'user' => 'bob',
-                'role' => 'agent',
+                'role' => 'agent'
               },
-              'ip'       => '127.0.0.1',
-              'domain'   => domain,
+              'ip' => '127.0.0.1',
+              'domain' => domain
             }
           }
         end
 
         it 'prints output with host fqdn, template, duration info, and tags' do
-          output = "- #{fqdn} (redhat-7-x86_64, 7.67/48 hours, user: bob, role: agent)"
+          output = "- #{fqdn} (running, redhat-7-x86_64, 7.67/48 hours, user: bob, role: agent)"
 
-          expect(STDOUT).to receive(:puts).with(output)
+          expect($stdout).to receive(:puts).with(output)
 
           subject
         end
@@ -323,7 +324,7 @@ describe Utils do
         let(:print_to_stderr) { true }
 
         it 'outputs to stderr instead of stdout' do
-          expect(STDERR).to receive(:puts).with(default_output)
+          expect($stderr).to receive(:puts).with(default_output)
 
           subject
         end
@@ -337,11 +338,11 @@ describe Utils do
       let(:response_body) do
         {
           hostname => {
-            'fqdn'                      => hostname,
-            'os_triple'                 => 'solaris-11-sparc',
-            'reserved_by_user'          => 'first.last',
-            'reserved_for_reason'       => '',
-            'hours_left_on_reservation' => 35.89,
+            'fqdn' => hostname,
+            'os_triple' => 'solaris-11-sparc',
+            'reserved_by_user' => 'first.last',
+            'reserved_for_reason' => '',
+            'hours_left_on_reservation' => 35.89
           }
         }
       end
@@ -349,7 +350,7 @@ describe Utils do
       let(:default_output) { "- #{hostname} (solaris-11-sparc, 35.89h remaining)" }
 
       it 'prints output with host, template, and time remaining' do
-        expect(STDOUT).to receive(:puts).with(default_output)
+        expect($stdout).to receive(:puts).with(default_output)
 
         subject
       end
@@ -358,11 +359,11 @@ describe Utils do
         let(:response_body) do
           {
             hostname => {
-              'fqdn'                      => hostname,
-              'os_triple'                 => 'solaris-11-sparc',
-              'reserved_by_user'          => 'first.last',
-              'reserved_for_reason'       => 'testing',
-              'hours_left_on_reservation' => 35.89,
+              'fqdn' => hostname,
+              'os_triple' => 'solaris-11-sparc',
+              'reserved_by_user' => 'first.last',
+              'reserved_for_reason' => 'testing',
+              'hours_left_on_reservation' => 35.89
             }
           }
         end
@@ -370,7 +371,7 @@ describe Utils do
         it 'prints output with host, template, time remaining, and reason' do
           output = '- sol11-9.delivery.mycompany.net (solaris-11-sparc, 35.89h remaining, reason: testing)'
 
-          expect(STDOUT).to receive(:puts).with(output)
+          expect($stdout).to receive(:puts).with(output)
 
           subject
         end
@@ -380,7 +381,7 @@ describe Utils do
         let(:print_to_stderr) { true }
 
         it 'outputs to stderr instead of stdout' do
-          expect(STDERR).to receive(:puts).with(default_output)
+          expect($stderr).to receive(:puts).with(default_output)
 
           subject
         end
@@ -392,7 +393,7 @@ describe Utils do
 
       let(:hostname) { '1597952189390' }
       let(:fqdn) { 'example-noun.delivery.mycompany.net' }
-      let(:fqdn_hostname) {'example-noun'}
+      let(:fqdn_hostname) { 'example-noun' }
       let(:template) { 'ubuntu-1604-x86_64' }
 
       # This seems to be the miminal stub response from ABS for the current output
@@ -404,14 +405,14 @@ describe Utils do
               {
                 'hostname' => fqdn,
                 'type' => template,
-                'engine' => 'vmpooler',
-              },
+                'engine' => 'vmpooler'
+              }
             ],
             'request' => {
               'job' => {
-                'id' => hostname,
+                'id' => hostname
               }
-            },
+            }
           }
         }
       end
@@ -420,47 +421,58 @@ describe Utils do
       let(:domain) { 'delivery.mycompany.net' }
       let(:response_body_vmpooler) do
         {
-            fqdn_hostname => {
-                'template' => template,
-                'lifetime' => 48,
-                'running'  => 7.67,
-                'state'    => 'running',
-                'tags'     => {
-                    'user' => 'bob',
-                    'role' => 'agent',
-                },
-                'ip'       => '127.0.0.1',
-                'domain'   => domain,
-            }
+          fqdn_hostname => {
+            'template' => template,
+            'lifetime' => 48,
+            'running' => 7.67,
+            'state' => 'running',
+            'tags' => {
+              'user' => 'bob',
+              'role' => 'agent'
+            },
+            'ip' => '127.0.0.1',
+            'domain' => domain
+          }
         }
       end
 
       before(:each) do
         allow(Utils).to receive(:get_vmpooler_service_config).and_return({
-          'url' => 'http://vmpooler.example.com',
-          'token' => 'krypto-knight'
-        })
+                                                                           'url' => 'http://vmpooler.example.com',
+                                                                           'token' => 'krypto-knight'
+                                                                         })
         allow(service).to receive(:query)
-                              .with(anything, fqdn_hostname)
-                              .and_return(response_body_vmpooler)
+          .with(anything, fqdn_hostname)
+          .and_return(response_body_vmpooler)
       end
 
       let(:default_output_first_line) { "- [JobID:#{hostname}] <allocated>" }
       let(:default_output_second_line) { "  - #{fqdn} (#{template})" }
 
       it 'prints output with job id, host, and template' do
-        expect(STDOUT).to receive(:puts).with(default_output_first_line)
-        expect(STDOUT).to receive(:puts).with(default_output_second_line)
+        expect($stdout).to receive(:puts).with(default_output_first_line)
+        expect($stdout).to receive(:puts).with(default_output_second_line)
 
         subject
       end
 
       it 'prints more information when vmpooler_fallback is set output with job id, host, template, lifetime, user and role' do
-        fallback = {'vmpooler_fallback' => 'vmpooler'}
+        fallback = { 'vmpooler_fallback' => 'vmpooler' }
+        service.config.merge! fallback
+        default_output_second_line = "  - #{fqdn} (running, #{template}, 7.67/48 hours, user: bob, role: agent)"
+        expect($stdout).to receive(:puts).with(default_output_first_line)
+        expect($stdout).to receive(:puts).with(default_output_second_line)
+
+        subject
+      end
+
+      it 'prints DESTROYED and hostname when destroyed' do
+        fallback = { 'vmpooler_fallback' => 'vmpooler' }
         service.config.merge! fallback
-        default_output_second_line="  - #{fqdn} (#{template}, 7.67/48 hours, user: bob, role: agent)"
-        expect(STDOUT).to receive(:puts).with(default_output_first_line)
-        expect(STDOUT).to receive(:puts).with(default_output_second_line)
+        response_body_vmpooler[fqdn_hostname]['state'] = 'destroyed'
+        default_output_second_line = "  - DESTROYED #{fqdn}"
+        expect($stdout).to receive(:puts).with(default_output_first_line)
+        expect($stdout).to receive(:puts).with(default_output_second_line)
 
         subject
       end
@@ -469,8 +481,8 @@ describe Utils do
         let(:print_to_stderr) { true }
 
         it 'outputs to stderr instead of stdout' do
-          expect(STDERR).to receive(:puts).with(default_output_first_line)
-          expect(STDERR).to receive(:puts).with(default_output_second_line)
+          expect($stderr).to receive(:puts).with(default_output_first_line)
+          expect($stderr).to receive(:puts).with(default_output_second_line)
 
           subject
         end
@@ -483,34 +495,34 @@ describe Utils do
       let(:hostname) { '1597952189390' }
       let(:fqdn) { 'this-noun.delivery.mycompany.net' }
       let(:fqdn_ns) { 'that-noun.delivery.mycompany.net' }
-      let(:fqdn_hostname) {'this-noun'}
-      let(:fqdn_ns_hostname) {'that-noun'}
+      let(:fqdn_hostname) { 'this-noun' }
+      let(:fqdn_ns_hostname) { 'that-noun' }
       let(:template) { 'ubuntu-1604-x86_64' }
       let(:template_ns) { 'solaris-10-sparc' }
 
       # This seems to be the miminal stub response from ABS for the current output
       let(:response_body) do
         {
-            hostname => {
-                'state' => 'allocated',
-                'allocated_resources' => [
-                    {
-                        'hostname' => fqdn,
-                        'type' => template,
-                        'engine' => 'vmpooler',
-                    },
-                    {
-                        'hostname' => fqdn_ns,
-                        'type' => template_ns,
-                        'engine' => 'nspooler',
-                    },
-                ],
-                'request' => {
-                    'job' => {
-                        'id' => hostname,
-                    }
-                },
+          hostname => {
+            'state' => 'allocated',
+            'allocated_resources' => [
+              {
+                'hostname' => fqdn,
+                'type' => template,
+                'engine' => 'vmpooler'
+              },
+              {
+                'hostname' => fqdn_ns,
+                'type' => template_ns,
+                'engine' => 'nspooler'
+              }
+            ],
+            'request' => {
+              'job' => {
+                'id' => hostname
+              }
             }
+          }
         }
       end
 
@@ -518,29 +530,29 @@ describe Utils do
       let(:domain) { 'delivery.mycompany.net' }
       let(:response_body_vmpooler) do
         {
-            fqdn_hostname => {
-                'template' => template,
-                'lifetime' => 48,
-                'running'  => 7.67,
-                'state'    => 'running',
-                'tags'     => {
-                    'user' => 'bob',
-                    'role' => 'agent',
-                },
-                'ip'       => '127.0.0.1',
-                'domain'   => domain,
-            }
+          fqdn_hostname => {
+            'template' => template,
+            'lifetime' => 48,
+            'running' => 7.67,
+            'state' => 'running',
+            'tags' => {
+              'user' => 'bob',
+              'role' => 'agent'
+            },
+            'ip' => '127.0.0.1',
+            'domain' => domain
+          }
         }
       end
 
       before(:each) do
         allow(Utils).to receive(:get_vmpooler_service_config).and_return({
-                                                                             'url' => 'http://vmpooler.example.com',
-                                                                             'token' => 'krypto-knight'
+                                                                           'url' => 'http://vmpooler.example.com',
+                                                                           'token' => 'krypto-knight'
                                                                          })
         allow(service).to receive(:query)
-                              .with(anything, fqdn_hostname)
-                              .and_return(response_body_vmpooler)
+          .with(anything, fqdn_hostname)
+          .and_return(response_body_vmpooler)
       end
 
       let(:default_output_first_line) { "- [JobID:#{hostname}] <allocated>" }
@@ -548,9 +560,9 @@ describe Utils do
       let(:default_output_third_line) { "  - #{fqdn_ns} (#{template_ns})" }
 
       it 'prints output with job id, host, and template' do
-        expect(STDOUT).to receive(:puts).with(default_output_first_line)
-        expect(STDOUT).to receive(:puts).with(default_output_second_line)
-        expect(STDOUT).to receive(:puts).with(default_output_third_line)
+        expect($stdout).to receive(:puts).with(default_output_first_line)
+        expect($stdout).to receive(:puts).with(default_output_second_line)
+        expect($stdout).to receive(:puts).with(default_output_third_line)
 
         subject
       end
@@ -559,9 +571,9 @@ describe Utils do
         let(:print_to_stderr) { true }
 
         it 'outputs to stderr instead of stdout' do
-          expect(STDERR).to receive(:puts).with(default_output_first_line)
-          expect(STDERR).to receive(:puts).with(default_output_second_line)
-          expect(STDERR).to receive(:puts).with(default_output_third_line)
+          expect($stderr).to receive(:puts).with(default_output_first_line)
+          expect($stderr).to receive(:puts).with(default_output_second_line)
+          expect($stderr).to receive(:puts).with(default_output_third_line)
 
           subject
         end
@@ -575,54 +587,59 @@ describe Utils do
       config = {
         'user' => 'foo',
         'services' => {
-            'myabs' => {
-              'url' => 'http://abs.com',
-              'token' => 'krypto-night',
-              'type' => 'abs'
-            }
+          'myabs' => {
+            'url' => 'http://abs.com',
+            'token' => 'krypto-night',
+            'type' => 'abs'
+          }
         }
       }
       allow(Conf).to receive(:read_config).and_return(config)
-      expect{Utils.get_vmpooler_service_config(config['services']['myabs']['vmpooler_fallback'])}.to raise_error(ArgumentError)
+      expect do
+        Utils.get_vmpooler_service_config(config['services']['myabs']['vmpooler_fallback'])
+      end.to raise_error(ArgumentError)
     end
     it 'returns an error if the vmpooler_fallback is setup but cannot be found' do
       config = {
         'user' => 'foo',
         'services' => {
           'myabs' => {
-              'url' => 'http://abs.com',
-              'token' => 'krypto-night',
-              'type' => 'abs',
-              'vmpooler_fallback' => 'myvmpooler'
+            'url' => 'http://abs.com',
+            'token' => 'krypto-night',
+            'type' => 'abs',
+            'vmpooler_fallback' => 'myvmpooler'
           }
         }
       }
       allow(Conf).to receive(:read_config).and_return(config)
-      expect{Utils.get_vmpooler_service_config(config['services']['myabs']['vmpooler_fallback'])}.to raise_error(ArgumentError, /myvmpooler/)
+      expect do
+        Utils.get_vmpooler_service_config(config['services']['myabs']['vmpooler_fallback'])
+      end.to raise_error(ArgumentError,
+                         /myvmpooler/)
     end
     it 'returns the vmpooler_fallback config' do
       config = {
         'user' => 'foo',
         'services' => {
           'myabs' => {
-              'url' => 'http://abs.com',
-              'token' => 'krypto-night',
-              'type' => 'abs',
-              'vmpooler_fallback' => 'myvmpooler'
+            'url' => 'http://abs.com',
+            'token' => 'krypto-night',
+            'type' => 'abs',
+            'vmpooler_fallback' => 'myvmpooler'
           },
           'myvmpooler' => {
-              'url' => 'http://vmpooler.com',
-              'token' => 'krypto-knight'
+            'url' => 'http://vmpooler.com',
+            'token' => 'krypto-knight'
           }
         }
       }
       allow(Conf).to receive(:read_config).and_return(config)
       expect(Utils.get_vmpooler_service_config(config['services']['myabs']['vmpooler_fallback'])).to include({
-                                                                                       'url' => 'http://vmpooler.com',
-                                                                                       'token' => 'krypto-knight',
-                                                                                       'user' => 'foo',
-                                                                                       'type' => 'vmpooler'
-                                                                                   })
+                                                                                                               'url' => 'http://vmpooler.com',
+                                                                                                               'token' => 'krypto-knight',
+                                                                                                               'user' => 'foo',
+                                                                                                               'type' => 'vmpooler'
+                                                                                                             })
     end
   end
 end