vmfloaty 1.0.0 → 1.4.0

data/spec/vmfloaty/pooler_spec.rb

@@ -15,7 +15,7 @@ describe Pooler do
 
     it 'returns a hash with operating systems from the pooler' do
       stub_request(:get, "#{@vmpooler_url}/vm")
-        .to_return(:status => 200, :body => @list_response_body, :headers => {})
+        .to_return(status: 200, body: @list_response_body, headers: {})
 
       list = Pooler.list(false, @vmpooler_url, nil)
       expect(list).to be_an_instance_of Array
@@ -23,7 +23,7 @@ describe Pooler do
 
     it 'filters operating systems based on the filter param' do
       stub_request(:get, "#{@vmpooler_url}/vm")
-        .to_return(:status => 200, :body => @list_response_body, :headers => {})
+        .to_return(status: 200, body: @list_response_body, headers: {})
 
       list = Pooler.list(false, @vmpooler_url, 'deb')
       expect(list).to be_an_instance_of Array
@@ -32,7 +32,7 @@ describe Pooler do
 
     it 'returns nothing if the filter does not match' do
       stub_request(:get, "#{@vmpooler_url}/vm")
-        .to_return(:status => 200, :body => @list_response_body, :headers => {})
+        .to_return(status: 200, body: @list_response_body, headers: {})
 
       list = Pooler.list(false, @vmpooler_url, 'windows')
       expect(list).to be_an_instance_of Array
@@ -48,8 +48,8 @@ describe Pooler do
 
     it 'raises an AuthError if the token is invalid' do
       stub_request(:post, "#{@vmpooler_url}/vm/debian-7-i386")
-        .with(:headers => { 'X-Auth-Token' => 'mytokenfile' })
-        .to_return(:status => 401, :body => '{"ok":false}', :headers => {})
+        .with(headers: { 'X-Auth-Token' => 'mytokenfile' })
+        .to_return(status: 401, body: '{"ok":false}', headers: {})
 
       vm_hash = {}
       vm_hash['debian-7-i386'] = 1
@@ -58,8 +58,8 @@ describe Pooler do
 
     it 'retrieves a single vm with a token' do
       stub_request(:post, "#{@vmpooler_url}/vm/debian-7-i386")
-        .with(:headers => { 'X-Auth-Token' => 'mytokenfile' })
-        .to_return(:status => 200, :body => @retrieve_response_body_single, :headers => {})
+        .with(headers: { 'X-Auth-Token' => 'mytokenfile' })
+        .to_return(status: 200, body: @retrieve_response_body_single, headers: {})
 
       vm_hash = {}
       vm_hash['debian-7-i386'] = 1
@@ -71,8 +71,8 @@ describe Pooler do
 
     it 'retrieves a multiple vms with a token' do
       stub_request(:post, "#{@vmpooler_url}/vm/debian-7-i386+debian-7-i386+centos-7-x86_64")
-        .with(:headers => { 'X-Auth-Token' => 'mytokenfile' })
-        .to_return(:status => 200, :body => @retrieve_response_body_double, :headers => {})
+        .with(headers: { 'X-Auth-Token' => 'mytokenfile' })
+        .to_return(status: 200, body: @retrieve_response_body_double, headers: {})
 
       vm_hash = {}
       vm_hash['debian-7-i386'] = 2
@@ -89,11 +89,11 @@ describe Pooler do
       let(:ondemand_response) { '{"ok":true,"request_id":"1234"}' }
       it 'retreives the vm with a token' do
         stub_request(:post, "#{@vmpooler_url}/ondemandvm/debian-7-i386")
-          .with(:headers => { 'X-Auth-Token' => 'mytokenfile' })
-          .to_return(:status => 200, :body => ondemand_response, :headers => {})
+          .with(headers: { 'X-Auth-Token' => 'mytokenfile' })
+          .to_return(status: 200, body: ondemand_response, headers: {})
 
         stub_request(:get, "#{@vmpooler_url}/ondemandvm/1234")
-          .to_return(:status => 200, :body => @retrieve_response_body_single, :headers => {})
+          .to_return(status: 200, body: @retrieve_response_body_single, headers: {})
 
         vm_hash = {}
         vm_hash['debian-7-i386'] = 1
@@ -117,11 +117,11 @@ describe Pooler do
     end
 
     it 'modifies the TTL of a vm' do
-      modify_hash = { :lifetime => 12 }
+      modify_hash = { lifetime: 12 }
       stub_request(:put, "#{@vmpooler_url}/vm/fq6qlpjlsskycq6")
-        .with(:body    => { '{"lifetime":12}' => true },
-              :headers => { 'Content-Type' => 'application/x-www-form-urlencoded', 'X-Auth-Token' => 'mytokenfile' })
-        .to_return(:status => 200, :body => @modify_response_body_success, :headers => {})
+        .with(body: { '{"lifetime":12}' => nil },
+              headers: get_headers(content_type: 'application/x-www-form-urlencoded', token: 'mytokenfile'))
+        .to_return(status: 200, body: @modify_response_body_success, headers: {})
 
       modify_req = Pooler.modify(false, @vmpooler_url, 'fq6qlpjlsskycq6', 'mytokenfile', modify_hash)
       expect(modify_req['ok']).to be true
@@ -136,8 +136,8 @@ describe Pooler do
 
     it 'deletes a specified vm' do
       stub_request(:delete, "#{@vmpooler_url}/vm/fq6qlpjlsskycq6")
-        .with(:headers => { 'X-Auth-Token' => 'mytokenfile' })
-        .to_return(:status => 200, :body => @delete_response_body_success, :headers => {})
+        .with(headers: { 'X-Auth-Token' => 'mytokenfile' })
+        .to_return(status: 200, body: @delete_response_body_success, headers: {})
 
       expect(Pooler.delete(false, @vmpooler_url, ['fq6qlpjlsskycq6'], 'mytokenfile', nil)).to eq @delete_response
     end
@@ -155,7 +155,7 @@ describe Pooler do
 
     it 'prints the status' do
       stub_request(:get, "#{@vmpooler_url}/status")
-        .to_return(:status => 200, :body => @status_response_body, :headers => {})
+        .to_return(status: 200, body: @status_response_body, headers: {})
 
       status = Pooler.status(false, @vmpooler_url)
       expect(status).to be_an_instance_of Hash
@@ -178,7 +178,7 @@ describe Pooler do
 
     it 'makes a query about a vm' do
       stub_request(:get, "#{@vmpooler_url}/vm/fq6qlpjlsskycq6")
-        .to_return(:status => 200, :body => @query_response_body, :headers => {})
+        .to_return(status: 200, body: @query_response_body, headers: {})
 
       query_req = Pooler.query(false, @vmpooler_url, 'fq6qlpjlsskycq6')
       expect(query_req).to be_an_instance_of Hash
@@ -192,8 +192,8 @@ describe Pooler do
 
     it 'makes a snapshot for a single vm' do
       stub_request(:post, "#{@vmpooler_url}/vm/fq6qlpjlsskycq6/snapshot")
-        .with(:headers => { 'X-Auth-Token' => 'mytokenfile' })
-        .to_return(:status => 200, :body => @snapshot_response_body, :headers => {})
+        .with(headers: { 'X-Auth-Token' => 'mytokenfile' })
+        .to_return(status: 200, body: @snapshot_response_body, headers: {})
 
       snapshot_req = Pooler.snapshot(false, @vmpooler_url, 'fq6qlpjlsskycq6', 'mytokenfile')
       expect(snapshot_req['ok']).to be true
@@ -207,15 +207,18 @@ describe Pooler do
 
     it 'makes a request to revert a vm from a snapshot' do
       stub_request(:post, "#{@vmpooler_url}/vm/fq6qlpjlsskycq6/snapshot/dAfewKNfaweLKNve")
-        .with(:headers => { 'X-Auth-Token' => 'mytokenfile' })
-        .to_return(:status => 200, :body => @revert_response_body, :headers => {})
+        .with(headers: { 'X-Auth-Token' => 'mytokenfile' })
+        .to_return(status: 200, body: @revert_response_body, headers: {})
 
       revert_req = Pooler.revert(false, @vmpooler_url, 'fq6qlpjlsskycq6', 'mytokenfile', 'dAfewKNfaweLKNve')
       expect(revert_req['ok']).to be true
     end
 
     it "doesn't make a request to revert a vm if snapshot is not provided" do
-      expect { Pooler.revert(false, @vmpooler_url, 'fq6qlpjlsskycq6', 'mytokenfile', nil) }.to raise_error(RuntimeError, 'Snapshot SHA provided was nil, could not revert fq6qlpjlsskycq6')
+      expect do
+        Pooler.revert(false, @vmpooler_url, 'fq6qlpjlsskycq6', 'mytokenfile',
+                      nil)
+      end.to raise_error(RuntimeError, 'Snapshot SHA provided was nil, could not revert fq6qlpjlsskycq6')
     end
 
     it 'raises a TokenError if no token was provided' do
@@ -231,7 +234,7 @@ describe Pooler do
 
     it 'makes a request to extend disk space of a vm' do
       stub_request(:post, "#{@vmpooler_url}/vm/fq6qlpjlsskycq6/disk/12")
-        .with(:headers => { 'X-Auth-Token' => 'mytokenfile' }). to_return(:status => 200, :body => @disk_response_body_success, :headers => {})
+        .with(headers: { 'X-Auth-Token' => 'mytokenfile' }).to_return(status: 200, body: @disk_response_body_success, headers: {})
 
       disk_req = Pooler.disk(false, @vmpooler_url, 'fq6qlpjlsskycq6', 'mytokenfile', 12)
       expect(disk_req['ok']).to be true

data/spec/vmfloaty/service_spec.rb

@@ -16,7 +16,7 @@ describe Service do
     it 'prompts the user for their password and retrieves a token' do
       config = { 'user' => 'first.last', 'url' => 'http://default.url' }
       service = Service.new(MockOptions.new, config)
-      allow(STDOUT).to receive(:puts).with('Enter your http://default.url service password:')
+      allow($stdout).to receive(:puts).with('Enter your http://default.url service password:')
       allow(Commander::UI).to(receive(:password)
                                   .with('Enter your http://default.url service password:', '*')
                                   .and_return('hunter2'))
@@ -29,9 +29,9 @@ describe Service do
     it 'prompts the user for their username and password if the username is unknown' do
       config = { 'url' => 'http://default.url' }
       service = Service.new(MockOptions.new({}), config)
-      allow(STDOUT).to receive(:puts).with 'Enter your http://default.url service username:'
-      allow(STDOUT).to receive(:puts).with "\n"
-      allow(STDIN).to receive(:gets).and_return('first.last')
+      allow($stdout).to receive(:puts).with 'Enter your http://default.url service username:'
+      allow($stdout).to receive(:puts).with "\n"
+      allow($stdin).to receive(:gets).and_return('first.last')
       allow(Commander::UI).to(receive(:password)
                                   .with('Enter your http://default.url service password:', '*')
                                   .and_return('hunter2'))
@@ -59,16 +59,16 @@ describe Service do
     it 'reports the status of a token' do
       config = {
         'user' => 'first.last',
-        'url'  => 'http://default.url',
+        'url' => 'http://default.url'
       }
       options = MockOptions.new('token' => 'token-value')
       service = Service.new(options, config)
       status = {
-        'ok'             => true,
-        'user'           => config['user'],
-        'created'        => '2017-09-22 02:04:18 +0000',
-        'last_accessed'  => '2017-09-22 02:04:28 +0000',
-        'reserved_hosts' => [],
+        'ok' => true,
+        'user' => config['user'],
+        'created' => '2017-09-22 02:04:18 +0000',
+        'last_accessed' => '2017-09-22 02:04:28 +0000',
+        'reserved_hosts' => []
       }
       allow(Auth).to(receive(:token_status)
                          .with(nil, config['url'], 'token-value')

data/spec/vmfloaty/ssh_spec.rb

@@ -8,14 +8,14 @@ class ServiceStub
     if os_types.keys[0] == 'abs_host_string'
       return {
         os_types.keys[0] => { 'hostname' => ['abs-hostname.delivery.puppetlabs.net'] },
-        'ok'             => true,
+        'ok' => true
       }
     end
 
     {
       os_types.keys[0] => { 'hostname' => 'vmpooler-hostname' },
-      'domain'         => 'delivery.puppetlabs.net',
-      'ok'             => true,
+      'domain' => 'delivery.puppetlabs.net',
+      'ok' => true
     }
   end
 

data/spec/vmfloaty/utils_spec.rb

@@ -5,6 +5,11 @@ require 'json'
 require 'commander/command'
 require_relative '../../lib/vmfloaty/utils'
 
+# allow changing config in service for tests
+class Service
+  attr_writer :config
+end
+
 describe Utils do
   describe '#standardize_hostnames' do
     before :each do
@@ -31,13 +36,14 @@ describe Utils do
 
     it 'formats a result from vmpooler into a hash of os to hostnames' do
       result = Utils.standardize_hostnames(JSON.parse(@vmpooler_response_body))
-      expect(result).to eq('centos-7-x86_64'    => ['dlgietfmgeegry2.delivery.mycompany.net'],
-                           'ubuntu-1610-x86_64' => ['gdoy8q3nckuob0i.delivery.mycompany.net', 'ctnktsd0u11p9tm.delivery.mycompany.net'])
+      expect(result).to eq('centos-7-x86_64' => ['dlgietfmgeegry2.delivery.mycompany.net'],
+                           'ubuntu-1610-x86_64' => ['gdoy8q3nckuob0i.delivery.mycompany.net',
+                                                    'ctnktsd0u11p9tm.delivery.mycompany.net'])
     end
 
     it 'formats a result from the nonstandard pooler into a hash of os to hostnames' do
       result = Utils.standardize_hostnames(JSON.parse(@nonstandard_response_body))
-      expect(result).to eq('solaris-10-sparc'    => ['sol10-10.delivery.mycompany.net', 'sol10-11.delivery.mycompany.net'],
+      expect(result).to eq('solaris-10-sparc' => ['sol10-10.delivery.mycompany.net', 'sol10-11.delivery.mycompany.net'],
                            'ubuntu-16.04-power8' => ['power8-ubuntu16.04-6.delivery.mycompany.net'])
     end
   end
@@ -45,12 +51,12 @@ describe Utils do
   describe '#format_host_output' do
     before :each do
       @vmpooler_results = {
-        'centos-7-x86_64'    => ['dlgietfmgeegry2.delivery.mycompany.net'],
-        'ubuntu-1610-x86_64' => ['gdoy8q3nckuob0i.delivery.mycompany.net', 'ctnktsd0u11p9tm.delivery.mycompany.net'],
+        'centos-7-x86_64' => ['dlgietfmgeegry2.delivery.mycompany.net'],
+        'ubuntu-1610-x86_64' => ['gdoy8q3nckuob0i.delivery.mycompany.net', 'ctnktsd0u11p9tm.delivery.mycompany.net']
       }
       @nonstandard_results = {
-        'solaris-10-sparc'    => ['sol10-10.delivery.mycompany.net', 'sol10-11.delivery.mycompany.net'],
-        'ubuntu-16.04-power8' => ['power8-ubuntu16.04-6.delivery.mycompany.net'],
+        'solaris-10-sparc' => ['sol10-10.delivery.mycompany.net', 'sol10-11.delivery.mycompany.net'],
+        'ubuntu-16.04-power8' => ['power8-ubuntu16.04-6.delivery.mycompany.net']
       }
       @vmpooler_output = <<~OUT.chomp
         - dlgietfmgeegry2.delivery.mycompany.net (centos-7-x86_64)
@@ -93,23 +99,23 @@ describe Utils do
   describe '#get_service_config' do
     before :each do
       @default_config = {
-        'url'   => 'http://default.url',
-        'user'  => 'first.last.default',
-        'token' => 'default-token',
+        'url' => 'http://default.url',
+        'user' => 'first.last.default',
+        'token' => 'default-token'
       }
       @services_config = {
         'services' => {
           'vm' => {
-            'url'   => 'http://vmpooler.url',
-            'user'  => 'first.last.vmpooler',
-            'token' => 'vmpooler-token',
+            'url' => 'http://vmpooler.url',
+            'user' => 'first.last.vmpooler',
+            'token' => 'vmpooler-token'
           },
           'ns' => {
-            'url'   => 'http://nspooler.url',
-            'user'  => 'first.last.nspooler',
-            'token' => 'nspooler-token',
-          },
-        },
+            'url' => 'http://nspooler.url',
+            'user' => 'first.last.nspooler',
+            'token' => 'nspooler-token'
+          }
+        }
       }
     end
 
@@ -121,26 +127,26 @@ describe Utils do
 
     it 'allows selection by configured service key' do
       config = @default_config.merge @services_config
-      options = MockOptions.new(:service => 'ns')
+      options = MockOptions.new(service: 'ns')
       expect(Utils.get_service_config(config, options)).to include @services_config['services']['ns']
     end
 
     it 'uses top-level service config values as defaults when configured service values are missing' do
       config = @default_config.merge @services_config
       config['services']['vm'].delete 'url'
-      options = MockOptions.new(:service => 'vm')
+      options = MockOptions.new(service: 'vm')
       expect(Utils.get_service_config(config, options)['url']).to eq 'http://default.url'
     end
 
     it "raises an error if passed a service name that hasn't been configured" do
       config = @default_config.merge @services_config
-      options = MockOptions.new(:service => 'none')
+      options = MockOptions.new(service: 'none')
       expect { Utils.get_service_config(config, options) }.to raise_error ArgumentError
     end
 
     it 'prioritizes values passed as command line options over configuration options' do
       config = @default_config
-      options = MockOptions.new(:url => 'http://alternate.url', :token => 'alternate-token')
+      options = MockOptions.new(url: 'http://alternate.url', token: 'alternate-token')
       expected = config.merge('url' => 'http://alternate.url', 'token' => 'alternate-token')
       expect(Utils.get_service_config(config, options)).to include expected
     end
@@ -177,15 +183,15 @@ describe Utils do
         {
           'template' => 'ubuntu-1604-x86_64',
           'lifetime' => 12,
-          'running'  => 9.66,
-          'state'    => 'running',
-          'ip'       => '127.0.0.1',
-          'domain'   => domain,
+          'running' => 9.66,
+          'state' => 'running',
+          'ip' => '127.0.0.1',
+          'domain' => domain
         }
       end
 
       it 'outputs fqdn for host' do
-        expect(STDOUT).to receive(:puts).with(fqdn)
+        expect($stdout).to receive(:puts).with(fqdn)
 
         subject
       end
@@ -196,17 +202,17 @@ describe Utils do
       let(:hostname) { 'sol11-9.delivery.mycompany.net' }
       let(:host_data) do
         {
-          'fqdn'                      => hostname,
-          'os_triple'                 => 'solaris-11-sparc',
-          'reserved_by_user'          => 'first.last',
-          'reserved_for_reason'       => '',
-          'hours_left_on_reservation' => 35.89,
+          'fqdn' => hostname,
+          'os_triple' => 'solaris-11-sparc',
+          'reserved_by_user' => 'first.last',
+          'reserved_for_reason' => '',
+          'hours_left_on_reservation' => 35.89
         }
       end
       let(:fqdn) { hostname } # for nspooler these are the same
 
       it 'outputs fqdn for host' do
-        expect(STDOUT).to receive(:puts).with(fqdn)
+        expect($stdout).to receive(:puts).with(fqdn)
 
         subject
       end
@@ -226,19 +232,19 @@ describe Utils do
             {
               'hostname' => fqdn,
               'type' => template,
-              'enging' => 'vmpooler',
-            },
+              'enging' => 'vmpooler'
+            }
           ],
           'request' => {
             'job' => {
-              'id' => hostname,
+              'id' => hostname
             }
-          },
+          }
         }
       end
 
       it 'outputs fqdn for host' do
-        expect(STDOUT).to receive(:puts).with(fqdn)
+        expect($stdout).to receive(:puts).with(fqdn)
 
         subject
       end
@@ -270,18 +276,18 @@ describe Utils do
           hostname => {
             'template' => 'ubuntu-1604-x86_64',
             'lifetime' => 12,
-            'running'  => 9.66,
-            'state'    => 'running',
-            'ip'       => '127.0.0.1',
-            'domain'   => domain,
+            'running' => 9.66,
+            'state' => 'running',
+            'ip' => '127.0.0.1',
+            'domain' => domain
           }
         }
       end
 
-      let(:default_output) { "- #{fqdn} (ubuntu-1604-x86_64, 9.66/12 hours)" }
+      let(:default_output) { "- #{fqdn} (running, ubuntu-1604-x86_64, 9.66/12 hours)" }
 
       it 'prints output with host fqdn, template and duration info' do
-        expect(STDOUT).to receive(:puts).with(default_output)
+        expect($stdout).to receive(:puts).with(default_output)
 
         subject
       end
@@ -293,22 +299,22 @@ describe Utils do
             hostname => {
               'template' => 'redhat-7-x86_64',
               'lifetime' => 48,
-              'running'  => 7.67,
-              'state'    => 'running',
-              'tags'     => {
+              'running' => 7.67,
+              'state' => 'running',
+              'tags' => {
                 'user' => 'bob',
-                'role' => 'agent',
+                'role' => 'agent'
               },
-              'ip'       => '127.0.0.1',
-              'domain'   => domain,
+              'ip' => '127.0.0.1',
+              'domain' => domain
             }
           }
         end
 
         it 'prints output with host fqdn, template, duration info, and tags' do
-          output = "- #{fqdn} (redhat-7-x86_64, 7.67/48 hours, user: bob, role: agent)"
+          output = "- #{fqdn} (running, redhat-7-x86_64, 7.67/48 hours, user: bob, role: agent)"
 
-          expect(STDOUT).to receive(:puts).with(output)
+          expect($stdout).to receive(:puts).with(output)
 
           subject
         end
@@ -318,7 +324,7 @@ describe Utils do
         let(:print_to_stderr) { true }
 
         it 'outputs to stderr instead of stdout' do
-          expect(STDERR).to receive(:puts).with(default_output)
+          expect($stderr).to receive(:puts).with(default_output)
 
           subject
         end
@@ -332,11 +338,11 @@ describe Utils do
       let(:response_body) do
         {
           hostname => {
-            'fqdn'                      => hostname,
-            'os_triple'                 => 'solaris-11-sparc',
-            'reserved_by_user'          => 'first.last',
-            'reserved_for_reason'       => '',
-            'hours_left_on_reservation' => 35.89,
+            'fqdn' => hostname,
+            'os_triple' => 'solaris-11-sparc',
+            'reserved_by_user' => 'first.last',
+            'reserved_for_reason' => '',
+            'hours_left_on_reservation' => 35.89
           }
         }
       end
@@ -344,7 +350,7 @@ describe Utils do
       let(:default_output) { "- #{hostname} (solaris-11-sparc, 35.89h remaining)" }
 
       it 'prints output with host, template, and time remaining' do
-        expect(STDOUT).to receive(:puts).with(default_output)
+        expect($stdout).to receive(:puts).with(default_output)
 
         subject
       end
@@ -353,11 +359,11 @@ describe Utils do
         let(:response_body) do
           {
             hostname => {
-              'fqdn'                      => hostname,
-              'os_triple'                 => 'solaris-11-sparc',
-              'reserved_by_user'          => 'first.last',
-              'reserved_for_reason'       => 'testing',
-              'hours_left_on_reservation' => 35.89,
+              'fqdn' => hostname,
+              'os_triple' => 'solaris-11-sparc',
+              'reserved_by_user' => 'first.last',
+              'reserved_for_reason' => 'testing',
+              'hours_left_on_reservation' => 35.89
             }
           }
         end
@@ -365,7 +371,7 @@ describe Utils do
         it 'prints output with host, template, time remaining, and reason' do
           output = '- sol11-9.delivery.mycompany.net (solaris-11-sparc, 35.89h remaining, reason: testing)'
 
-          expect(STDOUT).to receive(:puts).with(output)
+          expect($stdout).to receive(:puts).with(output)
 
           subject
         end
@@ -375,7 +381,7 @@ describe Utils do
         let(:print_to_stderr) { true }
 
         it 'outputs to stderr instead of stdout' do
-          expect(STDERR).to receive(:puts).with(default_output)
+          expect($stderr).to receive(:puts).with(default_output)
 
           subject
         end
@@ -387,7 +393,7 @@ describe Utils do
 
       let(:hostname) { '1597952189390' }
       let(:fqdn) { 'example-noun.delivery.mycompany.net' }
-      let(:fqdn_hostname) {'example-noun'}
+      let(:fqdn_hostname) { 'example-noun' }
       let(:template) { 'ubuntu-1604-x86_64' }
 
       # This seems to be the miminal stub response from ABS for the current output
@@ -399,14 +405,14 @@ describe Utils do
               {
                 'hostname' => fqdn,
                 'type' => template,
-                'engine' => 'vmpooler',
-              },
+                'engine' => 'vmpooler'
+              }
             ],
             'request' => {
               'job' => {
-                'id' => hostname,
+                'id' => hostname
               }
-            },
+            }
           }
         }
       end
@@ -415,37 +421,58 @@ describe Utils do
       let(:domain) { 'delivery.mycompany.net' }
       let(:response_body_vmpooler) do
         {
-            fqdn_hostname => {
-                'template' => template,
-                'lifetime' => 48,
-                'running'  => 7.67,
-                'state'    => 'running',
-                'tags'     => {
-                    'user' => 'bob',
-                    'role' => 'agent',
-                },
-                'ip'       => '127.0.0.1',
-                'domain'   => domain,
-            }
+          fqdn_hostname => {
+            'template' => template,
+            'lifetime' => 48,
+            'running' => 7.67,
+            'state' => 'running',
+            'tags' => {
+              'user' => 'bob',
+              'role' => 'agent'
+            },
+            'ip' => '127.0.0.1',
+            'domain' => domain
+          }
         }
       end
 
       before(:each) do
         allow(Utils).to receive(:get_vmpooler_service_config).and_return({
-          'url' => 'http://vmpooler.example.com',
-          'token' => 'krypto-knight'
-        })
+                                                                           'url' => 'http://vmpooler.example.com',
+                                                                           'token' => 'krypto-knight'
+                                                                         })
         allow(service).to receive(:query)
-                              .with(anything, fqdn_hostname)
-                              .and_return(response_body_vmpooler)
+          .with(anything, fqdn_hostname)
+          .and_return(response_body_vmpooler)
       end
 
       let(:default_output_first_line) { "- [JobID:#{hostname}] <allocated>" }
-      let(:default_output_second_line) { "  - #{fqdn} (#{template}, 7.67/48 hours, user: bob, role: agent)" }
+      let(:default_output_second_line) { "  - #{fqdn} (#{template})" }
 
       it 'prints output with job id, host, and template' do
-        expect(STDOUT).to receive(:puts).with(default_output_first_line)
-        expect(STDOUT).to receive(:puts).with(default_output_second_line)
+        expect($stdout).to receive(:puts).with(default_output_first_line)
+        expect($stdout).to receive(:puts).with(default_output_second_line)
+
+        subject
+      end
+
+      it 'prints more information when vmpooler_fallback is set output with job id, host, template, lifetime, user and role' do
+        fallback = { 'vmpooler_fallback' => 'vmpooler' }
+        service.config.merge! fallback
+        default_output_second_line = "  - #{fqdn} (running, #{template}, 7.67/48 hours, user: bob, role: agent)"
+        expect($stdout).to receive(:puts).with(default_output_first_line)
+        expect($stdout).to receive(:puts).with(default_output_second_line)
+
+        subject
+      end
+
+      it 'prints in red when destroyed' do
+        fallback = { 'vmpooler_fallback' => 'vmpooler' }
+        service.config.merge! fallback
+        response_body_vmpooler[fqdn_hostname]['state'] = 'destroyed'
+        default_output_second_line_red = "  - #{fqdn} (destroyed, #{template}, 7.67/48 hours, user: bob, role: agent)".red
+        expect($stdout).to receive(:puts).with(default_output_first_line)
+        expect($stdout).to receive(:puts).with(default_output_second_line_red)
 
         subject
       end
@@ -454,8 +481,8 @@ describe Utils do
         let(:print_to_stderr) { true }
 
         it 'outputs to stderr instead of stdout' do
-          expect(STDERR).to receive(:puts).with(default_output_first_line)
-          expect(STDERR).to receive(:puts).with(default_output_second_line)
+          expect($stderr).to receive(:puts).with(default_output_first_line)
+          expect($stderr).to receive(:puts).with(default_output_second_line)
 
           subject
         end
@@ -468,34 +495,34 @@ describe Utils do
       let(:hostname) { '1597952189390' }
       let(:fqdn) { 'this-noun.delivery.mycompany.net' }
       let(:fqdn_ns) { 'that-noun.delivery.mycompany.net' }
-      let(:fqdn_hostname) {'this-noun'}
-      let(:fqdn_ns_hostname) {'that-noun'}
+      let(:fqdn_hostname) { 'this-noun' }
+      let(:fqdn_ns_hostname) { 'that-noun' }
       let(:template) { 'ubuntu-1604-x86_64' }
       let(:template_ns) { 'solaris-10-sparc' }
 
       # This seems to be the miminal stub response from ABS for the current output
       let(:response_body) do
         {
-            hostname => {
-                'state' => 'allocated',
-                'allocated_resources' => [
-                    {
-                        'hostname' => fqdn,
-                        'type' => template,
-                        'engine' => 'vmpooler',
-                    },
-                    {
-                        'hostname' => fqdn_ns,
-                        'type' => template_ns,
-                        'engine' => 'nspooler',
-                    },
-                ],
-                'request' => {
-                    'job' => {
-                        'id' => hostname,
-                    }
-                },
+          hostname => {
+            'state' => 'allocated',
+            'allocated_resources' => [
+              {
+                'hostname' => fqdn,
+                'type' => template,
+                'engine' => 'vmpooler'
+              },
+              {
+                'hostname' => fqdn_ns,
+                'type' => template_ns,
+                'engine' => 'nspooler'
+              }
+            ],
+            'request' => {
+              'job' => {
+                'id' => hostname
+              }
             }
+          }
         }
       end
 
@@ -503,39 +530,39 @@ describe Utils do
       let(:domain) { 'delivery.mycompany.net' }
       let(:response_body_vmpooler) do
         {
-            fqdn_hostname => {
-                'template' => template,
-                'lifetime' => 48,
-                'running'  => 7.67,
-                'state'    => 'running',
-                'tags'     => {
-                    'user' => 'bob',
-                    'role' => 'agent',
-                },
-                'ip'       => '127.0.0.1',
-                'domain'   => domain,
-            }
+          fqdn_hostname => {
+            'template' => template,
+            'lifetime' => 48,
+            'running' => 7.67,
+            'state' => 'running',
+            'tags' => {
+              'user' => 'bob',
+              'role' => 'agent'
+            },
+            'ip' => '127.0.0.1',
+            'domain' => domain
+          }
         }
       end
 
       before(:each) do
         allow(Utils).to receive(:get_vmpooler_service_config).and_return({
-                                                                             'url' => 'http://vmpooler.example.com',
-                                                                             'token' => 'krypto-knight'
+                                                                           'url' => 'http://vmpooler.example.com',
+                                                                           'token' => 'krypto-knight'
                                                                          })
         allow(service).to receive(:query)
-                              .with(anything, fqdn_hostname)
-                              .and_return(response_body_vmpooler)
+          .with(anything, fqdn_hostname)
+          .and_return(response_body_vmpooler)
       end
 
       let(:default_output_first_line) { "- [JobID:#{hostname}] <allocated>" }
-      let(:default_output_second_line) { "  - #{fqdn} (#{template}, 7.67/48 hours, user: bob, role: agent)" }
+      let(:default_output_second_line) { "  - #{fqdn} (#{template})" }
       let(:default_output_third_line) { "  - #{fqdn_ns} (#{template_ns})" }
 
       it 'prints output with job id, host, and template' do
-        expect(STDOUT).to receive(:puts).with(default_output_first_line)
-        expect(STDOUT).to receive(:puts).with(default_output_second_line)
-        expect(STDOUT).to receive(:puts).with(default_output_third_line)
+        expect($stdout).to receive(:puts).with(default_output_first_line)
+        expect($stdout).to receive(:puts).with(default_output_second_line)
+        expect($stdout).to receive(:puts).with(default_output_third_line)
 
         subject
       end
@@ -544,9 +571,9 @@ describe Utils do
         let(:print_to_stderr) { true }
 
         it 'outputs to stderr instead of stdout' do
-          expect(STDERR).to receive(:puts).with(default_output_first_line)
-          expect(STDERR).to receive(:puts).with(default_output_second_line)
-          expect(STDERR).to receive(:puts).with(default_output_third_line)
+          expect($stderr).to receive(:puts).with(default_output_first_line)
+          expect($stderr).to receive(:puts).with(default_output_second_line)
+          expect($stderr).to receive(:puts).with(default_output_third_line)
 
           subject
         end
@@ -560,54 +587,59 @@ describe Utils do
       config = {
         'user' => 'foo',
         'services' => {
-            'myabs' => {
-              'url' => 'http://abs.com',
-              'token' => 'krypto-night',
-              'type' => 'abs'
-            }
+          'myabs' => {
+            'url' => 'http://abs.com',
+            'token' => 'krypto-night',
+            'type' => 'abs'
+          }
         }
       }
       allow(Conf).to receive(:read_config).and_return(config)
-      expect{Utils.get_vmpooler_service_config(config['services']['myabs']['vmpooler_fallback'])}.to raise_error(ArgumentError)
+      expect do
+        Utils.get_vmpooler_service_config(config['services']['myabs']['vmpooler_fallback'])
+      end.to raise_error(ArgumentError)
     end
     it 'returns an error if the vmpooler_fallback is setup but cannot be found' do
       config = {
         'user' => 'foo',
         'services' => {
           'myabs' => {
-              'url' => 'http://abs.com',
-              'token' => 'krypto-night',
-              'type' => 'abs',
-              'vmpooler_fallback' => 'myvmpooler'
+            'url' => 'http://abs.com',
+            'token' => 'krypto-night',
+            'type' => 'abs',
+            'vmpooler_fallback' => 'myvmpooler'
           }
         }
       }
       allow(Conf).to receive(:read_config).and_return(config)
-      expect{Utils.get_vmpooler_service_config(config['services']['myabs']['vmpooler_fallback'])}.to raise_error(ArgumentError, /myvmpooler/)
+      expect do
+        Utils.get_vmpooler_service_config(config['services']['myabs']['vmpooler_fallback'])
+      end.to raise_error(ArgumentError,
+                         /myvmpooler/)
     end
     it 'returns the vmpooler_fallback config' do
       config = {
         'user' => 'foo',
         'services' => {
           'myabs' => {
-              'url' => 'http://abs.com',
-              'token' => 'krypto-night',
-              'type' => 'abs',
-              'vmpooler_fallback' => 'myvmpooler'
+            'url' => 'http://abs.com',
+            'token' => 'krypto-night',
+            'type' => 'abs',
+            'vmpooler_fallback' => 'myvmpooler'
           },
           'myvmpooler' => {
-              'url' => 'http://vmpooler.com',
-              'token' => 'krypto-knight'
+            'url' => 'http://vmpooler.com',
+            'token' => 'krypto-knight'
           }
         }
       }
       allow(Conf).to receive(:read_config).and_return(config)
       expect(Utils.get_vmpooler_service_config(config['services']['myabs']['vmpooler_fallback'])).to include({
-                                                                                       'url' => 'http://vmpooler.com',
-                                                                                       'token' => 'krypto-knight',
-                                                                                       'user' => 'foo',
-                                                                                       'type' => 'vmpooler'
-                                                                                   })
+                                                                                                               'url' => 'http://vmpooler.com',
+                                                                                                               'token' => 'krypto-knight',
+                                                                                                               'user' => 'foo',
+                                                                                                               'type' => 'vmpooler'
+                                                                                                             })
     end
   end
 end