vmfloaty 0.8.2 → 0.9.0

data/spec/vmfloaty/pooler_spec.rb

@@ -1,224 +1,224 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require_relative '../../lib/vmfloaty/pooler'
 
 describe Pooler do
   before :each do
-    @vmpooler_url = "https://vmpooler.example.com"
+    @vmpooler_url = 'https://vmpooler.example.com'
   end
 
-  describe "#list" do
+  describe '#list' do
     before :each do
-      @list_response_body = "[\"debian-7-i386\",\"debian-7-x86_64\",\"centos-7-x86_64\"]"
+      @list_response_body = '["debian-7-i386","debian-7-x86_64","centos-7-x86_64"]'
     end
 
-    it "returns a hash with operating systems from the pooler" do
-      stub_request(:get, "#{@vmpooler_url}/vm").
-        to_return(:status => 200, :body => @list_response_body, :headers => {})
+    it 'returns a hash with operating systems from the pooler' do
+      stub_request(:get, "#{@vmpooler_url}/vm")
+        .to_return(:status => 200, :body => @list_response_body, :headers => {})
 
       list = Pooler.list(false, @vmpooler_url, nil)
       expect(list).to be_an_instance_of Array
     end
 
-    it "filters operating systems based on the filter param" do
-      stub_request(:get, "#{@vmpooler_url}/vm").
-        to_return(:status => 200, :body => @list_response_body, :headers => {})
+    it 'filters operating systems based on the filter param' do
+      stub_request(:get, "#{@vmpooler_url}/vm")
+        .to_return(:status => 200, :body => @list_response_body, :headers => {})
 
-      list = Pooler.list(false, @vmpooler_url, "deb")
+      list = Pooler.list(false, @vmpooler_url, 'deb')
       expect(list).to be_an_instance_of Array
       expect(list.size).to equal 2
     end
 
-    it "returns nothing if the filter does not match" do
-      stub_request(:get, "#{@vmpooler_url}/vm").
-        to_return(:status => 200, :body => @list_response_body, :headers => {})
+    it 'returns nothing if the filter does not match' do
+      stub_request(:get, "#{@vmpooler_url}/vm")
+        .to_return(:status => 200, :body => @list_response_body, :headers => {})
 
-      list = Pooler.list(false, @vmpooler_url, "windows")
+      list = Pooler.list(false, @vmpooler_url, 'windows')
       expect(list).to be_an_instance_of Array
       expect(list.size).to equal 0
     end
   end
 
-  describe "#retrieve" do
+  describe '#retrieve' do
     before :each do
-      @retrieve_response_body_single = "{\"ok\":true,\"debian-7-i386\":{\"hostname\":\"fq6qlpjlsskycq6\"}}"
-      @retrieve_response_body_double = "{\"ok\":true,\"debian-7-i386\":{\"hostname\":[\"sc0o4xqtodlul5w\",\"4m4dkhqiufnjmxy\"]},\"centos-7-x86_64\":{\"hostname\":\"zb91y9qbrbf6d3q\"}}"
+      @retrieve_response_body_single = '{"ok":true,"debian-7-i386":{"hostname":"fq6qlpjlsskycq6"}}'
+      @retrieve_response_body_double = '{"ok":true,"debian-7-i386":{"hostname":["sc0o4xqtodlul5w","4m4dkhqiufnjmxy"]},"centos-7-x86_64":{"hostname":"zb91y9qbrbf6d3q"}}'
     end
 
-    it "raises an AuthError if the token is invalid" do
-      stub_request(:post, "#{@vmpooler_url}/vm/debian-7-i386").
-        with(:headers => {'Accept'=>'*/*', 'Accept-Encoding'=>'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'Content-Length'=>'0', 'User-Agent'=>'Faraday v0.9.2', 'X-Auth-Token'=>'mytokenfile'}).
-        to_return(:status => 401, :body => "{\"ok\":false}", :headers => {})
+    it 'raises an AuthError if the token is invalid' do
+      stub_request(:post, "#{@vmpooler_url}/vm/debian-7-i386")
+        .with(:headers => { 'X-Auth-Token' => 'mytokenfile' })
+        .to_return(:status => 401, :body => '{"ok":false}', :headers => {})
 
       vm_hash = {}
       vm_hash['debian-7-i386'] = 1
-      expect{ Pooler.retrieve(false, vm_hash, 'mytokenfile', @vmpooler_url) }.to raise_error(AuthError)
+      expect { Pooler.retrieve(false, vm_hash, 'mytokenfile', @vmpooler_url, 'user', {}) }.to raise_error(AuthError)
     end
 
-    it "retrieves a single vm with a token" do
-      stub_request(:post, "#{@vmpooler_url}/vm/debian-7-i386").
-        with(:headers => {'Accept'=>'*/*', 'Accept-Encoding'=>'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'Content-Length'=>'0', 'User-Agent'=>'Faraday v0.9.2', 'X-Auth-Token'=>'mytokenfile'}).
-        to_return(:status => 200, :body => @retrieve_response_body_single, :headers => {})
+    it 'retrieves a single vm with a token' do
+      stub_request(:post, "#{@vmpooler_url}/vm/debian-7-i386")
+        .with(:headers => { 'X-Auth-Token' => 'mytokenfile' })
+        .to_return(:status => 200, :body => @retrieve_response_body_single, :headers => {})
 
       vm_hash = {}
       vm_hash['debian-7-i386'] = 1
-      vm_req = Pooler.retrieve(false, vm_hash, 'mytokenfile', @vmpooler_url)
+      vm_req = Pooler.retrieve(false, vm_hash, 'mytokenfile', @vmpooler_url, 'user', {})
       expect(vm_req).to be_an_instance_of Hash
-      expect(vm_req["ok"]).to equal true
-      expect(vm_req["debian-7-i386"]["hostname"]).to eq "fq6qlpjlsskycq6"
+      expect(vm_req['ok']).to equal true
+      expect(vm_req['debian-7-i386']['hostname']).to eq 'fq6qlpjlsskycq6'
     end
 
-    it "retrieves a multiple vms with a token" do
-      stub_request(:post, "#{@vmpooler_url}/vm/debian-7-i386+debian-7-i386+centos-7-x86_64").
-        with(:headers => {'Accept'=>'*/*', 'Accept-Encoding'=>'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'Content-Length'=>'0', 'User-Agent'=>'Faraday v0.9.2', 'X-Auth-Token'=>'mytokenfile'}).
-        to_return(:status => 200, :body => @retrieve_response_body_double, :headers => {})
+    it 'retrieves a multiple vms with a token' do
+      stub_request(:post, "#{@vmpooler_url}/vm/debian-7-i386+debian-7-i386+centos-7-x86_64")
+        .with(:headers => { 'X-Auth-Token' => 'mytokenfile' })
+        .to_return(:status => 200, :body => @retrieve_response_body_double, :headers => {})
 
       vm_hash = {}
       vm_hash['debian-7-i386'] = 2
       vm_hash['centos-7-x86_64'] = 1
-      vm_req = Pooler.retrieve(false, vm_hash, 'mytokenfile', @vmpooler_url)
+      vm_req = Pooler.retrieve(false, vm_hash, 'mytokenfile', @vmpooler_url, 'user', {})
       expect(vm_req).to be_an_instance_of Hash
-      expect(vm_req["ok"]).to equal true
-      expect(vm_req["debian-7-i386"]["hostname"]).to be_an_instance_of Array
-      expect(vm_req["debian-7-i386"]["hostname"]).to eq ["sc0o4xqtodlul5w", "4m4dkhqiufnjmxy"]
-      expect(vm_req["centos-7-x86_64"]["hostname"]).to eq "zb91y9qbrbf6d3q"
+      expect(vm_req['ok']).to equal true
+      expect(vm_req['debian-7-i386']['hostname']).to be_an_instance_of Array
+      expect(vm_req['debian-7-i386']['hostname']).to eq %w[sc0o4xqtodlul5w 4m4dkhqiufnjmxy]
+      expect(vm_req['centos-7-x86_64']['hostname']).to eq 'zb91y9qbrbf6d3q'
     end
   end
 
-  describe "#modify" do
+  describe '#modify' do
     before :each do
-      @modify_response_body_success = "{\"ok\":true}"
-      @modify_response_body_fail = "{\"ok\":false}"
+      @modify_response_body_success = '{"ok":true}'
+      @modify_response_body_fail = '{"ok":false}'
     end
 
-    it "raises a TokenError if token provided is nil" do
-      expect{ Pooler.modify(false, @vmpooler_url, 'myfakehost', nil, {}) }.to raise_error(TokenError)
+    it 'raises a TokenError if token provided is nil' do
+      expect { Pooler.modify(false, @vmpooler_url, 'myfakehost', nil, {}) }.to raise_error(TokenError)
     end
 
-    it "modifies the TTL of a vm" do
+    it 'modifies the TTL of a vm' do
       modify_hash = { :lifetime => 12 }
-      stub_request(:put, "#{@vmpooler_url}/vm/fq6qlpjlsskycq6").
-        with(:body => {'{"lifetime":12}'=>true},
-             :headers => {'Accept'=>'*/*', 'Accept-Encoding'=>'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'Content-Type'=>'application/x-www-form-urlencoded', 'User-Agent'=>'Faraday v0.9.2', 'X-Auth-Token'=>'mytokenfile'}).
-        to_return(:status => 200, :body => @modify_response_body_success, :headers => {})
+      stub_request(:put, "#{@vmpooler_url}/vm/fq6qlpjlsskycq6")
+        .with(:body    => { '{"lifetime":12}' => true },
+              :headers => { 'Content-Type' => 'application/x-www-form-urlencoded', 'X-Auth-Token' => 'mytokenfile' })
+        .to_return(:status => 200, :body => @modify_response_body_success, :headers => {})
 
       modify_req = Pooler.modify(false, @vmpooler_url, 'fq6qlpjlsskycq6', 'mytokenfile', modify_hash)
-      expect(modify_req["ok"]).to be true
+      expect(modify_req['ok']).to be true
     end
   end
 
-  describe "#delete" do
+  describe '#delete' do
     before :each do
-      @delete_response_body_success = "{\"ok\":true}"
-      @delete_response = {"fq6qlpjlsskycq6"=>{"ok"=>true}}
+      @delete_response_body_success = '{"ok":true}'
+      @delete_response = { 'fq6qlpjlsskycq6' => { 'ok' => true } }
     end
 
-    it "deletes a specified vm" do
-      stub_request(:delete, "#{@vmpooler_url}/vm/fq6qlpjlsskycq6").
-        with(:headers => {'Accept'=>'*/*', 'Accept-Encoding'=>'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'User-Agent'=>'Faraday v0.9.2', 'X-Auth-Token'=>'mytokenfile'}).
-        to_return(:status => 200, :body => @delete_response_body_success, :headers => {})
+    it 'deletes a specified vm' do
+      stub_request(:delete, "#{@vmpooler_url}/vm/fq6qlpjlsskycq6")
+        .with(:headers => { 'X-Auth-Token' => 'mytokenfile' })
+        .to_return(:status => 200, :body => @delete_response_body_success, :headers => {})
 
       expect(Pooler.delete(false, @vmpooler_url, ['fq6qlpjlsskycq6'], 'mytokenfile')).to eq @delete_response
     end
 
-    it "raises a token error if no token provided" do
-      expect{ Pooler.delete(false, @vmpooler_url, ['myfakehost'], nil) }.to raise_error(TokenError)
+    it 'raises a token error if no token provided' do
+      expect { Pooler.delete(false, @vmpooler_url, ['myfakehost'], nil) }.to raise_error(TokenError)
     end
   end
 
-  describe "#status" do
+  describe '#status' do
     before :each do
-      #smaller version
-      @status_response_body = "{\"capacity\":{\"current\":716,\"total\":717,\"percent\": 99.9},\"status\":{\"ok\":true,\"message\":\"Battle station fully armed and operational.\"}}"
+      # smaller version
+      @status_response_body = '{"capacity":{"current":716,"total":717,"percent": 99.9},"status":{"ok":true,"message":"Battle station fully armed and operational."}}'
     end
 
-    it "prints the status" do
-      stub_request(:get, "#{@vmpooler_url}/status").
-        with(:headers => {'Accept'=>'*/*', 'Accept-Encoding'=>'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'User-Agent'=>'Faraday v0.9.2'}).
-        to_return(:status => 200, :body => @status_response_body, :headers => {})
+    it 'prints the status' do
+      stub_request(:get, "#{@vmpooler_url}/status")
+        .to_return(:status => 200, :body => @status_response_body, :headers => {})
 
       status = Pooler.status(false, @vmpooler_url)
       expect(status).to be_an_instance_of Hash
     end
   end
 
-  describe "#summary" do
+  describe '#summary' do
     before :each do
-      @status_response_body = ""
+      @status_response_body = ''
 
-      it "prints the summary" do
+      it 'prints the summary' do
       end
     end
   end
 
-  describe "#query" do
+  describe '#query' do
     before :each do
-      @query_response_body = "{\"ok\": true,\"fq6qlpjlsskycq6\":{\"template\":\"debian-7-x86_64\",\"lifetime\": 2,\"running\": 0.08,\"state\":\"running\",\"snapshots\":[\"n4eb4kdtp7rwv4x158366vd9jhac8btq\" ],\"domain\": \"delivery.puppetlabs.net\"}}"
+      @query_response_body = '{"ok": true,"fq6qlpjlsskycq6":{"template":"debian-7-x86_64","lifetime": 2,"running": 0.08,"state":"running","snapshots":["n4eb4kdtp7rwv4x158366vd9jhac8btq" ],"domain": "delivery.puppetlabs.net"}}'
     end
 
-    it "makes a query about a vm" do
-      stub_request(:get, "#{@vmpooler_url}/vm/fq6qlpjlsskycq6").
-        with(:headers => {'Accept'=>'*/*', 'Accept-Encoding'=>'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'User-Agent'=>'Faraday v0.9.2'}).
-        to_return(:status => 200, :body => @query_response_body, :headers => {})
+    it 'makes a query about a vm' do
+      stub_request(:get, "#{@vmpooler_url}/vm/fq6qlpjlsskycq6")
+        .to_return(:status => 200, :body => @query_response_body, :headers => {})
 
       query_req = Pooler.query(false, @vmpooler_url, 'fq6qlpjlsskycq6')
       expect(query_req).to be_an_instance_of Hash
     end
   end
 
-  describe "#snapshot" do
+  describe '#snapshot' do
     before :each do
-      @snapshot_response_body = "{\"ok\":true}"
+      @snapshot_response_body = '{"ok":true}'
     end
 
-    it "makes a snapshot for a single vm" do
-      stub_request(:post, "#{@vmpooler_url}/vm/fq6qlpjlsskycq6/snapshot").
-        with(:headers => {'Accept'=>'*/*', 'Accept-Encoding'=>'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'Content-Length'=>'0', 'User-Agent'=>'Faraday v0.9.2', 'X-Auth-Token'=>'mytokenfile'}).
-        to_return(:status => 200, :body => @snapshot_response_body, :headers => {})
+    it 'makes a snapshot for a single vm' do
+      stub_request(:post, "#{@vmpooler_url}/vm/fq6qlpjlsskycq6/snapshot")
+        .with(:headers => { 'X-Auth-Token' => 'mytokenfile' })
+        .to_return(:status => 200, :body => @snapshot_response_body, :headers => {})
 
       snapshot_req = Pooler.snapshot(false, @vmpooler_url, 'fq6qlpjlsskycq6', 'mytokenfile')
-      expect(snapshot_req["ok"]).to be true
+      expect(snapshot_req['ok']).to be true
     end
   end
 
-  describe "#revert" do
+  describe '#revert' do
     before :each do
-      @revert_response_body = "{\"ok\":true}"
+      @revert_response_body = '{"ok":true}'
     end
 
-    it "makes a request to revert a vm from a snapshot" do
-      stub_request(:post, "#{@vmpooler_url}/vm/fq6qlpjlsskycq6/snapshot/dAfewKNfaweLKNve").
-        with(:headers => {'Accept'=>'*/*', 'Accept-Encoding'=>'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'Content-Length'=>'0', 'User-Agent'=>'Faraday v0.9.2', 'X-Auth-Token'=>'mytokenfile'}).
-        to_return(:status => 200, :body => @revert_response_body, :headers => {})
+    it 'makes a request to revert a vm from a snapshot' do
+      stub_request(:post, "#{@vmpooler_url}/vm/fq6qlpjlsskycq6/snapshot/dAfewKNfaweLKNve")
+        .with(:headers => { 'X-Auth-Token' => 'mytokenfile' })
+        .to_return(:status => 200, :body => @revert_response_body, :headers => {})
 
       revert_req = Pooler.revert(false, @vmpooler_url, 'fq6qlpjlsskycq6', 'mytokenfile', 'dAfewKNfaweLKNve')
-      expect(revert_req["ok"]).to be true
+      expect(revert_req['ok']).to be true
     end
 
     it "doesn't make a request to revert a vm if snapshot is not provided" do
-      expect{ Pooler.revert(false, @vmpooler_url, 'fq6qlpjlsskycq6', 'mytokenfile', nil) }.to raise_error(RuntimeError, "Snapshot SHA provided was nil, could not revert fq6qlpjlsskycq6")
+      expect { Pooler.revert(false, @vmpooler_url, 'fq6qlpjlsskycq6', 'mytokenfile', nil) }.to raise_error(RuntimeError, 'Snapshot SHA provided was nil, could not revert fq6qlpjlsskycq6')
     end
 
-    it "raises a TokenError if no token was provided" do
-      expect{ Pooler.revert(false, @vmpooler_url, 'myfakehost', nil, 'shaaaaaaa') }.to raise_error(TokenError)
+    it 'raises a TokenError if no token was provided' do
+      expect { Pooler.revert(false, @vmpooler_url, 'myfakehost', nil, 'shaaaaaaa') }.to raise_error(TokenError)
     end
   end
 
-  describe "#disk" do
+  describe '#disk' do
     before :each do
-      @disk_response_body_success = "{\"ok\":true}"
-      @disk_response_body_fail = "{\"ok\":false}"
+      @disk_response_body_success = '{"ok":true}'
+      @disk_response_body_fail = '{"ok":false}'
     end
 
-    it "makes a request to extend disk space of a vm" do
-      stub_request(:post, "#{@vmpooler_url}/vm/fq6qlpjlsskycq6/disk/12").
-        with(:headers => {'Accept'=>'*/*', 'Accept-Encoding'=>'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'Content-Length'=>'0', 'User-Agent'=>'Faraday v0.9.2', 'X-Auth-Token'=>'mytokenfile'}).  to_return(:status => 200, :body => @disk_response_body_success, :headers => {})
+    it 'makes a request to extend disk space of a vm' do
+      stub_request(:post, "#{@vmpooler_url}/vm/fq6qlpjlsskycq6/disk/12")
+        .with(:headers => { 'X-Auth-Token' => 'mytokenfile' }). to_return(:status => 200, :body => @disk_response_body_success, :headers => {})
 
       disk_req = Pooler.disk(false, @vmpooler_url, 'fq6qlpjlsskycq6', 'mytokenfile', 12)
-      expect(disk_req["ok"]).to be true
+      expect(disk_req['ok']).to be true
     end
 
-    it "raises a TokenError if no token was provided" do
-      expect{ Pooler.disk(false, @vmpooler_url, 'myfakehost', nil, 12) }.to raise_error(TokenError)
+    it 'raises a TokenError if no token was provided' do
+      expect { Pooler.disk(false, @vmpooler_url, 'myfakehost', nil, 12) }.to raise_error(TokenError)
     end
   end
 end

data/spec/vmfloaty/service_spec.rb

@@ -1,11 +1,12 @@
+# frozen_string_literal: true
+
 require_relative '../../lib/vmfloaty/service'
 
 describe Service do
-
   describe '#initialize' do
     it 'store configuration options' do
       options = MockOptions.new({})
-      config = {'url' => 'http://example.url'}
+      config = { 'url' => 'http://example.url' }
       service = Service.new(options, config)
       expect(service.config).to include config
     end
@@ -15,9 +16,9 @@ describe Service do
     it 'prompts the user for their password and retrieves a token' do
       config = { 'user' => 'first.last', 'url' => 'http://default.url' }
       service = Service.new(MockOptions.new, config)
-      allow(STDOUT).to receive(:puts).with('Enter your pooler service password:')
+      allow(STDOUT).to receive(:puts).with('Enter your http://default.url service password:')
       allow(Commander::UI).to(receive(:password)
-                                  .with('Enter your pooler service password:', '*')
+                                  .with('Enter your http://default.url service password:', '*')
                                   .and_return('hunter2'))
       allow(Auth).to(receive(:get_token)
                          .with(nil, config['url'], config['user'], 'hunter2')
@@ -28,11 +29,11 @@ describe Service do
     it 'prompts the user for their username and password if the username is unknown' do
       config = { 'url' => 'http://default.url' }
       service = Service.new(MockOptions.new({}), config)
-      allow(STDOUT).to receive(:puts).with 'Enter your pooler service username:'
+      allow(STDOUT).to receive(:puts).with 'Enter your http://default.url service username:'
       allow(STDOUT).to receive(:puts).with "\n"
       allow(STDIN).to receive(:gets).and_return('first.last')
       allow(Commander::UI).to(receive(:password)
-                                  .with('Enter your pooler service password:', '*')
+                                  .with('Enter your http://default.url service password:', '*')
                                   .and_return('hunter2'))
       allow(Auth).to(receive(:get_token)
                          .with(nil, config['url'], 'first.last', 'hunter2')
@@ -43,31 +44,31 @@ describe Service do
 
   describe '#delete_token' do
     it 'deletes a token' do
-      service = Service.new(MockOptions.new,{'user' => 'first.last', 'url' => 'http://default.url'})
+      service = Service.new(MockOptions.new, 'user' => 'first.last', 'url' => 'http://default.url')
       allow(Commander::UI).to(receive(:password)
-                                  .with('Enter your pooler service password:', '*')
+                                  .with('Enter your http://default.url service password:', '*')
                                   .and_return('hunter2'))
       allow(Auth).to(receive(:delete_token)
                          .with(nil, 'http://default.url', 'first.last', 'hunter2', 'token-value')
                          .and_return('ok' => true))
-      expect(service.delete_token(nil, 'token-value')).to eql({'ok' => true})
+      expect(service.delete_token(nil, 'token-value')).to eql('ok' => true)
     end
   end
 
   describe '#token_status' do
     it 'reports the status of a token' do
       config = {
-          'user' => 'first.last',
-          'url' => 'http://default.url'
+        'user' => 'first.last',
+        'url'  => 'http://default.url',
       }
       options = MockOptions.new('token' => 'token-value')
       service = Service.new(options, config)
       status = {
-          'ok' => true,
-          'user' => config['user'],
-          'created' => '2017-09-22 02:04:18 +0000',
-          'last_accessed' => '2017-09-22 02:04:28 +0000',
-          'reserved_hosts' => []
+        'ok'             => true,
+        'user'           => config['user'],
+        'created'        => '2017-09-22 02:04:18 +0000',
+        'last_accessed'  => '2017-09-22 02:04:28 +0000',
+        'reserved_hosts' => [],
       }
       allow(Auth).to(receive(:token_status)
                          .with(nil, config['url'], 'token-value')
@@ -75,5 +76,4 @@ describe Service do
       expect(service.token_status(nil, 'token-value')).to eql(status)
     end
   end
-
 end

data/spec/vmfloaty/utils_spec.rb

@@ -1,13 +1,14 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'json'
 require 'commander/command'
 require_relative '../../lib/vmfloaty/utils'
 
 describe Utils do
-
-  describe "#standardize_hostnames" do
+  describe '#standardize_hostnames' do
     before :each do
-      @vmpooler_response_body ='{
+      @vmpooler_response_body = '{
          "ok": true,
          "domain": "delivery.mycompany.net",
          "ubuntu-1610-x86_64": {
@@ -28,79 +29,79 @@ describe Utils do
        }'
     end
 
-    it "formats a result from vmpooler into a hash of os to hostnames" do
+    it 'formats a result from vmpooler into a hash of os to hostnames' do
       result = Utils.standardize_hostnames(JSON.parse(@vmpooler_response_body))
-      expect(result).to eq('centos-7-x86_64' => ["dlgietfmgeegry2.delivery.mycompany.net"],
-                           'ubuntu-1610-x86_64' => ["gdoy8q3nckuob0i.delivery.mycompany.net", "ctnktsd0u11p9tm.delivery.mycompany.net"])
+      expect(result).to eq('centos-7-x86_64'    => ['dlgietfmgeegry2.delivery.mycompany.net'],
+                           'ubuntu-1610-x86_64' => ['gdoy8q3nckuob0i.delivery.mycompany.net', 'ctnktsd0u11p9tm.delivery.mycompany.net'])
     end
 
-    it "formats a result from the nonstandard pooler into a hash of os to hostnames" do
+    it 'formats a result from the nonstandard pooler into a hash of os to hostnames' do
       result = Utils.standardize_hostnames(JSON.parse(@nonstandard_response_body))
-      expect(result).to eq('solaris-10-sparc' => ['sol10-10.delivery.mycompany.net', 'sol10-11.delivery.mycompany.net'],
+      expect(result).to eq('solaris-10-sparc'    => ['sol10-10.delivery.mycompany.net', 'sol10-11.delivery.mycompany.net'],
                            'ubuntu-16.04-power8' => ['power8-ubuntu16.04-6.delivery.mycompany.net'])
     end
   end
 
-  describe "#format_host_output" do
+  describe '#format_host_output' do
     before :each do
       @vmpooler_results = {
-        'centos-7-x86_64' => ["dlgietfmgeegry2.delivery.mycompany.net"],
-        'ubuntu-1610-x86_64' => ["gdoy8q3nckuob0i.delivery.mycompany.net", "ctnktsd0u11p9tm.delivery.mycompany.net"]
+        'centos-7-x86_64'    => ['dlgietfmgeegry2.delivery.mycompany.net'],
+        'ubuntu-1610-x86_64' => ['gdoy8q3nckuob0i.delivery.mycompany.net', 'ctnktsd0u11p9tm.delivery.mycompany.net'],
       }
       @nonstandard_results = {
-        'solaris-10-sparc' => ['sol10-10.delivery.mycompany.net', 'sol10-11.delivery.mycompany.net'],
-        'ubuntu-16.04-power8' => ['power8-ubuntu16.04-6.delivery.mycompany.net']
+        'solaris-10-sparc'    => ['sol10-10.delivery.mycompany.net', 'sol10-11.delivery.mycompany.net'],
+        'ubuntu-16.04-power8' => ['power8-ubuntu16.04-6.delivery.mycompany.net'],
       }
-      @vmpooler_output = <<-OUT.chomp
-- dlgietfmgeegry2.delivery.mycompany.net (centos-7-x86_64)
-- gdoy8q3nckuob0i.delivery.mycompany.net (ubuntu-1610-x86_64)
-- ctnktsd0u11p9tm.delivery.mycompany.net (ubuntu-1610-x86_64)
+      @vmpooler_output = <<~OUT.chomp
+        - dlgietfmgeegry2.delivery.mycompany.net (centos-7-x86_64)
+        - gdoy8q3nckuob0i.delivery.mycompany.net (ubuntu-1610-x86_64)
+        - ctnktsd0u11p9tm.delivery.mycompany.net (ubuntu-1610-x86_64)
       OUT
-      @nonstandard_output = <<-OUT.chomp
-- sol10-10.delivery.mycompany.net (solaris-10-sparc)
-- sol10-11.delivery.mycompany.net (solaris-10-sparc)
-- power8-ubuntu16.04-6.delivery.mycompany.net (ubuntu-16.04-power8)
+      @nonstandard_output = <<~OUT.chomp
+        - sol10-10.delivery.mycompany.net (solaris-10-sparc)
+        - sol10-11.delivery.mycompany.net (solaris-10-sparc)
+        - power8-ubuntu16.04-6.delivery.mycompany.net (ubuntu-16.04-power8)
       OUT
     end
-    it "formats a hostname hash from vmpooler into a list that includes the os" do
+    it 'formats a hostname hash from vmpooler into a list that includes the os' do
       expect(Utils.format_host_output(@vmpooler_results)).to eq(@vmpooler_output)
     end
 
-    it "formats a hostname hash from the nonstandard pooler into a list that includes the os" do
+    it 'formats a hostname hash from the nonstandard pooler into a list that includes the os' do
       expect(Utils.format_host_output(@nonstandard_results)).to eq(@nonstandard_output)
     end
   end
 
-  describe "#get_service_object" do
-    it "assumes vmpooler by default" do
+  describe '#get_service_object' do
+    it 'assumes vmpooler by default' do
       expect(Utils.get_service_object).to be Pooler
     end
 
-    it "uses nspooler when told explicitly" do
-      expect(Utils.get_service_object "nspooler").to be NonstandardPooler
+    it 'uses nspooler when told explicitly' do
+      expect(Utils.get_service_object('nspooler')).to be NonstandardPooler
     end
   end
 
-  describe "#get_service_config" do
+  describe '#get_service_config' do
     before :each do
       @default_config = {
-          "url" => "http://default.url",
-          "user" => "first.last.default",
-          "token" => "default-token",
+        'url'   => 'http://default.url',
+        'user'  => 'first.last.default',
+        'token' => 'default-token',
       }
       @services_config = {
-          "services" => {
-              "vm" => {
-                  "url" => "http://vmpooler.url",
-                  "user" => "first.last.vmpooler",
-                  "token" => "vmpooler-token"
-              },
-              "ns" => {
-                  "url" => "http://nspooler.url",
-                  "user" => "first.last.nspooler",
-                  "token" => "nspooler-token"
-              }
-          }
+        'services' => {
+          'vm' => {
+            'url'   => 'http://vmpooler.url',
+            'user'  => 'first.last.vmpooler',
+            'token' => 'vmpooler-token',
+          },
+          'ns' => {
+            'url'   => 'http://nspooler.url',
+            'user'  => 'first.last.nspooler',
+            'token' => 'nspooler-token',
+          },
+        },
       }
     end
 
@@ -110,70 +111,70 @@ describe Utils do
       expect(Utils.get_service_config(config, options)).to include @services_config['services']['vm']
     end
 
-    it "allows selection by configured service key" do
+    it 'allows selection by configured service key' do
       config = @default_config.merge @services_config
-      options = MockOptions.new({:service => "ns"})
+      options = MockOptions.new(:service => 'ns')
       expect(Utils.get_service_config(config, options)).to include @services_config['services']['ns']
     end
 
-    it "uses top-level service config values as defaults when configured service values are missing" do
+    it 'uses top-level service config values as defaults when configured service values are missing' do
       config = @default_config.merge @services_config
-      config["services"]['vm'].delete 'url'
-      options = MockOptions.new({:service => "vm"})
+      config['services']['vm'].delete 'url'
+      options = MockOptions.new(:service => 'vm')
       expect(Utils.get_service_config(config, options)['url']).to eq 'http://default.url'
     end
 
     it "raises an error if passed a service name that hasn't been configured" do
       config = @default_config.merge @services_config
-      options = MockOptions.new({:service => "none"})
+      options = MockOptions.new(:service => 'none')
       expect { Utils.get_service_config(config, options) }.to raise_error ArgumentError
     end
 
-    it "prioritizes values passed as command line options over configuration options" do
+    it 'prioritizes values passed as command line options over configuration options' do
       config = @default_config
-      options = MockOptions.new({:url => "http://alternate.url", :token => "alternate-token"})
-      expected = config.merge({"url" => "http://alternate.url", "token" => "alternate-token"})
+      options = MockOptions.new(:url => 'http://alternate.url', :token => 'alternate-token')
+      expected = config.merge('url' => 'http://alternate.url', 'token' => 'alternate-token')
       expect(Utils.get_service_config(config, options)).to include expected
     end
   end
 
-  describe "#generate_os_hash" do
+  describe '#generate_os_hash' do
     before :each do
-      @host_hash = {"centos"=>1, "debian"=>5, "windows"=>1}
+      @host_hash = { 'centos' => 1, 'debian' => 5, 'windows' => 1 }
     end
 
-    it "takes an array of os arguments and returns a formatted hash" do
-      host_arg = ["centos", "debian=5", "windows=1"]
+    it 'takes an array of os arguments and returns a formatted hash' do
+      host_arg = ['centos', 'debian=5', 'windows=1']
       expect(Utils.generate_os_hash(host_arg)).to eq @host_hash
     end
 
-    it "returns an empty hash if there are no arguments provided" do
+    it 'returns an empty hash if there are no arguments provided' do
       host_arg = []
       expect(Utils.generate_os_hash(host_arg)).to be_empty
     end
   end
 
   describe '#pretty_print_hosts' do
-    let(:url)               { 'http://pooler.example.com' }
+    let(:url) { 'http://pooler.example.com' }
 
     it 'prints a vmpooler output with host fqdn, template and duration info' do
       hostname = 'mcpy42eqjxli9g2'
       response_body = { hostname => {
-          'template' => 'ubuntu-1604-x86_64',
-          'lifetime' => 12,
-          'running'  => 9.66,
-          'state' => 'running',
-          'ip' => '127.0.0.1',
-          'domain'   => 'delivery.mycompany.net'
-      }}
-      output = "- mcpy42eqjxli9g2.delivery.mycompany.net (ubuntu-1604-x86_64, 9.66/12 hours)"
+        'template' => 'ubuntu-1604-x86_64',
+        'lifetime' => 12,
+        'running'  => 9.66,
+        'state'    => 'running',
+        'ip'       => '127.0.0.1',
+        'domain'   => 'delivery.mycompany.net',
+      } }
+      output = '- mcpy42eqjxli9g2.delivery.mycompany.net (ubuntu-1604-x86_64, 9.66/12 hours)'
 
       expect(Utils).to receive(:puts).with(output)
 
-      service = Service.new(MockOptions.new, {'url' => url})
+      service = Service.new(MockOptions.new, 'url' => url)
       allow(service).to receive(:query)
-                            .with(nil, hostname)
-                            .and_return(response_body)
+        .with(nil, hostname)
+        .and_return(response_body)
 
       Utils.pretty_print_hosts(nil, service, hostname)
     end
@@ -181,46 +182,46 @@ describe Utils do
     it 'prints a vmpooler output with host fqdn, template, duration info, and tags when supplied' do
       hostname = 'aiydvzpg23r415q'
       response_body = { hostname => {
-          'template' => 'redhat-7-x86_64',
-          'lifetime' => 48,
-          'running'  => 7.67,
-          'state' => 'running',
-          'tags'     => {
-              'user' => 'bob',
-              'role' => 'agent'
-          },
-          'ip' => '127.0.0.1',
-          'domain' => 'delivery.mycompany.net'
-      }}
-      output = "- aiydvzpg23r415q.delivery.mycompany.net (redhat-7-x86_64, 7.67/48 hours, user: bob, role: agent)"
+        'template' => 'redhat-7-x86_64',
+        'lifetime' => 48,
+        'running'  => 7.67,
+        'state'    => 'running',
+        'tags'     => {
+          'user' => 'bob',
+          'role' => 'agent',
+        },
+        'ip'       => '127.0.0.1',
+        'domain'   => 'delivery.mycompany.net',
+      } }
+      output = '- aiydvzpg23r415q.delivery.mycompany.net (redhat-7-x86_64, 7.67/48 hours, user: bob, role: agent)'
 
       expect(Utils).to receive(:puts).with(output)
 
-      service = Service.new(MockOptions.new, {'url' => url})
+      service = Service.new(MockOptions.new, 'url' => url)
       allow(service).to receive(:query)
-                            .with(nil, hostname)
-                            .and_return(response_body)
+        .with(nil, hostname)
+        .and_return(response_body)
 
       Utils.pretty_print_hosts(nil, service, hostname)
     end
 
     it 'prints a nonstandard pooler output with host, template, and time remaining' do
-      hostname = "sol11-9.delivery.mycompany.net"
+      hostname = 'sol11-9.delivery.mycompany.net'
       response_body = { hostname => {
-          'fqdn' => hostname,
-          'os_triple' => 'solaris-11-sparc',
-          'reserved_by_user' => 'first.last',
-          'reserved_for_reason' => '',
-          'hours_left_on_reservation' => 35.89
-      }}
-      output = "- sol11-9.delivery.mycompany.net (solaris-11-sparc, 35.89h remaining)"
+        'fqdn'                      => hostname,
+        'os_triple'                 => 'solaris-11-sparc',
+        'reserved_by_user'          => 'first.last',
+        'reserved_for_reason'       => '',
+        'hours_left_on_reservation' => 35.89,
+      } }
+      output = '- sol11-9.delivery.mycompany.net (solaris-11-sparc, 35.89h remaining)'
 
       expect(Utils).to receive(:puts).with(output)
 
-      service = Service.new(MockOptions.new, {'url' => url, 'type' => 'ns'})
+      service = Service.new(MockOptions.new, 'url' => url, 'type' => 'ns')
       allow(service).to receive(:query)
-                            .with(nil, hostname)
-                            .and_return(response_body)
+        .with(nil, hostname)
+        .and_return(response_body)
 
       Utils.pretty_print_hosts(nil, service, hostname)
     end
@@ -228,20 +229,20 @@ describe Utils do
     it 'prints a nonstandard pooler output with host, template, time remaining, and reason' do
       hostname = 'sol11-9.delivery.mycompany.net'
       response_body = { hostname => {
-          'fqdn' => hostname,
-          'os_triple' => 'solaris-11-sparc',
-          'reserved_by_user' => 'first.last',
-          'reserved_for_reason' => 'testing',
-          'hours_left_on_reservation' => 35.89
-      }}
-      output = "- sol11-9.delivery.mycompany.net (solaris-11-sparc, 35.89h remaining, reason: testing)"
+        'fqdn'                      => hostname,
+        'os_triple'                 => 'solaris-11-sparc',
+        'reserved_by_user'          => 'first.last',
+        'reserved_for_reason'       => 'testing',
+        'hours_left_on_reservation' => 35.89,
+      } }
+      output = '- sol11-9.delivery.mycompany.net (solaris-11-sparc, 35.89h remaining, reason: testing)'
 
       expect(Utils).to receive(:puts).with(output)
 
-      service = Service.new(MockOptions.new, {'url' => url, 'type' => 'ns'})
+      service = Service.new(MockOptions.new, 'url' => url, 'type' => 'ns')
       allow(service).to receive(:query)
-                            .with(nil, hostname)
-                            .and_return(response_body)
+        .with(nil, hostname)
+        .and_return(response_body)
 
       Utils.pretty_print_hosts(nil, service, hostname)
     end