vmc 0.5.0.rc1 → 0.5.0.rc2

data/spec/vmc/cli/app/stats_spec.rb

@@ -3,7 +3,7 @@ require 'stringio'
 
 describe VMC::App::Stats do
   let(:global) { { :color => false } }
-  let(:inputs) { {:app => apps[0]} }
+  let(:inputs) { { :app => apps[0] } }
   let(:given) { {} }
   let(:client) { fake_client(:apps => apps) }
   let(:apps) { [fake(:app, :name => "basic_app")] }
@@ -13,21 +13,27 @@ describe VMC::App::Stats do
       stub(cli).client { client }
       stub(cli).precondition { nil }
     end
-    stub(client).base.stub!.stats do
-      {"0" => {
-        :state => "RUNNING",
-        :stats => {
-          :name => "basic_app",
-          :uris => ["basic_app.p01.rbconsvcs.com"],
-          :host => "172.20.183.93",
-          :port => 61006,
-          :uptime => 3250,
-          :mem_quota => 301989888,
-          :disk_quota => 268435456,
-          :fds_quota => 256,
-          :usage => {:time => "2013-01-04 19:53:39 +0000", :cpu => 0.0019777013519415455, :mem => 31395840, :disk => 15638528}
+    stub(inputs[:app]).stats do
+      { "0" => {
+          :state => "RUNNING",
+          :stats => {
+            :name => "basic_app",
+            :uris => ["basic_app.p01.rbconsvcs.com"],
+            :host => "172.20.183.93",
+            :port => 61006,
+            :uptime => 3250,
+            :mem_quota => 301989888,
+            :disk_quota => 268435456,
+            :fds_quota => 256,
+            :usage => {
+              :time => "2013-01-04 19:53:39 +0000",
+              :cpu => 0.0019777013519415455,
+              :mem => 31395840,
+              :disk => 15638528
+            }
+          }
         }
-      }}
+      }
     end
   end
 

data/spec/vmc/cli/space/create_spec.rb

@@ -0,0 +1,73 @@
+require 'spec_helper'
+require "vmc/cli/space/create"
+
+describe VMC::Space::Create do
+  let(:spaces) { fake_list(:space, 3) }
+  let(:organization) { fake(:organization, :spaces => spaces) }
+  let(:new_space) { stub! }
+  let(:client) { fake_client(:current_organization => organization, :spaces => spaces) }
+  let(:new_name) { "some-new-name" }
+
+  before do
+    %w{create! organization= name= name add_manager add_developer add_auditor organization}.each do |method|
+      new_space.__send__(method.to_sym)
+    end
+
+    stub(client).space { new_space }
+    any_instance_of described_class do |cli|
+      stub(cli).client { client }
+      stub(cli).precondition { nil }
+    end
+  end
+
+  describe 'metadata' do
+    let(:command) { Mothership.commands[:create_space] }
+
+    describe 'command' do
+      subject { command }
+      its(:description) { should eq "Create a space in an organization" }
+      it { expect(Mothership::Help.group(:spaces)).to include(subject) }
+    end
+
+    include_examples 'inputs must have descriptions'
+
+    describe 'arguments' do
+      subject { command.arguments }
+      it 'has the correct argument order' do
+        should eq([
+          { :type => :optional, :value => nil, :name => :name },
+          { :type => :optional, :value => nil, :name => :organization }
+        ])
+      end
+    end
+  end
+
+  context "when we don't specify an organization" do
+    subject { vmc %W[--no-quiet create-space new-space-name] }
+
+    context "when we have a default organization" do
+      it "uses that organization to create a space" do
+        subject
+
+        stdout.rewind
+        expect(stdout.readline).to include "Creating space"
+      end
+    end
+
+    context "when we don't have a default organization" do
+      let(:organization) { nil }
+
+      it "shows the help for the command" do
+        subject
+
+        stdout.rewind
+        expect(stdout.readline).to include "Create a space in an organization"
+      end
+
+      it "does not try to create the space" do
+        new_space.create! { raise "should not call this method" } # rr not behaving
+        subject
+      end
+    end
+  end
+end

data/spec/vmc/cli/space/switch_space_spec.rb

@@ -0,0 +1,55 @@
+require 'spec_helper'
+require "vmc/cli/space/switch"
+
+describe VMC::Space::Switch do
+  let(:space_to_switch_to) { spaces.last }
+  let(:spaces) { fake_list(:space, 3) }
+  let(:organization) { fake(:organization, :spaces => spaces) }
+  let(:client) { fake_client(:current_organization => organization, :spaces => spaces) }
+
+  before do
+    any_instance_of described_class do |cli|
+      stub(cli).client { client }
+      stub(cli).precondition { nil }
+    end
+  end
+
+  describe 'metadata' do
+    let(:command) { Mothership.commands[:switch_space] }
+
+    describe 'command' do
+      subject { command }
+      its(:description) { should eq "Switch to a space" }
+      it { expect(Mothership::Help.group(:spaces)).to include(subject) }
+    end
+
+    include_examples 'inputs must have descriptions'
+
+    describe 'arguments' do
+      subject { command.arguments }
+      it 'has the correct argument order' do
+        should eq([{ :type => :normal, :value => nil, :name => :name }])
+      end
+    end
+  end
+
+  subject { vmc %W[--no-quiet switch-space #{space_to_switch_to.name} --no-color] }
+
+  context "when the space exists" do
+    it "switches to that space" do
+      any_instance_of(Mothership) do |m|
+        mock(m).invoke(:target, {:space => space_to_switch_to})
+      end
+
+      subject
+    end
+  end
+
+  context "when the space does not exist" do
+    let(:space_to_switch_to) { fake(:space, :name => "unique-name") }
+
+    it_behaves_like "an error that gets passed through",
+      :with_exception => VMC::UserError,
+      :with_message => "The space unique-name does not exist, please create the space first."
+  end
+end

data/spec/vmc/cli/start/info_spec.rb

@@ -24,18 +24,6 @@ describe VMC::Start::Info do
     any_instance_of described_class do |cli|
       stub(cli).client { client }
     end
-
-    described_class.class_eval do
-      def wrap_errors
-        yield
-      end
-    end
-  end
-
-  after do
-    described_class.class_eval do
-      remove_method :wrap_errors
-    end
   end
 
   describe 'metadata' do
@@ -165,9 +153,8 @@ describe VMC::Start::Info do
 
   context 'when there is no target' do
     let(:client) { nil }
-
-    it "tells the user to run 'vmc target'" do
-      expect { subject }.to raise_error(VMC::UserError)
-    end
+    it_behaves_like "an error that gets passed through",
+      :with_exception => VMC::UserError,
+      :with_message => "Please select a target with 'vmc target'."
   end
 end

data/spec/vmc/cli/start/login_spec.rb

@@ -7,18 +7,6 @@ describe VMC::Start::Login do
     any_instance_of described_class do |cli|
       stub(cli).client { client }
     end
-
-    described_class.class_eval do
-      def wrap_errors
-        yield
-      end
-    end
-  end
-
-  after do
-    described_class.class_eval do
-      remove_method :wrap_errors
-    end
   end
 
   describe 'metadata' do
@@ -27,7 +15,7 @@ describe VMC::Start::Login do
     describe 'command' do
       subject { command }
       its(:description) { should eq "Authenticate with the target" }
-      it { expect(Mothership::Help.group(:start)).to include(subject) }
+      specify { expect(Mothership::Help.group(:start)).to include(subject) }
     end
 
     include_examples 'inputs must have descriptions'
@@ -42,34 +30,31 @@ describe VMC::Start::Login do
     end
 
     describe 'arguments' do
-      subject { command.arguments }
+      subject(:arguments) { command.arguments }
       it 'have the correct commands' do
-        should eq [{:type=>:optional, :value=>:email, :name=>:username}]
+        expect(arguments).to eq [{:type => :optional, :value => :email, :name => :username}]
       end
     end
   end
 
   describe "running the command" do
-    use_fake_home_dir { home_dir }
-
-    let(:home_dir) do
-      tmp_root = Dir.tmpdir
-      FileUtils.cp_r(File.expand_path("#{SPEC_ROOT}/fixtures/fake_home_dirs/new"), tmp_root)
-      "#{tmp_root}/new"
-    end
+    stub_home_dir_with("new")
 
     let(:auth_token) { CFoundry::AuthToken.new("bearer some-new-access-token", "some-new-refresh-token") }
-
-    after { FileUtils.rm_rf home_dir }
+    let(:tokens_yaml) { YAML.load_file(File.expand_path(tokens_file_path)) }
+    let(:tokens_file_path) { '~/.vmc/tokens.yml' }
+    let(:organizations) { [] }
 
     before do
-      stub(client).login("my-username", "my-password") { auth_token }
-
-      stub(client).login_prompts do
-        {
-          :username => ["text", "Username"],
-          :password => ["password", "8-digit PIN"]
-        }
+      any_instance_of(CFoundry::V2::Client) do |client|
+        stub(client).login("my-username", "my-password") { auth_token }
+        stub(client).login_prompts do
+          {
+            :username => ["text", "Username"],
+            :password => ["password", "8-digit PIN"]
+          }
+        end
+        stub(client).organizations { [] }
       end
     end
 
@@ -77,21 +62,96 @@ describe VMC::Start::Login do
 
     it "logs in with the provided credentials and saves the token data to the YAML file" do
       stub_ask("Username", {}) { "my-username" }
-      stub_ask("8-digit PIN", { :echo => "*", :forget => true}) { "my-password" }
+      stub_ask("8-digit PIN", {:echo => "*", :forget => true}) { "my-password" }
 
       subject
 
-      tokens_yaml = YAML.load_file(File.expand_path("~/.vmc/tokens.yml"))
       expect(tokens_yaml["https://api.some-domain.com"][:token]).to eq("bearer some-new-access-token")
       expect(tokens_yaml["https://api.some-domain.com"][:refresh_token]).to eq("some-new-refresh-token")
     end
 
-    context 'when there is no target' do
-      let(:client) { nil }
+    context "with space and org in the token file" do
+      before do
+        write_token_file({:space => "space-id-1", :organization => "organization-id-1"})
+        stub_ask("Username", {}) { "my-username" }
+        stub_ask("8-digit PIN", {:echo => "*", :forget => true}) { "my-password" }
+      end
+
+      context "when the user has no organizations" do
+        it "clears the org and space param from the token file" do
+          subject
+
+          expect(tokens_yaml["https://api.some-domain.com"][:space]).to be_nil
+          expect(tokens_yaml["https://api.some-domain.com"][:organization]).to be_nil
+        end
+      end
 
-      it "tells the user to run 'vmc target'" do
-        expect { subject }.to raise_error(VMC::UserError)
+      context "when the user has an organization, but no spaces" do
+        before do
+          stub.proxy(client).organization { organization }
+          any_instance_of(described_class) do |instance|
+            stub(instance).client { client }
+          end
+        end
+
+        let(:client) { fake_client :organizations => organizations,
+          :token => CFoundry::AuthToken.new("bearer some-access-token") }
+        let(:organization) { OpenStruct.new(:name => 'My Org', :guid => 'organization-id-1', :users => [user]) }
+        let(:user) { stub }
+
+        before do
+          stub(organization).spaces { [] }
+        end
+
+        shared_examples_for :method_clearing_the_token_file do
+          it "sets the new organization in the token file" do
+            subject
+            expect(tokens_yaml["https://api.some-domain.com"][:organization]).to eq(organizations.first.guid)
+          end
+
+          it "clears the space param from the token file" do
+            subject
+            expect(tokens_yaml["https://api.some-domain.com"][:space]).to be_nil
+          end
+        end
+
+        context "with one organization" do
+          let(:organizations) {
+            [ organization ]
+          }
+
+          it "does not prompt for an organization" do
+            dont_allow_ask("Organization", anything)
+            subject
+          end
+
+          it_behaves_like :method_clearing_the_token_file
+        end
+
+        context "with multiple organizations" do
+          let(:organizations) {
+            [ organization, OpenStruct.new(:name => 'My Org 2', :guid => 'organization-id-2') ]
+          }
+
+          before do
+            stub_ask("Organization", anything) { organizations.first }
+          end
+
+          it "prompts for organization" do
+            mock_ask("Organization", anything) { organizations.first }
+            subject
+          end
+
+          it_behaves_like :method_clearing_the_token_file
+        end
       end
     end
+
+    context 'when there is no target' do
+      let(:client) { nil }
+      it_behaves_like "an error that gets passed through",
+        :with_exception => VMC::UserError,
+        :with_message => "Please select a target with 'vmc target'."
+    end
   end
 end

data/spec/vmc/cli/start/logout_spec.rb

@@ -7,18 +7,6 @@ describe VMC::Start::Logout do
     any_instance_of described_class do |cli|
       stub(cli).client { client }
     end
-
-    described_class.class_eval do
-      def wrap_errors
-        yield
-      end
-    end
-  end
-
-  after do
-    described_class.class_eval do
-      remove_method :wrap_errors
-    end
   end
 
   describe 'metadata' do
@@ -53,10 +41,9 @@ describe VMC::Start::Logout do
 
     context "when there is no target" do
       let(:client) { nil }
-
-      it "tells the user to run 'vmc target'" do
-        expect { subject }.to raise_error(VMC::UserError)
-      end
+      it_behaves_like "an error that gets passed through",
+        :with_exception => VMC::UserError,
+        :with_message => "Please select a target with 'vmc target'."
     end
   end
 end

data/spec/vmc/cli/start/target_spec.rb

@@ -0,0 +1,84 @@
+require 'spec_helper'
+
+describe VMC::Start::Target do
+  describe 'metadata' do
+    let(:command) { Mothership.commands[:target] }
+
+    describe 'command' do
+      subject { command }
+      its(:description) { should eq "Set or display the target cloud, organization, and space" }
+      specify { expect(Mothership::Help.group(:start)).to include(subject) }
+    end
+
+    include_examples 'inputs must have descriptions'
+
+    describe 'flags' do
+      subject { command.flags }
+
+      its(["-o"]) { should eq :organization }
+      its(["--org"]) { should eq :organization }
+      its(["-s"]) { should eq :space }
+    end
+
+    describe 'arguments' do
+      subject(:arguments) { command.arguments }
+      it 'have the correct commands' do
+        expect(arguments).to eq [{:type => :optional, :value => nil, :name => :url}]
+      end
+    end
+  end
+
+  describe 'running the command' do
+    stub_home_dir_with("new")
+
+    context "when the user is authenticated and has an organization" do
+      let(:tokens_file_path) { '~/.vmc/tokens.yml' }
+      let(:organizations) {
+        [ fake(:organization, :name => 'My Org', :guid => 'organization-id-1', :users => [user], :spaces => spaces),
+          fake(:organization, :name => 'My Org 2', :guid => 'organization-id-2') ]
+      }
+      let(:spaces) {
+        [ fake(:space, :name => 'Development', :guid => 'space-id-1'),
+          fake(:space, :name => 'Staging',     :guid => 'space-id-2') ]
+      }
+
+      let(:user) { stub! }
+      let(:organization) { organizations.first }
+      let(:client) do
+        fake_client :frameworks => fake_list(:framework, 3),
+          :organizations => organizations,
+          :token => CFoundry::AuthToken.new("bearer some-access-token")
+      end
+
+      before do
+        write_token_file({:space => "space-id-1", :organization => "organization-id-1"})
+        stub(client).current_user { user }
+        stub(client).organization { organization }
+        stub(client).current_organization { organization }
+        any_instance_of(described_class) do |instance|
+          stub(instance).client { client }
+        end
+      end
+
+      describe "switching the space" do
+        let(:space_name) { spaces.last.name }
+        let(:tokens_yaml) { YAML.load_file(File.expand_path(tokens_file_path)) }
+        let(:tokens_file_path) { '~/.vmc/tokens.yml' }
+
+        def run_command
+          vmc ["target", "-s", space_name]
+        end
+
+        it "should not reprompt for organization" do
+          dont_allow_ask("Organization", anything)
+          run_command
+        end
+
+        it "sets the space param in the token file" do
+          run_command
+          expect(tokens_yaml["https://api.some-domain.com"][:space]).to be == 'space-id-2'
+        end
+      end
+    end
+  end
+end