vite_ruby 3.2.4 → 3.2.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0370b365c1f6fbddd0cd14fc9467f56d4c039e167e62e380feb5df9c8b72a0d7
-  data.tar.gz: 13fa2eb1842a8868a9490dfcf99c450a1f8bdda35ad7d89e5da8e904bde55a4e
+  metadata.gz: 375a421ac4d10bc65044065ae4a69147c500808a2271ee77ed33b6721c34ca85
+  data.tar.gz: 917e97be44a37ad99dd3b700959d00ff26420727867c64b06a2b22354a7d8199
 SHA512:
-  metadata.gz: 0e18dd917b8ff8f593196cc4917ec5b4f0ecb0f3a3e6066f4438e4e56d150be0bd830fd9b66b82f95420ab1b53c3e530238f9dcdcb5505612df4d8b551b6f53d
-  data.tar.gz: 4f781ed0748d645d270c08c9b704c00c7529ab84ea6a531ee0904ef902fd8884410c714d8b30f4a0b9bafe3e493decad00bd4df78ddebc6d9d2c7e167eed008c
+  metadata.gz: babcceadc14d4f40e038610c47f09d57f22f1c3a4e3ded4ec1749b18c8ff3d3bb82ca6eaaab2b0036c026b586c705d9916dc3f030475679e7ad77d74c98bdd9e
+  data.tar.gz: 90d786e851da59d09ce76bc1162162f0d2e0c6f2824cba5a1e4bc3848936767a1a56387a9daa6fc77ee65d60cfa92cbecb6bca87107869b69150200df26d9cfd

data/CHANGELOG.md

@@ -1,3 +1,12 @@
+## [3.2.5](https://github.com/ElMassimo/vite_ruby/compare/vite_ruby@3.2.4...vite_ruby@3.2.5) (2022-10-07)
+
+
+### Features
+
+* display last build errors in MissingEntrypointError ([#274](https://github.com/ElMassimo/vite_ruby/issues/274)) ([107c980](https://github.com/ElMassimo/vite_ruby/commit/107c980449546ef73c527b88f1db11a7201e4438))
+
+
+
 ## [3.2.4](https://github.com/ElMassimo/vite_ruby/compare/vite_ruby@3.2.3...vite_ruby@3.2.4) (2022-10-04)
 
 

data/lib/vite_ruby/build.rb

@@ -4,24 +4,32 @@ require 'json'
 require 'time'
 
 # Internal: Value object with information about the last build.
-ViteRuby::Build = Struct.new(:success, :timestamp, :vite_ruby, :digest, :current_digest, :last_build_path) do
-  # Internal: Combines information from a previous build with the current digest.
-  def self.from_previous(last_build_path, current_digest)
-    attrs = begin
-      # Reads metadata recorded on the last build, if it exists.
-      last_build_path.exist? ? JSON.parse(last_build_path.read.to_s) : {}
+ViteRuby::Build = Struct.new(:success, :timestamp, :vite_ruby, :digest, :current_digest, :last_build_path, :errors, keyword_init: true) do
+  class << self
+    # Internal: Combines information from a previous build with the current digest.
+    def from_previous(last_build_path, current_digest)
+      new(
+        **parse_metadata(last_build_path),
+        current_digest: current_digest,
+        last_build_path: last_build_path,
+      )
+    end
+
+  private
+
+    # Internal: Reads metadata recorded on the last build, if it exists.
+    def parse_metadata(pathname)
+      return default_metadata unless pathname.exist?
+
+      JSON.parse(pathname.read.to_s).transform_keys(&:to_sym).slice(*members)
     rescue JSON::JSONError, Errno::ENOENT, Errno::ENOTDIR
-      {}
+      default_metadata
     end
 
-    new(
-      attrs['success'],
-      attrs['timestamp'] || 'never',
-      attrs['vite_ruby'] || 'unknown',
-      attrs['digest'] || 'none',
-      current_digest,
-      last_build_path,
-    )
+    # Internal: To make it evident that there's no last build in error messages.
+    def default_metadata
+      { timestamp: 'never', digest: 'none' }
+    end
   end
 
   # Internal: A build is considered stale when watched files have changed since
@@ -45,14 +53,14 @@ ViteRuby::Build = Struct.new(:success, :timestamp, :vite_ruby, :digest, :current
   end
 
   # Internal: Returns a new build with the specified result.
-  def with_result(success)
+  def with_result(**attrs)
     self.class.new(
-      success,
-      Time.now.strftime('%F %T'),
-      ViteRuby::VERSION,
-      current_digest,
-      current_digest,
-      last_build_path,
+      **attrs,
+      timestamp: Time.now.strftime('%F %T'),
+      vite_ruby: ViteRuby::VERSION,
+      digest: current_digest,
+      current_digest: current_digest,
+      last_build_path: last_build_path,
     )
   end
 
@@ -65,6 +73,7 @@ ViteRuby::Build = Struct.new(:success, :timestamp, :vite_ruby, :digest, :current
   def to_json(*_args)
     JSON.pretty_generate(
       success: success,
+      errors: errors,
       timestamp: timestamp,
       vite_ruby: vite_ruby,
       digest: digest,

data/lib/vite_ruby/builder.rb

@@ -14,7 +14,10 @@ class ViteRuby::Builder
     last_build = last_build_metadata(ssr: args.include?('--ssr'))
 
     if args.delete('--force') || last_build.stale?
-      build_with_vite(*args).tap { |success| record_build_metadata(success, last_build) }
+      stdout, stderr, success = build_with_vite(*args)
+      log_build_result(stdout, stderr, success)
+      record_build_metadata(last_build, errors: stderr, success: success)
+      success
     elsif last_build.success
       logger.debug "Skipping vite build. Watched files have not changed since the last build at #{ last_build.timestamp }"
       true
@@ -36,9 +39,9 @@ private
   def_delegators :@vite_ruby, :config, :logger, :run
 
   # Internal: Writes a digest of the watched files to disk for future checks.
-  def record_build_metadata(success, build)
+  def record_build_metadata(build, **attrs)
     config.build_cache_dir.mkpath
-    build.with_result(success).write_to_cache
+    build.with_result(**attrs).write_to_cache
   end
 
   # Internal: The file path where metadata of the last build is stored.
@@ -57,24 +60,19 @@ private
   end
 
   # Public: Initiates a Vite build command to generate assets.
-  #
-  # Returns true if the build is successful, or false if it failed.
   def build_with_vite(*args)
     logger.info 'Building with Vite ⚡️'
 
-    stdout, stderr, status = run(['build', *args])
-    log_build_result(stdout, stderr.to_s, status)
-
-    status.success?
+    run(['build', *args])
   end
 
   # Internal: Outputs the build results.
   #
   # NOTE: By default it also outputs the manifest entries.
   def log_build_result(_stdout, stderr, status)
-    if status.success?
+    if status
       logger.info "Build with Vite complete: #{ config.build_output_dir }"
-      logger.error stderr.to_s unless stderr.empty?
+      logger.error stderr unless stderr.empty?
     else
       logger.error stderr
       logger.error 'Build with Vite failed! ❌'

data/lib/vite_ruby/cli/install.rb

@@ -111,7 +111,7 @@ private
   def run_with_capture(*args, **options)
     Dir.chdir(root) do
       _, stderr, status = ViteRuby::IO.capture(*args, **options)
-      say(stderr) unless status.success? || stderr.to_s.empty?
+      say(stderr) unless status || stderr.empty?
     end
   end
 

data/lib/vite_ruby/io.rb

@@ -15,7 +15,7 @@ module ViteRuby::IO
         stdin.close
         out = Thread.new { read_lines(stdout, &with_output) }
         err = Thread.new { stderr.read }
-        [out.value, err.value, wait_threads.value]
+        [out.value, err.value.to_s, wait_threads.value.success?]
       }
     end
 

data/lib/vite_ruby/missing_entrypoint_error.rb

@@ -17,19 +17,27 @@ class ViteRuby::MissingEntrypointError < ViteRuby::Error
       #{ possible_causes(last_build) }
       :troubleshooting:
       #{ "\nContent in your manifests:\n#{ JSON.pretty_generate(manifest) }\n" if last_build.success }
-      #{ "Last build in #{ config.mode } mode:\n#{ last_build.to_json }\n" unless last_build.success.nil? }
+      #{ "Last build in #{ config.mode } mode:\n#{ last_build.to_json }\n" if last_build.success }
     MSG
   end
 
   def possible_causes(last_build)
-    return FAILED_BUILD_CAUSES.sub(':mode:', config.mode) if last_build.success == false
-    return DEFAULT_CAUSES if config.auto_build
-
-    DEFAULT_CAUSES + NO_AUTO_BUILD_CAUSES
+    if last_build.success == false
+      FAILED_BUILD_CAUSES
+        .sub(':mode:', config.mode)
+        .sub(':errors:', last_build.errors.to_s.gsub(/^(?!$)/, '  '))
+    elsif config.auto_build
+      DEFAULT_CAUSES
+    else
+      DEFAULT_CAUSES + NO_AUTO_BUILD_CAUSES
+    end
   end
 
-  FAILED_BUILD_CAUSES = <<-MSG
-  - The last build failed. Try running `bin/vite build --clear --mode=:mode:` manually and check for errors.
+  FAILED_BUILD_CAUSES = <<~MSG
+      - The last build failed. Try running `bin/vite build --clear --mode=:mode:` manually and check for errors.
+
+    Errors:
+    :errors:
   MSG
 
   DEFAULT_CAUSES = <<-MSG

data/lib/vite_ruby/version.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class ViteRuby
-  VERSION = '3.2.4'
+  VERSION = '3.2.5'
 
   # Internal: Versions used by default when running `vite install`.
   DEFAULT_VITE_VERSION = '^3.0.0'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: vite_ruby
 version: !ruby/object:Gem::Version
-  version: 3.2.4
+  version: 3.2.5
 platform: ruby
 authors:
 - Máximo Mussini
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-10-04 00:00:00.000000000 Z
+date: 2022-10-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dry-cli
@@ -202,8 +202,8 @@ homepage: https://github.com/ElMassimo/vite_ruby
 licenses:
 - MIT
 metadata:
-  source_code_uri: https://github.com/ElMassimo/vite_ruby/tree/vite_ruby@3.2.4/vite_ruby
-  changelog_uri: https://github.com/ElMassimo/vite_ruby/blob/vite_ruby@3.2.4/vite_ruby/CHANGELOG.md
+  source_code_uri: https://github.com/ElMassimo/vite_ruby/tree/vite_ruby@3.2.5/vite_ruby
+  changelog_uri: https://github.com/ElMassimo/vite_ruby/blob/vite_ruby@3.2.5/vite_ruby/CHANGELOG.md
 post_install_message: "Thanks for installing Vite Ruby!\n\nIf you upgraded the gem
   manually, please run:\n\tbundle exec vite upgrade"
 rdoc_options: []
@@ -213,7 +213,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.4'
+      version: '2.5'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="