vite_rails 1.0.8 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 01d2a1c3a1fb46873e2b8057e91829a74e6c52a010941ec8abe6ca8055242b71
-  data.tar.gz: 8fbe4d912f70e84631a0131cfc884e4dd547f10105955d6fb1c877d69a22c03c
+  metadata.gz: 04dad5363dea685fe1e9e7ad2a852566927bd2804f0dab0ddecc8016da915dd0
+  data.tar.gz: 5a8d82f9cfbcf65bef55d28dfdf8cdf5bb77fb04ba83ce9db6b7c4eb2ffb749d
 SHA512:
-  metadata.gz: 2807123abe076535c1b5a918d5d6d303b137e1e8025d036692162313ed479500db1fd09ba153e355e33b1a58a9072d19c17b17dc147cd09f841cceffb8d12daa
-  data.tar.gz: 2200102393275515c8dc4ef981a9676460f27e35d48bba8c906535401aea934b5cd08fddbc19bd61bf7aaaf385c2fc7f27ca99eddca12f2ea364373fb7d2fde0
+  metadata.gz: 312c305aa1d69cfb57f93110c093cc7f8b5193a24c16aa5916efc60f8b284d86eba0090aa2e1831748526c7bf57ea6c8962b6d290d469d0ca1b0bdd014888431
+  data.tar.gz: d118d7eecbc36163b8ef3789d9198da5c991aab64f6da739381878e7b045c1d365155d22be92226665ce7583f99e0d6d60fd6b01aeb94f5596371a359a242a6d

data/CHANGELOG.md

@@ -1,4 +1,30 @@
-## Vite Rails 1.0.8  (2020-01-20)
+## Vite Rails 2.0.0  (2020-02-09)
+
+- Extracted core functionality to `vite_ruby`.
+- User-facing API hasn't really changed, but internal classes have been renamed.
+- Installation script now injects tags to `application.html.erb` if it exists.
+
+## Vite Rails 1.0.12  (2020-01-29)
+
+- Add support for Vite 2.0.0-beta.56, which modified the manifest to output a `css` field in the manifest.
+- Start generating an assets manifest, since 2.0.0-beta.51 stopped including non-JS entrypoints in the manifest.
+
+## Vite Rails 1.0.11  (2020-01-24)
+
+- Fix bug in `assetHost` that caused `base` to be configured incorrectly.
+- Allow installing `vite` and `vite-plugin-ruby` as devDependencies, and install them when precompiling assets.
+- Move `base` to the configuration root after Vite's update in beta.38
+
+## Vite Rails 1.0.10  (2020-01-23)
+
+- Use `path_to_asset` in `vite_asset_path` so that it's prefixed automatically
+  when using a CDN (`config.action_controller.asset_host`).
+
+## Vite Rails 1.0.9  (2020-01-22)
+
+- Ensure `configPath` and `publicDir` are scoped from `root`, both in Ruby and JS.
+
+## Vite Rails 1.0.8  (2020-01-21)
 
 - Change the default of `sourceCodeDir` to `app/frontend`, add instructions for folks migrating
 from a `app/javascript` structure.

data/CONTRIBUTING.md

@@ -6,7 +6,6 @@
 
 ```
 bundle install
-yarn
 ```
 
 ## Making sure your changes pass all tests

data/README.md

@@ -1,45 +1,70 @@
 <h1 align="center">
-  Vite ⚡️ Rails
+  <a href="https://vite-ruby.netlify.app/">
+    <img src="https://raw.githubusercontent.com/ElMassimo/vite_ruby/main/docs/public/logo.svg" width="120px"/>
+  </a>
+
+  <br>
+
+  <a href="https://vite-ruby.netlify.app/">
+    Vite Rails
+  </a>
+
+  <br>
+
   <p align="center">
-<!--     <a href="https://github.com/ElMassimo/vite_rails/actions">
-      <img alt="Build Status" src="https://github.com/ElMassimo/vite_rails/workflows/build/badge.svg"/>
-    </a> -->
-    <!-- <a href="https://codeclimate.com/github/ElMassimo/vite_rails">
-      <img alt="Maintainability" src="https://codeclimate.com/github/ElMassimo/vite_rails/badges/gpa.svg"/>
+    <a href="https://github.com/ElMassimo/vite_ruby/actions">
+      <img alt="Build Status" src="https://github.com/ElMassimo/vite_ruby/workflows/build/badge.svg"/>
+    </a>
+    <a href="https://codeclimate.com/github/ElMassimo/vite_ruby">
+      <img alt="Maintainability" src="https://codeclimate.com/github/ElMassimo/vite_ruby/badges/gpa.svg"/>
+    </a>
+    <a href="https://codeclimate.com/github/ElMassimo/vite_ruby">
+      <img alt="Test Coverage" src="https://codeclimate.com/github/ElMassimo/vite_ruby/badges/coverage.svg"/>
     </a>
-    <a href="https://codeclimate.com/github/ElMassimo/vite_rails">
-      <img alt="Test Coverage" src="https://codeclimate.com/github/ElMassimo/vite_rails/badges/coverage.svg"/>
-    </a> -->
     <a href="https://rubygems.org/gems/vite_rails">
       <img alt="Gem Version" src="https://img.shields.io/gem/v/vite_rails.svg?colorB=e9573f"/>
     </a>
-    <a href="https://github.com/ElMassimo/vite_rails/blob/master/LICENSE.txt">
+    <a href="https://github.com/ElMassimo/vite_ruby/blob/master/LICENSE.txt">
       <img alt="License" src="https://img.shields.io/badge/license-MIT-428F7E.svg"/>
     </a>
   </p>
 </h1>
 
-[website]: https://vite-rails.netlify.app/
-[configuration reference]: https://vite-rails.netlify.app/config/
-[features]: https://vite-rails.netlify.app/guide/introduction.html
-[guides]: https://vite-rails.netlify.app/guide/
-[config]: https://vite-rails.netlify.app/config/
-[vite_rails]: https://github.com/ElMassimo/vite_rails
+[website]: https://vite-ruby.netlify.app/
+[configuration reference]: https://vite-ruby.netlify.app/config/
+[features]: https://vite-ruby.netlify.app/guide/introduction.html
+[guides]: https://vite-ruby.netlify.app/guide/
+[config]: https://vite-ruby.netlify.app/config/
+[vite_rails]: https://github.com/ElMassimo/vite_ruby/tree/main/vite_rails
 [webpacker]: https://github.com/rails/webpacker
 [vite]: http://vitejs.dev/
-[config file]: https://github.com/ElMassimo/vite_rails/blob/main/package/default.vite.json
-[example app]: https://github.com/ElMassimo/vite_rails/tree/main/examples/blog
-[heroku]: https://vite-rails-demo.herokuapp.com/
-
-[__Vite Rails__][vite_rails] allows you to use [Vite] to power the frontend of your Rails app.
+[config file]: https://github.com/ElMassimo/vite_ruby/blob/main/vite-plugin-ruby/default.vite.json
+[example app]: https://github.com/ElMassimo/pingcrm-vite
+[heroku]: https://pingcrm-vite.herokuapp.com/
+[Issues]: https://github.com/ElMassimo/vite_ruby/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc
+[Discussions]: https://github.com/ElMassimo/vite_ruby/discussions
+[no bundling]: https://vitejs.dev/guide/introduction.html#the-problem
+[bundling]: https://vitejs.dev/guide/introduction.html#why-bundle-for-production
 
 [Vite] is to frontend tooling as Ruby to programming, pure joy! 😍
 
-Check an [example app] running on [Heroku].
+[__Vite Rails__][vite_rails] provides a complete setup for Rails applications,
+allowing you to leverage [Vite] to power the frontend of your Rails app.
+
+## Why Vite? 🤔
+
+Vite [does not bundle your code during development][no bundling], which means the
+dev server is extremely __fast to start__, and your changes will be __updated instantly__.
+
+In production, Vite [bundles your code][bundling]
+with tree-shaking, lazy-loading, and common chunk splitting out of the box, to achieve optimal loading performance.
+
+Check [this video comparison with webpack](https://github.com/ElMassimo/pingcrm-vite/pull/1)
+which demonstrates the difference in speed during development.
 
 ## Features ⚡️
 
-- 🤖 Automatic entrypoint detection
+- 💡 Instant server start
 - ⚡️ Blazing fast hot reload
 - 🚀 Zero-config deployments
 - 🤝 Integrated with <kbd>assets:precompile</kbd>
@@ -61,7 +86,7 @@ Then, run:
 
 ```bash
 bundle install
-bin/rake vite:install
+bundle exec vite install
 ```
 
 This will generate configuration files and a sample setup.
@@ -70,18 +95,18 @@ Additional installation instructions are available in the [documentation website
 
 ## Getting Started 💻
 
-Restart your Rails server, and then run <kbd>bin/vite</kbd> to start the Vite development server.
+Restart your Rails server, and then run <kbd>bin/vite dev</kbd> to start the Vite development server.
 
-Add the following your `views/layouts/application.html.erb`:
+Visit any page and you should see a printed console output: `Vite ⚡️ Ruby`.
 
-```erb
-<%= vite_client_tag %>
-<%= vite_javascript_tag 'application' %>
-```
+For more [guides] and a full [configuration reference], check the [documentation website][website].
 
-Visit any page and you should see a printed console output: `Vite ⚡️ Rails`.
+## Contact ✉️
+
+Please use [Issues] to report bugs you find, and [Discussions] to make feature requests or get help.
+
+Don't hesitate to _⭐️ star the project_ if you find it useful!
 
-For more [guides] and a full [configuration reference], check the [documentation website][website].
 
 ## Special Thanks 🙏
 

data/lib/tasks/vite.rake

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+require 'vite_ruby'
+ViteRuby.install_tasks
+
+namespace :vite_rails do
+  desc 'Fixes Rails management of node dev dependencies (build dependencies)'
+  task :set_node_env do
+    ENV['NODE_ENV'] = 'development'
+  end
+end
+
+# Set NODE_ENV before installation, so that Rails installs JS build dependencies
+# on servers that precompile assets.
+['yarn:install', 'webpacker:yarn_install'].each do |name|
+  Rake::Task[name].enhance([:'vite_rails:set_node_env']) if Rake::Task.task_defined?(name)
+end

data/lib/vite_rails.rb

@@ -1,96 +1,8 @@
 # frozen_string_literal: true
 
-require 'active_support'
-require 'active_support/core_ext/class/attribute_accessors'
+require 'vite_ruby'
 
-require 'zeitwerk'
-loader = Zeitwerk::Loader.for_gem
-loader.ignore("#{ __dir__ }/install")
-loader.ignore("#{ __dir__ }/tasks")
-loader.setup
-
-class ViteRails
-  # Internal: Prefix used for environment variables that modify the configuration.
-  ENV_PREFIX = 'VITE_RUBY'
-
-  # Public: Additional environment variables to pass to Vite.
-  #
-  # Example:
-  #   ViteRails.env['VITE_RUBY_CONFIG_PATH'] = 'config/alternate_vite.json'
-  cattr_accessor(:env) { ENV.select { |key, _| key.start_with?(ENV_PREFIX) } }
-
-  cattr_accessor(:logger) { ActiveSupport::TaggedLogging.new(ActiveSupport::Logger.new(STDOUT)) }
-
-  class << self
-    delegate :config, :builder, :manifest, :commands, :dev_server, :dev_server_running?, to: :instance
-    delegate :mode, to: :config
-    delegate :bootstrap, :clean, :clobber, :build, to: :commands
-
-    attr_writer :instance
-
-    def instance
-      @instance ||= ViteRails.new
-    end
-
-    def run(args)
-      $stdout.sync = true
-      ViteRails::Runner.new(args).run
-    end
-
-    # Public: The proxy for assets should only run in development mode.
-    def run_proxy?
-      config.mode == 'development'
-    rescue StandardError => error
-      logger.error("Failed to check mode for Vite: #{ error.message }")
-      false
-    end
-
-    def with_node_env(env)
-      original = ENV['NODE_ENV']
-      ENV['NODE_ENV'] = env
-      yield
-    ensure
-      ENV['NODE_ENV'] = original
-    end
-
-    def ensure_log_goes_to_stdout
-      old_logger = ViteRails.logger
-      ViteRails.logger = ActiveSupport::Logger.new(STDOUT)
-      yield
-    ensure
-      ViteRails.logger = old_logger
-    end
-  end
-
-  # Public: Returns true if the Vite development server is running.
-  def dev_server_running?
-    ViteRails.run_proxy? && dev_server.running?
-  end
-
-  # Public: Current instance configuration for Vite.
-  def config
-    @config ||= ViteRails::Config.resolve_config
-  end
-
-  # Public: Keeps track of watched files and triggers builds as needed.
-  def builder
-    @builder ||= ViteRails::Builder.new(self)
-  end
-
-  # Public: Allows to check if the Vite development server is running.
-  def dev_server
-    @dev_server ||= ViteRails::DevServer.new(config)
-  end
-
-  # Public: Enables looking up assets managed by Vite using name and type.
-  def manifest
-    @manifest ||= ViteRails::Manifest.new(self)
-  end
-
-  # Internal: Helper to run commands related with Vite.
-  def commands
-    @commands ||= ViteRails::Commands.new(self)
-  end
-end
-
-ViteRails::Engine if defined?(Rails)
+require 'vite_rails/version'
+require 'vite_rails/config'
+require 'vite_rails/tag_helpers'
+require 'vite_rails/engine' if defined?(Rails)

data/lib/vite_rails/config.rb

@@ -1,104 +1,15 @@
 # frozen_string_literal: true
 
-# Public: Allows to resolve configuration sourced from `config/vite.json` and
-# environment variables, combining them with the default options.
-class ViteRails::Config
-  delegate :as_json, :inspect, to: :@config
-
-  def initialize(config)
-    @config = config.tap { coerce_values(config) }.freeze
-
-    config.each_key do |option|
-      define_singleton_method(option) { @config[option] }
-    end
-  end
-
-  def protocol
-    https ? 'https' : 'http'
-  end
-
-  def host_with_port
-    "#{ host }:#{ port }"
-  end
-
-  # Internal: Path where Vite outputs the manifest file.
-  def manifest_path
-    build_output_dir.join('manifest.json')
-  end
-
-  # Public: The directory where Vite will store the built assets.
-  def build_output_dir
-    public_dir.join(public_output_dir)
-  end
-
-private
-
-  # Internal: Coerces all the configuration values, in case they were passed
-  # as environment variables which are always strings.
-  def coerce_values(config)
-    coerce_booleans(config, 'auto_build', 'https')
-    coerce_paths(config, 'assets_dir', 'build_cache_dir', 'config_path', 'public_dir', 'source_code_dir', 'public_output_dir', 'root')
-    config['port'] = config['port'].to_i
-    config['root'] ||= Rails.root
-  end
-
-  # Internal: Coerces configuration options to boolean.
-  def coerce_booleans(config, *names)
-    names.each { |name| config[name] = [true, 'true'].include?(config[name]) }
-  end
-
-  # Internal: Converts configuration options to pathname.
-  def coerce_paths(config, *names)
-    names.each { |name| config[name] = Pathname.new(config[name]) unless config[name].nil? }
-  end
-
-  class << self
-    # Public: Returns the project configuration for Vite.
-    def resolve_config
-      new DEFAULT_CONFIG.merge(config_from_file).merge(config_from_env)
-    rescue Errno::ENOENT => error
-      warn "Check that your vite.json configuration file is available in the load path. #{ error.message }"
-      new DEFAULT_CONFIG.merge(config_from_env)
-    end
-
-  private
-
-    # Internal: Used to load a JSON file from the specified path.
-    def load_json(path)
-      JSON.parse(File.read(File.expand_path(path))).deep_transform_keys(&:underscore)
-    end
-
-    # Internal: Retrieves a configuration option from environment variables.
-    def config_option_from_env(name)
-      ENV["#{ ViteRails::ENV_PREFIX }_#{ name.upcase }"]
-    end
-
-    # Internal: Extracts the configuration options provided as env vars.
-    def config_from_env
-      CONFIGURABLE_WITH_ENV.each_with_object({}) do |key, env_vars|
-        if value = config_option_from_env(key)
-          env_vars[key] = value
-        end
-      end.merge(mode: vite_mode)
-    end
-
-    # Internal: The mode Vite should run on.
-    def vite_mode
-      config_option_from_env('mode') || Rails.env.to_s
-    end
-
-    # Internal: Loads the configuration options provided in a JSON file.
-    def config_from_file
-      path = config_option_from_env('config_path') || DEFAULT_CONFIG.fetch('config_path')
-      multi_env_config = load_json(path)
-      multi_env_config.fetch('all', {})
-        .merge(multi_env_config.fetch(vite_mode, {}))
-    end
+module ViteRails::Config
+  # Override: Default values for a Rails application.
+  def config_defaults
+    require 'rails'
+    super(
+      asset_host: Rails.application&.config&.action_controller&.asset_host,
+      mode: Rails.env.to_s,
+      root: Rails.root || Dir.pwd,
+    )
   end
-
-  # Internal: Shared configuration with the Vite plugin for Ruby.
-  DEFAULT_CONFIG = load_json("#{ __dir__ }/../../package/default.vite.json").freeze
-
-  # Internal: Configuration options that can be provided as env vars.
-  CONFIGURABLE_WITH_ENV = (DEFAULT_CONFIG.keys + ['root']).freeze
 end
+
+ViteRuby::Config.singleton_class.prepend(ViteRails::Config)

data/lib/vite_rails/engine.rb

@@ -4,36 +4,32 @@ require 'rails/railtie'
 
 class ViteRails::Engine < Rails::Engine
   initializer 'vite_rails.proxy' do |app|
-    app.middleware.insert_before 0, ViteRails::DevServerProxy, ssl_verify_none: true if ViteRails.run_proxy?
+    app.middleware.insert_before 0, ViteRuby::DevServerProxy, ssl_verify_none: true if ViteRuby.run_proxy?
   end
 
   initializer 'vite_rails.helper' do
     ActiveSupport.on_load(:action_controller) do
-      ActionController::Base.helper(ViteRails::Helper)
+      ActionController::Base.helper(ViteRails::TagHelpers)
     end
 
     ActiveSupport.on_load(:action_view) do
-      include ViteRails::Helper
+      include ViteRails::TagHelpers
     end
   end
 
   initializer 'vite_rails.logger' do
     config.after_initialize do
-      ViteRails.logger = if ::Rails.logger.respond_to?(:tagged)
-                           ::Rails.logger
-                         else
-                           ActiveSupport::TaggedLogging.new(::Rails.logger)
-                         end
+      ViteRuby.instance.logger = Rails.logger
     end
   end
 
   initializer 'vite_rails.bootstrap' do
     if defined?(Rails::Server) || defined?(Rails::Console)
-      ViteRails.bootstrap
+      ViteRuby.bootstrap
       if defined?(Spring)
         require 'spring/watcher'
-        Spring.after_fork { ViteRails.bootstrap }
-        Spring.watch(ViteRails.config.config_path)
+        Spring.after_fork { ViteRuby.bootstrap }
+        Spring.watch(ViteRuby.config.config_path)
       end
     end
   end