vite_rails 1.0.7 → 1.0.12

data/test/rake_tasks_test.rb

@@ -5,37 +5,23 @@ require 'test_helper'
 class RakeTasksTest < Minitest::Test
   def test_rake_tasks
     output = Dir.chdir(test_app_path) { `rake -T` }
-    assert_includes output, 'vite_rails'
-    assert_includes output, 'vite:check_binstubs'
-    assert_includes output, 'vite:check_node'
-    assert_includes output, 'vite:check_yarn'
+    assert_includes output, 'vite:build'
     assert_includes output, 'vite:clean'
     assert_includes output, 'vite:clobber'
-    assert_includes output, 'vite:compile'
     assert_includes output, 'vite:install'
+    assert_includes output, 'vite:install_dependencies'
     assert_includes output, 'vite:verify_install'
   end
 
   def test_rake_task_vite_check_binstubs
-    output = Dir.chdir(test_app_path) { `rake vite:check_binstubs 2>&1` }
+    output = Dir.chdir(test_app_path) { `rake vite:verify_install 2>&1` }
     refute_includes output, 'vite binstub not found.'
   end
 
-  def test_check_node_version
-    output = Dir.chdir(test_app_path) { `rake vite:check_node 2>&1` }
-    refute_includes output, 'ViteRails requires Node.js'
-  end
-
-  def test_check_yarn_version
-    output = Dir.chdir(test_app_path) { `rake vite:check_yarn 2>&1` }
-    refute_includes output, 'Yarn not installed'
-    refute_includes output, 'ViteRails requires Yarn'
-  end
-
   def test_rake_vite_install_dependencies_in_non_production_environments
     assert_includes test_app_dev_dependencies, 'right-pad'
 
-    ViteRails.with_node_env('test') do
+    ViteRails.commands.send(:with_node_env, 'test') do
       Dir.chdir(test_app_path) do
         `bundle exec rake vite:install_dependencies`
       end
@@ -46,14 +32,14 @@ class RakeTasksTest < Minitest::Test
   end
 
   def test_rake_vite_install_dependencies_in_production_environment
-    ViteRails.with_node_env('production') do
+    ViteRails.commands.send(:with_node_env, 'production') do
       Dir.chdir(test_app_path) do
         `bundle exec rake vite:install_dependencies`
       end
     end
 
-    refute_includes installed_node_module_names, 'right-pad',
-                    'Expected only production dependencies to be installed'
+    assert_includes installed_node_module_names, 'right-pad',
+                    'Expected development dependencies to be installed as well'
   end
 
 private

data/test/runner_test.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+require 'test_helper'
+
+class RunnerTest < ViteRails::Test
+  def test_dev_server_command
+    assert_run_command(flags: ['--mode', 'production'])
+  end
+
+  def test_dev_server_command_via_yarn
+    assert_run_command(flags: ['--mode', 'production'], use_yarn: true)
+  end
+
+  def test_dev_server_command_with_argument
+    assert_run_command('--quiet', flags: ['--mode', 'production'])
+  end
+
+  def test_build_command
+    assert_run_command('build', flags: ['--mode', 'production'])
+  end
+
+  def test_build_command_via_yarn
+    assert_run_command('build', flags: ['--mode', 'production'], use_yarn: true)
+  end
+
+  def test_build_command_with_argument
+    with_rails_env('development') do
+      assert_run_command('build', '--emptyOutDir', flags: ['--mode', 'development'])
+    end
+  end
+end

data/test/test_app/app/frontend/entrypoints/application.js

@@ -0,0 +1,2 @@
+/* eslint no-console:0 */
+console.log('Hello World from ViteRails')

data/test/test_app/config/vite.json

@@ -10,11 +10,9 @@
     "publicOutputDir": "vite-test"
   },
   "production": {
-    "autoBuild": false,
     "publicOutputDir": "vite-production"
   },
   "staging": {
-    "autoBuild": false,
     "publicOutputDir": "vite-staging"
   }
 }

data/test/test_app/config/vite_additional_paths.json

@@ -0,0 +1,5 @@
+{
+  "all": {
+    "watchAdditionalPaths": ["config/*"]
+  }
+}

data/test/test_app/config/vite_public_dir.json

@@ -0,0 +1,5 @@
+{
+  "all": {
+    "publicDir": "../public"
+  }
+}

data/test/test_app/public/vite-production/manifest-assets.json

@@ -0,0 +1,10 @@
+{
+  "logo.svg": {
+    "file": "assets/logo.490fa4f8.svg",
+    "src": "logo.svg"
+  },
+  "styles.css": {
+    "file": "assets/styles.0e53e684.css",
+    "src": "styles.css"
+  }
+}

data/test/test_app/public/vite-production/manifest.json

@@ -0,0 +1,39 @@
+{
+  "application.js": {
+    "file": "assets/application.d9514acc.js",
+    "src": "application.js",
+    "isEntry": true,
+    "imports": [
+      "_vendor.880705da.js",
+      "example_import.js"
+    ],
+    "css": [
+      "assets/application.f510c1e9.css"
+    ]
+  },
+  "application.ts": {
+    "file": "assets/application.d9514acc.js",
+    "src": "application.ts",
+    "isEntry": true,
+    "imports": [
+      "_vendor.880705da.js",
+      "example_import.js"
+    ],
+    "css": [
+      "assets/application.f510c1e9.css"
+    ]
+  },
+  "example_import.js": {
+    "file": "assets/example_import.8e1fddc0.js",
+    "src": "example_import.js",
+    "isEntry": true
+  },
+  "logo.svg": {
+    "file": "assets/logo.f1745d22.js",
+    "src": "logo.svg",
+    "isEntry": true
+  },
+  "_vendor.880705da.js": {
+    "file": "assets/vendor.880705da.js"
+  }
+}

data/test/test_helper.rb

@@ -1,34 +1,68 @@
 # frozen_string_literal: true
 
+require 'simplecov'
+SimpleCov.start {
+  add_filter '/test/'
+}
+
 require 'minitest/autorun'
 require 'rails'
 require 'rails/test_help'
-require 'byebug'
+require 'pry-byebug'
 
 require_relative 'test_app/config/environment'
 
 Rails.env = 'production'
 
-ViteRails.instance = ::ViteRails.new
+ViteRails.instance = ViteRails.new
 
-class ViteRails::Test < Minitest::Test
-private
-
-  def reloaded_config
-    ViteRails.instance.instance_variable_set(:@config, nil)
-    ViteRails.instance.instance_variable_set(:@dev_server, nil)
-    ViteRails.env = {}
-    ViteRails.config
-    ViteRails.dev_server
+module ViteRailsTestHelpers
+  def refresh_config(env_variables = ViteRails.load_env_variables)
+    ViteRails.env = env_variables
+    (ViteRails.instance = ViteRails.new).config
   end
 
   def with_rails_env(env)
     original = Rails.env
     Rails.env = ActiveSupport::StringInquirer.new(env)
-    reloaded_config
-    yield
+    yield(refresh_config)
   ensure
     Rails.env = ActiveSupport::StringInquirer.new(original)
-    reloaded_config
+    refresh_config
+  end
+
+  def test_app_path
+    File.expand_path('test_app', __dir__)
+  end
+
+  def with_dev_server_running(&block)
+    ViteRails.instance.stub(:dev_server_running?, true, &block)
+  end
+end
+
+class ViteRails::Test < Minitest::Test
+  include ViteRailsTestHelpers
+
+private
+
+  def assert_run_command(*argv, use_yarn: false, flags: [])
+    command = use_yarn ? %w[yarn vite] : ["#{ test_app_path }/node_modules/.bin/vite"]
+    cwd = Dir.pwd
+    Dir.chdir(test_app_path)
+
+    klass = ViteRails::Runner
+    instance = klass.new(argv)
+    mock = Minitest::Mock.new
+    mock.expect(:call, nil, [ViteRails.config.to_env, *command, *argv, *flags])
+
+    klass.stub(:new, instance) do
+      instance.stub(:executable_exists?, !use_yarn) do
+        Kernel.stub(:exec, mock) { ViteRails.run(argv) }
+      end
+    end
+
+    mock.verify
+  ensure
+    Dir.chdir(cwd)
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: vite_rails
 version: !ruby/object:Gem::Version
-  version: 1.0.7
+  version: 1.0.12
 platform: ruby
 authors:
 - Máximo Mussini
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-01-20 00:00:00.000000000 Z
+date: 2021-01-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -147,9 +147,9 @@ files:
 - package.json
 - package/default.vite.json
 - test/builder_test.rb
-- test/command_test.rb
-- test/configuration_test.rb
-- test/dev_server_runner_test.rb
+- test/commands_test.rb
+- test/config_test.rb
+- test/dev_server_proxy_test.rb
 - test/dev_server_test.rb
 - test/engine_rake_tasks_test.rb
 - test/helper_test.rb
@@ -164,30 +164,30 @@ files:
 - test/mounted_app/test/dummy/config/environment.rb
 - test/mounted_app/test/dummy/config/vite.json
 - test/mounted_app/test/dummy/package.json
+- test/mounted_app/test/dummy/yarn.lock
 - test/rake_tasks_test.rb
+- test/runner_test.rb
 - test/test_app/Rakefile
-- test/test_app/app/javascript/entrypoints/application.js
-- test/test_app/app/javascript/entrypoints/multi_entry.css
-- test/test_app/app/javascript/entrypoints/multi_entry.js
+- test/test_app/app/frontend/entrypoints/application.js
 - test/test_app/bin/vite
 - test/test_app/config.ru
 - test/test_app/config/application.rb
 - test/test_app/config/environment.rb
 - test/test_app/config/vite.json
-- test/test_app/config/vite_public_root.yml
+- test/test_app/config/vite_additional_paths.json
+- test/test_app/config/vite_public_dir.json
 - test/test_app/package.json
-- test/test_app/public/vite/manifest.json
+- test/test_app/public/vite-production/manifest-assets.json
+- test/test_app/public/vite-production/manifest.json
 - test/test_app/some.config.js
 - test/test_app/yarn.lock
 - test/test_helper.rb
-- test/vite_runner_test.rb
-- test/webpacker_test.rb
 homepage: https://github.com/ElMassimo/vite_rails
 licenses:
 - MIT
 metadata:
-  source_code_uri: https://github.com/ElMassimo/vite_rails/tree/v1.0.7
-  changelog_uri: https://github.com/ElMassimo/vite_rails/blob/v1.0.7/CHANGELOG.md
+  source_code_uri: https://github.com/ElMassimo/vite_rails/tree/v1.0.12
+  changelog_uri: https://github.com/ElMassimo/vite_rails/blob/v1.0.12/CHANGELOG.md
 post_install_message:
 rdoc_options: []
 require_paths:
@@ -196,7 +196,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.4.0
+      version: 2.5.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -209,9 +209,9 @@ specification_version: 4
 summary: Use Vite in Rails and bring joy to your JavaScript experience
 test_files:
 - test/builder_test.rb
-- test/command_test.rb
-- test/configuration_test.rb
-- test/dev_server_runner_test.rb
+- test/commands_test.rb
+- test/config_test.rb
+- test/dev_server_proxy_test.rb
 - test/dev_server_test.rb
 - test/engine_rake_tasks_test.rb
 - test/helper_test.rb
@@ -226,21 +226,21 @@ test_files:
 - test/mounted_app/test/dummy/config/environment.rb
 - test/mounted_app/test/dummy/config/vite.json
 - test/mounted_app/test/dummy/package.json
+- test/mounted_app/test/dummy/yarn.lock
 - test/rake_tasks_test.rb
+- test/runner_test.rb
 - test/test_app/Rakefile
-- test/test_app/app/javascript/entrypoints/application.js
-- test/test_app/app/javascript/entrypoints/multi_entry.css
-- test/test_app/app/javascript/entrypoints/multi_entry.js
+- test/test_app/app/frontend/entrypoints/application.js
 - test/test_app/bin/vite
 - test/test_app/config.ru
 - test/test_app/config/application.rb
 - test/test_app/config/environment.rb
 - test/test_app/config/vite.json
-- test/test_app/config/vite_public_root.yml
+- test/test_app/config/vite_additional_paths.json
+- test/test_app/config/vite_public_dir.json
 - test/test_app/package.json
-- test/test_app/public/vite/manifest.json
+- test/test_app/public/vite-production/manifest-assets.json
+- test/test_app/public/vite-production/manifest.json
 - test/test_app/some.config.js
 - test/test_app/yarn.lock
 - test/test_helper.rb
-- test/vite_runner_test.rb
-- test/webpacker_test.rb

data/test/command_test.rb

@@ -1,35 +0,0 @@
-# frozen_string_literal: true
-
-require 'test_helper'
-
-class CommandTest < Minitest::Test
-  def test_compile_command_returns_success_status_when_stale
-    ViteRails.builder.stub :stale?, true do
-      ViteRails.builder.stub :run_vite, true do
-        assert_equal true, ViteRails.commands.compile
-      end
-    end
-  end
-
-  def test_compile_command_returns_success_status_when_fresh
-    ViteRails.builder.stub :stale?, false do
-      ViteRails.builder.stub :run_vite, true do
-        assert_equal true, ViteRails.commands.compile
-      end
-    end
-  end
-
-  def test_compile_command_returns_failure_status_when_stale
-    ViteRails.builder.stub :stale?, true do
-      ViteRails.builder.stub :run_vite, false do
-        assert_equal false, ViteRails.commands.compile
-      end
-    end
-  end
-
-  def test_clean_command_works_with_nested_hashes_and_without_any_compiled_files
-    File.stub :delete, true do
-      assert ViteRails.commands.clean
-    end
-  end
-end

data/test/configuration_test.rb

@@ -1,80 +0,0 @@
-# frozen_string_literal: true
-
-require 'test_helper'
-
-class ConfigurationTest < ViteRails::Test
-  def setup
-    @config = ViteRails::Configuration.new(
-      root_path: Pathname.new(File.expand_path('test_app', __dir__)),
-      config_path: Pathname.new(File.expand_path('./test_app/config/vite.yml', __dir__)),
-      env: 'production',
-    )
-  end
-
-  def test_source_path
-    source_path = File.expand_path File.join(File.dirname(__FILE__), 'test_app/app/javascript').to_s
-    assert_equal source_path, @config.source_path.to_s
-  end
-
-  def test_source_entry_path
-    source_entry_path = File.expand_path File.join(File.dirname(__FILE__), 'test_app/app/javascript', 'packs').to_s
-    assert_equal @config.source_entry_path.to_s, source_entry_path
-  end
-
-  def test_public_root_path
-    public_root_path = File.expand_path File.join(File.dirname(__FILE__), 'test_app/public').to_s
-    assert_equal @config.public_path.to_s, public_root_path
-  end
-
-  def test_public_output_path
-    public_output_path = File.expand_path File.join(File.dirname(__FILE__), 'test_app/public/packs').to_s
-    assert_equal @config.public_output_path.to_s, public_output_path
-
-    @config = ViteRails::Configuration.new(
-      root_path: @config.root_path,
-      config_path: Pathname.new(File.expand_path('./test_app/config/vite_public_root.yml', __dir__)),
-      env: 'production',
-    )
-
-    public_output_path = File.expand_path File.join(File.dirname(__FILE__), 'public/packs').to_s
-    assert_equal @config.public_output_path.to_s, public_output_path
-  end
-
-  def test_public_manifest_path
-    public_manifest_path = File.expand_path File.join(File.dirname(__FILE__), 'test_app/public/packs', 'manifest.json').to_s
-    assert_equal @config.public_manifest_path.to_s, public_manifest_path
-  end
-
-  def test_cache_path
-    cache_path = File.expand_path File.join(File.dirname(__FILE__), 'test_app/tmp/cache/vite').to_s
-    assert_equal @config.cache_path.to_s, cache_path
-  end
-
-  def test_additional_paths
-    assert_equal @config.additional_paths, ['app/assets', '/etc/yarn', 'some.config.js', 'app/elm']
-  end
-
-  def test_cache_manifest?
-    assert @config.cache_manifest?
-
-    with_rails_env('development') do
-      refute ViteRails.config.cache_manifest?
-    end
-
-    with_rails_env('test') do
-      refute ViteRails.config.cache_manifest?
-    end
-  end
-
-  def test_compile?
-    refute @config.compile?
-
-    with_rails_env('development') do
-      assert ViteRails.config.compile?
-    end
-
-    with_rails_env('test') do
-      assert ViteRails.config.compile?
-    end
-  end
-end