visualize_packwerk 0.2.0 → 0.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c15049155fd43dca095255941ff8f996409fd2712f28008874fe3a772ba9b28b
-  data.tar.gz: 406b008fa89777838b588080aa3ee25afd417f16663124b668937ea91c3b9c17
+  metadata.gz: fa3fce5bdaac63e80b257bcb8a9294d01c6bf82fbd5f6eaf7e22bc4c2c46096d
+  data.tar.gz: e8d5e14f4c5d66749d76784fa985b49f9b0dc51c5a85a0581816f1218811eee3
 SHA512:
-  metadata.gz: b6ee92e733adf0da1062cf262849685a5adb053baef2adb34793aadedbb68c072193a19df4ff9d8eed280e491cfb0afac4bb9a1211962f6cd1d8a9b20c4bf6d8
-  data.tar.gz: 6ca30bbcadd94b1b8241456001c6d8144f6b395718cb1d765605cb0c2f1fb7b0bffe4d36c312cbb7510ed9930385013eafe598788f63d6c675abbcd8b6034539
+  metadata.gz: 90085ef3d52e36bd01eaabae163cd900cc26575958b75915976d4f426ec998396b650490a2eb7ca3d266d1951f6a333cf704da98ada665d7763656c428e8c61b
+  data.tar.gz: 98e21b88e7e0603347c52889510de23a0dd8a8fdbedb6526dc16f3868e731dd997acd312c29baaaf43b66957a3f2ff756841ce491f51b79445052a7c3539b0ab

data/lib/visualize_packwerk/package_graph.rb

@@ -16,7 +16,7 @@ module VisualizePackwerk
     sig { params(package_nodes: T::Set[PackageNode]).void }
     def initialize(package_nodes:)
       @package_nodes = package_nodes
-      @index_by_name = T.let({}, T::Hash[String, PackageNode])
+      @index_by_name = T.let({}, T::Hash[String, T.nilable(PackageNode)])
     end
 
     sig { returns(PackageGraph) }
@@ -46,9 +46,9 @@ module VisualizePackwerk
       PackageGraph.new(package_nodes: package_nodes)
     end
 
-    sig { params(name: String).returns(PackageNode) }
+    sig { params(name: String).returns(T.nilable(PackageNode)) }
     def package_by_name(name)
-      @index_by_name[name] ||= T.must(package_nodes.find { |node| node.name == name })
+      @index_by_name[name] ||= package_nodes.find { |node| node.name == name }
     end
   end
 end

data/lib/visualize_packwerk/team_graph.rb

@@ -26,7 +26,9 @@ module VisualizePackwerk
         package_nodes_for_team.map(&:violations_by_package).each do |new_violations_by_package|
           new_violations_by_package.each do |pack_name, count|
             # We first get the pack owner of the violated package
-            other_team = package_graph.package_by_name(pack_name).team_name
+            other_package = package_graph.package_by_name(pack_name)
+            next if other_package.nil?
+            other_team = other_package.team_name
             violations_by_team[other_team] ||= 0
             # Then we add the violations on that team together
             # TODO: We may want to ignore this if team == other_team to avoid arrows pointing to self, but maybe not!
@@ -36,7 +38,9 @@ module VisualizePackwerk
 
         dependencies = Set.new
         package_nodes_for_team.map(&:dependencies).reduce(Set.new, :+).each do |dependency|
-          dependencies << package_graph.package_by_name(dependency).team_name
+          other_pack = package_graph.package_by_name(dependency)
+          next if other_pack.nil?
+          dependencies << other_pack.team_name
         end
 
         team_nodes << TeamNode.new(

data/lib/visualize_packwerk.rb

@@ -1,6 +1,6 @@
 # typed: strict
 
-require 'packs'
+require 'packs-specification'
 require 'parse_packwerk'
 require 'code_ownership'
 require 'graphviz'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: visualize_packwerk
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.3
 platform: ruby
 authors:
 - Gusto Engineers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-05-02 00:00:00.000000000 Z
+date: 2023-08-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sorbet-runtime