visualize_packwerk 0.0.6 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a0b2682a8a34f87cc58bd46f0896ff4a743908035942abd58c49bbd13e1d0715
-  data.tar.gz: '08a6f4c9bf22cf18d6951d5ca594c2fbe79222921641a98ec6c1f3646587b398'
+  metadata.gz: 4425d05708c5fc0d1ccc3e76d991d222e4089e4ed7717bdcc90ebcb7577b8a0d
+  data.tar.gz: 2dc5bb9be62bbb7f3251de7a52b538de4c3ed3c1fc9ef1a53615f617da5f8d1b
 SHA512:
-  metadata.gz: cff9630c1df4d9dc684b2dda3c76c6e7dc14e95add1d00c117b9b9f641cdb80318aac6e523cf4fe0aac434b9fc40ddd9105fd993ebc1890a63bcf5825d04a8dd
-  data.tar.gz: 8c8e2208ddccbf4da02c68c747341667557cfb4df311477230d120f0979e6ab2d5a2add59ca7bd0aa2cae3e98028acaae4d39af3faefcece6e7112d34d2d355f
+  metadata.gz: 1934e543832c1b2df2811fdaed60687d223849b190cae86eeb3e67b2127b4e95cb89409f56d4609641c0bf9e99ba4fde7cb57836cfba0daef77ede66d7fde776
+  data.tar.gz: a9e3cc970f06aa8a36406fed5e8bff47de3070a9d2b1b0d8f3a3ab5bb4c544da21eb2c92cc158d25871250788d8b10a2f588d08c2851cc2c380916e63ce3b955

data/README.md

@@ -6,17 +6,17 @@ This gem contains rake tasks to help visualize relationships between packwerk pa
 ## Building a package graph for a selection of packages
 ```ruby
 # Select the packs you want to include
-selected_packs = ParsePackwerk.all
-selected_packs = ParsePackwerk.all.select{|p| ['packs/my_pack_1', 'packs/my_pack_2'].include?(p.name) }
-selected_packs = ParsePackwerk.all.select{|p| ['Team 1', 'Team 2'].include?(CodeOwnership.for_package(p)&.name) }
+selected_packs = Packs.all
+selected_packs = Packs.all.select{ |p| ['packs/my_pack_1', 'packs/my_pack_2'].include?(p.name) }
+selected_packs = Packs.all.select{ |p| ['Team 1', 'Team 2'].include?(CodeOwnership.for_package(p)&.name) }
 VisualizePackwerk.package_graph!(selected_packs)
 ```
 
 # Building a team graph for specific teams
-```
+```ruby
 # Select the teams you want to include
 selected_teams = CodeTeams.all
-selected_teams = CodeTeams.all.select{ ... }
+selected_teams = CodeTeams.all.select{ |t| ['Team 1', 'Team 2'].include?(t.name) }
 VisualizePackwerk.team_graph!(selected_teams)
 ```
 

data/lib/visualize_packwerk/package_graph.rb

@@ -22,18 +22,26 @@ module VisualizePackwerk
     sig { returns(PackageGraph) }
     def self.construct
       package_nodes = Set.new
-      ParsePackwerk.all.each do |p|
-        # We could consider ignoring the root!
-        # We would also need to ignore it when parsing PackageNodes.
-        # next if p.name == ParsePackwerk::ROOT_PACKAGE_NAME
+      Packs.all.each do |p|
         owner = CodeOwnership.for_package(p)
-        violations_by_package = p.violations.group_by(&:to_package_name).transform_values(&:count)
+
+        # Here we need to load the package violations and dependencies,
+        # so we need to use ParsePackwerk to parse that information.
+        package_info = ParsePackwerk.find(p.name)
+        next unless package_info # This should not happen unless packs/parse_packwerk change implementation
+
+        violations = package_info.violations
+        violations_by_package = violations.group_by(&:to_package_name).transform_values(&:count)
+        violations_by_package.delete('.') # remove root package violations
+
+        dependencies = package_info.dependencies
+        dependencies.delete('.') # remove root package dependencies
 
         package_nodes << PackageNode.new(
           name: p.name,
           team_name: owner&.name || 'Unknown',
           violations_by_package: violations_by_package,
-          dependencies: Set.new(p.dependencies)
+          dependencies: Set.new(dependencies)
         )
       end
 

data/lib/visualize_packwerk/package_relationships.rb

@@ -8,7 +8,7 @@ module VisualizePackwerk
 
     sig { params(teams: T::Array[CodeTeams::Team]).void }
     def create_package_graph_for_teams!(teams)
-      packages = ParsePackwerk.all.select do |package|
+      packages = Packs.all.select do |package|
         teams.map(&:name).include?(CodeOwnership.for_package(package)&.name)
       end
 
@@ -24,14 +24,14 @@ module VisualizePackwerk
       draw_graph!(team_graph, node_names, show_all_nodes: show_all_teams)
     end
 
-    sig { params(packages: T::Array[ParsePackwerk::Package]).void }
+    sig { params(packages: T::Array[Packs::Pack]).void }
     def create_package_graph!(packages)
       graph = PackageGraph.construct
       node_names = packages.map(&:name)
       draw_graph!(graph, node_names)
     end
 
-    sig { params(packages: T::Array[ParsePackwerk::Package], show_all_nodes: T::Boolean).void }
+    sig { params(packages: T::Array[Packs::Pack], show_all_nodes: T::Boolean).void }
     def create_graph!(packages, show_all_nodes: false)
       graph = PackageGraph.construct
       node_names = packages.map(&:name)

data/lib/visualize_packwerk.rb

@@ -1,5 +1,6 @@
 # typed: strict
 
+require 'packs'
 require 'parse_packwerk'
 require 'code_ownership'
 require 'graphviz'
@@ -16,7 +17,7 @@ require 'visualize_packwerk/package_relationships'
 module VisualizePackwerk
   extend T::Sig
 
-  sig { params(packages: T::Array[ParsePackwerk::Package]).void }
+  sig { params(packages: T::Array[Packs::Pack]).void }
   def self.package_graph!(packages)
     PackageRelationships.new.create_package_graph!(packages)
   end