visualize_packs 0.5.12 → 0.5.14

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8017d316d5d179efe32200f2152bb0abb1c8a3b3299ba8f777a604c07165660e
-  data.tar.gz: 5f306bd08bdc5cb70eee69ea23a9233ba03ad8d13bd7c6c75c92a39a18f3f1f6
+  metadata.gz: 23b734b878b51ec2da854f99e7f723b5cb00f59e1b2d0712b5ebcd8f0b05d638
+  data.tar.gz: f7ef0ac5c923a939067c6f0e8ed52dc899f80e60556a4d2469b453d14009e3be
 SHA512:
-  metadata.gz: e9c0773394b6f17466e75e00c825dfcca7a1d359922988b257a08e59fb1ce76e2c373cfe968783d87f3ec8da5b9f500d53d64dcfc74946a3ac804376e22bdeb3
-  data.tar.gz: aff8ae19a21ca89a91331c2c2679fc64e15c5151e5f59a72a7dc35b7d5df72680e0627d6462ec6b5cc519098263210c60994445a563fc6aa95149be7a4d4c684
+  metadata.gz: 0e7f6b1d1ec02ad20d524c2bd3bdb84841c799f4a4782742afd0c1ae310fce4ba90d780ce8d8c98fb15be68ed2d085daf03eb70b6d70870af9bb5bda7b00d80e
+  data.tar.gz: da4fafcf7b5639a300d2242971d40b2cf0c5b19f05d39941ff6610a0bb99e0d4dc4ad47e93ed503472574e8284af352dc3ead275bfadb6b9c450cfbd0f712790

data/lib/visualize_packs.rb

@@ -12,13 +12,12 @@ module VisualizePacks
   sig { params(options: Options, raw_config: T::Hash[String, T.untyped], packages: T::Array[ParsePackwerk::Package]).returns(String) }
   def self.package_graph!(options, raw_config, packages)
     all_packages = filtered(packages, options).compact.sort_by {|x| x.name }
-    all_package_names = all_packages.map &:name
-
     all_packages = remove_nested_packs(all_packages, options)
+    all_package_names = all_packages.map &:name
 
     show_edge = show_edge_builder(options, all_package_names)
     node_color = node_color_builder()
-    max_todo_count = max_todo_count(all_packages, show_edge)
+    max_todo_count = max_todo_count(all_packages, show_edge, options)
 
     title = diagram_title(options, max_todo_count)
 
@@ -130,17 +129,21 @@ module VisualizePacks
     end
   end
 
-  sig { params(all_packages: T::Array[ParsePackwerk::Package], show_edge: T.proc.params(arg0: String, arg1: String).returns(T::Boolean)).returns(T.nilable(Integer)) }
-  def self.max_todo_count(all_packages, show_edge)
+  sig { params(all_packages: T::Array[ParsePackwerk::Package], show_edge: T.proc.params(arg0: String, arg1: String).returns(T::Boolean), options: Options).returns(T.nilable(Integer)) }
+  def self.max_todo_count(all_packages, show_edge, options)
     todo_counts = {}
-    all_packages.each do |package|
-      todos_by_package = package.violations&.group_by(&:to_package_name)
-      todos_by_package&.keys&.each do |todos_to_package|
-        todo_types = todos_by_package&& todos_by_package[todos_to_package]&.group_by(&:type)
-        todo_types&.keys&.each do |todo_type|
-          if show_edge.call(package.name, todos_to_package)
-            key = "#{package.name}->#{todos_to_package}:#{todo_type}"
-            todo_counts[key] = todo_types && todo_types[todo_type]&.count
+    if options.show_todos
+      all_packages.each do |package|
+        todos_by_package = package.violations&.group_by(&:to_package_name)
+        todos_by_package&.keys&.each do |todos_to_package|
+          todo_types = todos_by_package&& todos_by_package[todos_to_package]&.group_by(&:type)
+          todo_types&.keys&.each do |todo_type|
+            if options.only_todo_types.empty? || options.only_todo_types.include?(todo_type)
+              if show_edge.call(package.name, todos_to_package)
+                key = "#{package.name}->#{todos_to_package}:#{todo_type}"
+                todo_counts[key] = todo_types && todo_types[todo_type]&.count
+              end
+            end
           end
         end
       end
@@ -190,11 +193,27 @@ module VisualizePacks
     if !focus_pack.empty?
       result = []
       result += packages.map { |pack| pack.name }.select { |p| match_packs?(p, focus_pack) }
-      result += packages.select{ |p| p.dependencies.any? { |d| match_packs?(d, focus_pack) }}.map { |pack| pack.name }
-      result += packages.select{ |p| p.violations&.map(&:to_package_name)&.any? { |v| match_packs?(v, focus_pack) }}.map { |pack| pack.name }
+      if options.show_dependencies
+        result += packages.select { |p| p.dependencies.any? { |d| match_packs?(d, focus_pack) }}.map { |pack| pack.name }
+      end
+      if options.show_todos && [nil, FocusPackEdgeDirection::In, FocusPackEdgeDirection::InOut].include?(options.show_only_edges_to_focus_pack)
+        result += packages.select do
+          |p| (p.violations || []).inject([]) do |res, todo|
+            res << todo.to_package_name if options.only_todo_types.empty? || options.only_todo_types.include?(todo.type)
+            res
+          end.any? { |v| match_packs?(v, focus_pack) }
+        end.map { |pack| pack.name }
+      end
       packages.map { |pack| pack.name }.select { |p| match_packs?(p, focus_pack) }.each do |p|
-        result += packages_by_name[p].dependencies
-        result += packages_by_name[p].violations.map(&:to_package_name)
+        if options.show_dependencies
+          result += packages_by_name[p].dependencies
+        end
+        if options.show_todos && [nil, FocusPackEdgeDirection::Out, FocusPackEdgeDirection::InOut].include?(options.show_only_edges_to_focus_pack)
+          result += (packages_by_name[p].violations || []).inject([]) do |res, todo|
+            res << todo.to_package_name if options.only_todo_types.empty? || options.only_todo_types.include?(todo.type)
+            res
+          end
+        end
       end
       result = result.uniq
       parent_packs = result.inject([]) do |res, package_name|

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: visualize_packs
 version: !ruby/object:Gem::Version
-  version: 0.5.12
+  version: 0.5.14
 platform: ruby
 authors:
 - Gusto Engineers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-09-02 00:00:00.000000000 Z
+date: 2023-09-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler