virustotal_api 0.5.3 → 0.5.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 549e10acf953216ded9295c21129e76fc737bd63f29703af799499c6feed2c6e
-  data.tar.gz: d20c12d67d748d329e3b0e340a4857115d516d942af5e3a282bb72e80a90e373
+  metadata.gz: 8bf33b0c496e55c74969e71e323aa64c664a4e7090db4f849601829143ee976a
+  data.tar.gz: 13eed4b64f8923c637e2155c3ece40f9bf55378c3f3a4cc7a321e29f58d8a357
 SHA512:
-  metadata.gz: 394ad7a9dbf0f4c59d7e286acd57974e042427f0f4c82d1c652195b0dca4d17a0eeed28cd82946da2a072679a824060bacf184c741ecd0578e383386295c328d
-  data.tar.gz: 0f9b0e2bc76a11d1b496ac1b0fb266875ed36cbfb51b27396396b555c3e47d5e411073e8bef956e1e44d08ec395e1165a45df8e525b24af6a0ae915d2c9c1b79
+  metadata.gz: 168c48232321aecaa6ad6bf5d34d07eb417cbf82f4bcd9a69ed678bb1c28c23a0121a859151662d0e810ea1ca4d8cda2dc50a771d98eaf85f5c98f424b9c4458
+  data.tar.gz: '021498bfce536a34eadc04c7b12766ff605b1f3ae61163be4c88e72aba5e05f2ce4be692aaa601420bdc480327d81e6e5496fd4c293c60f6fdb11f9537d68363'

data/.github/workflows/ruby.yml

@@ -15,7 +15,7 @@ jobs:
     - name: Set up Ruby
     # To automatically get bug fixes and new Ruby versions for ruby/setup-ruby,
     # change this to (see https://github.com/ruby/setup-ruby#versioning):
-      uses: ruby/setup-ruby@v1.46.0
+      uses: ruby/setup-ruby@v1
       with:
         ruby-version: 2.5
     - name: Install dependencies

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 # VirusTotal API Changelog
 
+## [0.5.4] - 2020-12-10
+* Manage bad requests like not found
+* Use strict base64 encoding
+  * [@crondaemon](https://github.com/crondaemon)
+
+## [0.5.3] = 2020-10-12
+
 ## [0.5.2] - 2020-10-06
 
 * Fix Fix exists? check

data/lib/virustotal_api/base.rb

@@ -37,7 +37,7 @@ module VirustotalAPI
         payload: options
       )
       JSON.parse(response.body)
-    rescue RestClient::NotFound
+    rescue RestClient::NotFound, RestClient::BadRequest
       {}
     rescue RestClient::Unauthorized
       # Raise a custom exception not to expose the underlying
@@ -62,7 +62,7 @@ module VirustotalAPI
     # Generate a URL identifier.
     # @see https://developers.virustotal.com/v3.0/reference#url
     def self.url_identifier(url)
-      Base64.encode64(url).strip.gsub('=', '')
+      Base64.strict_encode64(url).strip.gsub('=', '')
     end
   end
 end

data/lib/virustotal_api/version.rb

@@ -2,5 +2,5 @@
 
 module VirustotalAPI
   # The GEM version
-  VERSION = '0.5.3'
+  VERSION = '0.5.4'
 end

data/test/base_test.rb

@@ -4,6 +4,7 @@ require './test/test_helper'
 
 class VirustotalAPIBaseTest < Minitest::Test
   def setup
+    @domain  = 'xpressco.za'
     @sha256  = '01ba4719c80b6fe911b091a7c05124b64eeece964e09c058ef8f9805daca546b'
     @api_key = 'testapikey'
   end
@@ -43,5 +44,11 @@ class VirustotalAPIBaseTest < Minitest::Test
 
       assert !virustotal_report.exists?
     end
+
+    VCR.use_cassette('domain_bad_request') do
+      virustotal_report = VirustotalAPI::Domain.find(@domain, @api_key)
+
+      assert !virustotal_report.exists?
+    end
   end
 end

data/test/fixtures/domain_bad_request.yml

@@ -0,0 +1,52 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: https://www.virustotal.com/api/v3/domains/xpressco.za
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      Accept:
+      - "*/*"
+      User-Agent:
+      - rest-client/2.1.0 (linux-gnu x86_64) ruby/2.5.1p57
+      X-Apikey:
+      - testapikey
+      Content-Length:
+      - '0'
+      Content-Type:
+      - application/x-www-form-urlencoded
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Host:
+      - www.virustotal.com
+  response:
+    status:
+      code: 400
+      message: Bad Request
+    headers:
+      Cache-Control:
+      - no-cache
+      Content-Type:
+      - application/json; charset=utf-8
+      X-Cloud-Trace-Context:
+      - f9f5f005efc95b0390a91fb6306201d6
+      Date:
+      - Mon, 28 Dec 2020 13:56:50 GMT
+      Server:
+      - Google Frontend
+      Content-Length:
+      - '138'
+    body:
+      encoding: UTF-8
+      string: |-
+        {
+            "error": {
+                "code": "InvalidArgumentError",
+                "message": "Domain \"xpressco.za\" is not a valid domain pattern"
+            }
+        }
+    http_version: 
+  recorded_at: Mon, 28 Dec 2020 13:56:50 GMT
+recorded_with: VCR 5.0.0

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: virustotal_api
 version: !ruby/object:Gem::Version
-  version: 0.5.3
+  version: 0.5.4
 platform: ruby
 authors:
 - pwelch
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-10-12 00:00:00.000000000 Z
+date: 2021-01-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json
@@ -211,6 +211,7 @@ files:
 - test/file_test.rb
 - test/fixtures/analysis.yml
 - test/fixtures/domain.yml
+- test/fixtures/domain_bad_request.yml
 - test/fixtures/file_analyse.yml
 - test/fixtures/file_find.yml
 - test/fixtures/file_not_found.yml
@@ -263,6 +264,7 @@ test_files:
 - test/file_test.rb
 - test/fixtures/analysis.yml
 - test/fixtures/domain.yml
+- test/fixtures/domain_bad_request.yml
 - test/fixtures/file_analyse.yml
 - test/fixtures/file_find.yml
 - test/fixtures/file_not_found.yml