virus_scan_service 0.0.8 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 371745c9fa7656ebc95bff2a471861961978f3eb
-  data.tar.gz: 6149799e687ed9a11730e558606fd854936c65a4
+  metadata.gz: c7812a4d3d7f5f6d41008eadba3e0adb2910ed9f
+  data.tar.gz: 0f61de10f3e3f73a1a5bc6cacb48572351b77548
 SHA512:
-  metadata.gz: 92f8d01f68a75caefaedf6dd19cdf21107ec3b70fc5a36da5000b1db71d4728e49f73e8dab5afd506add7a84d36b0aa352df70c4002b48f863ada8962918ef30
-  data.tar.gz: ce4c379926311585102ec0053f63dc07f9e4b21818809e0f93f0bdbebebf3cd2968ec1b611b976d2ba023f30c9268f08047737b1c93eebbec2e392a6651492b4
+  metadata.gz: 0635159920ccc7b052bcd0a4629d4ef2457e70d29f056cc34cbaf20a58e22402642be52ee1a4d8b5008848ebb9fa3b60873757ad7b1858bcda2da48bfba9c581
+  data.tar.gz: b7a9cac97858a7ac03cc84929b13a753797bf4c7fcce4987d57d397018f3af738d931e1e54e1d0a1bbe430b9efa1e5c071199df521b5f87e79d163cf9baf127c

data/README.md

@@ -9,7 +9,11 @@ files to be scanned from your application server, lunch antivirus check (current
 Kasperky Endponit Security runner Windows or Linux) and send scan result
 back to server.
 
-You don't need to have this script running on the same server
+If you want to use difrent antivirus (like `ClamAV`) that's fine,
+but you will have to implement your own runner `:)`.
+Pull requests are welcome.
+
+You don't need to have script running this service on the same server
 as application server VM. (Article comming soon)
 
 Originaly built to work along [witch_doctor engine gem](https://github.com/equivalent/witch_doctor)
@@ -21,7 +25,7 @@ is provide API that this secvice can comunicate with:
 response
 
 ```json
-[{"id":"123","scan_result":"","file_url":"http://thisis.test/download/file.png"}]
+{"data":[{"id":"123","scan_result":"","file_url":"http://thisis.test/download/file.png"}]}
 ```
 
 #### PUT `/wd/virus_scans/123` `ContentType: application/json`
@@ -35,11 +39,14 @@ request body
 response
 
 ```json
-{"id":"123","scan_result":"Clean","file_url":"http://thisis.test/download/file.png"}
+{"data":{"id":"123","scan_result":"Clean","file_url":"http://thisis.test/download/file.png"}}
 ```
 
 For more examples check `spec/courier_spec.rb`, `spec/support/request_response_mocks.rb
 
+## JSON API
+
+gem is implementing [JSON API standard](http://jsonapi.org/)
 
 ## Statuses
 

data/lib/virus_scan_service/courier.rb

@@ -18,8 +18,8 @@ module VirusScanService
       scheduled_scans
         .first(num_of_scans)
         .each do |scheduled_scan|
-          resoult = yield(scheduled_scan.fetch('file_url'))
-          update_scan_result(scheduled_scan.fetch('id'), resoult)
+          result = yield(scheduled_scan.fetch('file_url'))
+          update_scan_result(scheduled_scan.fetch('id'), result)
         end
     end
 
@@ -68,7 +68,9 @@ module VirusScanService
 
     def json(body)
       logger.debug "Response body #{body}"
-      JSON.parse(body)
+      JSON
+        .parse(body)
+        .fetch("data")
     end
 
     def check_status(response)

data/lib/virus_scan_service/version.rb

@@ -1,3 +1,3 @@
 module VirusScanService
-  VERSION = "0.0.8"
+  VERSION = "0.1.0"
 end

data/spec/courier_spec.rb

@@ -11,11 +11,11 @@ RSpec.describe VirusScanService::Courier do
 
   before do
     server_response_list do
-      '[{"id":"123","scan_result":"","file_url":"http://thisis.test/download/file.png"}]'
+      '{"data":[{"id":"123","scan_result":"","file_url":"http://thisis.test/download/file.png"}]}'
     end
 
     server_request_put(id: 123, status: 'Clean') do
-      '{"id":"123","scan_result":"Clean","file_url":"http://thisis.test/download/file.png"}'
+      '{"data":{"id":"123","scan_result":"Clean","file_url":"http://thisis.test/download/file.png"}}'
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: virus_scan_service
 version: !ruby/object:Gem::Version
-  version: 0.0.8
+  version: 0.1.0
 platform: ruby
 authors:
 - Tomas Valent
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-11 00:00:00.000000000 Z
+date: 2015-04-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -166,3 +166,4 @@ test_files:
 - spec/support/dummy_viruscheck_runner.rb
 - spec/support/null_logger.rb
 - spec/support/request_response_mocks.rb
+has_rdoc: