virtus 0.5.1 → 0.5.2

data/.travis.yml

@@ -10,7 +10,6 @@ rvm:
   - rbx-18mode
   - rbx-19mode
   - ree
-  - ruby-head
   - jruby-head
 notifications:
   email:

data/Changelog.md

@@ -1,3 +1,13 @@
+# v0.5.2 2012-09-01
+
+* [feature] Object is now the default attribute type (dkubb)
+* [fixed] Fix module inclusion problems (dkubb)
+* [fixed] Evaluate default values when freezing an object (mbj)
+* [fixed] String representation of a big integer is now properly coerced to an integer (greyblake)
+* [changed] AttributeSet is now a module responsible for defining attribute methods (emmanuel)
+
+[Compare v0.5.1..v0.5.2](https://github.com/solnic/virtus/compare/v0.5.1...v0.5.2)
+
 # v0.5.1 2012-06-11
 
 * [fixed] EV properly handle nil as the value (solnic)

data/README.md

@@ -3,8 +3,7 @@ virtus
 
 [![Build Status](https://secure.travis-ci.org/solnic/virtus.png)](http://travis-ci.org/solnic/virtus)
 [![Dependency Status](https://gemnasium.com/solnic/virtus.png)](https://gemnasium.com/solnic/virtus)
-
-[Metrics on CodeClimate](https://codeclimate.com/github/solnic/virtus)
+[![Code Climate](https://codeclimate.com/badge.png)](https://codeclimate.com/github/solnic/virtus)
 
 This is a partial extraction of the DataMapper [Property
 API](http://rubydoc.info/github/datamapper/dm-core/master/DataMapper/Property)

data/config/flay.yml

@@ -1,3 +1,3 @@
 ---
 threshold: 19
-total_score: 385
+total_score: 425

data/config/site.reek

@@ -31,7 +31,8 @@ FeatureEnvy:
     Virtus::ClassMethods#build_attribute,
     Virtus::Coercion::TimeCoercions#to_string,
     Virtus::Coercion::TimeCoercions#coerce_with_method,
-    Virtus::TypeLookup#determine_type_from_primitive
+    Virtus::TypeLookup#determine_type_from_primitive,
+    Virtus::ValueObject::ClassMethods#attribute
   ]
   enabled: true
 ClassVariable:

data/lib/virtus.rb

@@ -56,7 +56,6 @@ require 'virtus/extensions'
 require 'virtus/class_inclusions'
 require 'virtus/module_extensions'
 
-require 'virtus/attributes_accessor'
 require 'virtus/class_methods'
 require 'virtus/instance_methods'
 

data/lib/virtus/attribute.rb

@@ -7,6 +7,7 @@ module Virtus
     extend DescendantsTracker
     extend TypeLookup
     extend Options
+    include Equalizer.new(inspect) << :name << :options
 
     accept_options :primitive, :accessor, :reader,
       :writer, :coercion_method, :default
@@ -50,15 +51,15 @@ module Virtus
     #   the name of an attribute
     #
     # @param [Class] type
-    #   the type class of an attribute
+    #   optional type class of an attribute
     #
     # @param [#to_hash] options
-    #   the extra options hash
+    #   optional extra options hash
     #
     # @return [Attribute]
     #
     # @api private
-    def self.build(name, type, options = {})
+    def self.build(name, type = Object, options = {})
       attribute_class = determine_type(type) or
         raise ArgumentError, "#{type.inspect} does not map to an attribute type"
       attribute_options = attribute_class.merge_options(type, options)

data/lib/virtus/attribute/boolean.rb

@@ -1,7 +1,7 @@
 module Virtus
   class Attribute
 
-    # Bolean attribute allows true or false values to be set
+    # Boolean attribute allows true or false values to be set
     # Additionally it adds boolean reader method, like "admin?"
     #
     # @example

data/lib/virtus/attribute/embedded_value.rb

@@ -44,7 +44,7 @@ module Virtus
       #
       # @return [Virtus::Attribute::EmbeddedValue]
       #
-      # @api public
+      # @api private
       def self.determine_type(klass)
         if klass <= Virtus || klass <= OpenStruct
           FromOpenStruct

data/lib/virtus/attribute_set.rb

@@ -1,7 +1,7 @@
 module Virtus
 
   # A set of Attribute objects
-  class AttributeSet
+  class AttributeSet < Module
     include Enumerable
 
     # Initialize an AttributeSet
@@ -66,6 +66,7 @@ module Virtus
     # @api public
     def <<(attribute)
       self[attribute.name] = attribute
+      attribute.define_accessor_methods(self)
       self
     end
 
@@ -110,6 +111,36 @@ module Virtus
       self
     end
 
+    # Defines an attribute reader method
+    #
+    # @param [Attribute] attribute
+    # @param [Symbol] method_name
+    # @param [Symbol] visibility
+    #
+    # @return [self]
+    #
+    # @api private
+    def define_reader_method(attribute, method_name, visibility)
+      define_method(method_name) { attribute.get(self) }
+      send(visibility, method_name)
+      self
+    end
+
+    # Defines an attribute writer method
+    #
+    # @param [Attribute] attribute
+    # @param [Symbol] method_name
+    # @param [Symbol] visibility
+    #
+    # @return [self]
+    #
+    # @api private
+    def define_writer_method(attribute, method_name, visibility)
+      define_method(method_name) { |value| attribute.set(self, value) }
+      send(visibility, method_name)
+      self
+    end
+
   private
 
     # Merge the attributes into the index

data/lib/virtus/class_inclusions.rb

@@ -13,7 +13,7 @@ module Virtus
     def self.included(descendant)
       super
       descendant.extend(ClassMethods)
-      descendant.send(:include, InstanceMethods)
+      descendant.class_eval { include InstanceMethods }
     end
     private_class_method :included
 

data/lib/virtus/class_methods.rb

@@ -15,7 +15,7 @@ module Virtus
       super
       descendant.module_eval do
         extend DescendantsTracker
-        virtus_setup_attributes_accessor_module
+        include attribute_set
       end
     end
 
@@ -31,7 +31,7 @@ module Virtus
     #     attribute :age,  Integer
     #   end
     #
-    #   User.attributes  # =>
+    #   User.attribute_set  # =>
     #
     #   TODO: implement inspect so the output is not cluttered - solnic
     #
@@ -56,16 +56,15 @@ module Virtus
       attribute_set
     end
 
-  protected
-
-    # Set up the anonymous module which will host Attribute accessor methods
+    # Hooks into const missing process to determine types of attributes
     #
-    # @return [self]
+    # @param [String] name
+    #
+    # @return [Class]
     #
     # @api private
-    def virtus_setup_attributes_accessor_module
-      @virtus_attributes_accessor_module = AttributesAccessor.new(inspect)
-      include @virtus_attributes_accessor_module
+    def const_missing(name)
+      Attribute.determine_type(name) or super
     end
 
   private
@@ -85,18 +84,7 @@ module Virtus
     # @api private
     def inherited(descendant)
       super
-      descendant.virtus_setup_attributes_accessor_module
-    end
-
-    # Hooks into const missing process to determine types of attributes
-    #
-    # @param [String] name
-    #
-    # @return [Class]
-    #
-    # @api private
-    def const_missing(name)
-      Attribute.determine_type(name) or super
+      descendant.module_eval { include attribute_set }
     end
 
     # Add the attribute to the class' and descendants' attributes
@@ -111,9 +99,13 @@ module Virtus
       descendants.each { |descendant| descendant.attribute_set.reset }
     end
 
+    # The list of allowed public methods
+    #
+    # @return [Array<String>]
+    #
     # @api private
-    def public_method_list
-      public_instance_methods
+    def allowed_methods
+      public_instance_methods.map(&:to_s)
     end
 
   end # module ClassMethods

data/lib/virtus/coercion/string.rb

@@ -133,10 +133,14 @@ module Virtus
       #
       # @api public
       def self.to_integer(value)
-        # coerce to a Float first to evaluate scientific notation (if any)
-        # that may change the integer part, then convert to an integer
-        coerced = to_float(value)
-        ::Float === coerced ? coerced.to_i : coerced
+        if value =~ /\A#{INTEGER_REGEXP}\z/
+          value.to_i
+        else
+          # coerce to a Float first to evaluate scientific notation (if any)
+          # that may change the integer part, then convert to an integer
+          coerced = to_float(value)
+          ::Float === coerced ? coerced.to_i : coerced
+        end
       end
 
       # Coerce value to float

data/lib/virtus/extensions.rb

@@ -13,10 +13,10 @@ module Virtus
     #
     # @api private
     def self.extended(object)
-      object.extend(InstanceMethods)
+      super
       object.instance_eval do
-        @virtus_attributes_accessor_module = AttributesAccessor.new(object.class.inspect)
-        extend @virtus_attributes_accessor_module
+        extend InstanceMethods
+        extend attribute_set
       end
     end
     private_class_method :extended
@@ -31,6 +31,7 @@ module Virtus
     #      attribute :author,       String
     #      attribute :published_at, DateTime
     #      attribute :page_count,   Integer
+    #      attribute :index                   # defaults to Object
     #    end
     #
     # @param [Symbol] name
@@ -49,7 +50,6 @@ module Virtus
     # @api public
     def attribute(*args)
       attribute = Attribute.build(*args)
-      attribute.define_accessor_methods(@virtus_attributes_accessor_module)
       virtus_add_attribute(attribute)
       self
     end
@@ -62,8 +62,7 @@ module Virtus
     def allowed_writer_methods
       @allowed_writer_methods ||=
         begin
-          allowed_writer_methods  = public_method_list.map(&:to_s)
-          allowed_writer_methods  = allowed_writer_methods.grep(WRITER_METHOD_REGEXP).to_set
+          allowed_writer_methods  = allowed_methods.grep(WRITER_METHOD_REGEXP).to_set
           allowed_writer_methods -= INVALID_WRITER_METHODS
           allowed_writer_methods.freeze
       end

data/lib/virtus/instance_methods.rb

@@ -132,6 +132,32 @@ module Virtus
       attributes
     end
 
+    # Freeze object
+    #
+    # @return [self]
+    #
+    # @api public
+    #
+    # @example
+    #
+    #   class User
+    #     include Virtus
+    #
+    #     attribute :name, String
+    #     attribute :age,  Integer
+    #   end
+    #
+    #   user = User.new(:name => 'John', :age => 28)
+    #   user.frozen? # => false
+    #   user.freeze
+    #   user.frozen? # => true
+    #
+    # @api public
+    def freeze
+      set_defaults
+      super
+    end
+
   private
 
     # Get values of all attributes defined for this class, ignoring privacy
@@ -146,6 +172,17 @@ module Virtus
       end
     end
 
+    # Ensure all defaults are set
+    #
+    # @return [AttributeSet]
+    #
+    # @api private
+    def set_defaults
+      attribute_set.each do |attribute|
+        get_attribute(attribute.name)
+      end
+    end
+
     # Mass-assign attribute values
     #
     # @see Virtus::InstanceMethods#attributes=
@@ -181,9 +218,13 @@ module Virtus
       __send__("#{name}=", value)
     end
 
+    # The list of allowed public methods
+    #
+    # @return [Array<String>]
+    #
     # @api private
-    def public_method_list
-      public_methods
+    def allowed_methods
+      public_methods.map(&:to_s)
     end
 
   end # module InstanceMethods

data/lib/virtus/module_extensions.rb

@@ -4,8 +4,16 @@ module Virtus
   #
   module ModuleExtensions
 
+    # Define an attribute in the module
+    #
+    # @see Virtus::Extensions#attribute
+    #
+    # @return [self]
+    #
+    # @api private
     def attribute(*args)
       attribute_definitions << args
+      self
     end
 
   private
@@ -32,7 +40,7 @@ module Virtus
     # @api private
     def included(object)
       super
-      object.send(:include, ClassInclusions)
+      object.module_eval { include Virtus }
       define_attributes(object)
     end
 
@@ -58,5 +66,5 @@ module Virtus
       end
     end
 
-  end # class ModuleExtensions
+  end # module ModuleExtensions
 end # module Virtus

data/lib/virtus/value_object.rb

@@ -35,6 +35,7 @@ module Virtus
         include ::Virtus
         include InstanceMethods
         extend ClassMethods
+        private :attributes=
       end
     end
 
@@ -93,10 +94,10 @@ module Virtus
       # @return [self]
       #
       # @api public
-      def attribute(name, type, options = {})
+      def attribute(name, *args)
         equalizer << name
-        options[:writer] = :private
-        super
+        options = args.last.kind_of?(Hash) ? args.pop : {}
+        super name, *args << options.merge(:writer => :private)
       end
 
       # Define and include a module that provides Value Object semantics

data/lib/virtus/version.rb

@@ -1,3 +1,3 @@
 module Virtus
-  VERSION = '0.5.1'
+  VERSION = '0.5.2'
 end

data/spec/integration/using_modules_spec.rb

@@ -3,14 +3,18 @@ require 'spec_helper'
 describe 'I can define attributes within a module' do
   before do
     module Examples
-      module Name
+      module Common
         include Virtus
+      end
+
+      module Name
+        include Common
 
         attribute :name, String
       end
 
       module Age
-        include Virtus
+        include Common
 
         attribute :age,  Integer
       end

data/spec/integration/virtus/value_object_spec.rb

@@ -40,7 +40,7 @@ describe Virtus::ValueObject do
     it 'writer methods are set to private' do
       private_methods = class_under_test.private_instance_methods
       private_methods.map! { |m| m.to_s }
-      private_methods.should include('latitude=', 'longitude=')
+      private_methods.should include('latitude=', 'longitude=', 'attributes=')
     end
 
     it 'attempts to call attribute writer methods raises NameError' do

data/spec/shared/freeze_method_behavior.rb

@@ -0,0 +1,37 @@
+shared_examples_for 'a #freeze method' do
+  let(:sample_exception) do
+    begin 
+      object.dup.freeze.instance_variable_set(:@foo,:bar)
+    rescue => exception
+      exception
+    end
+  end
+
+  let(:expected_exception_class) do
+    # Ruby 1.8 blows up with TypeError Ruby 1.9 with RuntimeError
+    sample_exception.class
+  end
+
+  let(:expected_exception_message) do
+    # Ruby 1.8 blows up with a different message than Ruby 1.9
+    sample_exception.message
+  end
+
+  it_should_behave_like 'an idempotent method'
+
+  it 'returns object' do
+    should be(object)
+  end
+
+  it 'prevents future modifications' do
+    subject
+    expectation = raise_error(expected_exception_class,expected_exception_message)
+    expect { object.instance_variable_set(:@foo,:bar) }.to(expectation)
+  end
+
+  its(:frozen?) { should be(true) }
+
+  it 'allows to access attribute' do
+    subject.name.should eql('John')
+  end
+end

data/spec/unit/virtus/attribute/class_methods/build_spec.rb

@@ -27,6 +27,16 @@ describe Virtus::Attribute, '.build' do
     its(:options) { should == Virtus::Attribute::String.options }
   end
 
+  context 'without a type' do
+    subject { object.build(name) }
+
+    it { should be_instance_of(Virtus::Attribute::Object) }
+
+    its(:name) { should be(name) }
+
+    its(:options) { should == Virtus::Attribute::Object.options }
+  end
+
   context 'with an invalid type' do
     subject { object.build(name, type) }
 

data/spec/unit/virtus/attribute_set/append_spec.rb

@@ -8,6 +8,8 @@ describe Virtus::AttributeSet, '#<<' do
   let(:object)     { described_class.new(parent, attributes) }
   let(:name)       { :name                                   }
 
+  before { attribute.stub(:define_accessor_methods) }
+
   context 'with a new attribute' do
     let(:attribute) { mock('Attribute', :name => name) }
 

data/spec/unit/virtus/{attributes_accessor → attribute_set}/define_reader_method_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
-describe Virtus::AttributesAccessor, '#define_reader_method' do
-  subject { described_class.new('Test') }
+describe Virtus::AttributeSet, '#define_reader_method' do
+  subject { described_class.new }
 
   let(:attribute) { mock('attribute') }
 

data/spec/unit/virtus/{attributes_accessor → attribute_set}/define_writer_method_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
-describe Virtus::AttributesAccessor, '#define_writer_method' do
-  subject { described_class.new('Test') }
+describe Virtus::AttributeSet, '#define_writer_method' do
+  subject { described_class.new }
 
   let(:attribute) { mock('attribute') }
 

data/spec/unit/virtus/{attributes_accessor → attribute_set}/inspect_spec.rb

@@ -1,9 +1,9 @@
 require 'spec_helper'
 
-describe Virtus::AttributesAccessor, '#inspect' do
+describe Virtus::AttributeSet, '#inspect' do
   subject { object.inspect }
 
   let(:object) { described_class.new('Test') }
 
-  it { should eql('Test::AttributesAccessor') }
+  it { pending; should eql('Test::AttributeSet') }
 end

data/spec/unit/virtus/attribute_set/merge_spec.rb

@@ -9,6 +9,8 @@ describe Virtus::AttributeSet, '#merge' do
   let(:name)       { :name                                   }
   let(:other)      { [ attribute ]                           }
 
+  before { attribute.stub(:define_accessor_methods) }
+
   context 'with a new attribute' do
     let(:attribute) { mock('Attribute', :name => name) }
 

data/spec/unit/virtus/attribute_set/reset_spec.rb

@@ -8,6 +8,8 @@ describe Virtus::AttributeSet, '#reset' do
   let(:attributes) { [ attribute ]                           }
   let(:object)     { described_class.new(parent, attributes) }
 
+  before { attribute.stub(:define_accessor_methods) }
+
   context 'when the parent has no attributes' do
     let(:parent) { described_class.new }
 
@@ -39,6 +41,8 @@ describe Virtus::AttributeSet, '#reset' do
     let(:parent)           { described_class.new([ parent_attribute ])       }
     let(:new_attribute)    { mock('New Attribute', :name => :parent_name)    }
 
+    before { new_attribute.stub(:define_accessor_methods) }
+
     it { should equal(object) }
 
     it 'includes changes from the parent' do

data/spec/unit/virtus/class_methods/attribute_spec.rb

@@ -13,6 +13,7 @@ describe Virtus::ClassMethods, '#attribute' do
     attributes[name].should be_nil
     subject
     attribute = attributes[name]
+    attribute.should_not be_nil
     attribute.name.should be(name)
     attribute.class.should be(attribute_class)
   end

data/spec/unit/virtus/class_methods/attributes_spec.rb

@@ -0,0 +1,22 @@
+require 'spec_helper'
+
+describe Virtus::ClassMethods, '#attributes' do
+  subject { object.attributes }
+
+  before do
+    @original_stderr, $stderr = $stderr, StringIO.new
+  end
+
+  after do
+    $stderr = @original_stderr
+  end
+
+  let(:object) { Class.new { extend Virtus::ClassMethods } }
+
+  it { should be_instance_of(Virtus::AttributeSet) }
+
+  it 'returns a deprecation warning' do
+    subject
+    $stderr.string.should =~ /\A#{object}.attributes is deprecated. Use #{object}.attribute_set instead: #{__FILE__}:4\b/
+  end
+end

data/spec/unit/virtus/class_methods/inherited_spec.rb

@@ -5,15 +5,15 @@ describe Virtus::ClassMethods, '#inherited' do
 
   let(:object) { Class.new { extend Virtus::ClassMethods } }
 
-  it 'includes an AttributesAccessor module' do
+  it 'includes an AttributeSet module' do
     descendant = subject
 
     # return the descendant's attribute accessor modules (superclass + own)
-    modules = descendant.ancestors.grep(Virtus::AttributesAccessor)
+    modules = descendant.ancestors.grep(Virtus::AttributeSet)
     modules.size.should be(2)
 
     # remove the superclass' attribute accessor module
-    modules -= object.ancestors.grep(Virtus::AttributesAccessor)
+    modules -= object.ancestors.grep(Virtus::AttributeSet)
 
     # the descendant should have it's own attribute accessor module
     modules.size.should be(1)

data/spec/unit/virtus/coercion/string/class_methods/to_integer_spec.rb

@@ -47,4 +47,10 @@ describe Virtus::Coercion::String, '.to_integer' do
 
     it { should equal(string) }
   end
+
+  context 'when integer string is big' do
+    let(:string) { '334490140000101135' }
+
+    it { should == 334490140000101135  }
+  end
 end

data/spec/unit/virtus/instance_methods/freeze_spec.rb

@@ -0,0 +1,64 @@
+require 'spec_helper'
+
+describe Virtus::InstanceMethods, '#freeze' do
+  subject { object.freeze }
+
+  let(:object) do
+    described_class.new(attributes)
+  end
+
+  context 'on class with no defaults' do
+    let(:described_class) do
+      Class.new do
+        include Virtus
+        attribute :name, String
+      end
+    end
+
+    let(:attributes) { { :name => 'John' } }
+
+    it_should_behave_like 'a #freeze method'
+  end
+
+  context 'on class with literal default' do
+    let(:described_class) do
+      Class.new do
+        include Virtus
+        attribute :name, String, :default => 'John'
+      end
+    end
+
+    context 'when value is provided' do
+      let(:attributes) { { :name => 'John' } }
+
+      it_should_behave_like 'a #freeze method'
+    end
+
+    context 'when value is NOT provided' do
+      let(:attributes) {}
+
+      it_should_behave_like 'a #freeze method'
+    end
+  end
+
+  context 'on class with computed default' do
+    let(:described_class) do
+      Class.new do
+        include Virtus
+        attribute :name, String, :default => proc { 'John' }
+      end
+    end
+
+    context 'when value is provided' do
+      let(:attributes) { { :name => 'John' } }
+
+      it_should_behave_like 'a #freeze method'
+    end
+
+    context 'when value is NOT provided' do
+      let(:attributes) {}
+
+      it_should_behave_like 'a #freeze method'
+    end
+  end
+end

data/spec/unit/virtus/module_extensions/attribute_spec.rb

@@ -0,0 +1,31 @@
+require 'spec_helper'
+
+describe Virtus::ModuleExtensions, '#attribute' do
+  subject { object.attribute(name, type, options) }
+
+  let(:object)  { Module.new              }
+  let(:name)    { :name                   }
+  let(:type)    { String                  }
+  let(:options) { { :default => default } }
+  let(:default) { 'John Doe'.freeze       }
+
+  before do
+    object.extend(Virtus::ModuleExtensions)
+  end
+
+  it { should be(object) }
+
+  it 'tracks the attribute for extension' do
+    subject
+    instance = Object.new
+    instance.extend(object)
+    instance.attributes[name].should eql(default)
+  end
+
+  it 'tracks the attribute for inclusion' do
+    subject
+    klass = Class.new
+    klass.send(:include, object)
+    klass.attribute_set[name].should eql(Virtus::Attribute::String.new(name, options))
+  end
+end

data/spec/unit/virtus/value_object/class_methods/attribute_spec.rb

@@ -1,23 +1,50 @@
 require 'spec_helper'
 
 describe Virtus::ValueObject, '.attribute' do
-  subject { object.attribute(name, type) }
-
   let(:object)    { Class.new { include Virtus::ValueObject } }
   let(:name)      { :latitude                                 }
   let(:type)      { Float                                     }
   let(:attribute) { object.attribute_set[name]                }
 
-  it { should be(object) }
+  context 'without options' do
+    subject { object.attribute(name, type) }
+
+    it { should be(object) }
 
-  it 'adds the attribute to the equalizer' do
-    object.new.inspect.should_not match(/\b#{name}=\b/)
-    subject
-    object.new.inspect.should match(/\b#{name}=\b/)
+    it 'adds the attribute to the equalizer' do
+      object.new.inspect.should_not match(/\b#{name}=\b/)
+      subject
+      object.new.inspect.should match(/\b#{name}=\b/)
+    end
+
+    it 'sets the writer to be private' do
+      subject
+      attribute.options[:writer].should be(:private)
+    end
   end
 
-  it 'sets the writer to be private' do
-    subject
-    attribute.options[:writer].should be(:private)
+  context 'with options' do
+    subject { object.attribute(name, type, options) }
+
+    let(:options) { { :default => default } }
+    let(:default) { 1.0                     }
+
+    it { should be(object) }
+
+    it 'adds the attribute to the equalizer' do
+      object.new.inspect.should_not match(/\b#{name}=\b/)
+      subject
+      object.new.inspect.should match(/\b#{name}=\b/)
+    end
+
+    it 'sets the writer to be private' do
+      subject
+      attribute.options[:writer].should be(:private)
+    end
+
+    it 'sets the default' do
+      subject
+      attribute.default.value.should eql(1.0)
+    end
   end
 end

data/spec/unit/virtus/value_object/instance_methods/clone_spec.rb

@@ -0,0 +1,21 @@
+require 'spec_helper'
+
+[ :clone, :dup ].each do |method|
+  describe Virtus::ValueObject::InstanceMethods, "##{method}" do
+    subject { object.send(method) }
+
+    let(:object) { described_class.new }
+
+    let(:described_class) do
+      Class.new do
+        include Virtus::ValueObject
+
+        attribute :name, String
+      end
+    end
+
+    it 'returns the same instance' do
+      should equal(object)
+    end
+  end
+end

data/tasks/metrics/heckle.rake

@@ -45,7 +45,10 @@ begin
     end
 
     aliases = Hash.new { |h,mod| h[mod] = Hash.new { |h,method| h[method] = method } }
-    map     = NameMap.new
+
+    aliases['Virtus::ValueObject::InstanceMethods']['dup'] = 'clone'
+
+    map = NameMap.new
 
     heckle_caught_modules = Hash.new { |hash, key| hash[key] = [] }
     unhandled_mutations = 0
@@ -111,7 +114,6 @@ begin
 
         unless spec_file.file?
           raise "No spec file #{spec_file} for #{mod}.#{method}"
-          next
         end
 
         specs << [ ".#{method}", [ spec_file ] ]
@@ -126,7 +128,6 @@ begin
 
         unless spec_file.file?
           raise "No spec file #{spec_file} for #{mod}##{method}"
-          next
         end
 
         specs << [ "##{method}", [ spec_file ] ]

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: virtus
 version: !ruby/object:Gem::Version 
-  hash: 9
+  hash: 15
   prerelease: 
   segments: 
   - 0
   - 5
-  - 1
-  version: 0.5.1
+  - 2
+  version: 0.5.2
 platform: ruby
 authors: 
 - Piotr Solnica
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-06-11 00:00:00 Z
+date: 2012-09-01 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: backports
@@ -136,7 +136,6 @@ files:
 - lib/virtus/attribute/symbol.rb
 - lib/virtus/attribute/time.rb
 - lib/virtus/attribute_set.rb
-- lib/virtus/attributes_accessor.rb
 - lib/virtus/class_inclusions.rb
 - lib/virtus/class_methods.rb
 - lib/virtus/coercion.rb
@@ -179,6 +178,7 @@ files:
 - spec/integration/virtus/value_object_spec.rb
 - spec/rcov.opts
 - spec/shared/constants_helpers.rb
+- spec/shared/freeze_method_behavior.rb
 - spec/shared/idempotent_method_behaviour.rb
 - spec/shared/options_class_method.rb
 - spec/spec_helper.rb
@@ -247,16 +247,17 @@ files:
 - spec/unit/virtus/attribute/time/coerce_spec.rb
 - spec/unit/virtus/attribute/value_coerced_spec.rb
 - spec/unit/virtus/attribute_set/append_spec.rb
+- spec/unit/virtus/attribute_set/define_reader_method_spec.rb
+- spec/unit/virtus/attribute_set/define_writer_method_spec.rb
 - spec/unit/virtus/attribute_set/each_spec.rb
 - spec/unit/virtus/attribute_set/element_reference_spec.rb
 - spec/unit/virtus/attribute_set/element_set_spec.rb
+- spec/unit/virtus/attribute_set/inspect_spec.rb
 - spec/unit/virtus/attribute_set/merge_spec.rb
 - spec/unit/virtus/attribute_set/reset_spec.rb
-- spec/unit/virtus/attributes_accessor/define_reader_method_spec.rb
-- spec/unit/virtus/attributes_accessor/define_writer_method_spec.rb
-- spec/unit/virtus/attributes_accessor/inspect_spec.rb
 - spec/unit/virtus/class_methods/attribute_set_spec.rb
 - spec/unit/virtus/class_methods/attribute_spec.rb
+- spec/unit/virtus/class_methods/attributes_spec.rb
 - spec/unit/virtus/class_methods/const_missing_spec.rb
 - spec/unit/virtus/class_methods/inherited_spec.rb
 - spec/unit/virtus/coercion/array/class_methods/to_set_spec.rb
@@ -323,8 +324,10 @@ files:
 - spec/unit/virtus/instance_methods/attributes_spec.rb
 - spec/unit/virtus/instance_methods/element_reference_spec.rb
 - spec/unit/virtus/instance_methods/element_set_spec.rb
+- spec/unit/virtus/instance_methods/freeze_spec.rb
 - spec/unit/virtus/instance_methods/initialize_spec.rb
 - spec/unit/virtus/instance_methods/to_hash_spec.rb
+- spec/unit/virtus/module_extensions/attribute_spec.rb
 - spec/unit/virtus/options/accept_options_spec.rb
 - spec/unit/virtus/options/accepted_options_spec.rb
 - spec/unit/virtus/options/options_spec.rb
@@ -335,7 +338,7 @@ files:
 - spec/unit/virtus/value_object/class_methods/attribute_spec.rb
 - spec/unit/virtus/value_object/class_methods/equalizer_spec.rb
 - spec/unit/virtus/value_object/initialize_spec.rb
-- spec/unit/virtus/value_object/instance_methods/duplicates_spec.rb
+- spec/unit/virtus/value_object/instance_methods/clone_spec.rb
 - spec/unit/virtus/value_object/instance_methods/with_spec.rb
 - tasks/metrics/ci.rake
 - tasks/metrics/flay.rake
@@ -377,7 +380,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.8.17
+rubygems_version: 1.8.15
 signing_key: 
 specification_version: 3
 summary: Attributes on Steroids for Plain Old Ruby Objects

data/lib/virtus/attributes_accessor.rb

@@ -1,68 +0,0 @@
-module Virtus
-
-  # Host attribute accessor methods
-  class AttributesAccessor < Module
-
-    # Initialize a module for hosting Attribute access methods
-    #
-    # @param [Symbol, String] name
-    #
-    # @api private
-    def initialize(name)
-      super()
-      @name = name
-    end
-
-    # Defines an attribute reader method
-    #
-    # @param [Attribute] attribute
-    # @param [Symbol] method_name
-    # @param [Symbol] visibility
-    #
-    # @return [self]
-    #
-    # @api private
-    def define_reader_method(attribute, method_name, visibility)
-      define_method(method_name) { attribute.get(self) }
-      send(visibility, method_name)
-      self
-    end
-
-    # Defines an attribute writer method
-    #
-    # @param [Attribute] attribute
-    # @param [Symbol] method_name
-    # @param [Symbol] visibility
-    #
-    # @return [self]
-    #
-    # @api private
-    def define_writer_method(attribute, method_name, visibility)
-      define_method(method_name) { |value| attribute.set(self, value) }
-      send(visibility, method_name)
-      self
-    end
-
-    # The inspect value of this Module
-    #
-    # This provides meaningful output when inspecting the ancestors
-    # of a class/module that includes this module
-    #
-    # @example
-    #
-    #   class ClassWithAttributes
-    #     include Virtus
-    #   end
-    #
-    #   mod = ClassWithAttributes.send(:virtus_setup_attributes_accessor_module)
-    #   mod.inspect
-    #
-    # @return [String]
-    #
-    # @api public
-    def inspect
-      "#{@name}::AttributesAccessor"
-    end
-
-  end
-end

data/spec/unit/virtus/value_object/instance_methods/duplicates_spec.rb

@@ -1,22 +0,0 @@
-require 'spec_helper'
-
-describe Virtus::ValueObject::InstanceMethods, 'duplication' do
-  let(:described_class) do
-    Class.new do
-      include Virtus::ValueObject
-
-      attribute :name, String
-    end
-  end
-
-  subject { described_class.new }
-
-  it '#clone returns the same instance' do
-    subject.should equal(subject.clone)
-  end
-
-  it '#dup returns the same instance' do
-    subject.should equal(subject.dup)
-  end
-
-end