virtus 0.0.10 → 0.1.0

data/spec/unit/virtus/class_methods/attribute_spec.rb

@@ -1,11 +1,29 @@
 require 'spec_helper'
 
-describe Virtus::ClassMethods, '.attribute' do
-  let(:described_class) do
-    Class.new { include Virtus }
+describe Virtus::ClassMethods, '#attribute' do
+  subject { object.attribute(name, type) }
+
+  let(:object)     { Class.new { include Virtus } }
+  let(:descendant) { Class.new(object)            }
+  let(:name)       { :name                        }
+  let(:type)       { Virtus::Attribute::String    }
+
+  def assert_attribute_added(klass, name, attribute_class)
+    attributes = klass.attributes
+    attributes[name].should be_nil
+    subject
+    attribute = attributes[name]
+    attribute.name.should be(name)
+    attribute.class.should be(attribute_class)
+  end
+
+  it { should be(object) }
+
+  it 'adds the attribute to the class' do
+    assert_attribute_added(object, name, type)
   end
 
-  it 'returns self' do
-    described_class.attribute(:name, String).should be(described_class)
+  it 'adds the attribute to the descendant' do
+    assert_attribute_added(descendant, name, type)
   end
 end

data/spec/unit/virtus/class_methods/attributes_spec.rb

@@ -1,11 +1,9 @@
 require 'spec_helper'
 
-describe Virtus::ClassMethods, '.attributes' do
-  subject { described_class.attributes }
+describe Virtus::ClassMethods, '#attributes' do
+  subject { object.attributes }
 
-  let(:described_class) do
-    Class.new { extend Virtus::ClassMethods }
-  end
+  let(:object) { Class.new { extend Virtus::ClassMethods } }
 
   it { should be_instance_of(Virtus::AttributeSet) }
 end

data/spec/unit/virtus/class_methods/const_missing_spec.rb

@@ -0,0 +1,27 @@
+require 'spec_helper'
+
+describe Virtus::ClassMethods, '#const_missing' do
+  let(:object) { Class.new { extend Virtus::ClassMethods } }
+
+  context 'with a constant name that is known' do
+    subject { object.class_eval 'String' }
+
+    it 'returns the constant' do
+      subject.should be(String)
+    end
+  end
+
+  context 'with a constant name that corresponds to a Virtus::Attribute' do
+    subject { object.class_eval 'Boolean' }
+
+    it 'determines the correct type' do
+      subject.should be(Virtus::Attribute::Boolean)
+    end
+  end
+
+  context 'with a constant name that is unknown' do
+    subject { object.class_eval 'Unknown' }
+
+    specify { expect { subject }.to raise_error(NameError) }
+  end
+end

data/spec/unit/virtus/class_methods/inherited_spec.rb

@@ -0,0 +1,21 @@
+require 'spec_helper'
+
+describe Virtus::ClassMethods, '#inherited' do
+  subject { Class.new(object) }
+
+  let(:object) { Class.new { extend Virtus::ClassMethods } }
+
+  it 'includes an AttributesAccessor module' do
+    descendant = subject
+
+    # return the descendant's attribute accessor modules (superclass + own)
+    modules = descendant.ancestors.grep(Virtus::AttributesAccessor)
+    modules.size.should be(2)
+
+    # remove the superclass' attribute accessor module
+    modules -= object.ancestors.grep(Virtus::AttributesAccessor)
+
+    # the descendant should have it's own attribute accessor module
+    modules.size.should be(1)
+  end
+end

data/spec/unit/virtus/coercion/array/to_set_spec.rb

@@ -0,0 +1,12 @@
+require 'spec_helper'
+
+describe Virtus::Coercion::Array, '.to_set' do
+  subject { object.to_set(array) }
+
+  let(:object) { described_class        }
+  let(:array)  { [ 'a', 1, 'b', 2, 'b', 1, 'a', 2 ] }
+
+  it { should be_instance_of(Set) }
+
+  it { should eql(Set[ 'a', 1, 'b', 2 ]) }
+end

data/spec/unit/virtus/coercion/date/class_methods/to_date_spec.rb

@@ -0,0 +1,10 @@
+require 'spec_helper'
+
+describe Virtus::Coercion::Date, '.to_date' do
+  subject { object.to_date(date) }
+
+  let(:object) { described_class      }
+  let(:date)   { Date.new(2012, 1, 1) }
+
+  it { should equal(date) }
+end

data/spec/unit/virtus/coercion/date_time/class_methods/to_datetime_spec.rb

@@ -0,0 +1,10 @@
+require 'spec_helper'
+
+describe Virtus::Coercion::DateTime, '.to_datetime' do
+  subject { object.to_datetime(date_time) }
+
+  let(:object)    { described_class          }
+  let(:date_time) { DateTime.new(2012, 1, 1) }
+
+  it { should equal(date_time) }
+end

data/spec/unit/virtus/coercion/hash/class_methods/to_date_spec.rb

@@ -10,8 +10,7 @@ describe Virtus::Coercion::Hash, '.to_date' do
     let(:hash)     { {}                     }
 
     before do
-      now = time_now
-      Time.stub!(:now).and_return(now)  # freeze time
+      Time.stub!(:now).and_return(time_now)  # freeze time
     end
 
     it { should be_instance_of(Date) }
@@ -21,11 +20,19 @@ describe Virtus::Coercion::Hash, '.to_date' do
     end
   end
 
-  context 'when time segments are populated' do
+  context 'when time segments are integers' do
     let(:hash) { { :year => 2011, :month => 1, :day => 1 } }
 
     it { should be_instance_of(Date) }
 
     it { should eql(Date.new(2011, 1, 1)) }
   end
+
+  context 'when time segments are strings' do
+    let(:hash) { { :year => '2011', :month => '1', :day => '1' } }
+
+    it { should be_instance_of(Date) }
+
+    it { should eql(Date.new(2011, 1, 1)) }
+  end
 end

data/spec/unit/virtus/coercion/hash/class_methods/to_datetime_spec.rb

@@ -10,8 +10,7 @@ describe Virtus::Coercion::Hash, '.to_datetime' do
     let(:hash)     { {}                     }
 
     before do
-      now = time_now
-      Time.stub!(:now).and_return(now)  # freeze time
+      Time.stub!(:now).and_return(time_now)  # freeze time
     end
 
     it { should be_instance_of(DateTime) }
@@ -21,11 +20,19 @@ describe Virtus::Coercion::Hash, '.to_datetime' do
     end
   end
 
-  context 'when time segments are populated' do
+  context 'when time segments are integers' do
     let(:hash) { { :year => 2011, :month => 1, :day => 1, :hour => 1, :min => 1, :sec => 1 } }
 
     it { should be_instance_of(DateTime) }
 
     it { should eql(DateTime.new(2011, 1, 1, 1, 1, 1)) }
   end
+
+  context 'when time segments are strings' do
+    let(:hash) { { :year => '2011', :month => '1', :day => '1', :hour => '1', :min => '1', :sec => '1' } }
+
+    it { should be_instance_of(DateTime) }
+
+    it { should eql(DateTime.new(2011, 1, 1, 1, 1, 1)) }
+  end
 end

data/spec/unit/virtus/coercion/hash/class_methods/to_time_spec.rb

@@ -10,8 +10,7 @@ describe Virtus::Coercion::Hash, '.to_time' do
     let(:hash)     { {}                     }
 
     before do
-      now = time_now
-      Time.stub!(:now).and_return(now)  # freeze time
+      Time.stub!(:now).and_return(time_now)  # freeze time
     end
 
     it { should be_instance_of(Time) }
@@ -21,11 +20,19 @@ describe Virtus::Coercion::Hash, '.to_time' do
     end
   end
 
-  context 'when time segments are populated' do
+  context 'when time segments are integers' do
     let(:hash) { { :year => 2011, :month => 1, :day => 1, :hour => 1, :min => 1, :sec => 1 } }
 
     it { should be_instance_of(Time) }
 
     it { should eql(Time.local(2011, 1, 1, 1, 1, 1)) }
   end
+
+  context 'when time segments are strings' do
+    let(:hash) { { :year => '2011', :month => '1', :day => '1', :hour => '1', :min => '1', :sec => '1' } }
+
+    it { should be_instance_of(Time) }
+
+    it { should eql(Time.local(2011, 1, 1, 1, 1, 1)) }
+  end
 end

data/spec/unit/virtus/coercion/object/class_methods/method_missing_spec.rb

@@ -1,20 +1,20 @@
 require 'spec_helper'
 
+shared_examples_for 'no method error' do
+  specify do
+    expect { subject }.to raise_error(NoMethodError)
+  end
+end
+
 describe Virtus::Coercion::Object, '.method_missing' do
   subject { described_class.send(method_name, value) }
 
   let(:value) { '1' }
 
-  shared_examples_for 'no method error' do
-    specify do
-      expect { subject }.to raise_error(NoMethodError)
-    end
-  end
-
   context 'with a non-typecast method' do
     let(:method_name) { 'not_here' }
 
-    it_behaves_like 'no method error'
+    it_should_behave_like 'no method error'
   end
 
   Virtus::Attribute::Object.descendants.each do |attribute|
@@ -27,7 +27,7 @@ describe Virtus::Coercion::Object, '.method_missing' do
     context "with #{attribute.coercion_method.inspect} and without an input value" do
       subject { described_class.send(method_name) }
 
-      it_behaves_like 'no method error'
+      it_should_behave_like 'no method error'
     end
   end
 end

data/spec/unit/virtus/coercion/string/class_methods/to_boolean_spec.rb

@@ -5,7 +5,7 @@ describe Virtus::Coercion::String, '.to_boolean' do
 
   let(:object) { described_class }
 
-  %w[ 1 t true T TRUE ].each do |value|
+  %w[ 1 on ON t true T TRUE y yes Y YES ].each do |value|
     context "with #{value.inspect}" do
       let(:string) { value }
 
@@ -13,7 +13,7 @@ describe Virtus::Coercion::String, '.to_boolean' do
     end
   end
 
-  %w[ 0 f false F FALSE ].each do |value|
+  %w[ 0 off OFF f false F FALSE n no N NO ].each do |value|
     context "with #{value.inspect}" do
       let(:string) { value }
 

data/spec/unit/virtus/coercion/string/class_methods/to_constant_spec.rb

@@ -5,7 +5,7 @@ describe Virtus::Coercion::String, '.to_constant' do
 
   let(:object) { described_class }
 
-  context "with a String" do
+  context 'with a String' do
     let(:string) { 'String' }
 
     it { should be(String) }

data/spec/unit/virtus/coercion/string/class_methods/to_date_spec.rb

@@ -6,7 +6,7 @@ describe Virtus::Coercion::String, '.to_date' do
   let(:object) { described_class }
 
   context 'with a valid date string' do
-    let(:string) { "July, 22th, 2011" }
+    let(:string) { 'July, 22th, 2011' }
 
     it { should be_instance_of(Date) }
 

data/spec/unit/virtus/coercion/string/class_methods/to_datetime_spec.rb

@@ -1,21 +1,21 @@
 require 'spec_helper'
 
+shared_examples_for 'a correct datetime object' do
+  it { should be_instance_of(DateTime) }
+
+  its(:year)  { should == year  }
+  its(:month) { should == month }
+  its(:day)   { should == day   }
+  its(:hour)  { should == hour  }
+  its(:min)   { should == min   }
+  its(:sec)   { should == sec   }
+end
+
 describe Virtus::Coercion::String, '.to_datetime' do
   subject { object.to_datetime(string) }
 
   let(:object) { described_class }
 
-  shared_examples_for 'a correct datetime object' do
-    it { should be_instance_of(DateTime) }
-
-    its(:year)  { should == year  }
-    its(:month) { should == month }
-    its(:day)   { should == day   }
-    its(:hour)  { should == hour  }
-    its(:min)   { should == min   }
-    its(:sec)   { should == sec   }
-  end
-
   context 'with a valid date string' do
     let(:year)  { 2011 }
     let(:month) { 7    }
@@ -28,7 +28,7 @@ describe Virtus::Coercion::String, '.to_datetime' do
       let(:min)  { 0 }
       let(:sec)  { 0 }
 
-      it_behaves_like 'a correct datetime object'
+      it_should_behave_like 'a correct datetime object'
     end
 
     context 'including time part' do
@@ -38,7 +38,7 @@ describe Virtus::Coercion::String, '.to_datetime' do
       let(:min)  { 44 }
       let(:sec)  { 50 }
 
-      it_behaves_like 'a correct datetime object'
+      it_should_behave_like 'a correct datetime object'
     end
   end
 

data/spec/unit/virtus/coercion/string/class_methods/to_decimal_spec.rb

@@ -5,7 +5,31 @@ describe Virtus::Coercion::String, '.to_decimal' do
 
   let(:object) { described_class }
 
-  { '1' => BigDecimal('1.0'), '1.0' => BigDecimal('1.0'), '.1' => BigDecimal('0.1') }.each do |value, expected|
+  {
+    '1'       => BigDecimal('1.0'),
+    '+1'      => BigDecimal('1.0'),
+    '-1'      => BigDecimal('-1.0'),
+    '1.0'     => BigDecimal('1.0'),
+    '1.0e+1'  => BigDecimal('10.0'),
+    '1.0e-1'  => BigDecimal('0.1'),
+    '1.0E+1'  => BigDecimal('10.0'),
+    '1.0E-1'  => BigDecimal('0.1'),
+    '+1.0'    => BigDecimal('1.0'),
+    '+1.0e+1' => BigDecimal('10.0'),
+    '+1.0e-1' => BigDecimal('0.1'),
+    '+1.0E+1' => BigDecimal('10.0'),
+    '+1.0E-1' => BigDecimal('0.1'),
+    '-1.0'    => BigDecimal('-1.0'),
+    '-1.0e+1' => BigDecimal('-10.0'),
+    '-1.0e-1' => BigDecimal('-0.1'),
+    '-1.0E+1' => BigDecimal('-10.0'),
+    '-1.0E-1' => BigDecimal('-0.1'),
+    '.1'      => BigDecimal('0.1'),
+    '.1e+1'   => BigDecimal('1.0'),
+    '.1e-1'   => BigDecimal('0.01'),
+    '.1E+1'   => BigDecimal('1.0'),
+    '.1E-1'   => BigDecimal('0.01'),
+  }.each do |value, expected|
     context "with #{value.inspect}" do
       let(:string) { value }
 

data/spec/unit/virtus/coercion/string/class_methods/to_float_spec.rb

@@ -3,7 +3,31 @@ require 'spec_helper'
 describe Virtus::Coercion::String, '.to_float' do
   subject { described_class.to_float(string) }
 
-  { '1' => 1.0, '1.0' => 1.0, '.1' => 0.1 }.each do |value, expected|
+  {
+    '1'       => 1.0,
+    '+1'      => 1.0,
+    '-1'      => -1.0,
+    '1.0'     => 1.0,
+    '1.0e+1'  => 10.0,
+    '1.0e-1'  => 0.1,
+    '1.0E+1'  => 10.0,
+    '1.0E-1'  => 0.1,
+    '+1.0'    => 1.0,
+    '+1.0e+1' => 10.0,
+    '+1.0e-1' => 0.1,
+    '+1.0E+1' => 10.0,
+    '+1.0E-1' => 0.1,
+    '-1.0'    => -1.0,
+    '-1.0e+1' => -10.0,
+    '-1.0e-1' => -0.1,
+    '-1.0E+1' => -10.0,
+    '-1.0E-1' => -0.1,
+    '.1'      => 0.1,
+    '.1e+1'   => 1.0,
+    '.1e-1'   => 0.01,
+    '.1E+1'   => 1.0,
+    '.1E-1'   => 0.01,
+  }.each do |value, expected|
     context "with #{value.inspect}" do
       let(:string) { value }
 

data/spec/unit/virtus/coercion/string/class_methods/to_integer_spec.rb

@@ -3,7 +3,36 @@ require 'spec_helper'
 describe Virtus::Coercion::String, '.to_integer' do
   subject { described_class.to_integer(string) }
 
-  { '1' => 1, '1.0' => 1, '.1' => 0 }.each do |value, expected|
+  min_float = Float::MIN
+  max_float = (Float::MAX / 10).to_s.to_f  # largest float that can be parsed
+
+  {
+    '1'            => 1,
+    '+1'           => 1,
+    '-1'           => -1,
+    '1.0'          => 1,
+    '1.0e+1'       => 10,
+    '1.0e-1'       => 0,
+    '1.0E+1'       => 10,
+    '1.0E-1'       => 0,
+    '+1.0'         => 1,
+    '+1.0e+1'      => 10,
+    '+1.0e-1'      => 0,
+    '+1.0E+1'      => 10,
+    '+1.0E-1'      => 0,
+    '-1.0'         => -1,
+    '-1.0e+1'      => -10,
+    '-1.0e-1'      => 0,
+    '-1.0E+1'      => -10,
+    '-1.0E-1'      => 0,
+    '.1'           => 0,
+    '.1e+1'        => 1,
+    '.1e-1'        => 0,
+    '.1E+1'        => 1,
+    '.1E-1'        => 0,
+    min_float.to_s => min_float.to_i,
+    max_float.to_s => max_float.to_i,
+  }.each do |value, expected|
     context "with #{value.inspect}" do
       let(:string) { value }