virtual_merchant 0.1.2 → 0.1.3

data/lib/virtual_merchant/communication.rb

@@ -0,0 +1,35 @@
+module VirtualMerchant
+  class Communication
+    require 'net/http'
+    require "rexml/document"
+  
+    attr_accessor :xml, :url, :http_referer, :uri
+  
+    def initialize(data)
+      @xml = data[:xml]
+      @url = data[:url]
+      @uri = URI.parse(@url)
+      @http_referer = data[:http_referer]
+    end
+  
+    def send
+      http = Net::HTTP.new(@uri.host, @uri.port)
+      http.use_ssl = true
+      http.verify_mode = OpenSSL::SSL::VERIFY_NONE
+      begin
+        http.post(uri.request_uri, xml, header).body
+      rescue
+        false
+      end
+    end
+  
+    private
+    def header
+      if @http_referer
+        header = { 'Referer' => @http_referer }
+      else
+        header = {}
+      end
+    end
+  end
+end

data/lib/virtual_merchant/response.rb

@@ -1,25 +1,54 @@
 module VirtualMerchant
+  require "rexml/document"
   class Response
-    attr_accessor :result_message, :result, :blurred_card_number, :exp_date, :approval_code,
-      :cvv2_response, :transaction_id, :transaction_time, :error, :approved
-  
-    def initialize(info)
-      @result_message = info[:result_message]
-      if info[:error]
-        @result_type = "error"
-        @error = info[:error]
-        @approved = false
+    attr_accessor :result_message, :result, :blurred_card_number, :exp_date, 
+      :approval_code, :cvv2_response, :transaction_id, :transaction_time, :error, 
+      :approved
+
+    def initialize(xml_string)
+      if xml_string == false
+        error_response("-1", "VirtualMerchant did not respond.")
       else
-        @approved = true
-        @result_type = "approval"
-        @result = info[:result]
-        @blurred_card_number = info[:blurred_card_number]
-        @exp_date = info[:exp_date]
-        @approval_code = info[:approval_code]
-        @cvv2_response = info[:cvv2_response]
-        @transaction_id = info[:transaction_id]
-        @transaction_time = info[:transaction_time]
+        decode_xml(xml_string)
       end
     end
+
+    private
+    def decode_xml(xml_string) 
+      doc = REXML::Document.new(xml_string)
+      REXML::XPath.each(doc, "txn") do |xml|
+        if xml.elements["errorCode"] 
+          #Something was wrong with the transaction so an 
+          #errorCode and errorMessage were sent back
+          error_response(
+            xml.elements["errorCode"].text, xml.elements["errorMessage"].text)
+        elsif (xml.elements["ssl_result"] && xml.elements["ssl_result"].text != "0")
+          #something closer to an approval, but still declined
+          error_response(
+            xml.elements["ssl_result"].text, xml.elements["ssl_result_message"].text)
+        else
+          #a clean transaction has taken place
+          approval(xml)
+        end
+      end
+    end
+
+    def error_response(code, message)
+      @approved = false
+      @result_message = message
+      @error = code
+    end
+
+    def approval(xml)
+      @approved = true
+      @result_message = xml.elements["ssl_result_message"].text
+      @result = xml.elements["ssl_result"].text
+      @blurred_card_number = xml.elements["ssl_card_number"].text
+      @exp_date = xml.elements["ssl_exp_date"].text
+      @approval_code = xml.elements["ssl_approval_code"].text
+      @cvv2_response = xml.elements["ssl_cvv2_response"].text
+      @transaction_id = xml.elements["ssl_txn_id"].text
+      @transaction_time = xml.elements["ssl_txn_time"].text
+    end
   end
 end

data/lib/virtual_merchant.rb

@@ -1,7 +1,7 @@
 module VirtualMerchant
   require "rexml/document"
-  require 'net/http'
   require 'virtual_merchant/amount'
+  require 'virtual_merchant/communication'
   require 'virtual_merchant/credentials'
   require 'virtual_merchant/credit_card'
   require 'virtual_merchant/response'
@@ -10,77 +10,34 @@ module VirtualMerchant
 
   def self.charge(card, amount, creds)
     xml = VirtualMerchant::XMLGenerator.generate(card, amount, creds, "ccsale")
-    vm_response = self.sendXMLtoVirtualMerchant(xml, creds)
-    response = self.generateResponse(vm_response)
-    VirtualMerchant::Logger.new(response)
-    response
+    self.process(xml, creds, amount)
   end
 
   def self.refund(card, amount, creds)
     xml = VirtualMerchant::XMLGenerator.generate(card, amount, creds, 'cccredit')
-    vm_response = self.sendXMLtoVirtualMerchant(xml, creds)
-    response = self.generateResponse(vm_response)
-    VirtualMerchant::Logger.new(response)
-    response
+    self.process(xml, creds, amount)
   end
 
   def self.void(transaction_id, creds)
     xml = VirtualMerchant::XMLGenerator.generateVoid(transaction_id, creds)
-    vm_response = self.sendXMLtoVirtualMerchant(xml, creds)
-    response = self.generateResponse(vm_response)
-    VirtualMerchant::Logger.new(response)
-    response
+    self.process(xml, creds)
   end
 
   private
-  def self.sendXMLtoVirtualMerchant(xml, creds)
-    if creds.referer
-      headers = {
-        'Referer' => creds.referer
-      }
-    end
-    if creds.demo
-      uri=URI.parse('https://demo.myvirtualmerchant.com/VirtualMerchantDemo/processxml.do')
-    else
-      uri=URI.parse('https://www.myvirtualmerchant.com/VirtualMerchant/processxml.do')
-    end
-
-    http = Net::HTTP.new(uri.host, uri.port)
-    http.use_ssl = true
-    http.verify_mode = OpenSSL::SSL::VERIFY_NONE
-    body = http.post(uri.request_uri, xml, headers).body
-    return body
+  def self.process(xml, creds, amount=0)
+    communication = VirtualMerchant::Communication.new(
+      {xml: xml, url: self.url(creds.demo), referer: creds.referer})
+    vm_response = communication.send
+    response = VirtualMerchant::Response.new(vm_response)
+    VirtualMerchant::Logger.new(response)
+    response
   end
 
-  def self.generateResponse(vm_response)
-    #decode XML sent back by virtualMerchant
-    response = {}
-    doc = REXML::Document.new(vm_response)
-    REXML::XPath.each(doc, "txn") do |xml|
-      if xml.elements["errorCode"] 
-        #Something was wrong with the transaction so an 
-        #errorCode and errorMessage were sent back
-        response = VirtualMerchant::Response.new(
-          error: xml.elements["errorCode"].text,
-          result_message: xml.elements["errorMessage"].text)
-      elsif (xml.elements["ssl_result"] && xml.elements["ssl_result"].text != "0")
-        #something closer to an approval, but still declined
-        response = VirtualMerchant::Response.new(
-          error: xml.elements["ssl_result_message"].text,
-          result_message: xml.elements["ssl_result"].text)
-      else
-        #a clean transaction has taken place
-        response = VirtualMerchant::Response.new(
-          result_message: xml.elements["ssl_result_message"].text,
-          result: xml.elements["ssl_result"].text,
-          blurred_card_number: xml.elements["ssl_card_number"].text,
-          exp_date: xml.elements["ssl_exp_date"].text,
-          approval_code: xml.elements["ssl_approval_code"].text,
-          cvv2_response: xml.elements["ssl_cvv2_response"].text,
-          transaction_id: xml.elements["ssl_txn_id"].text,
-          transaction_time: xml.elements["ssl_txn_time"].text)
-      end
+  def self.url(demo)
+    if demo
+      'https://demo.myvirtualmerchant.com/VirtualMerchantDemo/processxml.do'
+    else
+      'https://www.myvirtualmerchant.com/VirtualMerchant/processxml.do'
     end
-    response
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: virtual_merchant
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
   prerelease: 
 platform: ruby
 authors:
@@ -19,6 +19,7 @@ extra_rdoc_files: []
 files:
 - lib/virtual_merchant.rb
 - lib/virtual_merchant/amount.rb
+- lib/virtual_merchant/communication.rb
 - lib/virtual_merchant/credentials.rb
 - lib/virtual_merchant/credit_card.rb
 - lib/virtual_merchant/logger.rb
@@ -44,7 +45,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.24
+rubygems_version: 1.8.25
 signing_key: 
 specification_version: 3
 summary: Virtual Merchant API