virtual_merchant 0.1.1 → 0.1.2

data/lib/virtual_merchant/logger.rb

@@ -0,0 +1,14 @@
+module VirtualMerchant
+  class Logger
+    def initialize(response = {})
+      p "!!!!!!!!!!!!!!!!!!!!!!!! Credit Response !!!!!!!!!!!!!!!!!!!!!!!!!!!!"
+      if response.result
+        p "result " + response.result
+      elsif response.error
+        p "error " + response.error
+      end
+      p "result_message " + response.result_message
+      p "!!!!!!!!!!!!!!!!!!!!!!!! End Credit Response !!!!!!!!!!!!!!!!!!!!!!!!!!!!"
+    end
+  end
+end

data/lib/virtual_merchant/xml_generator.rb

@@ -0,0 +1,44 @@
+module VirtualMerchant
+  class XMLGenerator
+    def self.generateVoid(transaction_id, creds)
+      xml = "xmldata=<txn>
+        <ssl_merchant_id>#{creds.account_id}</ssl_merchant_id>
+        <ssl_user_id>#{creds.user_id}</ssl_user_id>
+        <ssl_pin>#{creds.pin}</ssl_pin>
+        <ssl_transaction_type>ccvoid</ssl_transaction_type>
+        <ssl_txn_id>#{transaction_id}</ssl_txn_id>
+        </txn>"
+      return xml
+    end
+  
+    def self.generate(card, amount, creds, transaction_type)
+      xml = "xmldata=<txn>
+        <ssl_merchant_id>" + creds.account_id + "</ssl_merchant_id>
+        <ssl_user_id>" + creds.user_id + "</ssl_user_id>
+        <ssl_pin>" + creds.pin + "</ssl_pin>
+        <ssl_transaction_type>" + transaction_type + "</ssl_transaction_type>
+        <ssl_amount>" + amount.total + "</ssl_amount>
+        <ssl_salestax>" + amount.tax + "</ssl_salestax>
+        <ssl_customer_code>" + card.last_four + "</ssl_customer_code>
+        <ssl_card_present>Y</ssl_card_present>
+        <ssl_partial_auth_indicator>0</ssl_partial_auth_indicator>"
+      if card.track2
+        xml += "<ssl_track_data>" + card.track2 + " </ssl_track_data>"
+      else
+        #Manual Entry
+        xml += "<ssl_card_number>" + card.number.to_s + "</ssl_card_number>
+          <ssl_exp_date>" + card.expiration + "</ssl_exp_date>"
+      end
+  
+      if !card.security_code || card.security_code == ""
+        xml += "<ssl_cvv2cvc2_indicator>0</ssl_cvv2cvc2_indicator>"
+      else
+        xml += "<ssl_cvv2cvc2_indicator>1</ssl_cvv2cvc2_indicator>
+            <ssl_cvv2cvc2>" + card.security_code + "</ssl_cvv2cvc2>"
+      end
+  
+      xml += "</txn>"
+      return xml
+    end
+  end
+end

data/lib/virtual_merchant.rb

@@ -5,72 +5,34 @@ module VirtualMerchant
   require 'virtual_merchant/credentials'
   require 'virtual_merchant/credit_card'
   require 'virtual_merchant/response'
+  require 'virtual_merchant/logger'
+  require 'virtual_merchant/xml_generator'
 
   def self.charge(card, amount, creds)
-    xml = self.generateXMLforVirtualMerchant(card, amount, creds, "ccsale")
+    xml = VirtualMerchant::XMLGenerator.generate(card, amount, creds, "ccsale")
     vm_response = self.sendXMLtoVirtualMerchant(xml, creds)
     response = self.generateResponse(vm_response)
-    self.printResponse(response)
+    VirtualMerchant::Logger.new(response)
     response
   end
 
   def self.refund(card, amount, creds)
-    xml = self.generateXMLforVirtualMerchant(card, amount, creds, 'cccredit')
+    xml = VirtualMerchant::XMLGenerator.generate(card, amount, creds, 'cccredit')
     vm_response = self.sendXMLtoVirtualMerchant(xml, creds)
     response = self.generateResponse(vm_response)
-    self.printResponse(response)
+    VirtualMerchant::Logger.new(response)
     response
   end
 
   def self.void(transaction_id, creds)
-    xml = self.generateVoidXML(transaction_id, creds)
+    xml = VirtualMerchant::XMLGenerator.generateVoid(transaction_id, creds)
     vm_response = self.sendXMLtoVirtualMerchant(xml, creds)
     response = self.generateResponse(vm_response)
-    self.printResponse(response)
+    VirtualMerchant::Logger.new(response)
     response
   end
 
-  def self.generateVoidXML(transaction_id, creds)
-    xml = "xmldata=<txn>
-      <ssl_merchant_id>#{creds.account_id}</ssl_merchant_id>
-      <ssl_user_id>#{creds.user_id}</ssl_user_id>
-      <ssl_pin>#{creds.pin}</ssl_pin>
-      <ssl_transaction_type>ccvoid</ssl_transaction_type>
-      <ssl_txn_id>#{transaction_id}</ssl_txn_id>
-      </txn>"
-    return xml
-  end
-
-  def self.generateXMLforVirtualMerchant(card, amount, creds, transaction_type)
-    xml = "xmldata=<txn>
-      <ssl_merchant_id>" + creds.account_id + "</ssl_merchant_id>
-      <ssl_user_id>" + creds.user_id + "</ssl_user_id>
-      <ssl_pin>" + creds.pin + "</ssl_pin>
-      <ssl_transaction_type>" + transaction_type + "</ssl_transaction_type>
-      <ssl_amount>" + amount.total + "</ssl_amount>
-      <ssl_salestax>" + amount.tax + "</ssl_salestax>
-      <ssl_customer_code>" + card.last_four + "</ssl_customer_code>
-      <ssl_card_present>Y</ssl_card_present>
-      <ssl_partial_auth_indicator>0</ssl_partial_auth_indicator>"
-    if card.track2
-      xml += "<ssl_track_data>" + card.track2 + " </ssl_track_data>"
-    else
-      #Manual Entry
-      xml += "<ssl_card_number>" + card.number.to_s + "</ssl_card_number>
-        <ssl_exp_date>" + card.expiration + "</ssl_exp_date>"
-    end
-
-    if !card.security_code || card.security_code == ""
-      xml += "<ssl_cvv2cvc2_indicator>0</ssl_cvv2cvc2_indicator>"
-    else
-      xml += "<ssl_cvv2cvc2_indicator>1</ssl_cvv2cvc2_indicator>
-          <ssl_cvv2cvc2>" + card.security_code + "</ssl_cvv2cvc2>"
-    end
-
-    xml += "</txn>"
-    return xml
-  end
-
+  private
   def self.sendXMLtoVirtualMerchant(xml, creds)
     if creds.referer
       headers = {
@@ -95,11 +57,17 @@ module VirtualMerchant
     response = {}
     doc = REXML::Document.new(vm_response)
     REXML::XPath.each(doc, "txn") do |xml|
-      if xml.elements["errorCode"]
-        #Something was wrong with the transaction so an errorCode and errorMessage were sent back
+      if xml.elements["errorCode"] 
+        #Something was wrong with the transaction so an 
+        #errorCode and errorMessage were sent back
         response = VirtualMerchant::Response.new(
           error: xml.elements["errorCode"].text,
           result_message: xml.elements["errorMessage"].text)
+      elsif (xml.elements["ssl_result"] && xml.elements["ssl_result"].text != "0")
+        #something closer to an approval, but still declined
+        response = VirtualMerchant::Response.new(
+          error: xml.elements["ssl_result_message"].text,
+          result_message: xml.elements["ssl_result"].text)
       else
         #a clean transaction has taken place
         response = VirtualMerchant::Response.new(
@@ -115,15 +83,4 @@ module VirtualMerchant
     end
     response
   end
-
-  def self.printResponse(response)
-    p "!!!!!!!!!!!!!!!!!!!!!!!! Credit Response !!!!!!!!!!!!!!!!!!!!!!!!!!!!"
-    if response.result
-      p "result " + response.result
-    elsif response.error
-      p "error " + response.error
-    end
-    p "result_message " + response.result_message
-    p "!!!!!!!!!!!!!!!!!!!!!!!! End Credit Response !!!!!!!!!!!!!!!!!!!!!!!!!!!!"
-  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: virtual_merchant
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
   prerelease: 
 platform: ruby
 authors:
@@ -21,7 +21,9 @@ files:
 - lib/virtual_merchant/amount.rb
 - lib/virtual_merchant/credentials.rb
 - lib/virtual_merchant/credit_card.rb
+- lib/virtual_merchant/logger.rb
 - lib/virtual_merchant/response.rb
+- lib/virtual_merchant/xml_generator.rb
 homepage: https://github.com/leequarella/VirtualMerchant-Ruby
 licenses: []
 post_install_message: