vinyldns-ruby 0.8.0 → 0.8.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4ef5dde452df46bed5a65f615d7ab5f4b2660976dbc15bbc5097169620752caa
-  data.tar.gz: 60ee81b14146092efb081c6a413a7ba966dad7fbddf97d444346c624540ae36d
+  metadata.gz: 4fea355780ee7ab55c1337a3e4535594277c8aa110a33f8c8a987a387e565e6f
+  data.tar.gz: b4dae93a5333284838208a6af657223861ebce58954f4b6765cc418b927778f3
 SHA512:
-  metadata.gz: 8d238071ef2c492033c770de76c50ae4935b1611f73f1862b2130aa5286d2218fcc0ebfe079e998efcb7001003b3ccdd70fb145d1808b3610219baa3da018db3
-  data.tar.gz: 51e9a3621e7997544c905067cfd84741c5708348570f42f874e63bfa7978caf948284a12cd674ffaa40028884a199a7d1bca98a5542b8069626a8943e14753fa
+  metadata.gz: f0d2c26747c776ff20307cbb7079dc058a694deec582ee29b52df330fc82e72de100b7f9c876f3fc40a8544afadc0188d2bafcacd72c7fd3216383f8b322cdec
+  data.tar.gz: 64c1b77c83ce367e64da7f66fb6feb62c94d588ffd0e40b0484a42481473145559d40ec75a5fda20caf06d05f416cb292e08d190cc8a292108c2ec7fedbd85fc

data/.gitignore

@@ -1,4 +1,6 @@
 Gemfile.lock
 .idea
 pkg
-.DS_Store
+.DS_Store
+*.gem
+api

data/.travis.yml

@@ -0,0 +1,9 @@
+sudo: false
+language: ruby
+
+services:
+  - docker
+
+script:
+  - make test
+

data/CONTRIBUTING.md

@@ -64,6 +64,12 @@ Include details about your configuration and environment:
 * Fill in [the required template](PULL_REQUEST_TEMPLATE.md)
 * Do not include issue numbers in the PR title
 
+### Contributor License Agreement
+
+Before Comcast merges your code into the project you must sign the [Comcast Contributor License Agreement (CLA)](https://gist.github.com/ComcastOSS/a7b8933dd8e368535378cda25c92d19a).
+
+If you haven't previously signed a Comcast CLA, you'll automatically be asked to when you open a pull request. Alternatively, we can send you a PDF that you can sign and scan back to us. Please create a new GitHub issue to request a PDF version of the CLA.
+
 ## Styleguides
 
 ### Git Commit Messages

data/Makefile

@@ -1,5 +1,8 @@
-init:
-	pip install -r requirements.txt
+start-api:
+	./scripts/start_api
 
-test:
-	nosetests tests
+stop-api:
+	./scripts/stop_api
+
+test: start-api
+	./scripts/run_tests

data/NOTICE

@@ -0,0 +1,17 @@
+vinyldns-ruby
+
+Copyright 2018 Comcast Cable Communications Management, LLC
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+
+This product includes software developed at Comcast (http://www.comcast.com/).

data/README.md

@@ -2,7 +2,7 @@
 
 Ruby gem for working with VinylDNS.
 
-* It was built around the API documentation
+* It was built around [the API](https://www.vinyldns.io/api/)
 * It relies, currently, on the AWS-SDK to sign the HTTP requests it makes
 
 # Requirements
@@ -11,7 +11,7 @@ Ruby gem for working with VinylDNS.
 2. ```ENV['VINYLDNS_ACCESS_KEY_ID']``` & ```ENV['VINYLDNS_SECRET_ACCESS_KEY']``` are set in your application or local shell
     * You can find both of these within the portal by downloading your credentials file
 3. ```ENV['VINYLDNS_API_URL']``` is set with your api url (if applicable include http[s]:// and port)
-    
+
 # Installation
 
 Add this line to your application's Gemfile:
@@ -34,7 +34,8 @@ This project adheres to the Contributor Covenant [code of conduct](CODE_OF_CONDU
 
 * Each method returns a JSON object
 * The methods request an 'api_request_object' with the HTTP Method specified like: ```Vinyldns::API.new('get')```, then perform a variation of ```Vinyldns::API.make_request(api_request_object, "zones/#{zone_id}")```
-* Method parameters match the HTTP Request Parameter requirements in the API. See the API Reference for more information.
+* Method parameters match the HTTP Request Parameter requirements in the API. See the [API Reference](https://www.vinyldns.io/api/) for more information.
+* SSL verification is enabled by default; `ENV['VINYLDNS_VERIFY_SSL']` can be set to false in order to disable.
 
 ## Contributing
 
@@ -156,3 +157,6 @@ If you decide to contribute, please read over our [contributor documentation](CO
     - list_group_members(id, max_items = 5, start_from = nil)
 
     - get_group_activity(id, max_items = 5, start_from = nil)
+
+# Maintainers
+* [Nathan Pierce](https://github.com/NorseGaud)

data/Rakefile

@@ -21,3 +21,12 @@ end
 require 'rake'
 
 require 'bundler/gem_tasks'
+
+begin
+  require 'rspec/core/rake_task'
+
+  RSpec::Core::RakeTask.new(:spec)
+
+  task default: :spec
+rescue LoadError
+end

data/lib/vinyldns/api.rb

@@ -52,8 +52,12 @@ module Vinyldns
       )
       url = URI(signed_object.api_url)
       https = Net::HTTP.new(url.host, url.port)
-      https.use_ssl = true
-      https.verify_mode = OpenSSL::SSL::VERIFY_NONE # SSL not signed? Don't care!
+      https.use_ssl = true ? url.scheme == "https" : https.use_ssl = false
+      if ENV['VINYLDNS_VERIFY_SSL'] == false || ENV['VINYLDNS_VERIFY_SSL'] =~ /^false$/i
+        https.verify_mode = OpenSSL::SSL::VERIFY_NONE
+      else
+        https.verify_mode = OpenSSL::SSL::VERIFY_PEER
+      end
       request = Net::HTTP::Post.new(uri == '/' ? uri : "/#{uri}") if signed_object.method == 'POST'
       request = Net::HTTP::Put.new(uri == '/' ? uri : "/#{uri}") if signed_object.method == 'PUT'
       request = Net::HTTP::Get.new(uri == '/' ? uri : "/#{uri}") if signed_object.method == 'GET'
@@ -66,7 +70,7 @@ module Vinyldns
         JSON.parse(response.body)
       else
         return response
-        #"HTTP Error: #{response.code} #{response.message} : #{response.body}"
+        # "HTTP Error: #{response.code} #{response.message} : #{response.body}"
       end
     end
   end

data/lib/vinyldns/version.rb

@@ -8,5 +8,5 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 module Vinyldns
-  VERSION = '0.8.0'.freeze
+  VERSION = '0.8.1'.freeze
 end

data/scripts/run_tests

@@ -0,0 +1,6 @@
+#!/usr/bin/env bash
+
+VINYLDNS_ACCESS_KEY_ID=okAccessKey \
+VINYLDNS_SECRET_ACCESS_KEY=okSecretKey \
+VINYLDNS_API_URL=http://localhost:9000 \
+bundle exec rspec

data/scripts/start_api

@@ -0,0 +1,5 @@
+#!/usr/bin/env bash
+
+mkdir -p ./api
+git clone https://github.com/vinyldns/vinyldns ./api/
+./api/bin/docker-up-vinyldns.sh

data/scripts/stop_api

@@ -0,0 +1,4 @@
+#!/usr/bin/env bash
+
+./api/bin/remove-vinyl-containers.sh
+rm -rf ./api

data/vinyldns.gemspec

@@ -42,5 +42,5 @@ Gem::Specification.new do |gem|
   # Dependencies
   # Licensed uses the the libgit2 bindings for Ruby provided by rugged. rugged has its own dependencies - cmake and pkg-config - which you may need to install before you can install Licensed.
   # For example, on macOS with Homebrew: brew install cmake pkg-config and on Ubuntu: apt-get install cmake pkg-config.
-  gem.add_development_dependency 'licensed', '1.0.0'
+  gem.add_development_dependency 'licensed', '1.5.2'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: vinyldns-ruby
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.8.1
 platform: ruby
 authors:
 - Nathan Pierce
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-07-26 00:00:00.000000000 Z
+date: 2019-01-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: aws-sigv4
@@ -72,14 +72,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: 1.5.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: 1.5.2
 description: Ruby gem containing methods to perform various API requests in VinylDNS
 email: nathan_pierce@comcast.com
 executables: []
@@ -92,12 +92,14 @@ files:
 - ".licenses/rubygem/vinyldns-ruby.txt"
 - ".rspec"
 - ".rubocop.yml"
+- ".travis.yml"
 - CODE_OF_CONDUCT.md
 - CONTRIBUTING.md
 - Gemfile
 - ISSUE_TEMPLATE.md
 - LICENSE
 - Makefile
+- NOTICE
 - PULL_REQUEST_TEMPLATE.md
 - README.md
 - Rakefile
@@ -106,6 +108,9 @@ files:
 - lib/vinyldns/api/group/group.rb
 - lib/vinyldns/api/zone/zone.rb
 - lib/vinyldns/version.rb
+- scripts/run_tests
+- scripts/start_api
+- scripts/stop_api
 - vinyldns.gemspec
 homepage: https://github.com/vinyldns/vinyldns-ruby
 licenses:
@@ -126,8 +131,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.4
+rubygems_version: 3.0.1
 signing_key: 
 specification_version: 4
 summary: Ruby gem for VinylDNS