vinted-ab 0.2.3 → 0.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 68b075c639ff1ef723c81b9f60ff1ac8f517f1dd
-  data.tar.gz: df20ae610c9aa79b8204930fb3079f9edeb80132
+  metadata.gz: f6e46f66084e779a1eeca15edf6b3eba928b747b
+  data.tar.gz: 5e47066cb8520292d863b97be976f42c7d93e0fa
 SHA512:
-  metadata.gz: 4f1dd1e36834fe06efc1318c4847a4b6121cb4093534a193a6ca321a4f5762696699e89a7d675b71423b2d7323302eb68889def55a0aca4833cb662a0ea502aa
-  data.tar.gz: c6c2691cdd4fa3ba241e461930491324f31331fd675ba15edc9199ddefcb87fb7d456ae22e34e18ef1d18faf33437e202fa7ff9b17ba8568ac30279645f0f422
+  metadata.gz: ed4970561d2c2ec748f29ea3d5c378d8b181a1dea026a12d6d7eea4fcaa0d930c5c55283bead185d8d81bb9f35e5a13675d56e4f455397ec58456e431c46310b
+  data.tar.gz: b56781fed1989fe0f536afafbb7dcce815feb0a7bc99c2056bef91a5b15e4af1c5c5000eb6c02ec19277207da6a6493cc42fbf93994fcb48c791362ef106dd39

data/README.md

@@ -54,8 +54,8 @@ An example config:
         {
             "id": 42,
             "name": "experiment",
-            "start_at": "2014-05-21T11:06:30+03:00",
-            "end_at": "2014-05-28T11:06:30+03:00",
+            "start_at": "2014-05-21T11:06:30+0300",
+            "end_at": "2014-05-28T11:06:30+0300",
             "seed": "aaaa1111",
             "buckets": [1, 2, 3, 4, 5],
             "variants": [

data/ab.gemspec

@@ -22,6 +22,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'bundler', '~> 1.3'
   spec.add_development_dependency 'rake', '~> 10.1', '>= 10.1.0'
   spec.add_development_dependency 'rspec', '~> 2.14', '>= 2.14.0'
+  spec.add_development_dependency 'rspec-its', '~> 1.0.1'
   spec.add_development_dependency 'json-schema', '~> 2.2.2', '>= 2.2.2'
   spec.add_development_dependency 'ruby-prof', '~> 0.15.0', '>= 0.15.0'
   spec.add_development_dependency 'pry', '~> 0.10.0', '>= 0.10.0'

data/lib/ab/assigned_test.rb

@@ -2,7 +2,7 @@ module Ab
   class AssignedTest
     def initialize(test, id)
       @test, @id = test, id
-      @test.variants.map(&:name).each do |name|
+      variants.each do |name|
         define_singleton_method("#{name}?") { name == variant }
       end
     end
@@ -40,6 +40,10 @@ module Ab
       @test.end_at
     end
 
+    def variants
+      @test.variants.map(&:name)
+    end
+
     private
 
     def part_of_test?

data/lib/ab/tests.rb

@@ -27,7 +27,6 @@ module Ab
     end
 
     def all
-      # TODO: temporary feature to support old Vinted ab testing system
       Hash[@assigned_tests.map { |name, assigned_test| [name, assigned_test.variant(false)] }]
     end
 

data/lib/ab/version.rb

@@ -1,3 +1,3 @@
 module Ab
-  VERSION = '0.2.3'
+  VERSION = '0.2.4'
 end

data/spec/examples/already_finished/input.json

@@ -6,8 +6,8 @@
             "id": 2,
             "name": "already_finished",
             "seed": "792e3b32a6dd59d3f300b2ac8b4caa09",
-            "start_at": "1605-11-05T00:00:00+01:00",
-            "end_at": "2014-02-01T02:15:00+03:00",
+            "start_at": "1605-11-05T00:00:00+0100",
+            "end_at": "2014-02-01T02:15:00+0300",
             "all_buckets": true,
             "variants": [
                 {

data/spec/examples/explicit_times/input.json

@@ -6,8 +6,8 @@
             "id": 5,
             "name": "explicit_times",
             "seed": "2a14d8c5a30618799547e428dfa4a807",
-            "start_at": "2013-01-01T00:00:00+00:00",
-            "end_at": "2222-02-02T02:02:02+02:00",
+            "start_at": "2013-01-01T00:00:00+0000",
+            "end_at": "2222-02-02T02:02:02+0200",
             "all_buckets": true,
             "variants": [
                 {

data/spec/examples/has_not_started/input.json

@@ -6,7 +6,7 @@
             "id": 2,
             "name": "has_not_started",
             "seed": "2",
-            "start_at": "2444-01-01T00:00:00+00:00",
+            "start_at": "2444-01-01T00:00:00+0000",
             "all_buckets": true,
             "variants": [
                 {

data/spec/integration_spec.rb

@@ -11,7 +11,7 @@ describe 'ab' do
 
       specify 'validates against schema' do
         result = JSON::Validator.validate(path_to_schema, input, version: :draft3)
-        result.should be_true
+        result.should be true
       end
 
       specify 'correctly assigns variants' do
@@ -21,7 +21,7 @@ describe 'ab' do
         cases.each do |id, variant|
           tests = Ab::Tests.new(input, id)
           tests.send(output['test']).variant.to_s.should == variant
-          tests.send(output['test']).send("#{variant}?").should be_true unless variant.empty?
+          tests.send(output['test']).send("#{variant}?").should be true unless variant.empty?
         end
       end
     end

data/spec/spec_helper.rb

@@ -1,7 +1,8 @@
 require 'rspec'
+require 'rspec/its'
 require 'ab'
 
 RSpec.configure do |config|
-  config.color_enabled = true
+  config.color = true
   config.treat_symbols_as_metadata_keys_with_true_values = true
 end

data/spec/tests_spec.rb

@@ -26,7 +26,7 @@ module Ab
       1.upto(10).each do |i|
         context "random method name of #{i} length" do
           let(:method_name) { SecureRandom.hex(i) }
-          it { should be_true }
+          it { should be true }
         end
       end
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: vinted-ab
 version: !ruby/object:Gem::Version
-  version: 0.2.3
+  version: 0.2.4
 platform: ruby
 authors:
 - Mindaugas Mozūras
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-07 00:00:00.000000000 Z
+date: 2014-09-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -65,6 +65,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 2.14.0
+- !ruby/object:Gem::Dependency
+  name: rspec-its
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.0.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.0.1
 - !ruby/object:Gem::Dependency
   name: json-schema
   requirement: !ruby/object:Gem::Requirement