vindetta 0.17.1 → 0.19.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: dc052c66bde259587a11d28f3b5639872d5e1dc1
-  data.tar.gz: 52340e3f20255fe4aee6533b6f30038ef970b6b9
+  metadata.gz: ef0a0382f394eb885e1ef31017cb92a1176ff84d
+  data.tar.gz: abdb80414aab149e380217fae57357c89a99579c
 SHA512:
-  metadata.gz: 14306fe4f6bfd2dade7f8e922953336d3fe809908d02fdeb52207b3f476122653197d549d3899d7d63282a083fdbf87a234435ddb2aaaf0b232d0515b6eaf228
-  data.tar.gz: 9bb861898cb7ba53e2642712c07cc466ce14e91271f99797b6b3665de0fd840adea5b947faaf9d47586a7db5b40cd5925cb4b4976052e78f2deb88b17044e110
+  metadata.gz: 67d06d280c0d2f201b124a1923911154f48e8441487340a7e0a47a8553a4713823b4bdd5a7f3f091b555d8e7cc1766a0ad8ec206fefd0dc9c4b3f1b5f78f943b
+  data.tar.gz: 96dae041eadc8982a620a1766d7b5d370b4f289167c4ef8cd9f47da29465edc3be525d3241faf38284d58ad49ad61a9103ee7f1b6032f53621dc8e26af083373

data/lib/vindetta/api.rb

@@ -3,12 +3,7 @@ require "json"
 
 module Vindetta
   class Api
-    def self.generate
-      Net::HTTP.get("randomvin.com", "/getvin.php")
-
-    end
-
-    def self.get(vin)
+    def self.decode(vin)
       uri = URI("https://vpic.nhtsa.dot.gov/api/vehicles/decodevin/#{vin}?format=json")
 
       http = Net::HTTP.new(uri.host, uri.port)

data/lib/vindetta/calculator.rb

@@ -1,15 +1,19 @@
 module Vindetta
   class Calculator
-    MAP = %w(0 1 2 3 4 5 6 7 8 9 X)
+    CHECK_DIGITS = "0123456789X".chars
     WEIGHTS = [8, 7, 6, 5, 4, 3, 2, 10, 0, 9, 8, 7, 6, 5, 4, 3, 2]
 
     def self.check_digit(vin)
-      sum = Transliterator
+      CHECK_DIGITS[sum(vin) % CHECK_DIGITS.length]
+    end
+
+    private
+
+    def self.sum(vin)
+      Transliterator
         .vin(vin)
         .zip(WEIGHTS)
-        .reduce(0) {|sum, (a, b)| sum + (a * b) }
-
-      MAP[sum % 11]
+        .reduce(0) { |sum, (a, b)| sum + (a * b) }
     end
   end
 end

data/lib/vindetta/cli.rb

@@ -11,16 +11,6 @@ module Vindetta
 
     program_desc "Vehicle Identification Number (VIN) CLI"
     version Vindetta::VERSION
-    error_device = error_device
-
-    desc "Transliterates a VIN character"
-    arg_name "character"
-
-    command %i[transliterate t] do |c|
-      c.action do |_global, _options, args|
-        puts Vindetta::Transliterator.run(args.first)
-      end
-    end
 
     desc "Validates a VIN"
 
@@ -50,7 +40,7 @@ module Vindetta
 
     command %i[generate g] do |c|
       c.action do |_global, _options, _args|
-        puts Vindetta::Generator.generate
+        puts Vindetta::Generator.vin
       end
     end
   end

data/lib/vindetta/decoder.rb

@@ -7,7 +7,7 @@ module Vindetta
     CHECK_DIGIT_INDEX = 8
 
     def self.vin(vin)
-      Result.new(Api.get(vin)["Results"])
+      Result.new(Api.decode(vin)["Results"])
     end
 
     def self.plant_code(vin)
@@ -23,7 +23,7 @@ module Vindetta
     end
 
     def self.vds(vin, options = {})
-      defaults = { :check_digit => true }
+      defaults = { check_digit: true }
       options = defaults.merge(options)
 
       vin[3..CHECK_DIGIT_INDEX].tap do |vds|

data/lib/vindetta/generator.rb

@@ -1,29 +1,33 @@
 module Vindetta
   class Generator
-    def self.vin(options = {})
-      generate(options)
-    end
+    WMI_CHARACTERS = "0123456789ABCDEFGHJKLMNPRSTUVWXYZ".chars
+    VDS_CHARACTERS = "0123456789ABCDEFGHJKLMNPRSTUVWXYZ".chars
+    VIS_CHARACTERS = "0123456789ABCDEFGHJKLMNPRSTUVWXYZ".chars
 
-    def self.generate(_options = {})
-      fetch
+    def self.vin(options = {})
+      "#{wmi}#{vds}#{vis}".tap do |vin|
+        vin[8] = Calculator.check_digit(vin)
+      end
     end
 
     def self.wmi(_options = {})
-      fetch[0..2]
+      WMI_CHARACTERS.sample(3).join("")
     end
 
     def self.vds(_options = {})
-      fetch[3..8]
+      VDS_CHARACTERS.sample(6).join("")
     end
 
+    ##
+    # One consistent element of the VIS is the 10th digit,
+    # which is required worldwide to encode the model year of
+    # the vehicle. Besides the three letters that are not
+    # allowed in the VIN itself (I, O and Q), the letters U
+    # and Z and the digit 0 are not used for the model year
+    # code. The year code is the model year for the vehicle.
+    #
     def self.vis(_options = {})
-      fetch[9..16]
-    end
-
-    private
-
-    def self.fetch(_options = {})
-      Api.generate
+      VIS_CHARACTERS.sample(8).join("")
     end
   end
 end

data/lib/vindetta/transliterator.rb

@@ -1,15 +1,17 @@
 module Vindetta
   class Transliterator
-    MAPPING = "0123456789.ABCDEFGH..JKLMN.P.R..STUVWXYZ".split("").freeze
+    MAPPING = "0123456789.ABCDEFGH..JKLMN.P.R..STUVWXYZ".chars
 
     def self.vin(vin)
-      vin.chars.map { |c| run(c) }
+      vin.chars.map do |c|
+        index = MAPPING.find_index(c)
+        raise Vindetta::InvalidCharacter, c unless index
+        index % 10
+      end
     end
 
     def self.run(character)
-      index = MAPPING.find_index(character)
-      raise Vindetta::InvalidCharacter, character unless index
-      index % 10
+      vin(character.to_s)[0]
     end
   end
 end

data/lib/vindetta/validator.rb

@@ -1,15 +1,25 @@
 module Vindetta
   class Validator
     def self.vin(vin)
-      length(vin) && check_digit(vin)
+      return false unless vin.length == Vindetta::VIN_LENGTH
+
+      Calculator.check_digit(vin) == Decoder.check_digit(vin)
     end
 
-    def self.length(vin)
-      vin.length == 17
+    def self.wmi(wmi)
+      return false unless wmi.length == Vindetta::WMI_LENGTH
     end
 
-    def self.check_digit(vin)
-      Calculator.check_digit(vin) == Decoder.check_digit(vin)
+    def self.vds(vds)
+      return false unless vds.length == Vindetta::VDS_LENGTH
+
+      true
+    end
+
+    def self.vis(vis)
+      return false unless vis.length == Vindetta::VIS_LENGTH
+
+      true
     end
   end
 end

data/lib/vindetta/version.rb

@@ -1,3 +1,3 @@
 module Vindetta
-  VERSION = "0.17.1".freeze
+  VERSION = "0.19.0".freeze
 end

data/lib/vindetta.rb

@@ -9,7 +9,8 @@ require "vindetta/calculator"
 require "vindetta/version"
 
 module Vindetta
-  def self.generate(options = {})
-    Generator.generate(options)
-  end
+  VIN_LENGTH = 17
+  WMI_LENGTH = 3
+  VDS_LENGTH = 6
+  VIS_LENGTH = 8
 end

data/vindetta.gemspec

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 lib = File.expand_path("../lib", __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require "vindetta/version"
@@ -28,11 +26,10 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "bundler", "~> 1.14"
   spec.add_development_dependency "factory_bot", "~> 4.8.2"
   spec.add_development_dependency "guard-rspec", "~> 4.7.3"
-  spec.add_development_dependency "pry", "~> 0.10"
   spec.add_development_dependency "rake", "~> 12.3.0"
   spec.add_development_dependency "rspec", "~> 3.0"
   spec.add_development_dependency "rubocop", "~> 0.49"
-  spec.add_development_dependency "webmock", "~> 3.1.1"
-  spec.add_development_dependency "vcr", "~> 4.0.0"
   spec.add_development_dependency "simplecov", "~> 0.15.1"
+  spec.add_development_dependency "vcr", "~> 4.0.0"
+  spec.add_development_dependency "webmock", "~> 3.1.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: vindetta
 version: !ruby/object:Gem::Version
-  version: 0.17.1
+  version: 0.19.0
 platform: ruby
 authors:
 - Kyle Decot
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-12-30 00:00:00.000000000 Z
+date: 2018-01-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: gli
@@ -80,20 +80,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 4.7.3
-- !ruby/object:Gem::Dependency
-  name: pry
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.10'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.10'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -137,19 +123,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0.49'
 - !ruby/object:Gem::Dependency
-  name: webmock
+  name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.1.1
+        version: 0.15.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.1.1
+        version: 0.15.1
 - !ruby/object:Gem::Dependency
   name: vcr
   requirement: !ruby/object:Gem::Requirement
@@ -165,19 +151,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 4.0.0
 - !ruby/object:Gem::Dependency
-  name: simplecov
+  name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.15.1
+        version: 3.1.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.15.1
+        version: 3.1.1
 description: Ruby gem for generating VINs
 email:
 - kyle@joinroot.com