vindata 0.0.10 → 0.0.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d8c4f9f81bb5a5effb3cf0becace3809063a6c64
-  data.tar.gz: c776fd750c8f4d1bd952cda38a8593647d9ecdce
+  metadata.gz: d696e00a32721eabc1780d9747aba12a89e9f981
+  data.tar.gz: f41d02df41a0abd722680e04c37c1a90c4617e25
 SHA512:
-  metadata.gz: 3c5093a3839323355d8f8e53d95eb397bca6448b4951b59658eb689d03025d6a4d4eafed1b787dbdd8ab3c9f30e3829cd1276ff6841a60024ed7d373a0a081e6
-  data.tar.gz: 1c376ba076d64c82eeb5259750f403ac47864f754b8eaf6780637e4cd4c906fc0993bb51057528a5648b33ede0a3f34fcbd4f36454fd1d487b4538e937147d23
+  metadata.gz: 4a517a73f9f4cc23d03602b52ec77bea3cd70ee078caf2bfa745fa0017a36bdb58cac2a5c1ce4829e65e8a3a02f57d6ae0e79c5ff20c05f61d2bf92eaa049417
+  data.tar.gz: df6b509255a53f51ab460d18f26f2310cf1822a72553e0012efc27a15c3f6949411357a75719440b9567a7a57f099147ac715ed79feb4c1bb54848ed7deabb3e

data/lib/vindata/services/edmunds.rb

@@ -92,8 +92,17 @@ module VinData::Services
     #   :mileage
     #   :zip
     def get_acv data
-      return nil unless ((data[:make] && data[:model] && data[:year]) || data[:vin]) && data[:mileage] && data[:zip]
-      if data[:vin]
+
+      info_is_present = data[:make] && data[:model] && data[:year]
+      vin_is_present = data[:vin].present?
+      condition_is_present = data[:condition].present?
+      location_is_present = data[:mileage] && data[:zip]
+
+      return nil unless (info_is_present || vin_is_present) &&
+        location_is_present &&
+        condition_is_present
+
+      if vin_is_present
         car_details = details_by_vin data.delete(:vin)
         return nil unless car_details
         data.merge! car_details
@@ -107,12 +116,12 @@ module VinData::Services
       acvlookup = 'https://api.edmunds.com/v1/api/tmv/tmvservice/calculateusedtmv'
       response = JSON.parse(RestClient.get acvlookup, {:params => {
         styleid: response['styles'][0]['id'],
-        condition: 'Clean',
+        condition: data[:condition].to_s.capitalize,
         mileage: data[:mileage],
         zip: data[:zip],
         fmt: 'json',
         api_key: configuration[:edmunds][:api_key]
-        }})
+      }})
 
       # TODO: Check data validity here
       if response == nil || response['tmv'] == nil

data/lib/vindata/version.rb

@@ -1,3 +1,3 @@
 module VinData
-  VERSION = '0.0.10'
+  VERSION = '0.0.11'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: vindata
 version: !ruby/object:Gem::Version
-  version: 0.0.10
+  version: 0.0.11
 platform: ruby
 authors:
 - Roupen Mouradian
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-27 00:00:00.000000000 Z
+date: 2016-10-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client
@@ -66,7 +66,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: Query popular VIN databases to get vehicle information.