vin-validator 0.0.4 → 1.0.0.pre.rc.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0ddfb8fb532566b001836257182732a1f9f959146dafe564aa9eb9b9f10b8638
-  data.tar.gz: 6e4fcf5cefc36ec23dc2ca9bc3d754d4e40e8d6837a5519b0df8ad1e616fb588
+  metadata.gz: 95cf357dcb88d24e42d8a35ff84b597669088179ce1c6c3fe83d6bf888fb8895
+  data.tar.gz: 925575c48c968a5c8acaf1c1ecec242deb9f859437582cb0958667f4e3ee6d55
 SHA512:
-  metadata.gz: 77045ee92e5492cd36ae02a334a155e19b3a105645c8bec5d721f2fe0ea6107f587108e8274d1827d687452cf5040fb4ae2fdc2ebc5a478465b41fd8c8683cae
-  data.tar.gz: cbde65d446fd1801a4797fbd1da2d63033a1e47ec87a1261b3269f8f87e97b06d843ae9eb2d50e4080946ff0167013c41360f28069addf4759cf48cf1cc4d5a0
+  metadata.gz: e516a350da7d1a69f95bdcf9ea560328d5683b7aa54f0b3c3262bfec61e060742212786b7313d1b76daed496b3ab20052b7cf2883cd36fc3a26f4d492ee7b3f5
+  data.tar.gz: d99a387b3c484ab33cbfc16080e7875a6e680e645ca71f5c36cebd5a1b8ae6f9e07fe188ad75bab6f5076a92f5852a0df8541d5d0bd02df344b66f032642b56f

data/README.adoc

@@ -8,7 +8,7 @@ Add this line to your application's Gemfile:
 
 [source,ruby]
 ----
-gem 'vin-validator', require: false
+gem 'vin-validator'
 ----
 
 And then execute:

data/lib/vin-validator.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
 
 require 'json'
-require_relative 'vin_validator/version'
 require_relative 'vin_validator/knowledge'
+require_relative 'vin_validator/version'
 require 'net/http'
 
 module VinValidator

data/lib/vin_validator/api.rb

@@ -14,7 +14,10 @@ module VinValidator
         check_nhtsa = block_given? ? yield : true
         return {} unless check_nhtsa
 
-        vins_to_check = [vins].flatten.compact.uniq
+        vins_to_check = [vins]
+        vins_to_check.flatten!
+        vins_to_check.compact!
+        vins_to_check.uniq!
 
         api_results =
           if vins_to_check.size == 1

data/lib/vin_validator/knowledge.rb

@@ -1,9 +1,9 @@
 # frozen_string_literal: true
 
-require_relative './result'
+require_relative './api'
 require_relative './maker'
+require_relative './result'
 require_relative './wmi'
-require_relative './api'
 
 module VinValidator
   class Knowledge
@@ -18,10 +18,7 @@ module VinValidator
       def vin_info(vins, hit_nhtsa = false, &block)
         results = hit_nhtsa ? VinValidator::Api.vin_info(vins, &block) : {}
 
-        Array(vins).to_h do |vin|
-          vin_results = results.fetch(vin, {})
-          [vin, build_results(vin, vin_results)]
-        end
+        Array(vins).map { |vin| [vin, build_results(vin, results.fetch(vin, {}))] }.to_h
       end
 
       private
@@ -39,47 +36,48 @@ module VinValidator
             if vin.is_a?(Array)
               vin.map(&:upcase)
             else
-              vin.upcase.split('')
+              vin.upcase.chars
             end
 
           vin_errors = []
 
-          if vin.join('') !~ /^[a-z0-9]{17}$/i
+          unless vin.join('').match?(/^[a-z0-9]{17}$/i)
             vin_errors << 'Only numbers and letters are allowed in VINs'
           end
 
-          # rubocop:disable Style/EachForSimpleLoop
-          (0..7).each do |slot|
-            # rubocop:enable Style/EachForSimpleLoop
+          8.times do |slot|
             # For 1-8, can't have 'I', 'O', or 'Q'
-            if /[ioq]/i =~ vin[slot].to_s
+            if vin[slot].to_s.match?(/[ioq]/i)
               vin_errors << "'I', 'O', and 'Q' are not allowed in slot #{slot + 1}."
             end
           end
 
-          unless /[0-9x]/i =~ vin[8].to_s # For 9, only 0-9 and 'X' are allowed
+          # For 9, only 0-9 and 'X' are allowed
+          unless vin[8].to_s.match?(/[0-9x]/i)
             vin_errors << "Only 0-9 and 'X' are allowed in slot 9."
           end
 
-          if /[iquz0]/i =~ vin[9].to_s # For 10, can't have 'I', 'O', 'Q', 'U', 'Z', '0'
+          # For 10, can't have 'I', 'O', 'Q', 'U', 'Z', '0'
+          if vin[9].to_s.match?(/[iquz0]/i)
             vin_errors << "'I', 'O', 'Q', 'U', 'Z', and 0 are not allowed in slot 10."
           end
 
           (10..13).each do |slot|
             # For 11-14, can't have 'I', 'O', 'Q'
-            if /[ioq]/i =~ vin[slot].to_s
+            if vin[slot].to_s.match?(/[ioq]/i)
               vin_errors << "'I', 'O', or 'Q' not allowed in slot #{slot + 1}."
             end
           end
 
           # For 15-17, only 0-9
           (14..16).each do |slot|
-            unless /[0-9]/i =~ vin[slot].to_s
+            unless vin[slot].to_s.match?(/[0-9]/i)
               vin_errors << "Only 0-9 allowed in slot #{slot + 1}."
             end
           end
 
-          vin_errors << 'Check digit is incorrect.' unless get_check_digit(vin) == vin[8]
+          vin_errors << 'Check digit is incorrect.' if get_check_digit(vin) != vin[8]
+
           vin_errors
         end
 
@@ -103,13 +101,16 @@ module VinValidator
           map = '0123456789X'
           weights = '8765432X098765432'
           sum = 0
-          (0..16).each do |i|
+
+          17.times do |i|
             value_weight = transliterate(vin[i])
+
             return nil if value_weight.nil?
 
             sum += value_weight * map.index(weights[i])
           end
-          return map[sum % 11]
+
+          map[sum % 11]
         end
 
         # Combines T2 and NHTSA's results. Will attempt to create `VinValidator::Result`s
@@ -143,10 +144,9 @@ module VinValidator
           reset_make ||= vin_results.dig(:make, 0).value.empty?
 
           if reset_make
-            vin_results[:make] =
-              VinValidator::Wmi.where(wmi: vin.strip.split('')[0..2].join).map do |wmi|
-                VinValidator::Result.new(vin: vin, type: :make, value: wmi.maker.name)
-              end
+            vin_results[:make] = VinValidator::Wmi.where(wmi: vin.strip[0..2]).map do |wmi|
+              VinValidator::Result.new(vin: vin, type: :make, value: wmi.maker.name)
+            end
           end
 
           return vin_results

data/lib/vin_validator/maker.rb

@@ -3,6 +3,10 @@
 module VinValidator
   class Maker
     class << self
+      # Loads all makers
+      #
+      # @return [Hash]
+      #
       def all
         return @all if defined?(@all)
 
@@ -11,13 +15,13 @@ module VinValidator
         end
       end
 
+      # Finds the maker with the given `id`
+      #
+      # @return [VinValidator::Maker]
+      #
       def find(id)
         all.fetch(id.to_s)
       end
-
-      def where(wmi:)
-
-      end
     end
 
     # @return [Integer]

data/lib/vin_validator/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module VinValidator
-  VERSION = '0.0.4'
+  VERSION = '1.0.0-rc.2'
 end

data/lib/vin_validator/wmi.rb

@@ -3,6 +3,10 @@
 module VinValidator
   class Wmi
     class << self
+      # Loads all wmis
+      #
+      # @return [Hash]
+      #
       def all
         return @all if defined?(@all)
 
@@ -11,10 +15,18 @@ module VinValidator
         end
       end
 
+      # Finds the wmi with the given `id`
+      #
+      # @return [VinValidator::Wmi]
+      #
       def find(id)
         all.fetch(id.to_s)
       end
 
+      # Finds the wmi(s) with the given `wmi`
+      #
+      # @return [Array<VinValidator::Wmi>]
+      #
       def where(wmi:)
         all.values.select { |w| w.wmi == wmi }
       end
@@ -37,6 +49,10 @@ module VinValidator
       @wmi_suffix = wmi_suffix
     end
 
+    # Finds the corresponding maker
+    #
+    # @return [VinValidator::Maker]
+    #
     def maker
       @maker ||= VinValidator::Maker.find(maker_id)
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: vin-validator
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 1.0.0.pre.rc.2
 platform: ruby
 authors:
 - Brands Insurance
@@ -59,12 +59,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 3.0.1
+      version: 2.5.3
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubygems_version: 3.4.10
 signing_key: