vigetlabs-provisional 2.1.6 → 2.1.7

data/.gitignore

@@ -0,0 +1,4 @@
+/pkg/
+/doc/
+/coverage/
+*.gem

data/README.md

@@ -27,6 +27,7 @@ Provisional is only tested on Mac OS X. It should also work on Linux. It is not
       --password, -p <s>:   Password (for some SCMs, see below)
             --id, -i <s>:   Id (for some SCMs, see below)
         --config, -c <s>:   Config file (optional)
+          --private, -r:   Private repository (for some SCMs, see documentation)
               --help, -h:   Show this message
 
 The SCM option can be one of the following ("`project_name`" refers to the value of the --name option):
@@ -61,6 +62,8 @@ Options specified via the command line take precedence over options specified in
 
 To use [GitHub](http://github.com/), you will need to place your GitHub username and token in your Git configuration as described here: http://github.com/guides/local-github-config Since there is already this established convention for GitHub credentials, to prevent redundant configuration, Provisional does not use its own configuration options for GitHub access.
 
+By default, repositories are publicly accessible. Use `--private` to make it private.
+
 ## Unfuddle
 
 To use [Unfuddle](http://unfuddle.com/) (for either Git or Subversion) you will need to specify the --domain, --id, --username and --password options. --domain is used to specify your unfuddle.com subdomain; --id is used to specify a project ID. Using a YAML file containing these options is recommended and should be helpful.
@@ -71,6 +74,13 @@ As of this writing (May 2009) [Beanstalk](http://beanstalkapp.com/)'s API is in
 
 To use Beanstalk you will need to specify the --domain, ---username and --password options. --domain is used to specify your beanstalkapp.com subdomain. Using a YAML file containing these options is recommended and should be helpful.
 
+## Acknowledgements
+
+Provisional acknowledges the support of Viewers Like You, and also the following significant contributors:
+
+* Clinton R. Nixon (crnixon)
+* David Eisinger (dce)
+
 ## License
 
 Copyright (c) 2009 Mark Cornick of Viget Labs <mark@viget.com>

data/Rakefile

@@ -43,7 +43,31 @@ rescue LoadError
   end
 end
 
+begin
+  require 'reek/rake_task'
+  Reek::RakeTask.new do |t|
+    t.fail_on_error = true
+    t.verbose = false
+    t.source_files = 'lib/**/*.rb'
+  end
+rescue LoadError
+  task :reek do
+    abort "Reek is not available. In order to run reek, you must: sudo gem install reek"
+  end
+end
 
+begin
+  require 'roodi'
+  require 'roodi_task'
+  RoodiTask.new do |t|
+    t.verbose = false
+  end
+rescue LoadError
+  task :roodi do
+    abort "Roodi is not available. In order to run roodi, you must: sudo gem install roodi"
+  end
+end
+  
 task :default => :test
 
 require 'rake/rdoctask'

data/VERSION.yml

@@ -1,4 +1,4 @@
 --- 
-:major: 2
 :minor: 1
-:patch: 6
+:patch: 7
+:major: 2

data/bin/provisional

@@ -13,6 +13,7 @@ options = Trollop::options do
   opt :password, "Password (for some SCMs, see documentation)", :type => String
   opt :id, "Id (for some SCMs, see documentation)", :type => String
   opt :config, "Config file (optional)", :type => String
+  opt :private, "Private repository (for some SCMs, see documentation)"
 end
 
 Provisional::Project.new(options)

data/lib/provisional/exceptions.reek

@@ -0,0 +1,23 @@
+---
+Duplication:
+  exclude:
+  - create_repository
+  - find_template_path
+  - initialize
+  - load_options
+  - validate_options
+  - xml_payload
+
+NestedIterators:
+  enabled: false
+
+FeatureEnvy:
+  exclude:
+  - xml_payload
+
+UtilityFunction:
+  exclude:
+  - xml_payload
+
+LongMethod: 
+  max_statements: 10

data/lib/provisional/project.rb

@@ -1,12 +1,13 @@
 require 'active_support'
+require 'provisional'
 require 'uri'
 require 'yaml'
 
 module Provisional
   class Project
     attr_reader :options
-    
-    def initialize(options)
+
+    def load_options(options)
       @options = HashWithIndifferentAccess.new
       if options[:config]
         begin
@@ -15,12 +16,18 @@ module Provisional
           raise ArgumentError, "could not be loaded or parsed: #{options[:config]}"
         end
       end
-      @options = @options.merge(options.reject{|k,v| v.nil?})
-
+      @options = @options.merge(options.reject{|key, value| value.nil?})
       @options[:scm] ||= 'git'
       @options[:template] ||= 'viget'
+    end
 
-      unless is_valid_url?(@options['template'])
+    def find_template_path
+      begin
+        template_is_url = [URI::HTTP, URI::HTTPS].include?(URI.parse(@options['template']).class)
+      rescue URI::InvalidURIError
+        template_is_url = false
+      end
+      unless template_is_url
         if File.exist?(File.expand_path(@options['template']))
           @options['template_path'] = File.expand_path(@options['template'])
         else
@@ -30,7 +37,9 @@ module Provisional
       else
         @options['template_path'] = @options['template']
       end
+    end
 
+    def validate_options
       raise ArgumentError, "name must be specified" unless @options['name']
       raise ArgumentError, "already exists: #{@options['name']}" if File.exist?(@options['name'])
       raise ArgumentError, "already exists: #{@options['name']}.repo" if @options['scm'] == 'svn' && File.exist?("#{@options['name']}.repo")
@@ -40,21 +49,18 @@ module Provisional
       rescue MissingSourceFile
         raise ArgumentError, "is not supported: #{@options['scm']}"
       end
+    end
 
+    def provision
       scm_class = "Provisional::SCM::#{@options['scm'].classify}".constantize
-      scm = scm_class.new(@options)
-      scm.init
-      scm.generate_rails
-      scm.checkin
+      scm_class.new(@options).provision
     end
 
-    def is_valid_url?(url)
-      begin
-        [URI::HTTP, URI::HTTPS].include?(URI.parse(url).class)
-      rescue URI::InvalidURIError
-        false
-      end
+    def initialize(options)
+      load_options(options)
+      find_template_path
+      validate_options
+      provision
     end
-
   end
 end

data/lib/provisional/rails_application.rb

@@ -1,3 +1,5 @@
+# FIXME: Provisional::RailsApplication#initialize doesn't depend on instance state (Utility Function)
+
 require 'rails/version'
 require 'rails_generator'
 require 'rails_generator/scripts/generate'

data/lib/provisional/scm/exceptions.reek

@@ -0,0 +1,14 @@
+---
+Duplication:
+  exclude:
+  - checkin
+  - generate_rails
+  - init
+
+ControlCouple: 
+  exclude:
+  - generate_rails
+
+FeatureEnvy:
+  exclude:
+  - checkin

data/lib/provisional/scm/git.rb

@@ -33,6 +33,12 @@ module Provisional
           repo
         end
       end
+      
+      def provision
+        self.init
+        self.generate_rails
+        self.checkin
+      end
     end
   end
 end

data/lib/provisional/scm/github.rb

@@ -1,5 +1,6 @@
 require 'provisional/scm/git'
 require 'net/http'
+require 'net/https'
 
 module Provisional
   module SCM
@@ -9,11 +10,22 @@ module Provisional
           repo = super
           github_user = repo.config 'github.user'
           github_token = repo.config 'github.token'
-          Net::HTTP.post_form URI.parse('https://github.com/api/v2/yaml/repos/create'), {
-            'login' => github_user,
-            'token' => github_token,
-            'name' => @options['name']
-          }
+
+          connection = Net::HTTP.new('github.com', 443)
+          connection.use_ssl = true
+          connection.verify_mode = OpenSSL::SSL::VERIFY_NONE
+
+          connection.start do |http|
+            req = Net::HTTP::Post.new("/api/v2/yaml/repos/create")
+            req.set_form_data(
+              'login'   => github_user,
+              'token'   => github_token,
+              'name'    => @options['name'],
+              'public'  => @options.keys.include?('private') ? 0 : 1
+            )
+            http.request(req)
+          end
+
           repo.add_remote('origin', "git@github.com:#{github_user}/#{@options['name']}.git")
           repo.push
         rescue

data/lib/provisional/scm/svn.rb

@@ -17,7 +17,7 @@ module Provisional
           system("svn co --username=#{@options['username']} --password=#{@options['password']} #{@options['url']} #{@options['name']}")
           Dir.chdir @options['name']
           if create_structure
-            %w(branches tags trunk).each {|d| Dir.mkdir(d)}
+            %w(branches tags trunk).each {|directory| Dir.mkdir(directory)}
             system("svn add branches tags trunk")
             system("svn commit -m 'Structure by Provisional'")
           end
@@ -32,6 +32,12 @@ module Provisional
           system("svn commit -m 'Initial commit by Provisional'")
         end
       end
+
+      def provision
+        self.init
+        self.generate_rails
+        self.checkin
+      end
     end
   end
 end

data/provisional.gemspec

@@ -0,0 +1,89 @@
+# -*- encoding: utf-8 -*-
+
+Gem::Specification.new do |s|
+  s.name = %q{provisional}
+  s.version = "2.1.7"
+
+  s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
+  s.authors = ["Mark Cornick"]
+  s.date = %q{2009-06-04}
+  s.default_executable = %q{provisional}
+  s.description = %q{Provisional creates a new Rails project, using a standard Rails 2.3 application template, and checks it into a new SCM repository.}
+  s.email = %q{mark@viget.com}
+  s.executables = ["provisional"]
+  s.extra_rdoc_files = [
+    "README.md"
+  ]
+  s.files = [
+    ".gitignore",
+     "README.md",
+     "Rakefile",
+     "VERSION.yml",
+     "bin/provisional",
+     "lib/provisional.rb",
+     "lib/provisional/exceptions.reek",
+     "lib/provisional/project.rb",
+     "lib/provisional/rails_application.rb",
+     "lib/provisional/scm/beanstalk.rb",
+     "lib/provisional/scm/exceptions.reek",
+     "lib/provisional/scm/git.rb",
+     "lib/provisional/scm/github.rb",
+     "lib/provisional/scm/svn.rb",
+     "lib/provisional/scm/unfuddle.rb",
+     "lib/provisional/scm/unfuddle_svn.rb",
+     "lib/provisional/templates/viget.rb",
+     "lib/provisional/unfuddle_common.rb",
+     "provisional.gemspec",
+     "test/test_helper.rb",
+     "test/unit/beanstalk_test.rb",
+     "test/unit/git_test.rb",
+     "test/unit/github_test.rb",
+     "test/unit/project_test.rb",
+     "test/unit/rails_application_test.rb",
+     "test/unit/svn_test.rb",
+     "test/unit/unfuddle_common_test.rb",
+     "test/unit/unfuddle_svn_test.rb",
+     "test/unit/unfuddle_test.rb"
+  ]
+  s.has_rdoc = true
+  s.homepage = %q{http://github.com/vigetlabs/provisional}
+  s.rdoc_options = ["--charset=UTF-8"]
+  s.require_paths = ["lib"]
+  s.rubyforge_project = %q{viget}
+  s.rubygems_version = %q{1.3.2}
+  s.summary = %q{Automation for new Rails Projects}
+  s.test_files = [
+    "test/test_helper.rb",
+     "test/unit/beanstalk_test.rb",
+     "test/unit/git_test.rb",
+     "test/unit/github_test.rb",
+     "test/unit/project_test.rb",
+     "test/unit/rails_application_test.rb",
+     "test/unit/svn_test.rb",
+     "test/unit/unfuddle_common_test.rb",
+     "test/unit/unfuddle_svn_test.rb",
+     "test/unit/unfuddle_test.rb"
+  ]
+
+  if s.respond_to? :specification_version then
+    current_version = Gem::Specification::CURRENT_SPECIFICATION_VERSION
+    s.specification_version = 3
+
+    if Gem::Version.new(Gem::RubyGemsVersion) >= Gem::Version.new('1.2.0') then
+      s.add_runtime_dependency(%q<trollop>, [">= 1.10.2"])
+      s.add_runtime_dependency(%q<rails>, [">= 2.3.0"])
+      s.add_runtime_dependency(%q<git>, [">= 1.0.5"])
+      s.add_runtime_dependency(%q<builder>, [">= 2.1.2"])
+    else
+      s.add_dependency(%q<trollop>, [">= 1.10.2"])
+      s.add_dependency(%q<rails>, [">= 2.3.0"])
+      s.add_dependency(%q<git>, [">= 1.0.5"])
+      s.add_dependency(%q<builder>, [">= 2.1.2"])
+    end
+  else
+    s.add_dependency(%q<trollop>, [">= 1.10.2"])
+    s.add_dependency(%q<rails>, [">= 2.3.0"])
+    s.add_dependency(%q<git>, [">= 1.0.5"])
+    s.add_dependency(%q<builder>, [">= 2.1.2"])
+  end
+end

data/test/unit/beanstalk_test.rb

@@ -11,7 +11,7 @@ class BeanstalkTest < Test::Unit::TestCase
     @scm.init
   end
 
-  def test_init_should_raise_RuntimeError_if_any_step_raises_any_exception
+  def test_init_should_fail_if_any_step_raises_any_exception
     Beanstalk::Repository.expects(:create).raises(Errno::ECONNREFUSED)
     assert_raise RuntimeError do
       @scm.init

data/test/unit/git_test.rb

@@ -14,7 +14,7 @@ class GitTest < Test::Unit::TestCase
     @scm.init
   end
 
-  def test_init_should_raise_RuntimeError_if_any_step_raises_any_exception
+  def test_init_should_fail_if_any_step_raises_any_exception
     FileUtils.expects(:mkdir_p).with('name').raises(Errno::EEXIST)
     assert_raise RuntimeError do
       @scm.init
@@ -26,7 +26,7 @@ class GitTest < Test::Unit::TestCase
     @scm.generate_rails
   end
 
-  def test_generate_rails_should_raise_RuntimeError_if_any_step_raises_any_exception
+  def test_generate_rails_should_fail_if_any_step_raises_any_exception
     Provisional::RailsApplication.expects(:new).raises(RuntimeError)
     assert_raise RuntimeError do
       @scm.generate_rails
@@ -38,10 +38,17 @@ class GitTest < Test::Unit::TestCase
     @scm.checkin
   end
 
-  def test_checkin_should_raise_RuntimeError_if_any_step_raises_any_exception
+  def test_checkin_should_fail_if_any_step_raises_any_exception
     Git.expects(:open).raises(ArgumentError)
     assert_raise RuntimeError do
       @scm.checkin
     end
   end
+  
+  def test_provision_should_call_init_generate_rails_and_checkin
+    @scm.expects(:init)
+    @scm.expects(:generate_rails)
+    @scm.expects(:checkin)
+    @scm.provision
+  end
 end

data/test/unit/github_test.rb

@@ -14,23 +14,38 @@ class GithubTest < Test::Unit::TestCase
       stub.expects(:push)
     end
 
-    URI.expects(:parse).with('https://github.com/api/v2/yaml/repos/create')
-    Net::HTTP.expects(:post_form).with(nil, { 'login' => 'user', 'token' => 'token', 'name' => 'name' })
+    stub_github do |stub|
+      stub.expects(:request).returns(true)
+    end
 
     @scm.checkin
   end
 
-  def test_checkin_should_raise_RuntimeError_if_any_step_raises_any_exception
+  def test_checkin_should_fail_if_any_step_raises_any_exception
     stub_git_checkin do |stub|
       stub.expects(:config).with('github.user').returns('user')
       stub.expects(:config).with('github.token').returns('token')
     end
 
-    URI.expects(:parse).with('https://github.com/api/v2/yaml/repos/create')
-    Net::HTTP.expects(:post_form).with(nil, { 'login' => 'user', 'token' => 'token', 'name' => 'name' }).raises(Net::HTTPUnauthorized)
+    stub_github do |stub|
+      stub.expects(:request).raises(Net::HTTPUnauthorized)
+    end
 
     assert_raise RuntimeError do
       @scm.checkin
     end
   end
+
+  private
+
+  def stub_github
+    http = stub
+
+    connection = stub(:use_ssl= => true, :verify_mode= => true)
+    connection.expects(:start).yields(http)
+
+    Net::HTTP.expects(:new).with('github.com', 443).returns(connection)
+
+    yield http
+  end
 end

data/test/unit/project_test.rb

@@ -7,9 +7,7 @@ class ProjectTest < Test::Unit::TestCase
 
   def stub_git
     git_stub = stub()
-    git_stub.expects(:init).returns('true')
-    git_stub.expects(:generate_rails).returns('true')
-    git_stub.expects(:checkin).returns('true')
+    git_stub.expects(:provision).returns('true')
     Provisional::SCM::Git.expects(:new).returns(git_stub)
   end
 

data/test/unit/svn_test.rb

@@ -30,7 +30,7 @@ class SvnTest < Test::Unit::TestCase
     @scm.generate_rails(false)
   end
 
-  def test_generate_rails_should_raise_RuntimeError_if_any_step_raises_any_exception
+  def test_generate_rails_should_fail_if_any_step_raises_any_exception
     @scm.expects(:system).with("svn co --username=username --password=password url name")
     Dir.expects(:chdir).with('name').raises(Errno::ENOENT)
     assert_raise RuntimeError do
@@ -44,10 +44,17 @@ class SvnTest < Test::Unit::TestCase
     @scm.checkin
   end
 
-  def test_checkin_should_raise_RuntimeError_if_any_step_raises_any_exception
+  def test_checkin_should_fail_if_any_step_raises_any_exception
     @scm.expects(:system).with("svn add *").raises(RuntimeError)
     assert_raise RuntimeError do
       @scm.checkin
     end
   end
+  
+  def test_provision_should_call_init_generate_rails_and_checkin
+    @scm.expects(:init)
+    @scm.expects(:generate_rails)
+    @scm.expects(:checkin)
+    @scm.provision
+  end
 end

data/test/unit/unfuddle_common_test.rb

@@ -38,7 +38,7 @@ class UnfuddleCommonTest < Test::Unit::TestCase
     create_repository(options)
   end
 
-  def test_checkin_should_raise_RuntimeError_if_unfuddle_api_call_fails
+  def test_checkin_should_fail_if_unfuddle_api_call_fails
     options = {'username' => 'username', 'password' => 'password', 'domain' => 'domain'}
     request_stub = stub()
     request_stub.expects(:basic_auth).with('username', 'password')
@@ -57,7 +57,7 @@ class UnfuddleCommonTest < Test::Unit::TestCase
     end
   end
 
-  def test_checkin_should_raise_RuntimeError_if_any_step_raises_any_exception
+  def test_checkin_should_fail_if_any_step_raises_any_exception
     options = {'domain' => 'domain'}
     Net::HTTP.expects(:new).with("domain.unfuddle.com", 80).raises(Net::HTTPNotFound)
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: vigetlabs-provisional
 version: !ruby/object:Gem::Version 
-  version: 2.1.6
+  version: 2.1.7
 platform: ruby
 authors: 
 - Mark Cornick
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-05-26 00:00:00 -07:00
+date: 2009-06-04 00:00:00 -07:00
 default_executable: provisional
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -61,14 +61,17 @@ extensions: []
 extra_rdoc_files: 
 - README.md
 files: 
+- .gitignore
 - README.md
 - Rakefile
 - VERSION.yml
 - bin/provisional
 - lib/provisional.rb
+- lib/provisional/exceptions.reek
 - lib/provisional/project.rb
 - lib/provisional/rails_application.rb
 - lib/provisional/scm/beanstalk.rb
+- lib/provisional/scm/exceptions.reek
 - lib/provisional/scm/git.rb
 - lib/provisional/scm/github.rb
 - lib/provisional/scm/svn.rb
@@ -76,6 +79,7 @@ files:
 - lib/provisional/scm/unfuddle_svn.rb
 - lib/provisional/templates/viget.rb
 - lib/provisional/unfuddle_common.rb
+- provisional.gemspec
 - test/test_helper.rb
 - test/unit/beanstalk_test.rb
 - test/unit/git_test.rb