view_primitives 0.2.2 → 0.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b7ad50f006f2e848d1ea1286888087965825cbc8177a521bd01e9ec0b63f0e94
-  data.tar.gz: 35177906e6b1a0cc9f2f91116b9bc220301c72a9c0a3f2e53cad5f95b61f71cb
+  metadata.gz: bf3e09110faf5ce30ed81d7760ab59bbf397fcdd1bfd907748e481d2ad31ae82
+  data.tar.gz: bfc5afe878bd677f57a02cf6a69169125a081490702f3194cd95113b0a8901ad
 SHA512:
-  metadata.gz: a00b47822b358a02788b878742bfac12f272e7cec10dc814d83463d199c0f8eddc233d428d7dbdfd659988cf94134809c08d9f23995727fccf3374da72161216
-  data.tar.gz: 406b1c90c6f485a2f6acc6655a993e45cc4466ebf4457fe8af738a3947e763e942328322253c5824d8fde752fde62283684a95257ebd0c12139b5f053002875f
+  metadata.gz: c3f2433c648728f95e0dceb2f22352866d7e868aff1b302527d6cc16298bd4251dae28a6c2753b91fd67fb4511edf5b6c38d1dc71a3f7ff1384bb65c1c93a55d
+  data.tar.gz: 10711ae4e2f413503f34621b3a3c0ffcf77b0ea80e9162fd2a38e2d2265690eaed83d16dccfd84b38d79d4c686f55eabe502e6c661cfb507c1379404cc12849e

data/CHANGELOG.md

@@ -7,6 +7,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.2.3] - 2026-09-02
+
+### Fixed
+
+- **Chart** resolves `var(--chart-1)`-style CSS custom properties to their computed value before handing colors to Chart.js — Canvas 2D's `fillStyle` cannot resolve CSS variables on its own, so every segment rendered black
+- **Chart** uses one color per data point (not per dataset) for `pie`/`doughnut`/`polarArea`, matching Chart.js's expected `backgroundColor` shape for single-dataset charts
+- **Dialog**, **Sheet**, **Drawer**, **Command**, **Menubar**, **Gallery** close on <kbd>Esc</kbd> again — the Stimulus key filter was `keydown.escape`, but Stimulus only recognizes the `esc` alias, so the action silently failed to bind (and threw in the console) on every one of these components
+- `install`/`add`/`update` generators no longer emit `method redefined` warnings under `ruby -w` — `ComponentCopier` defined its `template`/`copy_file` overrides via `define_method` in the `included` hook, which re-ran and redefined the methods when Rails loaded a generator under a second load path
+
 ## [0.2.2] - 2026-07-15
 
 ### Fixed

data/lib/generators/view_primitives/add/templates/chart/chart_controller.js

@@ -23,8 +23,18 @@ export default class extends Controller {
 
   connect() {
     const { labels, datasets, options = {}, colors } = JSON.parse(this.configValue)
-    const palette = colors?.length ? colors : DEFAULT_COLORS
+    const palette = (colors?.length ? colors : DEFAULT_COLORS).map((c) => this.#resolveColor(c))
+    const perSegment = ["pie", "doughnut", "polarArea"].includes(this.typeValue) && datasets.length === 1
     const coloredDatasets = datasets.map((dataset, index) => {
+      if (perSegment) {
+        const segmentColors = (dataset.data ?? []).map((_, i) => palette[i % palette.length])
+        return {
+          ...dataset,
+          backgroundColor: dataset.backgroundColor ?? segmentColors,
+          borderColor: dataset.borderColor ?? segmentColors
+        }
+      }
+
       const color = palette[index % palette.length]
       return {
         ...dataset,
@@ -39,7 +49,7 @@ export default class extends Controller {
       options: {
         responsive: true,
         maintainAspectRatio: true,
-        color: "var(--muted-foreground)",
+        color: this.#resolveColor("var(--muted-foreground)"),
         ...options
       }
     })
@@ -49,4 +59,14 @@ export default class extends Controller {
     this.#chart?.destroy()
     this.#chart = null
   }
+
+  // Canvas fillStyle can't resolve CSS custom properties on its own —
+  // read the computed value from the DOM before handing it to Chart.js.
+  #resolveColor(value) {
+    const match = /^var\((--[^),]+)\)$/.exec(value?.trim() ?? "")
+    if (!match) return value
+
+    const resolved = getComputedStyle(document.documentElement).getPropertyValue(match[1]).trim()
+    return resolved || value
+  }
 }

data/lib/generators/view_primitives/add/templates/command/command_component.rb.tt

@@ -51,7 +51,7 @@ module UI
           class: cn(DIALOG, @extra_class),
           role: "dialog",
           "aria-modal": "true",
-          data: { action: "keydown.escape@window->command#close" }) {
+          data: { action: "keydown.esc@window->command#close" }) {
           concat content_tag(:div, class: COMMAND) {
             concat search_bar
             concat content_tag(:div, class: LIST, data: { command_target: "list" }) {

data/lib/generators/view_primitives/add/templates/dialog/dialog_component.rb.tt

@@ -40,7 +40,7 @@ module UI
           role: "dialog",
           "aria-modal": "true",
           "aria-label": @title,
-          data: { action: "keydown.escape@window->dialog#close" }) {
+          data: { action: "keydown.esc@window->dialog#close" }) {
           concat close_button
           concat header_area
           concat content_tag(:div, content) unless content.blank?

data/lib/generators/view_primitives/add/templates/drawer/drawer_component.rb.tt

@@ -36,7 +36,7 @@ module UI
           role: "dialog",
           "aria-modal": "true",
           "aria-label": @title,
-          data: { action: "keydown.escape@window->dialog#close" }) {
+          data: { action: "keydown.esc@window->dialog#close" }) {
           concat drag_handle
           concat header_area
           concat content_tag(:div, content, class: "px-4 pb-6 text-sm")

data/lib/generators/view_primitives/add/templates/gallery/gallery_component.rb.tt

@@ -40,7 +40,7 @@ module UI
       attrs = { class: grid_cls }
       if @lightbox
         attrs[:data] = { controller: "gallery",
-                         action: "click@document->gallery#closeOnClickOutside keydown.escape@document->gallery#close" }
+                         action: "click@document->gallery#closeOnClickOutside keydown.esc@document->gallery#close" }
       end
       attrs.merge!(@html_attrs)
 

data/lib/generators/view_primitives/add/templates/menubar/menubar_component.rb.tt

@@ -23,7 +23,7 @@ module UI
         class: cn(BAR, @extra_class),
         data: {
           controller: "menubar",
-          action: "click@document->menubar#closeOnClickOutside keydown.escape@document->menubar#closeAll"
+          action: "click@document->menubar#closeOnClickOutside keydown.esc@document->menubar#closeAll"
         },
         **@html_attrs) do
         menus.each { |m| concat m }

data/lib/generators/view_primitives/add/templates/sheet/sheet_component.rb.tt

@@ -48,7 +48,7 @@ module UI
           role: "dialog",
           "aria-modal": "true",
           "aria-label": @title,
-          data: { action: "keydown.escape@window->dialog#close" }) {
+          data: { action: "keydown.esc@window->dialog#close" }) {
           concat close_button
           concat header_area
           concat content_tag(:div, content, class: "flex-1") unless content.blank?

data/lib/generators/view_primitives/component_copier.rb

@@ -5,22 +5,23 @@ require_relative "components"
 module ViewPrimitives
   module Generators
     module ComponentCopier
-      def self.included(base)
-        base.no_tasks do
-          define_method(:template) do |source, *args, **options, &blk|
-            destination = args.first || options[:to]
-            return unless destination.nil? || confirm_overwrite(destination)
-
-            super(source, *args, **options, &blk)
-          end
+      # Wrap Thor::Actions' file helpers so they prompt before clobbering an
+      # existing file. Defined as ordinary module methods (not via
+      # `define_method` inside `included`) so that re-including the module stays
+      # a silent no-op — Rails can load a generator under two different
+      # $LOADED_FEATURES keys, which reopens the class and runs `include` again.
+      def template(source, *args, **options, &blk)
+        destination = args.first || options[:to]
+        return unless destination.nil? || confirm_overwrite(destination)
+
+        super
+      end
 
-          define_method(:copy_file) do |source, *args, **options|
-            destination = args.first || options[:to]
-            return unless destination.nil? || confirm_overwrite(destination)
+      def copy_file(source, *args, **options, &blk)
+        destination = args.first || options[:to]
+        return unless destination.nil? || confirm_overwrite(destination)
 
-            super(source, *args, **options)
-          end
-        end
+        super
       end
 
       private

data/lib/view_primitives/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ViewPrimitives
-  VERSION = "0.2.2"
+  VERSION = "0.2.3"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: view_primitives
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.2.3
 platform: ruby
 authors:
 - Alexey Poimtsev
@@ -262,14 +262,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 3.2.0
+      version: 3.3.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.16
+rubygems_version: 4.0.19
 specification_version: 4
 summary: Primitive view components and helpers for Rails applications
 test_files: []