view_primitives 0.2.1 → 0.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5d6e218accad9b3ebd803b8818be2c9afe98ee00272d47b511f98dbf4c643d09
-  data.tar.gz: d27e24bde3d0b273681b71c4a981a8fb49db3ad8a0125a3da5709e0b633be0e7
+  metadata.gz: bf3e09110faf5ce30ed81d7760ab59bbf397fcdd1bfd907748e481d2ad31ae82
+  data.tar.gz: bfc5afe878bd677f57a02cf6a69169125a081490702f3194cd95113b0a8901ad
 SHA512:
-  metadata.gz: efe24edf1051beb9a015086e288b2258277b013c3a7c982bf937f96a5480d39573876039e020944ea1cff088b844d8f3ff0ff0b8a75e322ec419c8a7f7ebc2cd
-  data.tar.gz: 3cda9d5baac7d8ecd2d845fb1dbed9a48b8e04f7b43211484be7f036958843ba62012478c289cb7c65014d714d1ee5c5538b5608cbff9670ef7133fe97b1d988
+  metadata.gz: c3f2433c648728f95e0dceb2f22352866d7e868aff1b302527d6cc16298bd4251dae28a6c2753b91fd67fb4511edf5b6c38d1dc71a3f7ff1384bb65c1c93a55d
+  data.tar.gz: 10711ae4e2f413503f34621b3a3c0ffcf77b0ea80e9162fd2a38e2d2265690eaed83d16dccfd84b38d79d4c686f55eabe502e6c661cfb507c1379404cc12849e

data/CHANGELOG.md

@@ -7,6 +7,24 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.2.3] - 2026-09-02
+
+### Fixed
+
+- **Chart** resolves `var(--chart-1)`-style CSS custom properties to their computed value before handing colors to Chart.js — Canvas 2D's `fillStyle` cannot resolve CSS variables on its own, so every segment rendered black
+- **Chart** uses one color per data point (not per dataset) for `pie`/`doughnut`/`polarArea`, matching Chart.js's expected `backgroundColor` shape for single-dataset charts
+- **Dialog**, **Sheet**, **Drawer**, **Command**, **Menubar**, **Gallery** close on <kbd>Esc</kbd> again — the Stimulus key filter was `keydown.escape`, but Stimulus only recognizes the `esc` alias, so the action silently failed to bind (and threw in the console) on every one of these components
+- `install`/`add`/`update` generators no longer emit `method redefined` warnings under `ruby -w` — `ComponentCopier` defined its `template`/`copy_file` overrides via `define_method` in the `included` hook, which re-ran and redefined the methods when Rails loaded a generator under a second load path
+
+## [0.2.2] - 2026-07-15
+
+### Fixed
+
+- `install` generator respects overwrite prompts for `UI::Styles` and the CSS bundle (same behaviour as `add` and `update`)
+- **Calendar** renders a hidden input when `name` is set but no date is selected — fixes form data loss on clear or initial render
+- **TagsInput** no longer double-appends `[]` when `name` already ends with `[]`
+- **TagsInput** preserves pre-selected values that are missing from the current `options` list (edit forms with stale tags)
+
 ## [0.2.1] - 2026-07-15
 
 ### Changed
@@ -148,6 +166,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - `view_primitives:add` exits with status 1 on unknown components; prints copy summary
 - Requires `view_component >= 4.0` and Rails `>= 7.1`
 
+[0.2.2]: https://github.com/alec-c4/view_primitives/releases/tag/v0.2.2
 [0.2.1]: https://github.com/alec-c4/view_primitives/releases/tag/v0.2.1
 [0.2.0]: https://github.com/alec-c4/view_primitives/releases/tag/v0.2.0
 [0.1.0]: https://github.com/alec-c4/view_primitives/releases/tag/v0.1.0

data/lib/generators/view_primitives/add/templates/calendar/calendar_component.rb.tt

@@ -46,7 +46,7 @@ module UI
         class: cn(CONTAINER, @extra_class),
         data: { slot: "calendar", controller: "calendar", calendar_month_value: @month.iso8601 },
         **@html_attrs) do
-        concat hidden_input if @name && @selected
+        concat hidden_input if @name
         concat header_row
         concat day_of_week_row
         concat day_grid

data/lib/generators/view_primitives/add/templates/chart/chart_controller.js

@@ -23,8 +23,18 @@ export default class extends Controller {
 
   connect() {
     const { labels, datasets, options = {}, colors } = JSON.parse(this.configValue)
-    const palette = colors?.length ? colors : DEFAULT_COLORS
+    const palette = (colors?.length ? colors : DEFAULT_COLORS).map((c) => this.#resolveColor(c))
+    const perSegment = ["pie", "doughnut", "polarArea"].includes(this.typeValue) && datasets.length === 1
     const coloredDatasets = datasets.map((dataset, index) => {
+      if (perSegment) {
+        const segmentColors = (dataset.data ?? []).map((_, i) => palette[i % palette.length])
+        return {
+          ...dataset,
+          backgroundColor: dataset.backgroundColor ?? segmentColors,
+          borderColor: dataset.borderColor ?? segmentColors
+        }
+      }
+
       const color = palette[index % palette.length]
       return {
         ...dataset,
@@ -39,7 +49,7 @@ export default class extends Controller {
       options: {
         responsive: true,
         maintainAspectRatio: true,
-        color: "var(--muted-foreground)",
+        color: this.#resolveColor("var(--muted-foreground)"),
         ...options
       }
     })
@@ -49,4 +59,14 @@ export default class extends Controller {
     this.#chart?.destroy()
     this.#chart = null
   }
+
+  // Canvas fillStyle can't resolve CSS custom properties on its own —
+  // read the computed value from the DOM before handing it to Chart.js.
+  #resolveColor(value) {
+    const match = /^var\((--[^),]+)\)$/.exec(value?.trim() ?? "")
+    if (!match) return value
+
+    const resolved = getComputedStyle(document.documentElement).getPropertyValue(match[1]).trim()
+    return resolved || value
+  }
 }

data/lib/generators/view_primitives/add/templates/command/command_component.rb.tt

@@ -51,7 +51,7 @@ module UI
           class: cn(DIALOG, @extra_class),
           role: "dialog",
           "aria-modal": "true",
-          data: { action: "keydown.escape@window->command#close" }) {
+          data: { action: "keydown.esc@window->command#close" }) {
           concat content_tag(:div, class: COMMAND) {
             concat search_bar
             concat content_tag(:div, class: LIST, data: { command_target: "list" }) {

data/lib/generators/view_primitives/add/templates/dialog/dialog_component.rb.tt

@@ -40,7 +40,7 @@ module UI
           role: "dialog",
           "aria-modal": "true",
           "aria-label": @title,
-          data: { action: "keydown.escape@window->dialog#close" }) {
+          data: { action: "keydown.esc@window->dialog#close" }) {
           concat close_button
           concat header_area
           concat content_tag(:div, content) unless content.blank?

data/lib/generators/view_primitives/add/templates/drawer/drawer_component.rb.tt

@@ -36,7 +36,7 @@ module UI
           role: "dialog",
           "aria-modal": "true",
           "aria-label": @title,
-          data: { action: "keydown.escape@window->dialog#close" }) {
+          data: { action: "keydown.esc@window->dialog#close" }) {
           concat drag_handle
           concat header_area
           concat content_tag(:div, content, class: "px-4 pb-6 text-sm")

data/lib/generators/view_primitives/add/templates/gallery/gallery_component.rb.tt

@@ -40,7 +40,7 @@ module UI
       attrs = { class: grid_cls }
       if @lightbox
         attrs[:data] = { controller: "gallery",
-                         action: "click@document->gallery#closeOnClickOutside keydown.escape@document->gallery#close" }
+                         action: "click@document->gallery#closeOnClickOutside keydown.esc@document->gallery#close" }
       end
       attrs.merge!(@html_attrs)
 

data/lib/generators/view_primitives/add/templates/menubar/menubar_component.rb.tt

@@ -23,7 +23,7 @@ module UI
         class: cn(BAR, @extra_class),
         data: {
           controller: "menubar",
-          action: "click@document->menubar#closeOnClickOutside keydown.escape@document->menubar#closeAll"
+          action: "click@document->menubar#closeOnClickOutside keydown.esc@document->menubar#closeAll"
         },
         **@html_attrs) do
         menus.each { |m| concat m }

data/lib/generators/view_primitives/add/templates/sheet/sheet_component.rb.tt

@@ -48,7 +48,7 @@ module UI
           role: "dialog",
           "aria-modal": "true",
           "aria-label": @title,
-          data: { action: "keydown.escape@window->dialog#close" }) {
+          data: { action: "keydown.esc@window->dialog#close" }) {
           concat close_button
           concat header_area
           concat content_tag(:div, content, class: "flex-1") unless content.blank?

data/lib/generators/view_primitives/add/templates/tags_input/tags_input_component.rb.tt

@@ -56,7 +56,7 @@ module UI
         class: CHIP,
         data: {"tags-input-target": "chip", "tags-input-value": opt[:value]}) do
         concat content_tag(:span, opt[:label], class: CHIP_LABEL)
-        concat tag.input(type: "hidden", name: "#{@name}[]", value: opt[:value])
+        concat tag.input(type: "hidden", name: hidden_input_name, value: opt[:value])
         concat remove_button(opt[:value])
       end
     end
@@ -130,7 +130,13 @@ module UI
     end
 
     def selected_options
-      normalized_options.select { |o| @values.include?(o[:value]) }
+      options_by_value = normalized_options.to_h { |o| [o[:value], o] }
+      @values.map { |value| options_by_value.fetch(value, {value: value, label: value}) }
+    end
+
+    def hidden_input_name
+      name = @name.to_s
+      name.end_with?("[]") ? name : "#{name}[]"
     end
   end
 end

data/lib/generators/view_primitives/component_copier.rb

@@ -5,22 +5,23 @@ require_relative "components"
 module ViewPrimitives
   module Generators
     module ComponentCopier
-      def self.included(base)
-        base.no_tasks do
-          define_method(:template) do |source, *args, **options, &blk|
-            destination = args.first || options[:to]
-            return unless destination.nil? || confirm_overwrite(destination)
-
-            super(source, *args, **options, &blk)
-          end
+      # Wrap Thor::Actions' file helpers so they prompt before clobbering an
+      # existing file. Defined as ordinary module methods (not via
+      # `define_method` inside `included`) so that re-including the module stays
+      # a silent no-op — Rails can load a generator under two different
+      # $LOADED_FEATURES keys, which reopens the class and runs `include` again.
+      def template(source, *args, **options, &blk)
+        destination = args.first || options[:to]
+        return unless destination.nil? || confirm_overwrite(destination)
+
+        super
+      end
 
-          define_method(:copy_file) do |source, *args, **options|
-            destination = args.first || options[:to]
-            return unless destination.nil? || confirm_overwrite(destination)
+      def copy_file(source, *args, **options, &blk)
+        destination = args.first || options[:to]
+        return unless destination.nil? || confirm_overwrite(destination)
 
-            super(source, *args, **options)
-          end
-        end
+        super
       end
 
       private

data/lib/generators/view_primitives/install/install_generator.rb

@@ -1,16 +1,18 @@
 # frozen_string_literal: true
 
 require_relative "../detector"
+require_relative "../component_copier"
 
 module ViewPrimitives
   module Generators
     class InstallGenerator < Rails::Generators::Base
       include Detector
+      include ComponentCopier
 
       source_root File.expand_path("templates", __dir__)
 
       class_option :force, type: :boolean, default: false,
-        desc: "Overwrite existing ApplicationComponent and CSS files"
+        desc: "Overwrite existing ApplicationComponent, UI styles, and CSS files"
 
       def verify_ui_inflection
         return if "ui/button_component".camelize == "UI::ButtonComponent"

data/lib/view_primitives/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ViewPrimitives
-  VERSION = "0.2.1"
+  VERSION = "0.2.3"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: view_primitives
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.3
 platform: ruby
 authors:
 - Alexey Poimtsev
@@ -262,14 +262,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 3.2.0
+      version: 3.3.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.16
+rubygems_version: 4.0.19
 specification_version: 4
 summary: Primitive view components and helpers for Rails applications
 test_files: []