view_models 2.0.0 → 2.0.1

data/lib/shared/lib/view_models/base.rb

@@ -71,7 +71,7 @@ module ViewModels
         # Just raises a fitting template error.
         #
         def raise_template_error_with message
-          raise MissingTemplateError.new "No template #{message} found."
+          raise MissingTemplateError.new("No template #{message} found.")
         end
         # Check if the view lookup inheritance chain has ended.
         #

data/spec/padrino/integration/integration_spec.rb

@@ -0,0 +1,287 @@
+require File.join(File.dirname(__FILE__), '../spec_helper')
+
+require File.join(File.dirname(__FILE__), 'models/subclass')
+require File.join(File.dirname(__FILE__), 'models/sub_subclass')
+
+require File.join(File.dirname(__FILE__), 'view_models/project')
+require File.join(File.dirname(__FILE__), 'view_models/subclass')
+require File.join(File.dirname(__FILE__), 'view_models/sub_subclass')
+require File.join(File.dirname(__FILE__), 'view_models/module_for_rendering')
+
+class TestApp < Padrino::Application
+  
+end
+
+TestApp.helpers ViewModels::Helpers::Mapping
+
+describe 'Integration' do
+  
+  before(:each) do
+    begin
+      # @controller          = TestController.new
+      # @controller.class.view_paths = ['rails/spec/integration/views']
+      #
+      # 
+      # @request             = ActionController::TestRequest.new
+      # @response            = ActionController::TestResponse.new
+      # @controller.request  = @request
+      # @controller.response = @response
+      # 
+      # # TODO Make separate contexts, one where the controller has rendered, one where it has not.
+      # #
+      # # Let the Controller generate a view instance.
+      # #
+      # # @controller.process @request, @response
+      # 
+      # @view                = ActionView::Base.new @controller.class.view_paths, {}, @controller
+      
+      @app = stub :app
+      TestApp.new(@app) do |some_app|
+        @context = some_app
+      end
+      
+      @logger                         = stub :logger, :null_object => true
+      Thread.current[:padrino_logger] = @logger
+      
+      @model      = SubSubclass.new
+      @model.id   = :some_id
+      @view_model = ViewModels::SubSubclass.new @model, @context
+    end
+  end
+  
+  before(:all) { puts "\n#{self.send(:description_args)[0]}:" }
+  
+  # context 'experimental inclusion of module in render hierarchy' do
+  #   before(:each) do
+  #     ViewModels::Base.send :include, ModulesInRenderHierarchy
+  #     @view_model.class.send :include, ModuleForRendering
+  #   end
+  #   describe 'render_as' do
+  #     it 'should description' do
+  #       @view_model.render_as(:not_found_in_sub_subclass_but_in_module).should == '_not_found_in_sub_subclass_but_in_module.erb'
+  #     end
+  #   end
+  # end
+  
+  # TODO Not ActiveRecord Extensions.
+  #
+  describe 'ActiveRecord Extensions' do
+    before(:each) do
+      @view_model.extend ViewModels::Extensions::ActiveRecord
+    end
+    it 'should delegate the id' do
+      @view_model.id.should == :some_id
+    end
+    # it 'should delegate the id' do
+    #   @view_model.dom_id.should == 'sub_subclass_some_id'
+    # end
+  end
+  
+  describe 'view_model_for' do
+    context 'view model' do
+      it 'should be available' do
+        lambda { @view_model.view_model_for @model }.should_not raise_error
+      end
+      it 'should return the right one' do
+        @view_model.view_model_for(@model).should be_kind_of(ViewModels::SubSubclass)
+      end
+    end
+  end
+  describe 'view_model_class_for' do
+    context 'view model' do
+      it 'should be available' do
+        lambda { @view_model.view_model_class_for @model }.should_not raise_error
+      end
+      it 'should return the right class' do
+        @view_model.view_model_class_for(@model).should == ViewModels::SubSubclass
+      end
+    end
+  end
+  
+  # describe 'capture in view model method' do
+  #   context 'template' do
+  #     it 'should capture the content of the block' do
+  #       @view_model.render_as(:capture_in_template).should == 'Capturing: A Pirate!'
+  #     end
+  #   end
+  #   context 'in view model' do
+  #     it 'should capture the content of the block' do
+  #       @view_model.render_as(:capture_in_view_model).should == 'Capturing: A Pirate!'
+  #     end
+  #   end
+  # end
+  
+  # TODO Write similar.
+  # describe 'app context' do
+  #   it 'should work' do
+  #     controller = ActionController::Base.new
+  #     
+  #     lambda {
+  #       ViewModels::SubSubclass.new @model, controller
+  #     }.should_not raise_error
+  #   end
+  # end
+  
+  # TODO Write anew.
+  # describe 'view_model_for inclusion in view' do
+  #   it 'should be included' do
+  #     view = ActionView::Base.new
+  #     
+  #     lambda {
+  #       view.view_model_for @model
+  #     }.should_not raise_error
+  #   end
+  # end
+  
+  describe 'collection rendering' do
+    context 'default format' do
+      it 'should render a html list' do
+        @view_model.render_as(:list_example).should == "\n\n<ol class=\"collection\"><li>_list_item.html.erb</li><li>_list_item.html.erb</li></ol>"
+      end
+      it 'should render a html collection' do
+        @view_model.render_as(:collection_example).should == "\n\n<ul class=\"collection\"><li>_collection_item.html.erb</li><li>_collection_item.html.erb</li></ul>"
+      end
+    end
+    context 'format html' do
+      it 'should render a html list' do
+        @view_model.render_as(:list_example, :format => :html).should == "\n\n<ol class=\"collection\"><li>_list_item.html.erb</li><li>_list_item.html.erb</li></ol>"
+      end
+      it 'should render a html collection' do
+        @view_model.render_as(:collection_example, :format => :html).should == "\n\n<ul class=\"collection\"><li>_collection_item.html.erb</li><li>_collection_item.html.erb</li></ul>"
+      end
+    end
+    context 'format text' do
+      it 'should render a text list' do
+        @view_model.render_as(:list_example, :format => :text).should == "\n\n_list_item.text.erb\\n_list_item.text.erb"
+      end
+      it 'should render a text collection' do
+        @view_model.render_as(:collection_example, :format => :text).should == "\n\n_collection_item.text.erb_collection_item.text.erb"
+      end
+    end
+  end
+  
+  describe 'model attributes' do
+    it 'should pass through unfiltered attributes' do
+      @view_model.some_untouched_attribute.should == :some_value
+    end
+    it 'should filter some attributes' do
+      @view_model.some_filtered_attribute.should == '%3Cscript%3Efilter+me%3C%2Fscript%3E'
+    end
+    it 'should filter some attributes multiple times' do
+      @view_model.some_doubly_doubled_attribute.should == 'blahblahblahblah'
+    end
+    it 'should filter some attributes multiple times correctly' do
+      @view_model.some_mangled_attribute.should == 'DCBDCB'
+    end
+  end
+  
+  describe 'app_method' do
+    it 'should delegate to the context' do
+      @view_model.logger.should == @logger
+    end
+  end
+  
+  describe "render_template" do
+    it "should render the right template" do
+      @view_model.render_template(:show).should == 'show.html.erb'
+    end
+    it "should render the right template with format" do
+      @view_model.render_template(:show, :format => :text).should == 'show.text.erb'
+    end
+  end
+  
+  describe 'render_as' do
+    describe 'render_the alias' do
+      it 'should also render' do
+        @view_model.render_the(:part_that_is_dependent_on_the_view_model).should == '_part_that_is_dependent_on_the_view_model.erb'
+      end
+    end
+    describe "explicit partial rendering" do
+      it "should render the right partial" do
+        # If one wants explicit template rendering, he needs to work more.
+        # Let's be opinionated here :)
+        #
+        @view_model.render_as(:partial => 'view_models/sub_subclass/inner', :format => :nesting).should == '_inner.nesting.erb'
+      end
+    end
+    describe "nesting" do
+      it "should render the right nested template, with an explicitly defined format (see template)" do
+        @view_model.render_as(:outer, :format => :explicit).should == '_inner.also_explicit.erb'
+      end
+      it "should render the right nested template, respecting the already defined format" do
+        @view_model.render_as(:outer, :format => :nesting).should == '_inner.nesting.erb'
+      end
+    end
+    describe 'template inheritance' do
+      it 'should raise ViewModels::MissingTemplateError if template is not found' do
+        lambda { @view_model.render_as(:this_template_does_not_exist_at_allllll) }.should raise_error(ViewModels::MissingTemplateError, "No template '_this_template_does_not_exist_at_allllll' with default format found.")
+      end
+      it 'should raise ViewModels::MissingTemplateError if template is not found, with specific path' do
+        lambda { @view_model.render_as(:partial => 'view_models/sub_subclass/this_template_does_not_exist_at_allllll') }.should raise_error(ViewModels::MissingTemplateError, "No template 'view_models/sub_subclass/_this_template_does_not_exist_at_allllll' with default format found.")
+      end
+      it 'should raise ViewModels::MissingTemplateError if template is not found, with format' do
+        lambda { @view_model.render_as(:this_template_does_not_exist_at_allllll, :format => :gaga) }.should raise_error(ViewModels::MissingTemplateError, "No template '_this_template_does_not_exist_at_allllll' with format gaga found.")
+      end
+      it "should use its own template" do
+        @view_model.render_as(:exists).should == '_exists.html.erb' # The default
+      end
+      it "should use the subclass' template" do
+        @view_model.render_as(:no_sub_subclass).should == '_no_sub_subclass.erb'
+      end
+    end
+    describe 'format' do
+      it 'should render html' do
+        @view_model.render_as(:exists, :format => nil).should == '_exists.html.erb' # the default
+      end
+      it 'should render erb' do
+        @view_model.render_as(:exists, :format => '').should == '_exists.erb'
+      end
+      it 'should render text' do
+        @view_model.render_as(:exists, :format => :text).should == '_exists.text.erb'
+      end
+      it 'should render html' do
+        @view_model.render_as(:exists, :format => :html).should == '_exists.html.erb'
+      end
+    end
+    describe 'locals' do
+      it 'should render html' do
+        @view_model.render_as(:exists, :locals => { :local_name => :some_local }).should == '_exists.html.erb with some_local'
+      end
+      it 'should render html' do
+        @view_model.render_as(:exists, :format => nil, :locals => { :local_name => :some_local }).should == '_exists.html.erb with some_local'
+      end
+      it 'should render text' do
+        @view_model.render_as(:exists, :format => '', :locals => { :local_name => :some_local }).should == '_exists.erb with some_local'
+      end
+      it 'should render text' do
+        @view_model.render_as(:exists, :format => :text, :locals => { :local_name => :some_local }).should == '_exists.text.erb with some_local'
+      end
+      it 'should render html' do
+        @view_model.render_as(:exists, :format => :html, :locals => { :local_name => :some_local }).should == '_exists.html.erb with some_local'
+      end
+    end
+    describe 'memoizing' do
+      it 'should memoize and not generate always a new path' do
+        @view_model.class.should_receive(:generate_template_path_from).once.and_return "view_models/sub_subclass/_not_found_in_sub_subclass"
+        
+        @view_model.render_as :not_found_in_sub_subclass
+        @view_model.render_as :not_found_in_sub_subclass
+        @view_model.render_as :not_found_in_sub_subclass
+        @view_model.render_as :not_found_in_sub_subclass
+        @view_model.render_as :not_found_in_sub_subclass
+      end
+      it 'should render the right one' do
+        @view_model.render_as :exists_in_both
+        @view_model.render_as(:exists_in_both).should == 'in sub subclass'
+        
+        other_view_model = ViewModels::Subclass.new Subclass.new, @context
+        other_view_model.render_as :exists_in_both
+        other_view_model.render_as(:exists_in_both).should == 'in subclass'
+        
+        @view_model.render_as :exists_in_both
+        @view_model.render_as(:exists_in_both).should == 'in sub subclass'
+      end
+    end
+  end
+  
+end

data/spec/padrino/lib/helpers/collection_spec.rb

@@ -0,0 +1,30 @@
+require File.join(File.dirname(__FILE__), '../../spec_helper')
+
+describe ViewModels::Helpers::Mapping::Collection do
+  include ViewModels::Helpers::Mapping
+  
+  before(:each) do
+    @collection = stub :collection
+    @context    = stub :context
+    @collection_view_model = ViewModels::Helpers::Mapping::Collection.new @collection, @context
+  end
+  
+  describe "render_partial" do
+    it "should call instance eval on the context" do
+      @context.should_receive(:instance_eval).once
+      
+      @collection_view_model.send :render_partial, :some_name, :some_params
+    end
+    it "should render the partial in the 'context' context" do
+      @context.should_receive(:render).once
+      
+      @collection_view_model.send :render_partial, :some_name, :some_params
+    end
+    it "should call render partial on context with the passed through parameters" do
+      @context.should_receive(:render).once.with('view_models/collection/_some_name', :locals => { :a => :b })
+      
+      @collection_view_model.send :render_partial, :some_name, { :a => :b }
+    end
+  end
+  
+end

data/spec/rails2/integration/integration_spec.rb

@@ -0,0 +1,279 @@
+this = File.dirname(__FILE__)
+
+require File.join(this, '/../spec_helper')
+
+require File.join(this, 'models/subclass')
+require File.join(this, 'models/sub_subclass')
+
+require File.join(this, 'view_models/project')
+require File.join(this, 'view_models/subclass')
+require File.join(this, 'view_models/sub_subclass')
+require File.join(this, 'view_models/module_for_rendering')
+
+require 'action_controller'
+require 'action_controller/test_process'
+
+class TestController < ActionController::Base; end
+
+ActionView::Base.send :include, ViewModels::Helpers::Mapping
+
+describe 'Integration' do
+  
+  before(:each) do
+    begin
+      @controller          = TestController.new
+      @controller.class.view_paths = ['spec/rails2/integration/views']
+      
+      @logger              = stub :logger, :null_object => true
+      @controller.logger   = @logger
+      
+      @request             = ActionController::TestRequest.new
+      @response            = ActionController::TestResponse.new
+      @controller.request  = @request
+      @controller.response = @response
+      
+      # TODO Make separate contexts, one where the controller has rendered, one where it has not.
+      #
+      # Let the Controller generate a view instance.
+      #
+      # @controller.process @request, @response
+      
+      @view                = ActionView::Base.new @controller.class.view_paths, {}, @controller
+      @model               = SubSubclass.new
+      @model.id            = :some_id
+      @view_model          = ViewModels::SubSubclass.new @model, @view
+    end
+  end
+  
+  before(:all) { puts "\n#{self.send(:description_args)[0]}:" }
+  
+  # context 'experimental inclusion of module in render hierarchy' do
+  #   before(:each) do
+  #     ViewModels::Base.send :include, ModulesInRenderHierarchy
+  #     @view_model.class.send :include, ModuleForRendering
+  #   end
+  #   describe 'render_as' do
+  #     it 'should description' do
+  #       @view_model.render_as(:not_found_in_sub_subclass_but_in_module).should == '_not_found_in_sub_subclass_but_in_module.erb'
+  #     end
+  #   end
+  # end
+
+  describe 'ActiveRecord Extensions' do
+    before(:each) do
+      @view_model.extend ViewModels::Extensions::ActiveRecord
+    end
+    it 'should delegate the id' do
+      @view_model.id.should == :some_id
+    end
+    it 'should delegate the id' do
+      @view_model.dom_id.should == 'sub_subclass_some_id'
+    end
+  end
+  
+  describe 'view_model_for' do
+    context 'view model' do
+      it 'should be available' do
+        lambda { @view_model.view_model_for @model }.should_not raise_error
+      end
+      it 'should return the right one' do
+        @view_model.view_model_for(@model).should be_kind_of(ViewModels::SubSubclass)
+      end
+    end
+  end
+  describe 'view_model_class_for' do
+    context 'view model' do
+      it 'should be available' do
+        lambda { @view_model.view_model_class_for @model }.should_not raise_error
+      end
+      it 'should return the right class' do
+        @view_model.view_model_class_for(@model).should == ViewModels::SubSubclass
+      end
+    end
+  end
+  
+  describe 'capture in view model method' do
+    context 'template' do
+      it 'should capture the content of the block' do
+        @view_model.render_as(:capture_in_template).should == 'Capturing: A Pirate!'
+      end
+    end
+    context 'in view model' do
+      it 'should capture the content of the block' do
+        @view_model.render_as(:capture_in_view_model).should == 'Capturing: A Pirate!'
+      end
+    end
+  end
+  
+  describe 'controller context' do
+    it 'should work' do
+      controller = ActionController::Base.new
+      
+      lambda {
+        ViewModels::SubSubclass.new @model, controller
+      }.should_not raise_error
+    end
+  end
+  
+  describe 'view_model_for inclusion in view' do
+    it 'should be included' do
+      view = ActionView::Base.new
+      
+      lambda {
+        view.view_model_for @model
+      }.should_not raise_error
+    end
+  end
+  
+  describe 'collection rendering' do
+    context 'default format' do
+      it 'should render a html list' do
+        @view_model.render_as(:list_example).should == "<ol class=\"collection\"><li>_list_item.html.erb</li><li>_list_item.html.erb</li></ol>"
+      end
+      it 'should render a html collection' do
+        @view_model.render_as(:collection_example).should == "<ul class=\"collection\"><li>_collection_item.html.erb</li><li>_collection_item.html.erb</li></ul>"
+      end
+    end
+    context 'format html' do
+      it 'should render a html list' do
+        @view_model.render_as(:list_example, :format => :html).should == "<ol class=\"collection\"><li>_list_item.html.erb</li><li>_list_item.html.erb</li></ol>"
+      end
+      it 'should render a html collection' do
+        @view_model.render_as(:collection_example, :format => :html).should == "<ul class=\"collection\"><li>_collection_item.html.erb</li><li>_collection_item.html.erb</li></ul>"
+      end
+    end
+    context 'format text' do
+      it 'should render a text list' do
+        @view_model.render_as(:list_example, :format => :text).should == '_list_item.text.erb\n_list_item.text.erb'
+      end
+      it 'should render a text collection' do
+        @view_model.render_as(:collection_example, :format => :text).should == '_collection_item.text.erb_collection_item.text.erb'
+      end
+    end
+  end
+  
+  describe 'model attributes' do
+    it 'should pass through unfiltered attributes' do
+      @view_model.some_untouched_attribute.should == :some_value
+    end
+    it 'should filter some attributes' do
+      @view_model.some_filtered_attribute.should == '%3Cscript%3Efilter+me%3C%2Fscript%3E'
+    end
+    it 'should filter some attributes multiple times' do
+      @view_model.some_doubly_doubled_attribute.should == 'blahblahblahblah'
+    end
+    it 'should filter some attributes multiple times correctly' do
+      @view_model.some_mangled_attribute.should == 'DCBDCB'
+    end
+  end
+  
+  describe 'controller_method' do
+    it 'should delegate to the context' do
+      @view_model.logger.should == @logger
+    end
+  end
+  
+  describe "render_template" do
+    it "should render the right template" do
+      @view_model.render_template(:show).should == 'show.html.erb'
+    end
+    it "should render the right template with format" do
+      @view_model.render_template(:show, :format => :text).should == 'show.text.erb'
+    end
+  end
+  
+  describe 'render_as' do
+    describe 'render_the alias' do
+      it 'should also render' do
+        @view_model.render_the(:part_that_is_dependent_on_the_view_model).should == '_part_that_is_dependent_on_the_view_model.erb'
+      end
+    end
+    describe "explicit partial rendering" do
+      it "should render the right partial" do
+        # If one wants explicit template rendering, he needs to work more.
+        # Let's be opinionated here :)
+        #
+        @view_model.render_as(:partial => 'view_models/sub_subclass/inner', :format => :nesting).should == '_inner.nesting.erb'
+      end
+    end
+    describe "nesting" do
+      it "should render the right nested template, with an explicitly defined format (see template)" do
+        @view_model.render_as(:outer, :format => :explicit).should == '_inner.also_explicit.erb'
+      end
+      it "should render the right nested template, respecting the already defined format" do
+        @view_model.render_as(:outer, :format => :nesting).should == '_inner.nesting.erb'
+      end
+    end
+    describe 'template inheritance' do
+      it 'should raise ViewModels::MissingTemplateError if template is not found' do
+        lambda { @view_model.render_as(:this_template_does_not_exist_at_allllll) }.should raise_error(ViewModels::MissingTemplateError, "No template '_this_template_does_not_exist_at_allllll' with default format found.")
+      end
+      it 'should raise ViewModels::MissingTemplateError if template is not found, with specific path' do
+        lambda { @view_model.render_as(:partial => 'view_models/sub_subclass/this_template_does_not_exist_at_allllll') }.should raise_error(ViewModels::MissingTemplateError, "No template 'view_models/sub_subclass/_this_template_does_not_exist_at_allllll' with default format found.")
+      end
+      it 'should raise ViewModels::MissingTemplateError if template is not found, with format' do
+        lambda { @view_model.render_as(:this_template_does_not_exist_at_allllll, :format => :gaga) }.should raise_error(ViewModels::MissingTemplateError, "No template '_this_template_does_not_exist_at_allllll' with format gaga found.")
+      end
+      it "should use its own template" do
+        @view_model.render_as(:exists).should == '_exists.html.erb' # The default
+      end
+      it "should use the subclass' template" do
+        @view_model.render_as(:no_sub_subclass).should == '_no_sub_subclass.erb'
+      end
+    end
+    describe 'format' do
+      it 'should render html' do
+        @view_model.render_as(:exists, :format => nil).should == '_exists.html.erb' # the default
+      end
+      it 'should render erb' do
+        @view_model.render_as(:exists, :format => '').should == '_exists.erb'
+      end
+      it 'should render text' do
+        @view_model.render_as(:exists, :format => :text).should == '_exists.text.erb'
+      end
+      it 'should render html' do
+        @view_model.render_as(:exists, :format => :html).should == '_exists.html.erb'
+      end
+    end
+    describe 'locals' do
+      it 'should render html' do
+        @view_model.render_as(:exists, :locals => { :local_name => :some_local }).should == '_exists.html.erb with some_local'
+      end
+      it 'should render html' do
+        @view_model.render_as(:exists, :format => nil, :locals => { :local_name => :some_local }).should == '_exists.html.erb with some_local'
+      end
+      it 'should render text' do
+        @view_model.render_as(:exists, :format => '', :locals => { :local_name => :some_local }).should == '_exists.erb with some_local'
+      end
+      it 'should render text' do
+        @view_model.render_as(:exists, :format => :text, :locals => { :local_name => :some_local }).should == '_exists.text.erb with some_local'
+      end
+      it 'should render html' do
+        @view_model.render_as(:exists, :format => :html, :locals => { :local_name => :some_local }).should == '_exists.html.erb with some_local'
+      end
+    end
+    describe 'memoizing' do
+      it 'should memoize and not generate always a new path' do
+        @view_model.class.should_receive(:generate_template_path_from).once.and_return "view_models/sub_subclass/_not_found_in_sub_subclass"
+        
+        @view_model.render_as :not_found_in_sub_subclass
+        @view_model.render_as :not_found_in_sub_subclass
+        @view_model.render_as :not_found_in_sub_subclass
+        @view_model.render_as :not_found_in_sub_subclass
+        @view_model.render_as :not_found_in_sub_subclass
+      end
+      it 'should render the right one' do
+        @view_model.render_as :exists_in_both
+        @view_model.render_as(:exists_in_both).should == 'in sub subclass'
+        
+        other_view_model = ViewModels::Subclass.new Subclass.new, @view
+        other_view_model.render_as :exists_in_both
+        other_view_model.render_as(:exists_in_both).should == 'in subclass'
+        
+        @view_model.render_as :exists_in_both
+        @view_model.render_as(:exists_in_both).should == 'in sub subclass'
+      end
+    end
+  end
+  
+end

data/spec/rails2/lib/extensions/active_record_spec.rb

@@ -0,0 +1,31 @@
+require File.join(File.dirname(__FILE__), '/../../spec_helper')
+
+describe ViewModels::Extensions::ActiveRecord do
+  
+  describe "to_param" do
+    before(:each) do
+      @model      = stub :model
+      @view_model = ViewModels::Base.new @model, nil
+      @view_model.extend ViewModels::Extensions::ActiveRecord
+    end
+    it "should delegate to_param to the model" do
+      @model.should_receive(:to_param).once
+      
+      @view_model.to_param
+    end
+    
+    it "should delegate id to the model" do
+      @model.should_receive(:id).once
+      
+      @view_model.id
+    end
+    
+    it "should delegate dom_id to ActionController::RecordIdentifier" do
+      ActionController::RecordIdentifier.should_receive(:dom_id).once
+      
+      @view_model.dom_id
+    end
+    
+  end
+  
+end

data/spec/rails2/lib/extensions/model_reader_spec.rb

@@ -0,0 +1,91 @@
+require File.join(File.dirname(__FILE__), '/../../spec_helper')
+
+describe ViewModels::Extensions::ModelReader do
+
+  class ModelReaderModel < Struct.new(:some_model_value); end
+  
+  describe ".model_reader" do
+    before(:each) do
+      @model = ModelReaderModel.new
+      @view_model = ViewModels::Base.new(@model, nil)
+      class << @view_model
+        def a(s); s << 'a' end
+        def b(s); s << 'b' end
+      end
+      @model.some_model_value = 's'
+    end
+    it "should call filters in a given pattern" do
+      @view_model.class.model_reader :some_model_value, :filter_through => [:a, :b, :a, :a]
+    
+      @view_model.some_model_value.should == 'sabaa'
+    end
+    it "should pass through the model value if no filters are installed" do
+      @view_model.class.model_reader :some_model_value
+    
+      @view_model.some_model_value.should == 's'
+    end
+    it "should call filters in a given pattern" do
+      @view_model.class.model_reader [:some_model_value], :filter_through => [:a, :b, :a, :a]
+    
+      @view_model.some_model_value.should == 'sabaa'
+    end
+    it "should handle a single filter" do
+      @view_model.class.model_reader :some_model_value, :filter_through => :a
+    
+      lambda { @view_model.some_model_value }.should_not raise_error
+    end
+    it "should handle an array of readers" do
+      @view_model.class.model_reader [:some_model_value, :some_other_model_value], :filter_through => :a
+    
+      lambda { @view_model.some_model_value }.should_not raise_error
+    end
+  end
+  
+  describe 'FilteredDelegationInstaller' do
+    before(:each) do
+      @model = ModelReaderModel.new
+    end
+    context 'with filters' do
+      before(:each) do
+        @options = ViewModels::Extensions::ModelReader::Options.new :some_attribute_name, :filter_through => [:filter1, :filter2]
+        @installer = ViewModels::Extensions::ModelReader::FilteredDelegationInstaller.new @model, @options
+      end
+      it 'should have a correct filter definition' do
+        @installer.reader_definition_for(:some_attribute).should == 'def some_attribute; filter2(filter1(model.some_attribute)); end'
+      end
+    end
+    context 'without filters' do
+      before(:each) do
+        @options = ViewModels::Extensions::ModelReader::Options.new :some_attribute_name
+        @installer = ViewModels::Extensions::ModelReader::FilteredDelegationInstaller.new @model, @options
+      end
+      it 'should have a correct filter definition' do
+        @installer.reader_definition_for(:some_attribute).should == 'def some_attribute; model.some_attribute; end'
+      end
+    end
+  end
+  
+  describe 'Options' do
+    context 'without filters' do
+      before(:each) do
+        @options = ViewModels::Extensions::ModelReader::Options.new :some_attribute_name
+      end
+      describe 'split' do
+        it 'should return the right values' do
+          @options.to_a.should == [[:some_attribute_name], []]
+        end
+      end
+    end
+    context 'with filters' do
+      before(:each) do
+        @options = ViewModels::Extensions::ModelReader::Options.new :some_attribute_name, :filter_through => [:filter1, :filter2]
+      end
+      describe 'split' do
+        it 'should return the right values, with flipped options' do
+          @options.to_a.should == [[:some_attribute_name], [:filter2, :filter1]]
+        end
+      end
+    end
+  end
+  
+end

data/spec/rails2/lib/helpers/collection_spec.rb

@@ -0,0 +1,30 @@
+require File.join(File.dirname(__FILE__), '/../../spec_helper')
+
+describe ViewModels::Helpers::Mapping::Collection do
+  include ViewModels::Helpers::Mapping
+  
+  before(:each) do
+    @collection = stub :collection
+    @context    = stub :context
+    @collection_view_model = ViewModels::Helpers::Mapping::Collection.new @collection, @context
+  end
+  
+  describe "render_partial" do
+    it "should call instance eval on the context" do
+      @context.should_receive(:instance_eval).once
+      
+      @collection_view_model.send :render_partial, :some_name, :some_params
+    end
+    it "should render the partial in the 'context' context" do
+      @context.should_receive(:render).once
+      
+      @collection_view_model.send :render_partial, :some_name, :some_params
+    end
+    it "should call render partial on context with the passed through parameters" do
+      @context.should_receive(:render).once.with(:partial => 'view_models/collection/some_name', :locals => { :a => :b })
+      
+      @collection_view_model.send :render_partial, :some_name, { :a => :b }
+    end
+  end
+  
+end

data/spec/rails2/lib/helpers/view_spec.rb

@@ -0,0 +1,18 @@
+require File.join(File.dirname(__FILE__), '/../../spec_helper')
+
+describe ViewModels::Helpers::View do
+  
+  class TestClass < ActionView::Base; end
+  
+  describe "including it" do
+    it "should include all the view helpers" do
+      in_the TestClass do
+        include ViewModels::Helpers::View
+      end
+      
+      TestClass.should include(ActionView::Helpers)
+      TestClass.should include(ERB::Util)
+    end
+  end
+
+end

data/spec/rails2/lib/view_models/base_spec.rb

@@ -0,0 +1,109 @@
+require File.join(File.dirname(__FILE__), '/../../spec_helper')
+
+describe ViewModels::Base do
+  
+  describe "readers" do
+    describe "model" do
+      before(:each) do
+        @model      = stub :model
+        @view_model = ViewModels::Base.new @model, nil
+      end
+      it "should have a reader" do
+        in_the @view_model do
+          model.should == @model
+        end
+      end
+    end
+    describe "controller" do
+      before(:each) do
+        @context    = stub :controller
+        @view_model = ViewModels::Base.new nil, @context
+      end
+      it "should have a reader" do
+        in_the @view_model do
+          controller.should == @context
+        end
+      end
+    end
+  end
+  
+  describe "context recognition" do
+    describe "context is a view" do
+      before(:each) do
+        @view = stub :view, :controller => 'controller'
+        @view_model = ViewModels::Base.new nil, @view
+      end
+      it "should get the controller from the view" do
+        in_the @view_model do
+          controller.should == 'controller'
+        end
+      end
+    end
+    describe "context is a controller" do
+      before(:each) do
+        @controller = stub :controller
+        @view_model = ViewModels::Base.new nil, @controller
+      end
+      it "should just use it for the controller" do
+        expected = @controller
+        in_the @view_model do
+          controller.should == expected
+        end
+      end
+    end
+  end
+  
+  describe ".master_helper_module" do
+    before(:each) do
+      class ViewModels::SpecificMasterHelperModule < ViewModels::Base; end
+    end
+    it "should be a class specific inheritable accessor" do
+      ViewModels::SpecificMasterHelperModule.master_helper_module = :some_value
+      ViewModels::SpecificMasterHelperModule.master_helper_module.should == :some_value
+    end
+    it "should be an instance of Module on Base" do
+      ViewModels::Base.master_helper_module.should be_instance_of(Module)
+    end
+  end
+  
+  describe ".controller_method" do
+    it "should set up delegate calls to the context/controller" do
+      ViewModels::Base.should_receive(:delegate).once.with(:method1, :method2, :to => :context)
+      
+      ViewModels::Base.controller_method :method1, :method2
+    end
+  end
+  
+  describe ".helper" do
+    it "should include the helper" do
+      helper_module = Module.new
+      
+      ViewModels::Base.should_receive(:include).once.with helper_module
+      
+      ViewModels::Base.helper helper_module
+    end
+    it "should include the helper in the master helper module" do
+      master_helper_module = Module.new
+      ViewModels::Base.should_receive(:master_helper_module).and_return master_helper_module
+      
+      helper_module = Module.new
+      master_helper_module.should_receive(:include).once.with helper_module
+      
+      ViewModels::Base.helper helper_module
+    end
+  end
+  
+  describe "#logger" do
+    it "should delegate to the controller" do
+      controller = stub :controller
+      view_model = ViewModels::Base.new nil, controller
+      
+      controller.should_receive(:logger).once
+      
+      in_the view_model do
+        logger
+      end
+    end
+  end
+  
+end

data/spec/rails2/lib/view_models/view_spec.rb

@@ -0,0 +1,12 @@
+require File.join(File.dirname(__FILE__), '/../../spec_helper')
+
+describe ViewModels::View do
+  
+  it "should be initializable" do
+    controller_class = stub :controller_class, :view_paths => ActionView::PathSet.new
+    controller       = stub :controller, :class => controller_class
+    
+    ViewModels::View.new controller, Module.new
+  end
+  
+end

data/spec/shared/lib/helpers/collection_spec.rb

@@ -0,0 +1,191 @@
+require File.join(File.dirname(__FILE__), '../../spec_helper')
+
+describe ViewModels::Helpers::Mapping::Collection do
+  include ViewModels::Helpers::Mapping
+  
+  before(:each) do
+    @collection = stub :collection
+    @context    = stub :context
+    @collection_view_model = ViewModels::Helpers::Mapping::Collection.new @collection, @context
+  end
+  
+  describe "collection_view_model_for" do
+    it "should return kind of a ViewModels::Collection" do
+      collection_view_model_for([]).should be_kind_of ViewModels::Helpers::Mapping::Collection
+    end
+    it "should pass any parameters directly through" do
+      collection = stub :collection
+      context = stub :context
+      ViewModels::Helpers::Mapping::Collection.should_receive(:new).with(collection, context).once
+      collection_view_model_for collection, context
+    end
+  end
+  
+  describe "list" do
+    it "should call render_partial and return the rendered result" do
+      @collection_view_model.stub! :render_partial => :result
+      
+      @collection_view_model.list.should == :result
+    end
+    it "should call render_partial with the right parameters" do
+      default_options = {
+        :collection => @collection,
+        :template_name => :list_item,
+        :separator => nil
+      }
+      
+      @collection_view_model.should_receive(:render_partial).once.with :list, default_options
+      
+      @collection_view_model.list
+    end
+    it "should override the default options if specific options are given" do
+      specific_options = {
+        :collection => :a,
+        :template_name => :c,
+        :separator => :d
+      }
+      
+      @collection_view_model.should_receive(:render_partial).once.with :list, specific_options
+      
+      @collection_view_model.list specific_options
+    end
+  end
+  
+  describe "collection" do
+    it "should call render_partial and return the rendered result" do
+      @collection_view_model.stub! :render_partial => :result
+      
+      @collection_view_model.collection.should == :result
+    end
+    it "should call render_partial with the right parameters" do
+      default_options = {
+        :collection => @collection,
+        :template_name => :collection_item,
+        :separator => nil
+      }
+      @collection_view_model.should_receive(:render_partial).once.with :collection, default_options
+      
+      @collection_view_model.collection
+    end
+    it "should override the default options if specific options are given" do
+      specific_options = {
+        :collection => :a,
+        :template_name => :c,
+        :separator => :d
+      }
+      
+      @collection_view_model.should_receive(:render_partial).once.with :collection, specific_options
+      
+      @collection_view_model.collection specific_options
+    end
+  end
+  
+  describe "table" do
+    it "should call render_partial and return the rendered result" do
+      @collection_view_model.stub! :render_partial => :result
+      
+      @collection_view_model.table.should == :result
+    end
+    it "should call render_partial with the right parameters" do
+      default_options = {
+        :collection => @collection,
+        :template_name => :table_row,
+        :separator => nil
+      }
+      
+      @collection_view_model.should_receive(:render_partial).once.with :table, default_options
+      
+      @collection_view_model.table
+    end
+    it "should override the default options if specific options are given" do
+      specific_options = {
+        :collection => :a,
+        :template_name => :c,
+        :separator => :d
+      }
+      
+      @collection_view_model.should_receive(:render_partial).once.with :table, specific_options
+      
+      @collection_view_model.table(specific_options)
+    end
+  end
+  
+  describe "pagination" do
+    it "should call render_partial and return the rendered result" do
+      @collection_view_model.stub! :render_partial => :result
+      
+      @collection_view_model.pagination.should == :result
+    end
+    it "should call render_partial with the right parameters" do
+      default_options = {
+        :collection => @collection,
+        :separator => '|'
+      }
+      @collection_view_model.should_receive(:render_partial).once.with :pagination, default_options
+      
+      @collection_view_model.pagination
+    end
+    it "should override the default options if specific options are given" do
+      specific_options = {
+        :collection => :a,
+        :separator => :c
+      }
+      @collection_view_model.should_receive(:render_partial).once.with :pagination, specific_options
+      
+      @collection_view_model.pagination specific_options
+    end
+  end
+  
+  describe "delegation" do
+    describe "enumerable" do
+      Enumerable.instance_methods.map(&:to_sym).each do |method|
+        it "should delegate #{method} to the collection" do
+          @collection.should_receive(method).once
+          
+          @collection_view_model.send method
+        end
+      end
+    end
+    describe "array" do
+      describe "length" do
+        it "should delegate to #length of the collection" do
+          @collection.should_receive(:length).once
+          
+          @collection_view_model.length
+        end
+        it "should return the length of the collection" do
+          @collection.should_receive(:length).and_return :this_length
+          
+          @collection_view_model.length.should == :this_length
+        end
+        it "should alias size" do
+          @collection.should_receive(:size).and_return :this_length
+          
+          @collection_view_model.size.should == :this_length
+        end
+      end
+      describe "empty?" do
+        it "should delegate to #empty? of the collection" do
+          @collection.should_receive(:empty?).once
+          
+          @collection_view_model.empty?
+        end
+        it "should return whatever #empty? of the collection returns" do
+          @collection.should_receive(:empty?).and_return :true_or_false
+          
+          @collection_view_model.empty?.should == :true_or_false
+        end
+      end
+      describe "each" do
+        it "should delegate to #each of the collection" do
+          proc = stub :proc
+          
+          @collection.should_receive(:each).with(proc).once
+          
+          @collection_view_model.each proc
+        end
+      end
+    end
+  end
+  
+end

data/spec/shared/lib/helpers/mapping_spec.rb

@@ -0,0 +1,72 @@
+require File.join(File.dirname(__FILE__), '../../spec_helper')
+
+describe ViewModels::Helpers::Mapping do
+  include ViewModels::Helpers::Mapping
+  
+  describe "view_model_for" do
+    it "should just pass the params through to the view_model" do
+      class SomeModelClazz; end
+      class ViewModels::SomeModelClazz < ViewModels::Base; end
+      context = stub :context
+      self.stub! :default_view_model_class_for => ViewModels::SomeModelClazz
+      model = SomeModelClazz.new
+      
+      ViewModels::SomeModelClazz.should_receive(:new).once.with model, context
+      
+      view_model_for model, context
+    end
+    describe "specific_view_model_mapping" do
+      it "should return an empty hash by default" do
+        specific_view_model_mapping.should == {}
+      end
+      it "should raise an ArgumentError on an non-mapped model" do
+        class SomeViewModelClass; end
+        specific_view_model_mapping[String] = SomeViewModelClass
+        lambda {
+          view_model_for("Some String")
+        }.should raise_error(ArgumentError, "wrong number of arguments (2 for 0)")
+      end
+    end
+    describe "no specific mapping" do
+      it "should raise on an non-mapped model" do
+        lambda {
+          view_model_for(42)
+        }.should raise_error(NameError, "uninitialized constant ViewModels::Fixnum")
+      end
+      it "should return a default view_model instance" do
+        class SomeModelClazz; end
+        class ViewModels::SomeModelClazz < ViewModels::Base; end
+        view_model_for(SomeModelClazz.new).should be_instance_of ViewModels::SomeModelClazz
+      end
+    end
+    describe "with specific mapping" do
+      class SomeModelClazz; end
+      class ViewModels::SomeSpecificClazz < ViewModels::Base; end
+      before(:each) do
+        self.should_receive(:specific_view_model_mapping).any_number_of_times.and_return SomeModelClazz => ViewModels::SomeSpecificClazz
+      end
+      it "should return a specifically mapped view_model instance" do
+        view_model_for(SomeModelClazz.new).should be_instance_of ViewModels::SomeSpecificClazz
+      end
+      it "should not call #default_view_model_class_for" do
+        mock(self).should_receive(:default_view_model_class_for).never
+        view_model_for SomeModelClazz.new
+      end
+    end
+  end
+  
+  describe "default_view_model_class_for" do
+    it "should return a class with ViewModels:: prepended" do
+      class Gaga; end # The model.
+      class ViewModels::Gaga < ViewModels::Base; end
+      default_view_model_class_for(Gaga.new).should == ViewModels::Gaga
+    end
+    it "should raise a NameError if the Presenter class does not exist" do
+      class Brrzt; end # Just the model.
+      lambda {
+        default_view_model_class_for(Brrzt.new)
+      }.should raise_error(NameError, "uninitialized constant ViewModels::Brrzt")
+    end
+  end
+  
+end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: view_models
 version: !ruby/object:Gem::Version 
-  hash: 15
-  prerelease: false
+  hash: 13
+  prerelease: 
   segments: 
   - 2
   - 0
-  - 0
-  version: 2.0.0
+  - 1
+  version: 2.0.1
 platform: ruby
 authors: 
 - Florian Hanke
@@ -18,7 +18,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-07-20 00:00:00 +02:00
+date: 2011-04-10 00:00:00 +10:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -63,14 +63,23 @@ extra_rdoc_files: []
 
 files: 
 - lib/init.rb
-- lib/padrino/README.textile
+- lib/view_models.rb
+- lib/shared/init.rb
+- lib/shared/lib/view_models/base.rb
+- lib/shared/lib/view_models/context_extractor.rb
+- lib/shared/lib/view_models/extensions/active_record.rb
+- lib/shared/lib/view_models/extensions/model_reader.rb
+- lib/shared/lib/view_models/helpers/collection.rb
+- lib/shared/lib/view_models/helpers/mapping.rb
+- lib/shared/lib/view_models/path_store.rb
+- lib/shared/lib/view_models/render_options.rb
+- lib/shared/lib/view_models.rb
+- lib/shared/README.textile
 - lib/padrino/init.rb
 - lib/padrino/lib/helpers/collection.rb
 - lib/padrino/lib/padrino/view_models.rb
 - lib/padrino/lib/view_models/base.rb
-- lib/rails2/README.textile
-- lib/rails2/TODO.textile
-- lib/rails2/generators/view_models/USAGE
+- lib/padrino/README.textile
 - lib/rails2/generators/view_models/templates/README
 - lib/rails2/generators/view_models/templates/spec/view_model_spec.rb
 - lib/rails2/generators/view_models/templates/view_models/view_model.rb
@@ -84,28 +93,30 @@ files:
 - lib/rails2/generators/view_models/templates/views/view_models/collection/_pagination.text.erb
 - lib/rails2/generators/view_models/templates/views/view_models/collection/_table.html.haml
 - lib/rails2/generators/view_models/templates/views/view_models/collection/_table.text.erb
+- lib/rails2/generators/view_models/USAGE
 - lib/rails2/generators/view_models/view_models_generator.rb
 - lib/rails2/init.rb
-- lib/rails2/lib/experimental/README.textile
 - lib/rails2/lib/experimental/modules_in_render_hierarchy.rb
+- lib/rails2/lib/experimental/README.textile
 - lib/rails2/lib/extensions/view.rb
 - lib/rails2/lib/helpers/collection.rb
 - lib/rails2/lib/helpers/view.rb
-- lib/rails2/lib/view_models.rb
 - lib/rails2/lib/view_models/base.rb
 - lib/rails2/lib/view_models/view.rb
-- lib/shared/README.textile
-- lib/shared/init.rb
-- lib/shared/lib/view_models.rb
-- lib/shared/lib/view_models/base.rb
-- lib/shared/lib/view_models/context_extractor.rb
-- lib/shared/lib/view_models/extensions/active_record.rb
-- lib/shared/lib/view_models/extensions/model_reader.rb
-- lib/shared/lib/view_models/helpers/collection.rb
-- lib/shared/lib/view_models/helpers/mapping.rb
-- lib/shared/lib/view_models/path_store.rb
-- lib/shared/lib/view_models/render_options.rb
-- lib/view_models.rb
+- lib/rails2/lib/view_models.rb
+- lib/rails2/README.textile
+- lib/rails2/TODO.textile
+- spec/padrino/integration/integration_spec.rb
+- spec/padrino/lib/helpers/collection_spec.rb
+- spec/rails2/integration/integration_spec.rb
+- spec/rails2/lib/extensions/active_record_spec.rb
+- spec/rails2/lib/extensions/model_reader_spec.rb
+- spec/rails2/lib/helpers/collection_spec.rb
+- spec/rails2/lib/helpers/view_spec.rb
+- spec/rails2/lib/view_models/base_spec.rb
+- spec/rails2/lib/view_models/view_spec.rb
+- spec/shared/lib/helpers/collection_spec.rb
+- spec/shared/lib/helpers/mapping_spec.rb
 has_rdoc: true
 homepage: http://floere.github.com/view_models
 licenses: []
@@ -137,9 +148,19 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.3.7
+rubygems_version: 1.4.2
 signing_key: 
 specification_version: 3
 summary: A model proxy for Rails views. Helps you keep the representation of a model and the model itself separate.
-test_files: []
-
+test_files: 
+- spec/padrino/integration/integration_spec.rb
+- spec/padrino/lib/helpers/collection_spec.rb
+- spec/rails2/integration/integration_spec.rb
+- spec/rails2/lib/extensions/active_record_spec.rb
+- spec/rails2/lib/extensions/model_reader_spec.rb
+- spec/rails2/lib/helpers/collection_spec.rb
+- spec/rails2/lib/helpers/view_spec.rb
+- spec/rails2/lib/view_models/base_spec.rb
+- spec/rails2/lib/view_models/view_spec.rb
+- spec/shared/lib/helpers/collection_spec.rb
+- spec/shared/lib/helpers/mapping_spec.rb