view_component_storybook 0.6.0 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cc377c2ee4e53057d77622560164f181fcaca50a95e4fcfc53ad78a3cb10a2ba
-  data.tar.gz: b1137074ecbb7b5d44c38475774d06400b936f427dfec1bd1602fe4edb1696d7
+  metadata.gz: 4e8c8a3875d64fe89649af8851324d2a07bd40868065abce8b57cf848cbeb5d3
+  data.tar.gz: 554f43665400373ba30b9bc6e307285843b67d3760e5957e0088fa2ba53b325e
 SHA512:
-  metadata.gz: c8bbafc19737e00f631c0099affc6c616e327c4bfc60e9426fb74e55550701d915131f15d5d00d780dd3b6374c940edd17feebe24774c91e48db84accd46930d
-  data.tar.gz: 2d992393f87285d057bedaffd9be722cd8d147a38f543b2a1afdb9c92d73e6ce26546744941826cd91517c2d1f30e27f782d8090e07d420343241c1a5bb20c8d
+  metadata.gz: 398124fee399213bea34acf3aef434877eb01d0c76d9d6f127f5d5493981ecf5ac1f0ddc94ad9850354f6ec3629f1a9e5ca6005b57208abd39d045026415abbd
+  data.tar.gz: 31a4a06293f40d19e575243a61cb61e1cff2bd7646da950c01de20f8edd73d1179970a7700064a8ee15cbcd3a73b2060f525bdbf427baeaddc9f9bd9ee6b7ebe

data/lib/view_component/storybook/controls/array_config.rb

@@ -6,7 +6,7 @@ module ViewComponent
       class ArrayConfig < ControlConfig
         attr_reader :separator
 
-        validates :value, :separator, presence: true
+        validates :separator, presence: true
 
         def initialize(component, param, value, separator = ",", name: nil)
           super(component, param, value, name: name)

data/lib/view_component/storybook/controls/boolean_config.rb

@@ -6,7 +6,7 @@ module ViewComponent
       class BooleanConfig < ControlConfig
         BOOLEAN_VALUES = [true, false].freeze
 
-        validates :value, inclusion: { in: BOOLEAN_VALUES }
+        validates :value, inclusion: { in: BOOLEAN_VALUES }, unless: -> { value.nil? }
 
         def type
           :boolean

data/lib/view_component/storybook/controls/color_config.rb

@@ -5,7 +5,6 @@ module ViewComponent
     module Controls
       class ColorConfig < ControlConfig
         attr_reader :preset_colors
-        validates :value, presence: true
 
         def initialize(component, param, value, name: nil, preset_colors: nil)
           super(component, param, value, name: name)

data/lib/view_component/storybook/controls/control_config.rb

@@ -9,7 +9,7 @@ module ViewComponent
         attr_reader :component, :param, :value, :name
 
         validates :component, :param, presence: true
-        validates :param, inclusion: { in: ->(control_config) { control_config.component_params } }, unless: -> { component.nil? }
+        validates :param, inclusion: { in: ->(control_config) { control_config.component_param_names } }, if: :should_validate_params?
 
         def initialize(component, param, value, name: nil)
           @component = component
@@ -30,8 +30,8 @@ module ViewComponent
           param
         end
 
-        def component_params
-          @component_params ||= component && component.instance_method(:initialize).parameters.map(&:last)
+        def component_param_names
+          @component_param_names ||= component_params&.map(&:last)
         end
 
         private
@@ -44,6 +44,18 @@ module ViewComponent
         def csf_control_params
           { type: type }
         end
+
+        def component_accepts_kwargs?
+          component_params.map(&:first).include?(:keyrest)
+        end
+
+        def component_params
+          @component_params ||= component.instance_method(:initialize).parameters
+        end
+
+        def should_validate_params?
+          component.present? && !component_accepts_kwargs?
+        end
       end
     end
   end

data/lib/view_component/storybook/controls/date_config.rb

@@ -4,8 +4,6 @@ module ViewComponent
   module Storybook
     module Controls
       class DateConfig < ControlConfig
-        validates :value, presence: true
-
         def initialize(component, param, value, name: nil)
           super(component, param, value, name: name)
         end

data/lib/view_component/storybook/controls/number_config.rb

@@ -4,9 +4,12 @@ module ViewComponent
   module Storybook
     module Controls
       class NumberConfig < ControlConfig
+        TYPES = %i[number range].freeze
+
         attr_reader :type, :min, :max, :step
 
-        validates :value, :type, presence: true
+        validates :type, presence: true
+        validates :type, inclusion: { in: TYPES }, unless: -> { type.nil? }
 
         def initialize(type, component, param, value, min: nil, max: nil, step: nil, name: nil)
           super(component, param, value, name: name)

data/lib/view_component/storybook/controls/object_config.rb

@@ -4,15 +4,13 @@ module ViewComponent
   module Storybook
     module Controls
       class ObjectConfig < ControlConfig
-        validates :value, presence: true
-
         def type
           :object
         end
 
         def value_from_param(param)
           if param.is_a?(String)
-            JSON.parse(param).symbolize_keys
+            JSON.parse(param).deep_symbolize_keys
           else
             super(param)
           end

data/lib/view_component/storybook/controls/options_config.rb

@@ -4,7 +4,6 @@ module ViewComponent
   module Storybook
     module Controls
       class OptionsConfig < ControlConfig
-
         class << self
           # support the options being a Hash or an Array. Storybook supports either.
           def inclusion_in(config)
@@ -13,8 +12,6 @@ module ViewComponent
               config.options.values
             when Array
               config.options
-            else
-              []
             end
           end
         end
@@ -23,7 +20,7 @@ module ViewComponent
 
         attr_reader :type, :options, :symbol_value
 
-        validates :value, :type, :options, presence: true
+        validates :type, :options, presence: true
         validates :type, inclusion: { in: TYPES }, unless: -> { type.nil? }
         validates :value, inclusion: { in: method(:inclusion_in) }, unless: -> { options.nil? || value.nil? }
 

data/lib/view_component/storybook/controls/text_config.rb

@@ -4,8 +4,6 @@ module ViewComponent
   module Storybook
     module Controls
       class TextConfig < ControlConfig
-        validates :value, presence: true
-
         def type
           :text
         end

data/lib/view_component/storybook/dsl/controls_dsl.rb

@@ -67,7 +67,7 @@ module ViewComponent
           controls << Controls::DateConfig.new(component, param, value, name: name)
         end
 
-        def respond_to_missing?(_method)
+        def respond_to_missing?(_method, *)
           true
         end
 

data/lib/view_component/storybook/stories.rb

@@ -33,7 +33,7 @@ module ViewComponent
         end
 
         def write_csf_json
-          json_path = File.join(ViewComponent::Storybook.stories_path, "#{stories_name}.stories.json")
+          json_path = File.join(stories_path, "#{stories_name}.stories.json")
           File.open(json_path, "w") do |f|
             f.write(JSON.pretty_generate(to_csf_params))
           end
@@ -81,8 +81,6 @@ module ViewComponent
 
         def default_component
           name.chomp("Stories").constantize
-        rescue StandardError
-          nil
         end
 
         def load_stories
@@ -93,10 +91,6 @@ module ViewComponent
           Storybook.stories_path
         end
 
-        def show_stories
-          Storybook.show_stories
-        end
-
         def story_id(name)
           "#{stories_name}/#{name.to_s.parameterize}".underscore
         end

data/lib/view_component/storybook/version.rb

@@ -2,6 +2,6 @@
 
 module ViewComponent
   module Storybook
-    VERSION = "0.6.0"
+    VERSION = "0.8.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: view_component_storybook
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.8.0
 platform: ruby
 authors:
 - Jon Palmer
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-09-19 00:00:00.000000000 Z
+date: 2021-02-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: view_component
@@ -100,42 +100,42 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.81'
+        version: '1.9'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.81'
+        version: '1.9'
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.4.2
+        version: 2.9.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.4.2
+        version: 2.9.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.38'
+        version: '2.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.38'
+        version: '2.1'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -150,6 +150,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.18.5
+- !ruby/object:Gem::Dependency
+  name: simplecov-console
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.9'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.9'
 description: Generate Storybook CSF JSON for rendering Rails View Components in Storybook
 email:
 - 328224+jonspalmer@users.noreply.github.com
@@ -195,7 +209,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.3.0
+      version: 2.4.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="