view_component_reflex 3.1.9 → 3.1.13.pre1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8df0782e33267ea91ff1e99610107ee004cdec87947087750227907af88a3674
-  data.tar.gz: 5f488b266c6ade0cc81317da9ed0cb3d08cb8680654aef045348b3809997c9f4
+  metadata.gz: f1a30942491401f78a741641c3b44ed305ea65c83a66f3579e38ffade53c298e
+  data.tar.gz: dfe5b05f7410074bd5510a0bf162a8afd24e7cbae059337131156bd057886411
 SHA512:
-  metadata.gz: 281166ac7c1e2589d9b97733ad3edca6986720c87b239dd779c55529644bff5f8fad352a46abd43dc53c2e46947525d3517335a0621c8fa6478ad23767ef2b31
-  data.tar.gz: dece5fcacf66ee99a5fb539b42bb37cd71904435851ac71e8804b5ed75f0d67b8473b4a7e25e288dfbf81299a9c9f1834c418241b3a3055042136d2308f3f4ff
+  metadata.gz: 5b93d76545cd97ecd8e2a4cfa7e2accdfddb44aaa54ff178dd9296fe33706ebc3c72833d7b8fe2fafc9a061550514ab054b46d4e2e0c02e50675400985a28cda
+  data.tar.gz: 7b03a1e65f5a436b0f6c2450228d80050ceaae24d942880ded1faf43468e47996bf6b6a3a252eb287016e5b1e4eb458693f8e1d96e192ec2292e0e88b316b8f4

data/README.md

@@ -55,6 +55,22 @@ end
 <%= render(TodoComponent.with_collection(Todo.all)) %>
 ```
 
+In case you're rendering a collection of empty models, use a UUID of some sort to address the correct component instance on your page:
+
+```ruby
+class TodoComponent < ViewComponentReflex::Component
+  def initialize(todo:)
+    @todo = todo
+  end
+
+  def collection_key
+    @todo.id || SecureRandom.hex(16)
+  end
+end
+#
+<%= render(TodoComponent.with_collection((0..5).map { Todo.new })) %>
+```
+
 ## API
 
 ### permit_parameter?(initial_param, new_params)
@@ -385,6 +401,31 @@ end
 ```
 Please use a different name to be able to save them to the session.
 
+## Foo Can't Be Dumped
+
+If you are getting errors that e.g. MatchData, Singleton etc. can't be dumped, ensure that you do not set any instance variables in your components (or any class you inject into them, for that matter) that cannot be marshaled.
+
+This can be easily remedied though, by providing a list of unmarshalable instance variables and overwriting `marshal_dump` and `marshal_load` (from [https://stackoverflow.com/a/32877159/4341756](https://stackoverflow.com/a/32877159/4341756)):
+
+```rb
+class MarshalTest
+  UNMARSHALED_VARIABLES = [:@foo, :@bar]
+
+  def marshal_dump
+    instance_variables.reject{|m| UNMARSHALED_VARIABLES.include? m}.inject({}) do |vars, attr|
+      vars[attr] = instance_variable_get(attr)
+      vars
+    end
+  end
+
+  def marshal_load(vars)
+    vars.each do |attr, value|
+      instance_variable_set(attr, value) unless UNMARSHALED_VARIABLES.include?(attr)
+    end
+  end
+end
+```
+
 ## Anycable
 
 @sebyx07 provided a solution to use anycable (https://github.com/joshleblanc/view_component_reflex/issues/23#issue-721786338)

data/lib/view_component_reflex/engine.rb

@@ -22,7 +22,7 @@ module ViewComponentReflex
             if component&.respond_to?(:init_stimulus_reflex)
               component.init_stimulus_reflex
             else
-              p "Tried to initialize view_component_reflex on #{component_name}, but it's not a view_component_reflex"
+              Rails.logger.info "Tried to initialize view_component_reflex on #{component_name}, but it's not a view_component_reflex"
             end
             receive_original(data)
           end

data/lib/view_component_reflex/reflex.rb

@@ -20,15 +20,17 @@ module ViewComponentReflex
       end
       if primary_selector
         prevent_refresh!
-
+        
+        document = controller_document
         [primary_selector, *rest].each do |s|
-          html = controller_document.css(s)
+          html = document.css(s)
           if html.present?
             CableReady::Channels.instance[stream].morph(
               selector: s,
               html: html.inner_html,
               children_only: true,
               permanent_attribute_name: "data-reflex-permanent",
+              reflex_id: reflex_id
             )
           end
         end
@@ -62,6 +64,7 @@ module ViewComponentReflex
         children_only: true,
         html: component_document.css(selector).inner_html,
         permanent_attribute_name: "data-reflex-permanent",
+        reflex_id: reflex_id
       )
     end
 

data/lib/view_component_reflex/state_adapter/session.rb

@@ -9,7 +9,6 @@ module ViewComponentReflex
         new_state.each do |k, v|
           state(request, key)[k] = v
         end
-        p new_state
         store = request.session.instance_variable_get("@by")
         store.commit_session request, controller.response
       end
@@ -19,7 +18,6 @@ module ViewComponentReflex
         new_state.each do |k, v|
           request.session[key][k] = v
         end
-        p new_state
       end
 
       def self.wrap_write_async

data/lib/view_component_reflex/version.rb

@@ -1,3 +1,3 @@
 module ViewComponentReflex
-  VERSION = '3.1.9'
+  VERSION = '3.1.13.pre1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: view_component_reflex
 version: !ruby/object:Gem::Version
-  version: 3.1.9
+  version: 3.1.13.pre1
 platform: ruby
 authors:
 - Joshua LeBlanc
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-03-29 00:00:00.000000000 Z
+date: 2021-06-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -36,14 +36,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.4.1
+        version: 3.5.0.pre1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.4.1
+        version: 3.5.0.pre1
 - !ruby/object:Gem::Dependency
   name: view_component
   requirement: !ruby/object:Gem::Requirement
@@ -108,11 +108,11 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
-rubygems_version: 3.1.4
+rubygems_version: 3.2.3
 signing_key: 
 specification_version: 4
 summary: Allow stimulus reflexes in a view component