view_component_reflex 3.1.14.pre4 → 3.1.14.pre8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e5ccc3bdc0b0a80f7be53b17bc99a7edd35acf72b78a45229b8be6e64bca7e19
-  data.tar.gz: 31e7bd34a88647a6c35433fe4e8bd2ac4f8c283d050f4bab272a08ca47f4550b
+  metadata.gz: 68c3165a8b1c6121e1be99b4464ade2bf4bea8920b70d6d8b2461239f7278a9c
+  data.tar.gz: 55b823177cf414e6271bfbcaaac376e03dbaae73ebe73df0fff814a8e7b73912
 SHA512:
-  metadata.gz: 5966a7aaebf72045ce3316c4e4ac24c0d0bff372df85f9a5968e602608c4b4f65c92ae07bbf70cb76141b6337712bf572b807c09e6d09208fead39bdc7b79d37
-  data.tar.gz: cf07e301eb404f8598e6ac7f12108fb7e5429cfd4a32e85ed159c762dc330a4992117134fc9175f01a73dc5ca33a3078177e6d3bb986dd26b4efdccc8971f985
+  metadata.gz: 4a053c9d3ecd441c6b3235b590780312df465495f7f81c3be2087c78b0f556f59a0638b9f9a224b36d5f4f4aa4627da3c6df9b6f0159754d3592e4d239d3d2b1
+  data.tar.gz: 720261c26f0d0e45a26d490c6d818a5a3e373db45216bc1a0a7a094be3223012e2bb640a811550e11780ae9676df9ce84fdf03d4dca33fb700bcb1ced50555e0

data/README.md

@@ -440,6 +440,31 @@ Otherwise @instance_variables were nil after a reflex
   config.session_store :cache_store
 ```
 
+## Sidecar assets
+
+When using ViewComponent generated sidecar assets, the stimulus controller won't resolve properly.
+To resolve this, override the `self.stimulus_controller` method in your component to the correct method. 
+
+For example, if you have a structure of 
+
+```
+components/
+  example_component/
+    example_component_controller.js
+    example_component.html.erb
+  example_component.rb
+```
+
+You would update your `self.stimulus_controller` method to 
+
+```ruby
+def self.stimulus_controller
+  "example-component--example-component"
+end
+```
+
+Thanks @omairrazam for this solution
+
 ## License
 The gem is available as open source under the terms of the [MIT License](https://opensource.org/licenses/MIT).
 

data/app/components/view_component_reflex/component.rb

@@ -7,7 +7,14 @@ module ViewComponentReflex
       def init_stimulus_reflex
         factory = ViewComponentReflex::ReflexFactory.new(self)
         @stimulus_reflex ||= factory.reflex
-        wire_up_callbacks if factory.new?
+
+        # Always wire up new callbacks in development
+        if Rails.env.development?
+          reset_callbacks
+          wire_up_callbacks
+        elsif factory.new? # only wire up callbacks in production if they haven't been wired up yet
+          wire_up_callbacks
+        end
       end
 
       def queue_callback(key, args, blk)
@@ -40,6 +47,11 @@ module ViewComponentReflex
         queue_callback(:around, args, blk)
       end
 
+      def reset_callbacks
+        # SR uses :process as the underlying callback key
+        @stimulus_reflex.reset_callbacks(:process)
+      end
+
       def wire_up_callbacks
         register_callbacks(:before)
         register_callbacks(:after)
@@ -192,7 +204,7 @@ module ViewComponentReflex
     # end
 
     def safe_instance_variables
-      instance_variables - unsafe_instance_variables - omitted_from_state
+      instance_variables.reject { |ivar| ivar.start_with?("@__vc") } - unsafe_instance_variables - omitted_from_state
     end
 
     private
@@ -202,8 +214,8 @@ module ViewComponentReflex
         :@view_context, :@lookup_context, :@view_renderer, :@view_flow,
         :@virtual_path, :@variant, :@current_template, :@output_buffer, :@key,
         :@helpers, :@controller, :@request, :@tag_builder, :@state_initialized,
-        :@_content_evaluated, :@_render_in_block, :@__vc_controller, :@__vc_helpers,
-        :@__cached_content, :@__vc_variant, :@__vc_content_evaluated, :@__vc_render_in_block,
+        :@_content_evaluated, :@_render_in_block, :@__cached_content,
+        :@original_view_context,
       ]
     end
 

data/lib/view_component_reflex/version.rb

@@ -1,3 +1,3 @@
 module ViewComponentReflex
-  VERSION = '3.1.14.pre4'
+  VERSION = '3.1.14.pre8'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: view_component_reflex
 version: !ruby/object:Gem::Version
-  version: 3.1.14.pre4
+  version: 3.1.14.pre8
 platform: ruby
 authors:
 - Joshua LeBlanc
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-09-11 00:00:00.000000000 Z
+date: 2021-12-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -19,7 +19,7 @@ dependencies:
         version: '5.2'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7.0'
+        version: '8.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -29,7 +29,7 @@ dependencies:
         version: '5.2'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7.0'
+        version: '8.0'
 - !ruby/object:Gem::Dependency
   name: stimulus_reflex
   requirement: !ruby/object:Gem::Requirement
@@ -112,7 +112,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: 1.3.1
 requirements: []
-rubygems_version: 3.2.15
+rubygems_version: 3.2.9
 signing_key: 
 specification_version: 4
 summary: Allow stimulus reflexes in a view component