view_component_reflex 3.1.14.pre2 → 3.1.14.pre6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ce6db06f7743b61da866498868faddc3b371080d5abcea9cdb61c91bd8ae3603
-  data.tar.gz: 66e3216507c4bfc92b5340a615445b6330e4bdfa9cd85c9b598e9430d7ec5433
+  metadata.gz: a2bc64cc6358619458915ab821a8f690257cb8239c8a5e55986c82f12620b642
+  data.tar.gz: 85fbc21a9c3f2a9ce7331fe2b9aaf67255bb74a98d7f4a5ddece7b75ff6a710c
 SHA512:
-  metadata.gz: 95f384579a1a22a9d319637f6e0976eed69b280a5cf0dd23d643a4947ebdfcfa575080d2a2962118e9727cf7cbdf7981bc634b61ac384368ef6b723fcdd76370
-  data.tar.gz: 00aee505873d12021c51e9e40329160ea9d1aa5c9a687e69313a102bb6e6892899032902d2e685b02e197e70f0a049b92750449c8629ba478f98519a84a07704
+  metadata.gz: c80401f2a8ed054f8feaa74fa976eb61d1829ba70bc809e836c887463f20b74dc37f85252c8ae9fcc2f5da0f32f7c12d1856fd3592fc13998929323adee2b334
+  data.tar.gz: cf388efa838d347177ffff53969e2ec7f44acedb51e6257d92a135606d3e9b11d2faf3c3f0866238d70c15f6c81e4798f59991f3fbf82b0a529e56d668e662cb

data/README.md

@@ -440,6 +440,31 @@ Otherwise @instance_variables were nil after a reflex
   config.session_store :cache_store
 ```
 
+## Sidecar assets
+
+When using ViewComponent generated sidecar assets, the stimulus controller won't resolve properly.
+To resolve this, override the `self.stimulus_controller` method in your component to the correct method. 
+
+For example, if you have a structure of 
+
+```
+components/
+  example_component/
+    example_component_controller.js
+    example_component.html.erb
+  example_component.rb
+```
+
+You would update your `self.stimulus_controller` method to 
+
+```ruby
+def self.stimulus_controller
+  "example-component--example-component"
+end
+```
+
+Thanks @omairrazam for this solution
+
 ## License
 The gem is available as open source under the terms of the [MIT License](https://opensource.org/licenses/MIT).
 

data/app/components/view_component_reflex/component.rb

@@ -7,7 +7,14 @@ module ViewComponentReflex
       def init_stimulus_reflex
         factory = ViewComponentReflex::ReflexFactory.new(self)
         @stimulus_reflex ||= factory.reflex
-        wire_up_callbacks if factory.new?
+
+        # Always wire up new callbacks in development
+        if Rails.env.development?
+          reset_callbacks
+          wire_up_callbacks
+        elsif factory.new? # only wire up callbacks in production if they haven't been wired up yet
+          wire_up_callbacks
+        end
       end
 
       def queue_callback(key, args, blk)
@@ -40,6 +47,11 @@ module ViewComponentReflex
         queue_callback(:around, args, blk)
       end
 
+      def reset_callbacks
+        # SR uses :process as the underlying callback key
+        @stimulus_reflex.reset_callbacks(:process)
+      end
+
       def wire_up_callbacks
         register_callbacks(:before)
         register_callbacks(:after)
@@ -204,6 +216,7 @@ module ViewComponentReflex
         :@helpers, :@controller, :@request, :@tag_builder, :@state_initialized,
         :@_content_evaluated, :@_render_in_block, :@__vc_controller, :@__vc_helpers,
         :@__cached_content, :@__vc_variant, :@__vc_content_evaluated, :@__vc_render_in_block,
+        :@original_view_context,
       ]
     end
 

data/lib/view_component_reflex/engine.rb

@@ -19,11 +19,14 @@ module ViewComponentReflex
               # Since every reflex runs through this monkey patch, we're just going to ignore the ones that aren't for components
             end
 
-            if component&.respond_to?(:init_stimulus_reflex)
-              component.init_stimulus_reflex
-            else
-              Rails.logger.info "Tried to initialize view_component_reflex on #{component_name}, but it's not a view_component_reflex"
+            if component 
+              if component.respond_to?(:init_stimulus_reflex)
+                component.init_stimulus_reflex
+              else
+                Rails.logger.info "Tried to initialize view_component_reflex on #{component_name}, but it's not a view_component_reflex"
+              end
             end
+            
             receive_original(data)
           end
         end

data/lib/view_component_reflex/reflex.rb

@@ -147,13 +147,18 @@ module ViewComponentReflex
     end
 
     def stimulate(target, data)
-      data_to_receive = {}
+      data_to_receive = {
+        "dataset" => {
+          "datasetAll" => {},
+          "dataset" => {}
+        }
+      }
 
       stimulus_reflex_data.each do |k, v|
         data_to_receive[k.to_s.camelize(:lower)] = v
       end
 
-      data_to_receive["dataset"] = data.each_with_object({}) do |(k, v), o|
+      data_to_receive["dataset"]["dataset"] = data.each_with_object({}) do |(k, v), o|
         o["data-#{k}"] = v
       end
 

data/lib/view_component_reflex/version.rb

@@ -1,3 +1,3 @@
 module ViewComponentReflex
-  VERSION = '3.1.14.pre2'
+  VERSION = '3.1.14.pre6'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: view_component_reflex
 version: !ruby/object:Gem::Version
-  version: 3.1.14.pre2
+  version: 3.1.14.pre6
 platform: ruby
 authors:
 - Joshua LeBlanc
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-07-23 00:00:00.000000000 Z
+date: 2021-11-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -36,14 +36,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.5.0.pre1
+        version: 3.5.0.pre2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.5.0.pre1
+        version: 3.5.0.pre2
 - !ruby/object:Gem::Dependency
   name: view_component
   requirement: !ruby/object:Gem::Requirement
@@ -112,7 +112,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: 1.3.1
 requirements: []
-rubygems_version: 3.2.15
+rubygems_version: 3.2.9
 signing_key: 
 specification_version: 4
 summary: Allow stimulus reflexes in a view component