view_component_reflex 3.0.0 → 3.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 047aa78feb4675abeb3bb5a5ed86ea4071c6a22fef3e06fb2806b04d651898cd
-  data.tar.gz: 5c0cc3c3c6fca877e8b2d8a595c601ddea90b892a62367af6abed6099a6b1b81
+  metadata.gz: 0c063a5b69263cf48e6a92937e65a73cd1a2c5e00577734f62b7cbf6186604d3
+  data.tar.gz: 26ec1a060c0283a906df2bcda4cd11110bb31ebe69e9d5c741cf568d6dabd7de
 SHA512:
-  metadata.gz: 0f3f2e6f15c43e47aa3cdcd39632f4e2d7d76dd7065dcfd38b718db0e34ac100fed7268371660994c402a9c0aacd07635a935f088cec49cebbbcbccae6533aea
-  data.tar.gz: 56fa191797a8d3f757457a7a8c94f4394304ca0dd201639c0d47225a7f7be7ceb9b349641805783538325e884431e483a5b51714c4f75f26826912c953474d7c
+  metadata.gz: b7f55e4e85f42a9c9b0044710f8f2c295e0c13350bfc26f1c940626b581e68a851feb1c7cf4c54124a7e96ac9ade6565b1e3361f789e0efbc16644c78bc906b2
+  data.tar.gz: aa24fa075eae92847e04931a1278b20358472fc9fdb00079bb1f0b774d84f5a3a047f90d61e42295a578999a7c69ec12e152847d77ecf6a4236554d4b4c38605

data/README.md

@@ -359,6 +359,21 @@ end
 
 StimulusReflex 3.4 introduced a fix that merges the current `request.env` and provides the CSRF token to fetch the session.
 
+## Help, my instance variables do not persist into the session
+
+These instance variable names are not working and unsafe:
+
+```rb
+def unsafe_instance_variables
+  [
+    :@view_context, :@lookup_context, :@view_renderer, :@view_flow,
+    :@virtual_path, :@variant, :@current_template, :@output_buffer, :@key,
+    :@helpers, :@controller, :@request, :@tag_builder, :@initialized_state
+  ]
+end
+```
+Please use a different name to be able to save them to the session.
+
 ## Anycable
 
 @sebyx07 provided a solution to use anycable (https://github.com/joshleblanc/view_component_reflex/issues/23#issue-721786338)

data/app/components/view_component_reflex/component.rb

@@ -47,7 +47,7 @@ module ViewComponentReflex
     end
 
     def self.stimulus_controller
-      name.chomp("Component").underscore.dasherize
+      name.chomp("Component").underscore.dasherize.gsub("/", "--")
     end
 
     def stimulus_reflex?
@@ -57,7 +57,7 @@ module ViewComponentReflex
     def component_controller(opts_or_tag = :div, opts = {}, &blk)
       init_key
 
-      tag = :div
+      tag = :di
       options = if opts_or_tag.is_a? Hash
         opts_or_tag
       else

data/lib/view_component_reflex.rb

@@ -1,5 +1,6 @@
 require "stimulus_reflex"
 require 'view_component_reflex/reflex_factory'
+require "view_component_reflex/state_adapter/base"
 require "view_component_reflex/state_adapter/session"
 require "view_component_reflex/state_adapter/memory"
 require "view_component_reflex/state_adapter/redis"

data/lib/view_component_reflex/engine.rb

@@ -13,13 +13,16 @@ module ViewComponentReflex
             reflex_name, _ = target.split("#")
             reflex_name = reflex_name.camelize
             component_name = reflex_name.end_with?("Reflex") ? reflex_name[0...-6] : reflex_name
-            if component_name.end_with?("Component")
-              begin
-                component_name.constantize.init_stimulus_reflex
-              rescue
-                p "Tried to initialize view_component_reflex on #{component_name}, but it's not a view_component_reflex"
-              end
+            component = begin
+              component_name.constantize
+            rescue
+              # Since every reflex runs through this monkey patch, we're just going to ignore the ones that aren't for components
+            end
 
+            if component&.respond_to?(:init_stimulus_reflex)
+              component.init_stimulus_reflex
+            else
+              p "Tried to initialize view_component_reflex on #{component_name}, but it's not a view_component_reflex"
             end
             receive_original(data)
           end

data/lib/view_component_reflex/state_adapter/base.rb

@@ -0,0 +1,18 @@
+module ViewComponentReflex
+  module StateAdapter
+    class Base
+
+      private
+
+      def self.extract_id(request)
+        session = request&.session
+        if session.respond_to? :id
+          session.id.to_s
+        else
+          nil
+        end
+      end
+
+    end
+  end
+end

data/lib/view_component_reflex/state_adapter/memory.rb

@@ -1,10 +1,12 @@
 VIEW_COMPONENT_REFLEX_MEMORY_STATE = {}
 module ViewComponentReflex
   module StateAdapter
-    class Memory
+    class Memory < Base
       def self.state(request, key)
-        VIEW_COMPONENT_REFLEX_MEMORY_STATE[request.session.id.to_s] ||= {}
-        VIEW_COMPONENT_REFLEX_MEMORY_STATE[request.session.id.to_s][key] ||= {}
+        id = extract_id(request)
+
+        VIEW_COMPONENT_REFLEX_MEMORY_STATE[id] ||= {}
+        VIEW_COMPONENT_REFLEX_MEMORY_STATE[id][key] ||= {}
       end
 
       def self.set_state(request, _, key, new_state)
@@ -14,10 +16,12 @@ module ViewComponentReflex
       end
 
       def self.store_state(request, key, new_state = {})
-        VIEW_COMPONENT_REFLEX_MEMORY_STATE[request.session.id.to_s] ||= {}
-        VIEW_COMPONENT_REFLEX_MEMORY_STATE[request.session.id.to_s][key] = {}
+        id = extract_id(request)
+
+        VIEW_COMPONENT_REFLEX_MEMORY_STATE[id] ||= {}
+        VIEW_COMPONENT_REFLEX_MEMORY_STATE[id][key] = {}
         new_state.each do |k, v|
-          VIEW_COMPONENT_REFLEX_MEMORY_STATE[request.session.id.to_s][key][k] = v
+          VIEW_COMPONENT_REFLEX_MEMORY_STATE[id][key][k] = v
         end
       end
 

data/lib/view_component_reflex/state_adapter/redis.rb

@@ -10,7 +10,7 @@
 
 module ViewComponentReflex
   module StateAdapter
-    class Redis
+    class Redis < Base
       attr_reader :client, :ttl
 
       def initialize(redis_opts:, ttl: 3600)
@@ -67,8 +67,9 @@ module ViewComponentReflex
       end
 
       def get_key(request, key)
-        "#{request.session.id.to_s}_#{key}_session_reflex_redis"
+        id = Redis.extract_id(request)
+        "#{id}_#{key}_session_reflex_redis"
       end
     end
   end
-end
+end

data/lib/view_component_reflex/state_adapter/session.rb

@@ -1,6 +1,6 @@
 module ViewComponentReflex
   module StateAdapter
-    class Session
+    class Session < Base
       def self.state(request, key)
         request.session[key] ||= {}
       end

data/lib/view_component_reflex/version.rb

@@ -1,3 +1,3 @@
 module ViewComponentReflex
-  VERSION = '3.0.0'
+  VERSION = '3.0.5'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: view_component_reflex
 version: !ruby/object:Gem::Version
-  version: 3.0.0
+  version: 3.0.5
 platform: ruby
 authors:
 - Joshua LeBlanc
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-12-06 00:00:00.000000000 Z
+date: 2021-01-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -34,16 +34,16 @@ dependencies:
   name: stimulus_reflex
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 3.4.0.pre8
+        version: 3.4.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 3.4.0.pre8
+        version: 3.4.0
 - !ruby/object:Gem::Dependency
   name: view_component
   requirement: !ruby/object:Gem::Requirement
@@ -58,6 +58,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: sqlite3
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Allow stimulus reflexes in a view component
 email:
 - joshleblanc94@gmail.com
@@ -73,6 +87,7 @@ files:
 - lib/view_component_reflex/engine.rb
 - lib/view_component_reflex/reflex.rb
 - lib/view_component_reflex/reflex_factory.rb
+- lib/view_component_reflex/state_adapter/base.rb
 - lib/view_component_reflex/state_adapter/memory.rb
 - lib/view_component_reflex/state_adapter/redis.rb
 - lib/view_component_reflex/state_adapter/session.rb