view_component_reflex 2.6.2 → 3.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a3a9136d14d056ea6ca9ca73d54b905fbad80c7c65d4bdd453dcb37519cc6a3c
-  data.tar.gz: 33561fcf8eeff01af4c975f4367886cedfc1efcd69f38f50b9c8a9808d231eb8
+  metadata.gz: eb02765f889a8b562adc0dc0d5d4413c9f9d4a03dee0bf4250f2efc5469e6927
+  data.tar.gz: fc2cdce4de4712ab91820ede8ba124b1ec74757a1a66f488148d43fb31d7e409
 SHA512:
-  metadata.gz: bc56428b8d278bec1e50d69f36180a2714fd67a093c1bd3d32a49ee5277393eb5f6d33a72ccc33b3df412ae2fecdaab1a4422f6bb148418c4f660165bce573db
-  data.tar.gz: 36a563499b5b313243a19d1a8e3feeb510ea0fc4126515b82ac9c0390206af754221953fffd80bcc36076970638b1c2685b3069f0985976b33ff98afa6644069
+  metadata.gz: a8073aab28996f5f1941fd3574140d64b1e583c75083031162b373269a8d226b9d26513cf891507de43d215daf044d0e2586a31b2ac46b9c4c693d9f319af877
+  data.tar.gz: dc81f869b0c4648eb3cf63276872acad47b0563d3a19f3f0c90c1db4474ab7995798a735c878afe319576f5b04655de501b7e599f32b21faefaf8603c5de0089

data/README.md

@@ -207,7 +207,7 @@ end
 ```
 
 ## Custom reflex base class
-Reflexes typically inherit from a base ApplicationReflex. You can define the base class for a view_component_reflex by using the `reflex_base_class` method.
+Reflexes typically inherit from a base ApplicationReflex. You can define the base class for a view_component_reflex by using the `reflex_base_class` accessor.
 The parent class must inherit ViewComponentReflex::Reflex, and will throw an error if it does not.
 
 ```ruby
@@ -217,7 +217,7 @@ end
 
 
 class MyComponent < ViewComponentReflex::Component
-  reflex_base_class ApplicationReflex
+  MyComponent.reflex_base_class = ApplicationReflex
 end
 ```
 
@@ -359,6 +359,35 @@ end
 
 StimulusReflex 3.4 introduced a fix that merges the current `request.env` and provides the CSRF token to fetch the session.
 
+## Help, my instance variables do not persist into the session
+
+These instance variable names are not working and unsafe:
+
+```rb
+def unsafe_instance_variables
+  [
+    :@view_context, :@lookup_context, :@view_renderer, :@view_flow,
+    :@virtual_path, :@variant, :@current_template, :@output_buffer, :@key,
+    :@helpers, :@controller, :@request, :@tag_builder, :@initialized_state
+  ]
+end
+```
+Please use a different name to be able to save them to the session.
+
+## Anycable
+
+@sebyx07 provided a solution to use anycable (https://github.com/joshleblanc/view_component_reflex/issues/23#issue-721786338)
+
+Leaving this, might help others:
+
+I tried this with any cable and I had to add this to development.rb
+Otherwise @instance_variables were nil after a reflex
+
+```ruby
+  config.cache_store = :redis_cache_store, { url: "redis://localhost:6379/1", driver: :hiredis }
+  config.session_store :cache_store
+```
+
 ## License
 The gem is available as open source under the terms of the [MIT License](https://opensource.org/licenses/MIT).
 

data/app/components/view_component_reflex/component.rb

@@ -1,5 +1,7 @@
 module ViewComponentReflex
   class Component < ViewComponent::Base
+    class_attribute :reflex_base_class, default: ViewComponentReflex::Reflex
+
     class << self
       def init_stimulus_reflex
         factory = ViewComponentReflex::ReflexFactory.new(self)
@@ -7,18 +9,6 @@ module ViewComponentReflex
         wire_up_callbacks if factory.new?
       end
 
-      def reflex_base_class(new_base_class = nil)
-        if new_base_class.nil?
-          @reflex_base_class ||= ViewComponentReflex::Reflex
-        else
-          if new_base_class <= ViewComponentReflex::Reflex
-            @reflex_base_class = new_base_class
-          else
-            raise StandardError.new("The reflex base class must inherit from ViewComponentReflex::Reflex")
-          end
-        end
-      end
-
       def queue_callback(key, args, blk)
         callbacks(key).push({
           args: args,
@@ -57,7 +47,7 @@ module ViewComponentReflex
     end
 
     def self.stimulus_controller
-      name.chomp("Component").underscore.dasherize
+      name.chomp("Component").underscore.dasherize.gsub("/", "--")
     end
 
     def stimulus_reflex?
@@ -151,7 +141,7 @@ module ViewComponentReflex
       adapter = ViewComponentReflex::Engine.state_adapter
 
       # initialize session state
-      if !stimulus_reflex? || adapter.state(request, @key).empty?
+      if (!stimulus_reflex? || adapter.state(request, @key).empty?) && !@initialized_state
 
         new_state = create_safe_state
 
@@ -179,13 +169,14 @@ module ViewComponentReflex
           end
         end
         after_state_initialized(parameters_changed)
-        @initialized_state = true
       end
+
+      @initialized_state = true
       @key
     end
 
     def safe_instance_variables
-      instance_variables - unsafe_instance_variables
+      instance_variables - unsafe_instance_variables - omitted_from_state
     end
 
     private
@@ -203,7 +194,7 @@ module ViewComponentReflex
 
       # this will almost certainly break
       safe_instance_variables.each do |k|
-        new_state[k] = instance_variable_get(k) unless omitted_from_state.include?(k)
+        new_state[k] = instance_variable_get(k)
       end
       new_state
     end

data/lib/view_component_reflex/engine.rb

@@ -13,13 +13,16 @@ module ViewComponentReflex
             reflex_name, _ = target.split("#")
             reflex_name = reflex_name.camelize
             component_name = reflex_name.end_with?("Reflex") ? reflex_name[0...-6] : reflex_name
-            if component_name.end_with?("Component")
-              begin
-                component_name.constantize.init_stimulus_reflex
-              rescue
-                p "Tried to initialize view_component_reflex on #{component_name}, but it's not a view_component_reflex"
-              end
+            component = begin
+              component_name.constantize
+            rescue
+              # Since every reflex runs through this monkey patch, we're just going to ignore the ones that aren't for components
+            end
 
+            if component&.respond_to?(:init_stimulus_reflex)
+              component.init_stimulus_reflex
+            else
+              p "Tried to initialize view_component_reflex on #{component_name}, but it's not a view_component_reflex"
             end
             receive_original(data)
           end

data/lib/view_component_reflex/reflex.rb

@@ -1,6 +1,5 @@
 module ViewComponentReflex
   class Reflex < StimulusReflex::Reflex
-    include CableReady::Broadcaster
 
     class << self
       attr_accessor :component_class
@@ -15,16 +14,26 @@ module ViewComponentReflex
       if primary_selector
         prevent_refresh!
 
-        controller.process(url_params[:action])
+        controller.process(params[:action])
         document = Nokogiri::HTML(controller.response.body)
         [primary_selector, *rest].each do |s|
           html = document.css(s)
           if html.present?
-            cable_ready[channel.stream_name].morph(
+            CableReady::Channels.instance[stream_name].morph(
               selector: s,
               html: html.inner_html,
               children_only: true,
-              permanent_attribute_name: "data-reflex-permanent"
+              permanent_attribute_name: "data-reflex-permanent",
+              stimulus_reflex: {
+                  reflex_id: reflex_id,
+                  xpath: xpath,
+                  c_xpath: c_xpath,
+                  target: target,
+                  reflex_controller: reflex_controller,
+                  url: url,
+                  morph: :page,
+                  attrs: {key: element.dataset[:key]}
+              }
             )
           end
         end
@@ -41,14 +50,28 @@ module ViewComponentReflex
         end
       end
       document = Nokogiri::HTML(component.render_in(controller.view_context))
-      cable_ready[channel.stream_name].morph(
+      CableReady::Channels.instance[stream_name].morph(
         selector: selector,
         children_only: true,
         html: document.css(selector).inner_html,
-        permanent_attribute_name: "data-reflex-permanent"
+        permanent_attribute_name: "data-reflex-permanent",
+        stimulus_reflex: {
+            reflex_id: reflex_id,
+            xpath: xpath,
+            target: target,
+            c_xpath: c_xpath,
+            reflex_controller: reflex_controller,
+            url: url,
+            morph: :page,
+            attrs: {key: element.dataset[:key]}
+        }
       )
     end
 
+    def target
+      "#{component_class}##{method_name}"
+    end
+
     def refresh_all!
       refresh!("body")
     end

data/lib/view_component_reflex/state_adapter/memory.rb

@@ -3,8 +3,10 @@ module ViewComponentReflex
   module StateAdapter
     class Memory
       def self.state(request, key)
-        VIEW_COMPONENT_REFLEX_MEMORY_STATE[request.session.id.to_s] ||= {}
-        VIEW_COMPONENT_REFLEX_MEMORY_STATE[request.session.id.to_s][key] ||= {}
+        id = extract_id(request)
+
+        VIEW_COMPONENT_REFLEX_MEMORY_STATE[id] ||= {}
+        VIEW_COMPONENT_REFLEX_MEMORY_STATE[id][key] ||= {}
       end
 
       def self.set_state(request, _, key, new_state)
@@ -14,16 +16,29 @@ module ViewComponentReflex
       end
 
       def self.store_state(request, key, new_state = {})
-        VIEW_COMPONENT_REFLEX_MEMORY_STATE[request.session.id.to_s] ||= {}
-        VIEW_COMPONENT_REFLEX_MEMORY_STATE[request.session.id.to_s][key] = {}
+        id = extract_id(request)
+
+        VIEW_COMPONENT_REFLEX_MEMORY_STATE[id] ||= {}
+        VIEW_COMPONENT_REFLEX_MEMORY_STATE[id][key] = {}
         new_state.each do |k, v|
-          VIEW_COMPONENT_REFLEX_MEMORY_STATE[request.session.id.to_s][key][k] = v
+          VIEW_COMPONENT_REFLEX_MEMORY_STATE[id][key][k] = v
         end
       end
 
       def self.wrap_write_async
         yield
       end
+
+      private
+
+      def self.extract_id(request)
+        session = request&.session
+        if session.respond_to? :id
+          session.id.to_s
+        else
+          nil
+        end
+      end
     end
   end
 end

data/lib/view_component_reflex/version.rb

@@ -1,3 +1,3 @@
 module ViewComponentReflex
-  VERSION = '2.6.2'
+  VERSION = '3.0.4'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: view_component_reflex
 version: !ruby/object:Gem::Version
-  version: 2.6.2
+  version: 3.0.4
 platform: ruby
 authors:
 - Joshua LeBlanc
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-11-13 00:00:00.000000000 Z
+date: 2020-12-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -36,20 +36,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.3.0
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '3.4'
+        version: 3.4.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.3.0
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '3.4'
+        version: 3.4.0
 - !ruby/object:Gem::Dependency
   name: view_component
   requirement: !ruby/object:Gem::Requirement
@@ -64,6 +58,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: sqlite3
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Allow stimulus reflexes in a view component
 email:
 - joshleblanc94@gmail.com