view_component 4.5.0 → 4.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9bb24a0e61e0b08097feff53e3303b5961b3c7bf24a8cc81b9a70480e7a7bfea
-  data.tar.gz: 7ba2ec6ff0f9ecaaf391c9218c86ebdbba78ac5cdee29d76c6f5367dc4fc7840
+  metadata.gz: cc884d47517a4f27d0159acd6e744d31a51b29217e3c5e38d9db9594bc25bc79
+  data.tar.gz: 0ca9efab88b736c678177eab1edd7165365519724c9efe4b7071391f605707b8
 SHA512:
-  metadata.gz: ef478e3d1270858f2d08fcfafee488c1c6899d9f80f7dcf0827f024519b60a366128e09ca308032d98a2087e993a6d6d4b36f5b8406d9fecb6baf05619ef72e9
-  data.tar.gz: 17f0d08421581f0f1b584debb484626b66f821317ff32d573dc2f52649a2cf6a82d911caec0bbb2362ee42bb9d99550c0857ebea42b0011b366f86149f1ec125
+  metadata.gz: 23fee96c0259c1a245132a138edf4233fdc228aafb4807ce62f746796295a870548420cb73f99e5ff6705d536e4cfeb6128fe87135c122741a54e8235cba9a31
+  data.tar.gz: ca9c6a5d1af51e689d8ec17d91aa06f8cfb25781eb6b77702ecb74639778d0b7d0842f14aaed51243bc4a373329f17bf66beb2efa9d0bb7fb7ced7880d4d8878

data/docs/CHANGELOG.md

@@ -10,6 +10,34 @@ nav_order: 6
 
 ## main
 
+## 4.7.0
+
+* Fix stale content cache when slots are accessed before `render_in`.
+
+    *Jared Armstrong*
+
+* Add rubocop-view_component to resources.
+
+    *Andy Waite*
+
+* Fix bug where inheritance of components with formatless templates improperly raised a NoMethodError.
+
+    *GitHub Copilot*, *Joel Hawksley*, *Cameron Dutro*
+
+## 4.6.0
+
+* Add `view_identifier` to the `render.view_component` instrumentation event payload, containing the path to the component's template file (e.g. `app/components/my_component.html.erb`). For components using inline render methods, `view_identifier` will be `nil`.
+
+    *GitHub Copilot*
+
+* Replace deprecated `require_dependency` with `require` in preview loading.
+
+    *GitHub Copilot*
+
+* Return `html_safe` empty string from `render_in` when `render?` is false.
+
+    *GitHub Copilot*
+
 ## 4.5.0
 
 * Fix initialization ordering issue causing missing asset errors in Sprockets.

data/lib/view_component/base.rb

@@ -131,6 +131,7 @@ module ViewComponent
       end
 
       @__vc_content_evaluated = false
+      remove_instance_variable(:@__vc_content) if defined?(@__vc_content)
       @__vc_render_in_block = block
       @view_context.instance_variable_set(:@virtual_path, virtual_path)
 
@@ -160,7 +161,7 @@ module ViewComponent
 
         value
       else
-        ""
+        "".html_safe
       end
     ensure
       view_context.instance_variable_set(:@virtual_path, @old_virtual_path)

data/lib/view_component/instrumentation.rb

@@ -11,15 +11,28 @@ module ViewComponent # :nodoc:
     def render_in(view_context, &block)
       return super if !Rails.application.config.view_component.instrumentation_enabled.present?
 
+      payload = {
+        name: self.class.name,
+        identifier: self.class.identifier,
+        view_identifier: nil
+      }
+
       ActiveSupport::Notifications.instrument(
         "render.view_component",
-        {
-          name: self.class.name,
-          identifier: self.class.identifier
-        }
+        payload
       ) do
-        super
+        result = super
+        payload[:view_identifier] = @__vc_instrumentation_view_identifier
+        result
       end
+    ensure
+      @__vc_instrumentation_view_identifier = nil
+    end
+
+    def around_render
+      result = super
+      @__vc_instrumentation_view_identifier = current_template&.path
+      result
     end
   end
 end

data/lib/view_component/preview.rb

@@ -95,7 +95,7 @@ module ViewComponent # :nodoc:
       # @private
       def __vc_load_previews
         Array(preview_paths).each do |preview_path|
-          Dir["#{preview_path}/**/*preview.rb"].sort.each { |file| require_dependency file }
+          Dir["#{preview_path}/**/*preview.rb"].sort.each { |file| require file }
         end
       end
 

data/lib/view_component/template.rb

@@ -21,6 +21,13 @@ module ViewComponent
 
     class File < Template
       def initialize(component:, details:, path:)
+        # If the template file has no format (e.g. .erb instead of .html.erb),
+        # assume the default format (html).
+        if details.format.nil?
+          Kernel.warn("WARNING: Template format for #{path} is missing, defaulting to :html.")
+          details = ActionView::TemplateDetails.new(details.locale, details.handler, DEFAULT_FORMAT, details.variant)
+        end
+
         @strip_annotation_line = false
 
         # Rails 8.1 added a newline to compiled ERB output (rails/rails#53731).

data/lib/view_component/version.rb

@@ -3,7 +3,7 @@
 module ViewComponent
   module VERSION
     MAJOR = 4
-    MINOR = 5
+    MINOR = 7
     PATCH = 0
     PRE = nil
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: view_component
 version: !ruby/object:Gem::Version
-  version: 4.5.0
+  version: 4.7.0
 platform: ruby
 authors:
 - ViewComponent Team
@@ -135,7 +135,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.3
+rubygems_version: 4.0.6
 specification_version: 4
 summary: A framework for building reusable, testable & encapsulated view components
   in Ruby on Rails.