view_component 4.16.0 → 4.17.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6b893658a7831510ca06effa1b9abb1d50669a6910c31049f4225a164987e858
-  data.tar.gz: c4e55c9e7f4e49117c8abbaeaafb077c535be72d3b78775283e8599110cd47aa
+  metadata.gz: 49aef67be789faf45059eeab902b02dcc50197a5b2da2482306966f809c3a2a3
+  data.tar.gz: e8bab208c38f90f778eef18ba4f2f9a41593c88b4332870b537d11deaafcb647
 SHA512:
-  metadata.gz: f4d1ad504f345a9eff5088d22f34955d9a0d95f6990d16923e373f264c189ed8871a8551ec039985650251e330f22c752d7cb04a8bc1e0ddfc40dfde42148947
-  data.tar.gz: 05a6b4ace5d3bbb6fede8ea9f8d93a1291d1222f998d8cce3158133167430c06d5371cc2fdf7794dc2e432bde2ec650a0edeccea0465eabfb2dad6589289acd2
+  metadata.gz: 786b0a2c41adef88d25b11755a567b9adc356830ea2d23e9eb16b20d2882c38cbee10c0c14a6b2e052363f200b5493bdca493fdda87c514a109c93fac8501cb6
+  data.tar.gz: 7eb9c8c3234baf98fd725cdaf0d9ceae6a083f068bb043ed12b8db4162666370e4ad70f449adc5477c056dc72d12f6850090933579944480fd7618b2e3c0b51a

data/docs/CHANGELOG.md

@@ -10,6 +10,20 @@ nav_order: 6
 
 ## main
 
+## 4.17.0
+
+* Only register the executor hook that watches component templates when Action View doesn't cache templates at boot. With template caching on, as in production, the hook did nothing but still read `ActionView::Base.cache_template_loading` on every request. That value lives in a class variable, which non-main Ractors can't read on Ruby 4.0, so under Rails' experimental `Rails.application.ractorize!` every request failed.
+
+    *Mikael Henriksson*
+
+* Fix `Component.translate` raising `UncaughtThrowError` for keys missing from the sidecar translations, and `NoMethodError` for components without sidecar translations. It now falls back to the global translations, like the instance method does. Fix `translate` returning the `default:` value instead of an existing global translation.
+
+    *Andrii Furmanets*
+
+* Only recompile components when a template or a translation file changed, instead of before every request, when templates aren't cached. Pages render about twice as fast in development.
+
+    *Clément Joubert*
+
 ## 4.16.0
 
 * Fix subclasses defined after their parent renders a collection using the parent's default collection parameter name instead of their own. Fix recompiling a component not refreshing its collection parameter, counter, and iteration detection. Compute that detection when a component compiles, and store the results frozen so they're shareable across Ractors.

data/lib/view_component/compile_cache.rb

@@ -25,5 +25,14 @@ module ViewComponent
     def invalidate!
       cache.clear
     end
+
+    # Invalidates the cache when a template or a translation file is added,
+    # changed, or removed. Changes to Ruby files reload the application instead.
+    def template_watcher(file_watcher)
+      extensions = ActionView::Template::Handlers.extensions.map(&:to_s) + %w[yml yaml]
+      directories = ActiveSupport::Dependencies.autoload_paths.index_with(extensions)
+
+      file_watcher.new([], directories) { invalidate! }
+    end
   end
 end

data/lib/view_component/engine.rb

@@ -132,9 +132,22 @@ module ViewComponent
         end
       end
 
-      app.executor.to_run :before do
-        CompileCache.invalidate! unless ActionView::Base.cache_template_loading
+      # Like Rails' own template cache expiry, only watch templates when they
+      # aren't cached at boot. With template caching on, as in production, no
+      # hook runs per request, so requests never read ActionView's caching
+      # class variable, which non-main Ractors can't access.
+      ActiveSupport.on_load(:action_view) do
+        next if ActionView::Base.cache_template_loading
+
+        template_watcher = nil
+
+        app.executor.to_run :before do
+          template_watcher ||= CompileCache.template_watcher(app.config.file_watcher)
+          template_watcher.execute_if_updated
+        end
       end
+
+      app.reloader.before_class_unload { CompileCache.invalidate! }
     end
   end
 end

data/lib/view_component/translatable.rb

@@ -59,7 +59,11 @@ module ViewComponent
         locale = options.delete(:locale) || ::I18n.locale
         key = __vc_i18n_key(key, options.delete(:scope))
 
-        __vc_i18n_backend.translate(locale, key, options)
+        if __vc_i18n_backend&.exists?(locale, key)
+          __vc_i18n_backend.translate(locale, key, options)
+        else
+          ::I18n.translate(key, locale: locale, **options)
+        end
       end
 
       alias_method :t, :translate
@@ -102,17 +106,8 @@ module ViewComponent
 
       __vc_html_escape_translation_options!(options) if as_html
 
-      if key.start_with?(__vc_i18n_scope + ".")
-        translated =
-          catch(:exception) do
-            __vc_i18n_backend.translate(locale, key, options)
-          end
-
-        # Fallback to the global translations
-        if translated.is_a? ::I18n::MissingTranslation
-          return @view_context.translate(key, locale: locale, **options)
-        end
-
+      if __vc_i18n_backend.exists?(locale, key)
+        translated = __vc_i18n_backend.translate(locale, key, options)
         translated = __vc_html_safe_translation(translated) if as_html
         translated
       else

data/lib/view_component/version.rb

@@ -3,7 +3,7 @@
 module ViewComponent
   module VERSION
     MAJOR = 4
-    MINOR = 16
+    MINOR = 17
     PATCH = 0
     PRE = nil
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: view_component
 version: !ruby/object:Gem::Version
-  version: 4.16.0
+  version: 4.17.0
 platform: ruby
 authors:
 - ViewComponent Team