view_component 4.12.0 → 4.15.0

data/lib/view_component/collection.rb

@@ -13,7 +13,7 @@ module ViewComponent
     delegate :size, to: :@collection
 
     def render_in(view_context, **_, &block)
-      rendered = components.map do |component|
+      rendered = components.map! do |component|
         component.render_in(view_context, &block)
       end
       safe_join(rendered, rendered_spacer(view_context))
@@ -63,19 +63,25 @@ module ViewComponent
     end
 
     def component_options(item, iterator)
-      item_options = {component.__vc_collection_parameter => item}
+      item_options = @options.dup
+      item_options[component.__vc_collection_parameter] = item
       item_options[component.__vc_collection_counter_parameter] = iterator.index if component.__vc_counter_argument_present?
       item_options[component.__vc_collection_iteration_parameter] = iterator.dup if component.__vc_iteration_argument_present?
 
-      @options.merge(item_options)
+      item_options
     end
 
     # Render the spacer through a fresh `dup` so a collection rendered multiple
-    # times always gets a clean spacer instance.
+    # times does not reuse (and trip the single-render guard on) the spacer
+    # instance passed by the caller.
     def rendered_spacer(view_context)
       return "" unless @spacer_component
 
-      @spacer_component.dup.render_in(view_context)
+      spacer = @spacer_component.dup
+      if spacer.instance_variable_defined?(:@__vc_rendered)
+        spacer.remove_instance_variable(:@__vc_rendered)
+      end
+      spacer.render_in(view_context)
     end
   end
 end

data/lib/view_component/compiler.rb

@@ -115,11 +115,11 @@ module ViewComponent
           .tally
           .select { |_, count| count > 1 }
           .each do |tally|
-            variant, this_format = tally.first
+          variant, this_format = tally.first
 
-            variant_string = " for variant `#{variant}`" if variant.present?
+          variant_string = " for variant `#{variant}`" if variant.present?
 
-            errors << "More than one #{this_format.upcase} template found#{variant_string} for #{@component}. "
+          errors << "More than one #{this_format.upcase} template found#{variant_string} for #{@component}. "
         end
 
         default_template_types = @templates.each_with_object(Set.new) do |template, memo|
@@ -177,7 +177,7 @@ module ViewComponent
         else
           path_parser = ActionView::Resolver::PathParser.new
           templates = @component.sidecar_files(
-            ActionView::Template.template_handler_extensions
+            ActionView::Template::Handlers.extensions
           ).map do |path|
             details = path_parser.parse(path).details
             Template::File.new(component: @component, path: path, details: details)
@@ -190,11 +190,11 @@ module ViewComponent
           ).flat_map { |ancestor| ancestor.instance_methods(false).grep(/^call(_|$)/) }
             .uniq
             .each do |method_name|
-              templates << Template::InlineCall.new(
-                component: @component,
-                method_name: method_name,
-                defined_on_self: component_instance_methods_on_self.include?(method_name)
-              )
+            templates << Template::InlineCall.new(
+              component: @component,
+              method_name: method_name,
+              defined_on_self: component_instance_methods_on_self.include?(method_name)
+            )
           end
 
           templates

data/lib/view_component/engine.rb

@@ -77,6 +77,13 @@ module ViewComponent
       end
     end
 
+    initializer "view_component.serializable" do
+      ActiveSupport.on_load(:active_job) do
+        require "view_component/active_job_serializer"
+        ActiveJob::Serializers.add_serializers(ViewComponent::ActiveJobSerializer)
+      end
+    end
+
     initializer "view_component.eager_load_actions" do
       ActiveSupport.on_load(:after_initialize) do
         if Rails.application.config.eager_load

data/lib/view_component/errors.rb

@@ -9,7 +9,7 @@ module ViewComponent
     MESSAGE =
       "It looks like a block was provided after calling `with_content` on COMPONENT, " \
       "which means that ViewComponent doesn't know which content to use.\n\n" \
-      "To fix this issue, use either `with_content` or a block."
+      "To fix this issue, use either `with_content` or a block.".freeze
 
     def initialize(klass_name)
       super(MESSAGE.gsub("COMPONENT", klass_name.to_s))
@@ -25,13 +25,13 @@ module ViewComponent
   end
 
   class MultipleInlineTemplatesError < BaseError
-    MESSAGE = "Inline templates can only be defined once per-component."
+    MESSAGE = "Inline templates can only be defined once per-component.".freeze
   end
 
   class MissingPreviewTemplateError < StandardError
     MESSAGE =
       "A preview template for example EXAMPLE doesn't exist.\n\n" \
-      "To fix this issue, create a template for the example."
+      "To fix this issue, create a template for the example.".freeze
 
     def initialize(example)
       super(MESSAGE.gsub("EXAMPLE", example))
@@ -41,7 +41,7 @@ module ViewComponent
   class MissingTemplateError < StandardError
     MESSAGE =
       "No templates for COMPONENT match the request DETAIL.\n\n" \
-      "To fix this issue, provide a suitable template."
+      "To fix this issue, provide a suitable template.".freeze
 
     def initialize(component, request_detail)
       detail = {
@@ -58,7 +58,7 @@ module ViewComponent
     MESSAGE =
       "It looks like a block was provided after calling `with_content` on COMPONENT, " \
       "which means that ViewComponent doesn't know which content to use.\n\n" \
-      "To fix this issue, use either `with_content` or a block."
+      "To fix this issue, use either `with_content` or a block.".freeze
 
     def initialize(klass_name)
       super(MESSAGE.gsub("COMPONENT", klass_name.to_s))
@@ -70,7 +70,7 @@ module ViewComponent
       "The initializer for COMPONENT doesn't accept the parameter `PARAMETER`, " \
       "which is required to render it as a collection.\n\n" \
       "To fix this issue, update the initializer to accept `PARAMETER`.\n\n" \
-      "See [the collections docs](https://viewcomponent.org/guide/collections.html) for more information on rendering collections."
+      "See [the collections docs](https://viewcomponent.org/guide/collections.html) for more information on rendering collections.".freeze
 
     def initialize(klass_name, parameter)
       super(MESSAGE.gsub("COMPONENT", klass_name.to_s).gsub("PARAMETER", parameter.to_s))
@@ -80,7 +80,7 @@ module ViewComponent
   class ReservedParameterError < StandardError
     MESSAGE =
       "COMPONENT initializer can't accept the parameter `PARAMETER`, as it will override a " \
-      "public ViewComponent method. To fix this issue, rename the parameter."
+      "public ViewComponent method. To fix this issue, rename the parameter.".freeze
 
     def initialize(klass_name, parameter)
       super(MESSAGE.gsub("COMPONENT", klass_name.to_s).gsub("PARAMETER", parameter.to_s))
@@ -90,14 +90,14 @@ module ViewComponent
   class InvalidCollectionArgumentError < BaseError
     MESSAGE =
       "The value of the first argument passed to `with_collection` isn't a valid collection. " \
-      "Make sure it responds to `to_ary`."
+      "Make sure it responds to `to_ary`.".freeze
   end
 
   class ContentSlotNameError < StandardError
     MESSAGE =
       "COMPONENT declares a slot named content, which is a reserved word in ViewComponent.\n\n" \
       "Content passed to a ViewComponent as a block is captured and assigned to the `content` accessor without having to create an explicit slot.\n\n" \
-      "To fix this issue, either use the `content` accessor directly or choose a different slot name."
+      "To fix this issue, either use the `content` accessor directly or choose a different slot name.".freeze
 
     def initialize(klass_name)
       super(MESSAGE.gsub("COMPONENT", klass_name.to_s))
@@ -107,7 +107,7 @@ module ViewComponent
   class InvalidSlotDefinitionError < BaseError
     MESSAGE =
       "Invalid slot definition. Please pass a class, " \
-      "string, or callable (that is proc, lambda, etc)"
+      "string, or callable (that is proc, lambda, etc)".freeze
   end
 
   class InvalidSlotNameError < StandardError
@@ -118,7 +118,7 @@ module ViewComponent
       "COMPONENT declares a slot named SLOT_NAME, which ends with a question mark.\n\n" \
       "This isn't allowed because the ViewComponent framework already provides predicate " \
       "methods ending in `?`.\n\n" \
-      "To fix this issue, choose a different name."
+      "To fix this issue, choose a different name.".freeze
 
     def initialize(klass_name, slot_name)
       super(MESSAGE.gsub("COMPONENT", klass_name.to_s).gsub("SLOT_NAME", slot_name.to_s))
@@ -128,7 +128,7 @@ module ViewComponent
   class RedefinedSlotError < StandardError
     MESSAGE =
       "COMPONENT declares the SLOT_NAME slot multiple times.\n\n" \
-      "To fix this issue, choose a different slot name."
+      "To fix this issue, choose a different slot name.".freeze
 
     def initialize(klass_name, slot_name)
       super(MESSAGE.gsub("COMPONENT", klass_name.to_s).gsub("SLOT_NAME", slot_name.to_s))
@@ -138,7 +138,7 @@ module ViewComponent
   class ReservedSingularSlotNameError < InvalidSlotNameError
     MESSAGE =
       "COMPONENT declares a slot named SLOT_NAME, which is a reserved word in the ViewComponent framework.\n\n" \
-      "To fix this issue, choose a different name."
+      "To fix this issue, choose a different name.".freeze
 
     def initialize(klass_name, slot_name)
       super(MESSAGE.gsub("COMPONENT", klass_name.to_s).gsub("SLOT_NAME", slot_name.to_s))
@@ -148,7 +148,7 @@ module ViewComponent
   class ReservedPluralSlotNameError < InvalidSlotNameError
     MESSAGE =
       "COMPONENT declares a slot named SLOT_NAME, which is a reserved word in the ViewComponent framework.\n\n" \
-      "To fix this issue, choose a different name."
+      "To fix this issue, choose a different name.".freeze
 
     def initialize(klass_name, slot_name)
       super(MESSAGE.gsub("COMPONENT", klass_name.to_s).gsub("SLOT_NAME", slot_name.to_s))
@@ -158,7 +158,7 @@ module ViewComponent
   class UncountableSlotNameError < InvalidSlotNameError
     MESSAGE =
       "COMPONENT declares a slot named SLOT_NAME, which is an uncountable word\n\n" \
-      "To fix this issue, choose a different name."
+      "To fix this issue, choose a different name.".freeze
 
     def initialize(klass_name, slot_name)
       super(MESSAGE.gsub("COMPONENT", klass_name.to_s).gsub("SLOT_NAME", slot_name.to_s))
@@ -166,7 +166,7 @@ module ViewComponent
   end
 
   class ContentAlreadySetForPolymorphicSlotError < StandardError
-    MESSAGE = "Content for slot SLOT_NAME has already been provided."
+    MESSAGE = "Content for slot SLOT_NAME has already been provided.".freeze
 
     def initialize(slot_name)
       super(MESSAGE.gsub("SLOT_NAME", slot_name.to_s))
@@ -176,7 +176,20 @@ module ViewComponent
   class NilWithContentError < BaseError
     MESSAGE =
       "No content provided to `#with_content` for #{self}.\n\n" \
-      "To fix this issue, pass a value."
+      "To fix this issue, pass a value.".freeze
+  end
+
+  class ReusedInstanceError < StandardError
+    MESSAGE =
+      "ViewComponent instances are single-use; a COMPONENT instance was rendered more than once.\n\n" \
+      "Reusing a component instance across renders can leak request-scoped state " \
+      "(controller, helpers, request, view_flow, slot content, `with_content`) from an earlier render " \
+      "into a later one, which has security and correctness implications (GHSA-8qw7-6phv-7q6p).\n\n" \
+      "To fix this issue, create a new component instance per render.".freeze
+
+    def initialize(klass_name)
+      super(MESSAGE.gsub("COMPONENT", klass_name.to_s))
+    end
   end
 
   class TranslateCalledBeforeRenderError < BaseError
@@ -185,7 +198,7 @@ module ViewComponent
       "on the view context that only exists once a ViewComponent is passed to " \
       "the Rails render pipeline.\n\n" \
       "It's sometimes possible to fix this issue by moving code dependent on " \
-      "`#translate` to a [`#before_render` method](https://viewcomponent.org/api.html#before_render--void)."
+      "`#translate` to a [`#before_render` method](https://viewcomponent.org/api.html#before_render--void).".freeze
   end
 
   class HelpersCalledBeforeRenderError < BaseError
@@ -194,7 +207,7 @@ module ViewComponent
       "on the view context that only exists once a ViewComponent is passed to " \
       "the Rails render pipeline.\n\n" \
       "It's sometimes possible to fix this issue by moving code dependent on " \
-      "`#helpers` to a [`#before_render` method](https://viewcomponent.org/api.html#before_render--void)."
+      "`#helpers` to a [`#before_render` method](https://viewcomponent.org/api.html#before_render--void).".freeze
   end
 
   class ControllerCalledBeforeRenderError < BaseError
@@ -203,20 +216,55 @@ module ViewComponent
       "on the view context that only exists once a ViewComponent is passed to " \
       "the Rails render pipeline.\n\n" \
       "It's sometimes possible to fix this issue by moving code dependent on " \
-      "`#controller` to a [`#before_render` method](https://viewcomponent.org/api.html#before_render--void)."
+      "`#controller` to a [`#before_render` method](https://viewcomponent.org/api.html#before_render--void).".freeze
   end
 
   class SystemTestControllerNefariousPathError < BaseError
-    MESSAGE = "ViewComponent SystemTest controller attempted to load a file outside of the expected directory."
+    MESSAGE = "ViewComponent SystemTest controller attempted to load a file outside of the expected directory.".freeze
   end
 
   class AlreadyDefinedPolymorphicSlotSetterError < StandardError
     MESSAGE =
       "A method called 'SETTER_METHOD_NAME' already exists and would be overwritten by the 'SETTER_NAME' polymorphic " \
-      "slot setter.\n\nPlease choose a different setter name."
+      "slot setter.\n\nPlease choose a different setter name.".freeze
 
     def initialize(setter_method_name, setter_name)
       super(MESSAGE.gsub("SETTER_METHOD_NAME", setter_method_name.to_s).gsub("SETTER_NAME", setter_name.to_s))
     end
   end
+
+  class CacheDigestTemplateError < StandardError
+    MESSAGE =
+      "The synthetic cache digest template for COMPONENT was rendered.\n\n" \
+      "This template exists only so Rails can compute a cache digest for the " \
+      "component and is never meant to be rendered. Render the component " \
+      "itself instead.".freeze
+
+    def initialize(component_name)
+      super(MESSAGE.gsub("COMPONENT", component_name.to_s))
+    end
+  end
+
+  class UndefinedCacheKeyMethodError < StandardError
+    MESSAGE =
+      "`cache_on` declared `METHOD` on COMPONENT, but no such method is defined.\n\n" \
+      "To fix this issue, define `METHOD` or remove it from `cache_on`.".freeze
+
+    def initialize(component_name, method_name)
+      super(MESSAGE.gsub("COMPONENT", component_name.to_s).gsub("METHOD", method_name.to_s))
+    end
+  end
+
+  class ContentPassedToCachedComponentError < StandardError
+    MESSAGE =
+      "COMPONENT declares `cache_on`, so it caches its own output, but its caller passed it content.\n\n" \
+      "Content and slots set by the caller aren't part of the cache key, so caching them would risk " \
+      "serving one caller's content to another.\n\n" \
+      "To fix this issue, either remove `cache_on` from COMPONENT, or move the content into the " \
+      "component and derive it from the values declared in `cache_on`.".freeze
+
+    def initialize(component_name)
+      super(MESSAGE.gsub("COMPONENT", component_name.to_s))
+    end
+  end
 end

data/lib/view_component/experimentally_cacheable.rb

@@ -0,0 +1,285 @@
+# frozen_string_literal: true
+
+require "view_component/cache_digest"
+
+module ViewComponent
+  # Experimental caching support for ViewComponents.
+  #
+  # **This API is experimental.** It may change or be removed in a non-major
+  # release. Please share feedback in
+  # https://github.com/ViewComponent/view_component/issues/234.
+  #
+  # Including this module does two things:
+  #
+  # 1. Registers the component with Rails' template digest tree, so a
+  #    `<% cache %>` block wrapping the component in a view is invalidated when
+  #    the component's template, Ruby class, sidecar files, or child components
+  #    change.
+  # 2. Enables the `cache_on` macro, which caches the component's own rendered
+  #    output.
+  #
+  # ```ruby
+  # class MessageComponent < ViewComponent::Base
+  #   include ViewComponent::ExperimentallyCacheable
+  #
+  #   cache_on :message
+  #
+  #   def initialize(message:)
+  #     @message = message
+  #   end
+  # end
+  # ```
+  module ExperimentallyCacheable
+    extend ActiveSupport::Concern
+
+    # Stands in for `nil` in the cache key. Without it, `expand_cache_key`
+    # renders `nil` and `""` identically, so two components differing only in
+    # that respect would share an entry.
+    NIL_CACHE_VALUE = :__vc_nil
+
+    included do
+      ViewComponent::CacheDigest.install!
+      ViewComponent::CacheDigest.register(self)
+    end
+
+    class_methods do
+      # Declare the values that identify a rendering of this component.
+      #
+      # Each argument names a method on the component whose value is mixed into
+      # the cache key, alongside a digest of the component's source. Private
+      # methods are allowed.
+      #
+      # ```ruby
+      # cache_on :message, :current_user
+      # ```
+      #
+      # Calling `cache_on` opts the component into caching its own output.
+      # Without it, including this module only registers the component with
+      # Rails' digest tree.
+      #
+      # Pass `if:` or `unless:` to cache only some renders. Both accept a method
+      # name or a proc evaluated on the component:
+      #
+      # ```ruby
+      # cache_on :message, if: :persisted?
+      # cache_on :message, unless: -> { message.draft? }
+      # ```
+      #
+      # These methods are called before the component renders, so they can only
+      # depend on the component's own state, not on `helpers` or the view
+      # context.
+      #
+      # @param methods [Array<Symbol>] Methods whose values form the cache key.
+      # @param options [Hash] `:if` and/or `:unless` conditions.
+      # @return [void]
+      def cache_on(*methods, **options, &block)
+        if block
+          raise ArgumentError,
+            "`cache_on` doesn't accept a block. Name the methods whose values form the cache key, " \
+            "such as `cache_on :message`."
+        end
+
+        methods.each do |method|
+          next if method.is_a?(Symbol) || method.is_a?(String)
+
+          raise ArgumentError,
+            "`cache_on` expects method names as symbols, got #{method.class}. " \
+            "Define a method for the value and name it, such as `cache_on :message`."
+        end
+
+        unknown = options.keys - %i[if unless]
+        if unknown.any?
+          raise ArgumentError,
+            "`cache_on` received unknown #{"option".pluralize(unknown.count)} " \
+            "#{unknown.map(&:inspect).to_sentence}. Supported options are `:if` and `:unless`."
+        end
+
+        @__vc_cache_on = __vc_cache_on | methods.map(&:to_sym)
+        @__vc_cache_if = options[:if] if options.key?(:if)
+        @__vc_cache_unless = options[:unless] if options.key?(:unless)
+      end
+
+      # @private
+      def __vc_cache_on
+        @__vc_cache_on ||= superclass.respond_to?(:__vc_cache_on) ? superclass.__vc_cache_on : []
+      end
+
+      # @private
+      def __vc_cache_if
+        return @__vc_cache_if if defined?(@__vc_cache_if)
+
+        superclass.__vc_cache_if if superclass.respond_to?(:__vc_cache_if)
+      end
+
+      # @private
+      def __vc_cache_unless
+        return @__vc_cache_unless if defined?(@__vc_cache_unless)
+
+        superclass.__vc_cache_unless if superclass.respond_to?(:__vc_cache_unless)
+      end
+
+      # @private
+      def __vc_cacheable?
+        true
+      end
+
+      # Whether this component caches its own rendered output.
+      #
+      # @return [Boolean]
+      def __vc_caches_output?
+        __vc_cache_on.any?
+      end
+
+      # A digest of everything this component renders from: its template, its
+      # Ruby class, its sidecar files, its superclasses, and the components and
+      # partials it renders.
+      #
+      # Computed with Rails' own `ActionView::Digestor`, so it's the same digest
+      # used to invalidate `<% cache %>` blocks.
+      #
+      # Usable outside a request, where no view context exists:
+      #
+      # ```ruby
+      # MessageComponent.cache_digest
+      # ```
+      #
+      # @param finder [ActionView::LookupContext] Defaults to a lookup context
+      #   built from `ActionController::Base.view_paths`.
+      # @param format [Symbol]
+      # @return [String]
+      def cache_digest(finder: nil, format: :html)
+        ViewComponent::CacheDigest.digest(
+          self,
+          finder: finder || ViewComponent::CacheDigest.default_finder,
+          format: format
+        )
+      end
+
+      # @private
+      def inherited(child)
+        super
+        ViewComponent::CacheDigest.register(child)
+      end
+    end
+
+    # Renders the component, reading from and writing to the Rails cache when
+    # `cache_on` has been declared.
+    #
+    # @private
+    def render_in(view_context, **, &block)
+      return super unless self.class.__vc_caches_output?
+
+      # Content provided by the caller isn't part of the cache key, so caching
+      # it would serve one caller's content to another. Raised whether or not
+      # caching is currently enabled, so the conflict surfaces in development
+      # and test rather than only in production.
+      if block || __vc_content_set_by_with_content_defined? || __vc_slots_set_by_caller?
+        raise ContentPassedToCachedComponentError.new(self.class.name)
+      end
+
+      return super unless __vc_cache_enabled?(view_context)
+
+      store = Rails.cache
+      key = cache_key(view_context)
+
+      if (cached = store.read(key))
+        # Safe to mark as HTML-safe: the cached string was produced by this same
+        # rendering pipeline, which escapes output before it's written.
+        return cached.html_safe # rubocop:disable Rails/OutputSafety
+      end
+
+      super.tap do |output|
+        store.write(key, output.to_s)
+      end
+    end
+
+    # The cache key for this rendering of the component.
+    #
+    # Combines the component's identity, its source digest, the requested
+    # format and variant, the current locale, and the values declared with
+    # `cache_on`. Override for full control.
+    #
+    # @param view_context [ActionView::Base]
+    # @return [String]
+    def cache_key(view_context = nil)
+      lookup_context = view_context&.lookup_context
+      format = __vc_cache_format(lookup_context)
+
+      parts = [
+        "view_component",
+        self.class.virtual_path,
+        self.class.cache_digest(finder: lookup_context, format: format),
+        # Included in its own right, not just as a digest input: components that
+        # render every format from one template have the same digest for each.
+        format,
+        __vc_cache_variant(lookup_context),
+        I18n.locale,
+        *__vc_cache_on_values
+      ]
+
+      # Positions are significant, so nils are substituted rather than removed.
+      # Compacting the array would let a nil in one position collapse into a nil
+      # in another.
+      ActiveSupport::Cache.expand_cache_key(
+        parts.map { |part| part.nil? ? NIL_CACHE_VALUE : part }
+      )
+    end
+
+    private
+
+    # Slots set by the caller via `with_*`. Checked before rendering, so slots
+    # a component fills in for itself with a `default_*` method — which resolve
+    # lazily during the render — aren't counted.
+    def __vc_slots_set_by_caller?
+      defined?(@__vc_set_slots) && @__vc_set_slots.present?
+    end
+
+    def __vc_cache_enabled?(view_context)
+      return false unless defined?(Rails) && Rails.respond_to?(:cache) && Rails.cache
+      return false unless __vc_cache_conditions_met?
+
+      controller = view_context.try(:controller)
+      controller.respond_to?(:perform_caching) && controller.perform_caching
+    end
+
+    def __vc_cache_conditions_met?
+      if (condition = self.class.__vc_cache_if)
+        return false unless __vc_evaluate_cache_condition(condition)
+      end
+
+      if (condition = self.class.__vc_cache_unless)
+        return false if __vc_evaluate_cache_condition(condition)
+      end
+
+      true
+    end
+
+    def __vc_evaluate_cache_condition(condition)
+      return instance_exec(&condition) if condition.respond_to?(:to_proc) && !condition.is_a?(Symbol)
+
+      unless respond_to?(condition, true)
+        raise UndefinedCacheKeyMethodError.new(self.class.name, condition)
+      end
+
+      send(condition)
+    end
+
+    def __vc_cache_on_values
+      self.class.__vc_cache_on.map do |method_name|
+        unless respond_to?(method_name, true)
+          raise UndefinedCacheKeyMethodError.new(self.class.name, method_name)
+        end
+
+        send(method_name)
+      end
+    end
+
+    def __vc_cache_format(lookup_context)
+      Array(lookup_context&.formats).first || :html
+    end
+
+    def __vc_cache_variant(lookup_context)
+      Array(lookup_context&.variants).first
+    end
+  end
+end

data/lib/view_component/instrumentation.rb

@@ -8,7 +8,7 @@ module ViewComponent # :nodoc:
       mod.prepend(self) unless self <= ViewComponent::Instrumentation
     end
 
-    def render_in(view_context, **_, &block)
+    def render_in(...)
       return super if !Rails.application.config.view_component.instrumentation_enabled.present?
 
       payload = {

data/lib/view_component/request_details.rb

@@ -11,6 +11,8 @@ module ViewComponent
   # We're exposing it to the compiler via `refine` so that ViewComponent
   # can match Rails' template picking logic.
   module RequestDetails
+    EMPTY_DETAILS = {}.freeze
+
     refine ActionView::LookupContext do
       # Return an abstraction for matching and sorting available templates
       # based on the current lookup context details.
@@ -18,7 +20,7 @@ module ViewComponent
       # @return ActionView::TemplateDetails::Requested
       # @see ActionView::LookupContext#detail_args_for
       # @see ActionView::FileSystemResolver#_find_all
-      def vc_requested_details(user_details = {})
+      def vc_requested_details(user_details = EMPTY_DETAILS)
         # The hash `user_details` would normally be the standard arguments that
         # `render` accepts, but there's currently no mechanism for users to
         # provide these when calling render on a ViewComponent.