view_component 4.0.0.rc4 → 4.0.0.rc5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3d836f60a33d5a66087281b9edbb578a118d706721160676173390a8eab5d361
-  data.tar.gz: 9c6129650fbc464da3e315244eba6a893d5722dc9e577673efb0f3b090279386
+  metadata.gz: 2022f4dafcbde4a0b374fc19399e58a9a7ff97ba64b3567de75ec24c9bb9e8eb
+  data.tar.gz: 2936979e68ecbe66cc0cc0b8a9ab77064265cb4d0763974daa6eb22c4b2a4e5d
 SHA512:
-  metadata.gz: 46da774d6dd963153254af7e11ce5d03891d69c302e48220b5e7f54795ebdb58ca93d09af9975c47076bb58a13f379df60fafff04b597b5236bd77c3e2d122c2
-  data.tar.gz: a4038c0360c90b2958ce31b31bd50260d6e10964e15733de9c2a7b57488ddaaa0773d583da2efdbe81c7aaae340ad1f8324f00283dac5bd3db69588befb1b76d
+  metadata.gz: c124cc7b4de10d07896f5c1fd80a2533a606f29de5406836b6d63968261e1de54e1cbe682879a2e20fe66e3173f1178111ce5047177b9130ac359cbdb7b759d0
+  data.tar.gz: 228eee5270b9d0b6d2ac0395151255759fb73faea87365a79fc42b301b7d5ddac0f6d260f040a5801981a067f84f02735624236af86937ed5eee7a2080aad2c9

data/docs/CHANGELOG.md

@@ -10,6 +10,20 @@ nav_order: 6
 
 ## main
 
+## 4.0.0.rc5
+
+* Revert change setting `#format`. In GitHub's codebase, the change led to hard-to-detect failures. For example, components rendered from controllers included layouts when they didn't before. In other cases, the response `content_type` changed, breaking downstream consumers. For cases where a specific content type is needed, use:
+
+```ruby
+respond_to do |f|
+  f.html_fragment do
+    render(MyComponent.new)
+  end
+end
+```
+
+    *Joel Hawksley*
+
 ## 4.0.0.rc4
 
 * Fix issue where generators were not included in published gem.

data/lib/view_component/base.rb

@@ -71,8 +71,6 @@ module ViewComponent
     # Config option that strips trailing whitespace in templates before compiling them.
     class_attribute :__vc_strip_trailing_whitespace, instance_accessor: false, instance_predicate: false, default: false
 
-    class_attribute :__vc_response_format, instance_accessor: false, instance_predicate: false, default: nil
-
     attr_accessor :__vc_original_view_context
     attr_reader :current_template
 
@@ -356,10 +354,6 @@ module ViewComponent
       __vc_render_in_block_provided? || __vc_content_set_by_with_content_defined?
     end
 
-    def format
-      self.class.__vc_response_format
-    end
-
     # @private
     def with_original_virtual_path
       @view_context.instance_variable_set(:@virtual_path, @old_virtual_path)

data/lib/view_component/compiler.rb

@@ -48,15 +48,6 @@ module ViewComponent
 
         define_render_template_for
 
-        # Set the format if the component only responds to a single format.
-        # Unfortunately we cannot determine which format a multi-format
-        # component will respond to until render time, so those components
-        # will not set the response format.
-        #
-        # TODO: Investigate upstream changes necessary to support multi-format renderables
-        unique_formats = templates.map(&:format).uniq
-        @component.__vc_response_format = unique_formats.last if unique_formats.one?
-
         @component.__vc_register_default_slots
         @component.__vc_build_i18n_backend
 
@@ -118,7 +109,6 @@ module ViewComponent
         errors << "Couldn't find a template file or inline render method for #{@component}." if @templates.empty?
 
         @templates
-          .reject { |template| template.inline_call? && !template.defined_on_self? }
           .map { |template| [template.variant, template.format] }
           .tally
           .select { |_, count| count > 1 }

data/lib/view_component/template.rb

@@ -43,7 +43,7 @@ module ViewComponent
       attr_reader :source
 
       def initialize(component:, inline_template:)
-        details = ActionView::TemplateDetails.new(nil, inline_template.language.to_sym, DEFAULT_FORMAT, nil)
+        details = ActionView::TemplateDetails.new(nil, inline_template.language.to_sym, nil, nil)
 
         super(
           component: component,
@@ -63,7 +63,7 @@ module ViewComponent
     class InlineCall < Template
       def initialize(component:, method_name:, defined_on_self:)
         variant = method_name.to_s.include?("call_") ? method_name.to_s.sub("call_", "").to_sym : nil
-        details = ActionView::TemplateDetails.new(nil, nil, DEFAULT_FORMAT, variant)
+        details = ActionView::TemplateDetails.new(nil, nil, nil, variant)
 
         super(component: component, details: details)
 

data/lib/view_component/version.rb

@@ -5,7 +5,7 @@ module ViewComponent
     MAJOR = 4
     MINOR = 0
     PATCH = 0
-    PRE = "rc4"
+    PRE = "rc5"
 
     STRING = [MAJOR, MINOR, PATCH, PRE].compact.join(".")
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: view_component
 version: !ruby/object:Gem::Version
-  version: 4.0.0.rc4
+  version: 4.0.0.rc5
 platform: ruby
 authors:
 - ViewComponent Team