view_component 3.0.0.rc4 → 3.0.0.rc5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 53d058ef489a0f7230b3a83fe92d36fab42b9b8ccf0cd2bba0d12f7320f2c261
-  data.tar.gz: de28dc5a7e3e9c34c3cf81bbd5d52f518c653950552547c86a547bb4a577bdfa
+  metadata.gz: 3746041e156447e727a9974ad435795bd08333c13f6004ba5a03f629764d301d
+  data.tar.gz: 47e3d85474b5cb69fbc12abb48a59a85776f14475508ff55f40f672f393bd309
 SHA512:
-  metadata.gz: d6161e41e5b9b82ce20f9ffc624cfe2910e707d867e2ba0019bc960a02353e7d2b083700e3504ea1f84da83f9a31110eb581a07a16609d30c6a7737806f5986e
-  data.tar.gz: c137ce79675ec78c4f31dff419b42fdf31d2af696e2275047d74058c7e1402be00e0e44df125ea6c5803b59e6931d8a7619c9c266376b02881965a778e60d784
+  metadata.gz: cc5edccc814c845eb63ce951e621365ec9ec3013363b32b0bc5f05db8a0fb15ea26688eae22f54fcc17bbc477c5e93350cd0b3fbf3af9bd1e27f1f3f9e53cbec
+  data.tar.gz: d87a2ee301acf5b4e67ec159bc3433ce2d46da343de5da26af975314b862b4befbfdd247a0046239b99bb322e26b4062625073424ba0fd7e54a1e973a2d56ebd

data/app/controllers/view_components_system_test_controller.rb

@@ -1,11 +1,13 @@
 # frozen_string_literal: true
 
 class ViewComponentsSystemTestController < ActionController::Base # :nodoc:
-  TEMP_DIR = FileUtils.mkdir_p("./tmp/view_components/").first
-
   before_action :validate_test_env
   before_action :validate_file_path
 
+  def self.temp_dir
+    @_tmpdir ||= FileUtils.mkdir_p("./tmp/view_components/").first
+  end
+
   def system_test_entrypoint
     render file: @path
   end
@@ -19,7 +21,7 @@ class ViewComponentsSystemTestController < ActionController::Base # :nodoc:
   # Ensure that the file path is valid and doesn't target files outside
   # the expected directory (e.g. via a path traversal or symlink attack)
   def validate_file_path
-    base_path = ::File.realpath(TEMP_DIR)
+    base_path = ::File.realpath(self.class.temp_dir)
     @path = ::File.realpath(params.permit(:file)[:file], base_path)
     unless @path.start_with?(base_path)
       raise ArgumentError, "Invalid file path"

data/docs/CHANGELOG.md

@@ -10,6 +10,20 @@ nav_order: 5
 
 ## main
 
+## v3.0.0.rc5
+
+* Fix bug where `mkdir_p` failed due to incorrect permissions.
+
+    *Joel Hawksley*
+
+* Check for inline `erb_template` calls when deciding whether or not to compile a component's superclass.
+
+    *Justin Kenyon*
+
+* Protect against `SystemStackError` if `CaptureCompatibility` module is included more than once.
+
+    *Cameron Dutro*
+
 ## v3.0.0.rc4
 
 Run into an issue with this release candidate? [Let us know](https://github.com/ViewComponent/view_component/issues/1629).

data/lib/view_component/capture_compatibility.rb

@@ -17,6 +17,8 @@ module ViewComponent
   # the `capture` logic to the ViewComponent that created the block.
   module CaptureCompatibility
     def self.included(base)
+      return if base < InstanceMethods
+
       base.class_eval do
         alias_method :original_capture, :capture
       end

data/lib/view_component/compiler.rb

@@ -285,8 +285,7 @@ module ViewComponent
     end
 
     def should_compile_superclass?
-      development? &&
-        templates.empty? &&
+      development? && templates.empty? && !has_inline_template? &&
         !(
           component_class.instance_methods(false).include?(:call) ||
             component_class.private_instance_methods(false).include?(:call)

data/lib/view_component/system_test_helpers.rb

@@ -12,7 +12,7 @@ module ViewComponent
     def with_rendered_component_path(fragment, layout: false, &block)
       file = Tempfile.new(
         ["rendered_#{fragment.class.name}", ".html"],
-        ViewComponentsSystemTestController::TEMP_DIR
+        ViewComponentsSystemTestController.temp_dir
       )
       begin
         file.write(vc_test_controller.render_to_string(html: fragment.to_html.html_safe, layout: layout))

data/lib/view_component/version.rb

@@ -5,7 +5,7 @@ module ViewComponent
     MAJOR = 3
     MINOR = 0
     PATCH = 0
-    PRE = "rc4"
+    PRE = "rc5"
 
     STRING = [MAJOR, MINOR, PATCH, PRE].compact.join(".")
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: view_component
 version: !ruby/object:Gem::Version
-  version: 3.0.0.rc4
+  version: 3.0.0.rc5
 platform: ruby
 authors:
 - ViewComponent Team
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-03-09 00:00:00.000000000 Z
+date: 2023-03-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport