view_component 2.45.0 → 2.46.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a209f06f513d226dba5ddcfefe8c08d16f84da6d8664fd9a4f2f70fe1ef48d96
-  data.tar.gz: cc11c7e358b6fa3b07474a257202be93b0283c7c6189ce8d939770a805a28ef6
+  metadata.gz: b9b1ca38d53b64e55ff434c43f11839cf122d82d17768c2f064e2622ef88dc88
+  data.tar.gz: 7bc10806de04abbe6c7458305592d09ea6f4dfe9d86aff5d0cf0b9b9cfa9a620
 SHA512:
-  metadata.gz: 2420eadefc54d1045c432b7b53010281bd923b556b72d4ed924b49a0a88b1841800d6e04f25bb043913f5c648693d19ad56117e441c838e7eb09e0ab5cf21315
-  data.tar.gz: 4deb4c925810fcc2e3918e8735dd957003536e5533289d48caf69100dcb5ed58af6bb7af88fdc0cdf3c73e9905bb0222de18d9fd6cba65ca05e6bc3ed1f9964f
+  metadata.gz: 5c100fe77483f4b5f7227a47188f63428cbde65ebddf75cd0accf881d2140536150ea1d52f5c68b66126dd5087d9ac7fd7725f4c829a82d58c5cf86ef8abff2e
+  data.tar.gz: 19e3230c2b894651462dd6dbae44b4579267cc662c962e2bf9208e28cea299e01286427ae3c949d5622e8302cad4ba2b8f5e58a6aa6dabd3e872de367affb8bb

data/README.md

@@ -1,4 +1,5 @@
-<img src="/docs/logo/github-readme-logo.svg" alt="ViewComponent logo" width="400">
+![ViewComponent logo](/docs/logo/readme-light.svg#gh-light-mode-only)
+![ViewComponent logo](/docs/logo/readme-dark.svg#gh-dark-mode-only)
 
 A framework for building reusable, testable & encapsulated view components in Ruby on Rails.
 

data/docs/CHANGELOG.md

@@ -7,6 +7,24 @@ title: Changelog
 
 ## main
 
+## 2.46.0
+
+* Add thread safety to the compiler.
+
+    *Horia Radu*
+
+* Add theme-specific logo images to readme.
+
+    *Dylan Smith*
+
+* Add Orbit to users list.
+
+    *Nicolas Goutay*
+
+* Increase clarity around purpose and use of slots.
+
+    *Simon Fish*
+
 ## 2.45.0
 
 * Remove internal APIs from API documentation, fix link to license.
@@ -45,6 +63,10 @@ title: Changelog
 
     *Yoshiyuki Hirano*
 
+* Deprecate engine loading manually.
+
+    *Yoshiyuki Hirano*
+
 ## 2.44.0
 
 * Rename internal accessor to use private naming.

data/lib/view_component/compile_cache.rb

@@ -18,6 +18,10 @@ module ViewComponent
       cache.include? klass
     end
 
+    def invalidate_class!(klass)
+      cache.delete(klass)
+    end
+
     def invalidate!
       cache.clear
     end

data/lib/view_component/compiler.rb

@@ -2,8 +2,12 @@
 
 module ViewComponent
   class Compiler
+    # Lock required to be obtained before compiling the component
+    attr_reader :__vc_compiler_lock
+
     def initialize(component_class)
       @component_class = component_class
+      @__vc_compiler_lock = Monitor.new
     end
 
     def compiled?
@@ -13,55 +17,59 @@ module ViewComponent
     def compile(raise_errors: false)
       return if compiled?
 
-      subclass_instance_methods = component_class.instance_methods(false)
+      __vc_compiler_lock.synchronize do
+        CompileCache.invalidate_class!(component_class)
 
-      if subclass_instance_methods.include?(:with_content) && raise_errors
-        raise ViewComponent::ComponentError.new(
-          "#{component_class} implements a reserved method, `#with_content`.\n\n" \
-          "To fix this issue, change the name of the method."
-        )
-      end
+        subclass_instance_methods = component_class.instance_methods(false)
 
-      if template_errors.present?
-        raise ViewComponent::TemplateError.new(template_errors) if raise_errors
-
-        return false
-      end
+        if subclass_instance_methods.include?(:with_content) && raise_errors
+          raise ViewComponent::ComponentError.new(
+            "#{component_class} implements a reserved method, `#with_content`.\n\n" \
+            "To fix this issue, change the name of the method."
+          )
+        end
 
-      if subclass_instance_methods.include?(:before_render_check)
-        ActiveSupport::Deprecation.warn(
-          "`#before_render_check` will be removed in v3.0.0.\n\n" \
-          "To fix this issue, use `#before_render` instead."
-        )
-      end
+        if template_errors.present?
+          raise ViewComponent::TemplateError.new(template_errors) if raise_errors
 
-      if raise_errors
-        component_class.validate_initialization_parameters!
-        component_class.validate_collection_parameter!
-      end
+          return false
+        end
 
-      templates.each do |template|
-        # Remove existing compiled template methods,
-        # as Ruby warns when redefining a method.
-        method_name = call_method_name(template[:variant])
+        if subclass_instance_methods.include?(:before_render_check)
+          ActiveSupport::Deprecation.warn(
+            "`#before_render_check` will be removed in v3.0.0.\n\n" \
+            "To fix this issue, use `#before_render` instead."
+          )
+        end
 
-        if component_class.instance_methods.include?(method_name.to_sym)
-          component_class.send(:undef_method, method_name.to_sym)
+        if raise_errors
+          component_class.validate_initialization_parameters!
+          component_class.validate_collection_parameter!
         end
 
-        component_class.class_eval <<-RUBY, template[:path], -1
-          def #{method_name}
-            @output_buffer = ActionView::OutputBuffer.new
-            #{compiled_template(template[:path])}
+        templates.each do |template|
+          # Remove existing compiled template methods,
+          # as Ruby warns when redefining a method.
+          method_name = call_method_name(template[:variant])
+
+          if component_class.instance_methods.include?(method_name.to_sym)
+            component_class.send(:undef_method, method_name.to_sym)
           end
-        RUBY
-      end
 
-      define_render_template_for
+          component_class.class_eval <<-RUBY, template[:path], -1
+            def #{method_name}
+              @output_buffer = ActionView::OutputBuffer.new
+              #{compiled_template(template[:path])}
+            end
+          RUBY
+        end
+
+        define_render_template_for
 
-      component_class._after_compile
+        component_class._after_compile
 
-      CompileCache.register(component_class)
+        CompileCache.register(component_class)
+      end
     end
 
     private

data/lib/view_component/engine.rb

@@ -145,6 +145,13 @@ module ViewComponent
   end
 end
 
-# In the case of automatic loading, "view_component" is loaded first,
-# so there is no need to load it.
-require "view_component" unless defined?(ViewComponent::Base)
+# :nocov:
+unless defined?(ViewComponent::Base)
+  ActiveSupport::Deprecation.warn(
+    "This manually engine loading is deprecated and will be removed in v3.0.0. " \
+    "Remove `require \"view_component/engine\"`."
+  )
+
+  require "view_component"
+end
+# :nocov:

data/lib/view_component/version.rb

@@ -3,7 +3,7 @@
 module ViewComponent
   module VERSION
     MAJOR = 2
-    MINOR = 45
+    MINOR = 46
     PATCH = 0
 
     STRING = [MAJOR, MINOR, PATCH].join(".")

data/lib/view_component.rb

@@ -19,6 +19,13 @@ module ViewComponent
   autoload :Translatable
 end
 
-# In the case of manually loading, "view_component/engine" is loaded first,
-# so there is no need to load it.
-require "view_component/engine" if defined?(Rails::Engine) && !defined?(ViewComponent::Engine)
+# :nocov:
+if defined?(ViewComponent::Engine)
+  ActiveSupport::Deprecation.warn(
+    "This manually engine loading is deprecated and will be removed in v3.0.0. " \
+    "Remove `require \"view_component/engine\"`."
+  )
+elsif defined?(Rails::Engine)
+  require "view_component/engine"
+end
+# :nocov:

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: view_component
 version: !ruby/object:Gem::Version
-  version: 2.45.0
+  version: 2.46.0
 platform: ruby
 authors:
 - GitHub Open Source
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-11-23 00:00:00.000000000 Z
+date: 2021-12-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport