vidibus-versioning 0.1.3 → 0.2.0

data/README.md

@@ -72,6 +72,14 @@ To apply a version on the current article itself (without persisting it), call `
 article.version!(3) # applies version 3 to the article and returns nil
 ```
 
+To find out if a version exists, call:
+
+```ruby
+article.version?(1) # returns true on a fresh object
+article.version?(2) # returns true if version 2 exists
+article.version?(3) # returns false if version 3 does not exist
+```
+
 It is even possible to apply versioned attributes directly by adding them to the `version` call:
 
 ```ruby

data/lib/vidibus/versioning/_version.rb

@@ -1,5 +1,5 @@
 module Vidibus
   module Versioning
-    VERSION = '0.1.3'
+    VERSION = '0.2.0'
   end
 end

data/lib/vidibus/versioning/errors.rb

@@ -2,5 +2,6 @@ module Vidibus
   module Versioning
     class Error < StandardError; end
     class MigrationError < Error; end
+    class VersionNotFoundError < Error; end
   end
 end

data/lib/vidibus/versioning/mongoid.rb

@@ -64,6 +64,18 @@ module Vidibus
         self.apply_version!(*args)
       end
 
+      # Returns true if version number exists.
+      # Argument must be an integer.
+      #
+      def version?(number)
+        raise ArgumentError unless number.is_a?(Integer)
+        if version_number == number
+          true
+        else
+          !!versions.where(:number => number).first
+        end
+      end
+
       # Applies attributes of wanted version on self.
       # Stores current attributes in a new version.
       def migrate!(number = nil)
@@ -141,8 +153,14 @@ module Vidibus
       def apply_version!(*args)
         raise ArgumentError if args.empty?
         set_version_args(*args)
-        version_cache.self_version = (version_number == version_cache.wanted_version_number)
-        return if version_cache.self_version
+        if version_number == version_cache.wanted_version_number
+          version_cache.self_version = true
+          return
+        end
+        version_cache.self_version = false
+        unless version_obj
+          raise VersionNotFoundError.new("version #{version_cache.wanted_version_number} does not exist")
+        end
 
         self.attributes = version_attributes
         self.version_number = version_cache.wanted_version_number
@@ -199,14 +217,15 @@ module Vidibus
       def set_version_args(*args)
         version_cache.version_args = args
         version_cache.wanted_attributes = args.extract_options!
-        wanted_version_number = args.first
+        num = args.first
 
-        version_cache.wanted_version_number = case wanted_version_number
+        version_cache.wanted_version_number = case num
         when :new, 'new' then new_version_number
         when :next, 'next' then version_number + 1
         when :previous, 'previous' then version_number - 1
         else
-          wanted_version_number.to_i
+          version_cache.existing_version_wanted = true
+          num.to_i
         end
 
         if version_cache.wanted_version_number < 1
@@ -235,7 +254,7 @@ module Vidibus
           if version_cache.wanted_version_number
             obj = versions.
               where(:number => version_cache.wanted_version_number).first
-            unless obj || version_cache.self_version
+            unless obj || version_cache.self_version || version_cache.existing_version_wanted
               # versions.to_a # TODO: prefetch versions before building a new one?
               obj = versions.build({
                 :number => version_cache.wanted_version_number,
@@ -268,6 +287,7 @@ module Vidibus
       def version_cache
         @version_cache ||= Struct.new(
           :wanted_version_number,
+          :existing_version_wanted,
           :wanted_attributes,
           :new_version_number,
           :version_obj,

data/lib/vidibus/versioning/version.rb

@@ -22,11 +22,11 @@ module Vidibus
       scope :timeline, desc(:created_at)
 
       def past?
-        @is_past ||= created_at && created_at < Time.now
+        created_at && created_at < Time.now
       end
 
       def future?
-        @is_future ||= !created_at || created_at >= Time.now
+        created_at && created_at >= Time.now
       end
 
       protected

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: vidibus-versioning
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.2.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-08-21 00:00:00.000000000 Z
+date: 2013-08-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mongoid
@@ -185,7 +185,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -1266597105678882758
+      hash: 819804143186839926
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements: