video_info 2.3.1 → 2.3.2

data/spec/lib/video_info/providers/youtube_spec.rb

@@ -7,61 +7,136 @@ describe VideoInfo::Providers::Youtube do
 
     context "with youtube.com url" do
       let(:url) { 'http://www.youtube.com/watch?v=Xp6CXF' }
-      it { should be_true }
+      it { is_expected.to be_truthy }
     end
 
     context "with youtu.be url" do
       let(:url) { 'http://youtu.be/JM9NgvjjVng' }
-      it { should be_true }
+      it { is_expected.to be_truthy }
     end
 
     context "with other url" do
       let(:url) { 'http://google.com/video1' }
-      it { should be_false }
+      it { is_expected.to be_falsey }
     end
 
     context "with playlist url" do
       let(:url) { 'http://www.youtube.com/playlist?p=PLA575C81A1FBC04CF' }
-      it { should be_false }
+      it { is_expected.to be_falsey }
     end
   end
 
   describe "#available?" do
     context "with valid video", :vcr do
       subject { VideoInfo.new('http://www.youtube.com/watch?v=mZqGqE0D0n4') }
-      its(:available?)       { should be_true }
+
+      describe '#available?' do
+        subject { super().available? }
+        it { is_expected.to be_truthy }
+      end
     end
 
     context "with 'video is unavailable' video", :vcr do
       subject { VideoInfo.new('http://www.youtube.com/watch?v=SUkXvWn1m7Q') }
-      its(:available?)       { should be_false }
+
+      describe '#available?' do
+        subject { super().available? }
+        it { is_expected.to be_falsey }
+      end
     end
 
     context "with 'video no longer available due to a copyright claim' video", :vcr do
       subject { VideoInfo.new('http://www.youtube.com/watch?v=ffClNhwx0KU') }
-      its(:available?)       { should be_false }
+
+      describe '#available?' do
+        subject { super().available? }
+        it { is_expected.to be_falsey }
+      end
     end
   end
 
   context "with video mZqGqE0D0n4", :vcr do
     subject { VideoInfo.new('http://www.youtube.com/watch?v=mZqGqE0D0n4') }
 
-    its(:provider)         { should eq 'YouTube' }
-    its(:video_id)         { should eq 'mZqGqE0D0n4' }
-    its(:url)              { should eq 'http://www.youtube.com/watch?v=mZqGqE0D0n4' }
-    its(:embed_url)        { should eq '//www.youtube.com/embed/mZqGqE0D0n4' }
-    its(:embed_code)       { should eq '<iframe src="//www.youtube.com/embed/mZqGqE0D0n4" frameborder="0" allowfullscreen="allowfullscreen"></iframe>' }
-    its(:title)            { should eq 'Cherry Bloom - King Of The Knife' }
-    its(:description)      { should eq 'The first video from the upcoming album Secret Sounds, to download in-stores April 14. Checkout http://www.cherrybloom.net' }
-    its(:keywords)         { should be_nil }
-    its(:duration)         { should eq 176 }
-    its(:width)            { should be_nil }
-    its(:height)           { should be_nil }
-    its(:date)             { should eq Time.parse('Sat Apr 12 22:25:35 UTC 2008', Time.now.utc) }
-    its(:thumbnail_small)  { should eq 'http://i1.ytimg.com/vi/mZqGqE0D0n4/default.jpg' }
-    its(:thumbnail_medium) { should eq 'http://i1.ytimg.com/vi/mZqGqE0D0n4/mqdefault.jpg' }
-    its(:thumbnail_large)  { should eq 'http://i1.ytimg.com/vi/mZqGqE0D0n4/hqdefault.jpg' }
-    its(:view_count)       { should be > 4000 }
+    describe '#provider' do
+      subject { super().provider }
+      it { is_expected.to eq 'YouTube' }
+    end
+
+    describe '#video_id' do
+      subject { super().video_id }
+      it { is_expected.to eq 'mZqGqE0D0n4' }
+    end
+
+    describe '#url' do
+      subject { super().url }
+      it { is_expected.to eq 'http://www.youtube.com/watch?v=mZqGqE0D0n4' }
+    end
+
+    describe '#embed_url' do
+      subject { super().embed_url }
+      it { is_expected.to eq '//www.youtube.com/embed/mZqGqE0D0n4' }
+    end
+
+    describe '#embed_code' do
+      subject { super().embed_code }
+      it { is_expected.to eq '<iframe src="//www.youtube.com/embed/mZqGqE0D0n4" frameborder="0" allowfullscreen="allowfullscreen"></iframe>' }
+    end
+
+    describe '#title' do
+      subject { super().title }
+      it { is_expected.to eq 'Cherry Bloom - King Of The Knife' }
+    end
+
+    describe '#description' do
+      subject { super().description }
+      it { is_expected.to eq 'The first video from the upcoming album Secret Sounds, to download in-stores April 14. Checkout http://www.cherrybloom.net' }
+    end
+
+    describe '#keywords' do
+      subject { super().keywords }
+      it { is_expected.to be_nil }
+    end
+
+    describe '#duration' do
+      subject { super().duration }
+      it { is_expected.to eq 176 }
+    end
+
+    describe '#width' do
+      subject { super().width }
+      it { is_expected.to be_nil }
+    end
+
+    describe '#height' do
+      subject { super().height }
+      it { is_expected.to be_nil }
+    end
+
+    describe '#date' do
+      subject { super().date }
+      it { is_expected.to eq Time.parse('Sat Apr 12 22:25:35 UTC 2008', Time.now.utc) }
+    end
+
+    describe '#thumbnail_small' do
+      subject { super().thumbnail_small }
+      it { is_expected.to eq 'http://i.ytimg.com/vi/mZqGqE0D0n4/default.jpg' }
+    end
+
+    describe '#thumbnail_medium' do
+      subject { super().thumbnail_medium }
+      it { is_expected.to eq 'http://i.ytimg.com/vi/mZqGqE0D0n4/mqdefault.jpg' }
+    end
+
+    describe '#thumbnail_large' do
+      subject { super().thumbnail_large }
+      it { is_expected.to eq 'http://i.ytimg.com/vi/mZqGqE0D0n4/hqdefault.jpg' }
+    end
+
+    describe '#view_count' do
+      subject { super().view_count }
+      it { is_expected.to be > 4000 }
+    end
   end
 
   context "with video oQ49W_xKzKA", :vcr do
@@ -73,79 +148,160 @@ describe VideoInfo::Providers::Youtube do
   context "with video oQ49W_xKzKA", :vcr do
     subject { VideoInfo.new('http://www.youtube.com/watch?v=oQ49W_xKzKA') }
 
-    its(:provider) { should eq 'YouTube' }
-    its(:video_id) { should eq 'oQ49W_xKzKA' }
+    describe '#provider' do
+      subject { super().provider }
+      it { is_expected.to eq 'YouTube' }
+    end
+
+    describe '#video_id' do
+      subject { super().video_id }
+      it { is_expected.to eq 'oQ49W_xKzKA' }
+    end
   end
 
   context "with video Xp6CXF-Cesg", :vcr do
     subject { VideoInfo.new('http://www.youtube.com/watch?v=Xp6CXF-Cesg') }
 
-    its(:provider) { should eq 'YouTube' }
-    its(:video_id) { should eq 'Xp6CXF-Cesg' }
+    describe '#provider' do
+      subject { super().provider }
+      it { is_expected.to eq 'YouTube' }
+    end
+
+    describe '#video_id' do
+      subject { super().video_id }
+      it { is_expected.to eq 'Xp6CXF-Cesg' }
+    end
   end
 
   context "with video VeasFckfMHY in user url", :vcr do
     subject { VideoInfo.new('http://www.youtube.com/user/EducatorVids3?v=VeasFckfMHY') }
 
-    its(:provider) { should eq 'YouTube' }
-    its(:video_id) { should eq 'VeasFckfMHY' }
-    its(:url)      { should eq 'http://www.youtube.com/user/EducatorVids3?v=VeasFckfMHY' }
+    describe '#provider' do
+      subject { super().provider }
+      it { is_expected.to eq 'YouTube' }
+    end
+
+    describe '#video_id' do
+      subject { super().video_id }
+      it { is_expected.to eq 'VeasFckfMHY' }
+    end
+
+    describe '#url' do
+      subject { super().url }
+      it { is_expected.to eq 'http://www.youtube.com/user/EducatorVids3?v=VeasFckfMHY' }
+    end
   end
 
   context "with video VeasFckfMHY after params", :vcr do
     subject { VideoInfo.new('http://www.youtube.com/watch?feature=player_profilepage&v=VeasFckfMHY') }
 
-    its(:provider) { should eq 'YouTube' }
-    its(:video_id) { should eq 'VeasFckfMHY' }
-    its(:url)      { should eq 'http://www.youtube.com/watch?feature=player_profilepage&v=VeasFckfMHY' }
+    describe '#provider' do
+      subject { super().provider }
+      it { is_expected.to eq 'YouTube' }
+    end
+
+    describe '#video_id' do
+      subject { super().video_id }
+      it { is_expected.to eq 'VeasFckfMHY' }
+    end
+
+    describe '#url' do
+      subject { super().url }
+      it { is_expected.to eq 'http://www.youtube.com/watch?feature=player_profilepage&v=VeasFckfMHY' }
+    end
   end
 
   context "with video VeasFckfMHY in path", :vcr do
     subject { VideoInfo.new('http://www.youtube.com/v/VeasFckfMHY') }
 
-    its(:provider) { should eq 'YouTube' }
-    its(:video_id) { should eq 'VeasFckfMHY' }
+    describe '#provider' do
+      subject { super().provider }
+      it { is_expected.to eq 'YouTube' }
+    end
+
+    describe '#video_id' do
+      subject { super().video_id }
+      it { is_expected.to eq 'VeasFckfMHY' }
+    end
   end
 
   context "with video VeasFckfMHY in e path", :vcr do
     subject { VideoInfo.new('http://www.youtube.com/e/VeasFckfMHY') }
 
-    its(:provider) { should eq 'YouTube' }
-    its(:video_id) { should eq 'VeasFckfMHY' }
+    describe '#provider' do
+      subject { super().provider }
+      it { is_expected.to eq 'YouTube' }
+    end
+
+    describe '#video_id' do
+      subject { super().video_id }
+      it { is_expected.to eq 'VeasFckfMHY' }
+    end
   end
 
   context "with video VeasFckfMHY in embed path", :vcr do
     subject { VideoInfo.new('http://www.youtube.com/embed/VeasFckfMHY') }
 
-    its(:provider) { should eq 'YouTube' }
-    its(:video_id) { should eq 'VeasFckfMHY' }
+    describe '#provider' do
+      subject { super().provider }
+      it { is_expected.to eq 'YouTube' }
+    end
+
+    describe '#video_id' do
+      subject { super().video_id }
+      it { is_expected.to eq 'VeasFckfMHY' }
+    end
   end
 
   context "with video JM9NgvjjVng in youtu.be url", :vcr do
     subject { VideoInfo.new('http://youtu.be/JM9NgvjjVng') }
 
-    its(:provider) { should eq 'YouTube' }
-    its(:video_id) { should eq 'JM9NgvjjVng' }
+    describe '#provider' do
+      subject { super().provider }
+      it { is_expected.to eq 'YouTube' }
+    end
+
+    describe '#video_id' do
+      subject { super().video_id }
+      it { is_expected.to eq 'JM9NgvjjVng' }
+    end
   end
 
   context 'without http or www', :vcr do
     subject { VideoInfo.new('youtu.be/JM9NgvjjVng') }
 
-    its(:provider) { should == 'YouTube' }
-    its(:video_id) { should eq 'JM9NgvjjVng' }
+    describe '#provider' do
+      subject { super().provider }
+      it { is_expected.to eq('YouTube') }
+    end
+
+    describe '#video_id' do
+      subject { super().video_id }
+      it { is_expected.to eq 'JM9NgvjjVng' }
+    end
   end
 
   context "with video url in text", :vcr do
     subject { VideoInfo.new('<a href="http://www.youtube.com/watch?v=mZqGqE0D0n4">http://www.youtube.com/watch?v=mZqGqE0D0n4</a>') }
 
-    its(:provider) { should == 'YouTube' }
-    its(:video_id) { should == 'mZqGqE0D0n4' }
+    describe '#provider' do
+      subject { super().provider }
+      it { is_expected.to eq('YouTube') }
+    end
+
+    describe '#video_id' do
+      subject { super().video_id }
+      it { is_expected.to eq('mZqGqE0D0n4') }
+    end
   end
 
   context "with iframe attributes", :vcr do
     subject { VideoInfo.new('http://www.youtube.com/watch?v=mZqGqE0D0n4') }
 
-    its(:provider) { should == 'YouTube' }
+    describe '#provider' do
+      subject { super().provider }
+      it { is_expected.to eq('YouTube') }
+    end
     it { expect(subject.embed_code(iframe_attributes: { width: 800, height: 600 })).to match(/width="800"/) }
     it { expect(subject.embed_code(iframe_attributes: { width: 800, height: 600 })).to match(/height="600"/) }
   end
@@ -153,7 +309,10 @@ describe VideoInfo::Providers::Youtube do
   context "with arbitrary iframe_attributes", :vcr do
     subject { VideoInfo.new('http://www.youtube.com/watch?v=mZqGqE0D0n4') }
 
-    its(:provider)   { should == 'YouTube' }
+    describe '#provider' do
+      subject { super().provider }
+      it { is_expected.to eq('YouTube') }
+    end
     it { expect(subject.embed_code(iframe_attributes: { :'data-colorbox' => true })).to match(/data-colorbox="true"/) }
   end
 

data/spec/lib/video_info_spec.rb

@@ -8,18 +8,18 @@ describe VideoInfo do
     let(:provider) { double('provider', provider: 'Provider') }
 
     it "uses the first usable provider" do
-      VideoInfo::Providers::Vimeo.stub(:usable?) { false }
-      VideoInfo::Providers::Vkontakte.stub(:usable?) { false }
-      VideoInfo::Providers::Youtube.stub(:usable?) { true }
-      VideoInfo::Providers::Youtube.stub(:new) { provider }
+      allow(VideoInfo::Providers::Vimeo).to receive(:usable?) { false }
+      allow(VideoInfo::Providers::Vkontakte).to receive(:usable?) { false }
+      allow(VideoInfo::Providers::Youtube).to receive(:usable?) { true }
+      allow(VideoInfo::Providers::Youtube).to receive(:new) { provider }
 
       expect(VideoInfo.new(url, options).provider).to eq 'Provider'
     end
 
     it "raise when no providers are usable" do
-      VideoInfo::Providers::Vimeo.stub(:usable?) { false }
-      VideoInfo::Providers::Vkontakte.stub(:usable?) { false }
-      VideoInfo::Providers::Youtube.stub(:usable?) { false }
+      allow(VideoInfo::Providers::Vimeo).to receive(:usable?) { false }
+      allow(VideoInfo::Providers::Vkontakte).to receive(:usable?) { false }
+      allow(VideoInfo::Providers::Youtube).to receive(:usable?) { false }
 
       expect { VideoInfo.new(url, options) }.to raise_error(VideoInfo::UrlError)
     end
@@ -30,20 +30,20 @@ describe VideoInfo do
     let(:provider) { double('provider', new: true) }
 
     it "returns true when a provider is usable" do
-      VideoInfo::Providers::Vimeo.stub(:usable?) { false }
-      VideoInfo::Providers::Vkontakte.stub(:usable?) { false }
-      VideoInfo::Providers::Youtube.stub(:usable?) { true }
-      VideoInfo::Providers::Youtube.stub(:new) { true }
+      allow(VideoInfo::Providers::Vimeo).to receive(:usable?) { false }
+      allow(VideoInfo::Providers::Vkontakte).to receive(:usable?) { false }
+      allow(VideoInfo::Providers::Youtube).to receive(:usable?) { true }
+      allow(VideoInfo::Providers::Youtube).to receive(:new) { true }
 
-      expect(VideoInfo.usable?(url)).to be_true
+      expect(VideoInfo.usable?(url)).to be_truthy
     end
 
     it "returns false when no providers are usable" do
-      VideoInfo::Providers::Vimeo.stub(:usable?) { false }
-      VideoInfo::Providers::Vkontakte.stub(:usable?) { false }
-      VideoInfo::Providers::Youtube.stub(:usable?) { false }
+      allow(VideoInfo::Providers::Vimeo).to receive(:usable?) { false }
+      allow(VideoInfo::Providers::Vkontakte).to receive(:usable?) { false }
+      allow(VideoInfo::Providers::Youtube).to receive(:usable?) { false }
 
-      expect(VideoInfo.usable?(url)).to be_false
+      expect(VideoInfo.usable?(url)).to be_falsey
     end
   end
 
@@ -54,15 +54,15 @@ describe VideoInfo do
 
     context "matching" do
       it "returns true" do
-        expect(vi_a == vi_a).to be_true
-        expect(vi_a == vi_b).to be_true
+        expect(vi_a == vi_a).to be_truthy
+        expect(vi_a == vi_b).to be_truthy
       end
     end
 
     context "not matching" do
       it "returns false" do
-        expect(vi_a == vi_c).to be_false
-        expect(vi_b == vi_c).to be_false
+        expect(vi_a == vi_c).to be_falsey
+        expect(vi_b == vi_c).to be_falsey
       end
     end
   end

data/spec/spec_helper.rb

@@ -1,4 +1,5 @@
 require 'rspec'
+require 'rspec/its'
 require 'video_info'
 require 'vcr'
 
@@ -18,11 +19,6 @@ VCR.configure do |config|
 end
 
 RSpec.configure do |config|
-  config.color_enabled = true
   config.filter_run focus: true
   config.run_all_when_everything_filtered = true
-  config.treat_symbols_as_metadata_keys_with_true_values = true
-  config.expect_with :rspec do |c|
-    c.syntax = :expect
-  end
 end

data/video_info.gemspec

@@ -27,6 +27,7 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'bundler', '>= 1.3.5'
   s.add_development_dependency 'rake'
   s.add_development_dependency 'rspec'
+  s.add_development_dependency 'rspec-its'
   s.add_development_dependency 'vcr'
   s.add_development_dependency 'webmock'
 end