video-gif-previewer 0.1.0 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2fe9890ceea6d652191c3d4a719aa052c84a3191a8d181961ea0b07b98a0faff
-  data.tar.gz: f1d5ca0abd315f740291049e87dca214173150270435c6b1bf3e7acc2e4418ab
+  metadata.gz: 292c2cc47f8ede9e3a0ee23a79e971599be7de0cffc81602f2e494a5e13daeb7
+  data.tar.gz: 6de21e7755a025814b7343df160ce7348715ed4a47c3aeedf001aea74991de76
 SHA512:
-  metadata.gz: c77fa639612714dfd901a986a39b9c7224e20d96b621f4d1ba63677b1386b7276114bc7afacfebf10a272922ec403cd70e8211aaea9293802f4fe8e517d21d07
-  data.tar.gz: 93d5de03d0badc7fa137a1f19db0c3b87f6e10f7d39c96e00b05cd9e306e5ebc0623836d2ca299bb7632496d15268a9cba5cf13021cba4151dd8e866ce32efeb
+  metadata.gz: df66a6f10b8b7ce17f854f550d1485de29aaea08358f4f193622dc8aafb69aaeb6dc4d12262067c7309bbf284740f936b131551cb45656d35d846ccc068276bb
+  data.tar.gz: fa832e3f7318c9939d68f73e3bdec938e1ef2c3a239d44b1965af24ad9f390f099aa5a996c45afd56757d60a1917489ed993a41d9caba1e9ff0dfa99537845b0

data/lib/gif_previewer.rb

@@ -1,24 +1,109 @@
 # frozen_string_literal: true
 
+require 'timeout'
+
 class GifPreviewer < ActiveStorage::Previewer::VideoPreviewer
+  MAX_PROCESSING_TIME = 60
+
   def preview(**options)
+    Rails.logger.info(msg: 'Downloading Blob', blob: @blob)
     download_blob_to_tempfile do |input|
-      draw_relevant_frames_from input do |output|
+      file_duration = duration(input_file: input)
+      Rails.logger.info(msg: 'generation of gif preview starting', blob: @blob)
+      draw_relevant_frames_from input, file_duration do |output|
+        Rails.logger.info(msg: 'generation of gif preview completed')
         yield io: output, filename: "#{blob.filename.base}-preview.gif", content_type: "image/gif", **options
       end
     end
+
+  rescue Timeout::Error
+    Rails.logger.error(
+      msg: "Timeout::Error, processing took too long",
+      max_allowed_time: MAX_PROCESSING_TIME,
+      record_type: @blob.attachments.first.record_type,
+      record_id: @blob.attachments.first.record.id,
+    )
+
+    # If we take too long encoding a gif, fallback to the standard rails VideoPreviewer
+    super
+  rescue ActiveStorage::PreviewError => e
+    Rails.logger.error(msg: "ActiveStorage::PreviewError", message: e.message)
+
+    # If we hit an issue encoding a gif, fallback to the standard rails VideoPreviewer
+    super
   end
 
   private
 
+  def ffprobe_path
+    ActiveStorage.paths[:ffprobe] || "ffprobe"
+  end
+
+  # Use ffprobe to analyze the media for duration
+  def duration(input_file: nil)
+    start_time = Time.now
+
+    file_duration = if input_file.present?
+                      duration_command(input_file)
+                    else
+                      download_blob_to_tempfile do |file|
+                        duration_command(file)
+                      end
+                    end
+
+    Rails.logger.info(msg: 'ffprobe for durations finished', file_duration:, elapsed_time: Time.now - start_time)
+
+    file_duration
+  end
+
+  def duration_command(input_file)
+    `#{ffprobe_path} -v error -show_entries format=duration -of default=noprint_wrappers=1:nokey=1 #{input_file.path}`.to_f.floor.to_i
+  end
+
+  # Use file_duration to either pick a random place ~33% into the file, or if the file is too short, use 0
+  def start_frame(file_duration:)
+    if file_duration > 10
+      mid_frame = (file_duration.to_f / 3).floor
+      mid_frame > 3 ? mid_frame : 3
+    else
+      0
+    end
+  end
+
+  # Use file_duration to pick an end frame frame_duration after the start, or if the file is too short, use file_duration
+  def end_frame(start_frame_num:, file_duration:)
+    expected_end = (start_frame_num + frame_duration)
+
+    if file_duration < expected_end
+      file_duration
+    else
+      expected_end
+    end
+  end
+
+  def frame_duration
+    5
+  end
+
+  def draw_relevant_frames_from(file, file_duration, &block)
+    start_frame_num = start_frame(file_duration:)
+    end_frame_num = end_frame(start_frame_num:, file_duration:)
 
-  def draw_relevant_frames_from(file, &block)
-    draw self.class.ffmpeg_path,
-      "-i", file.path,
-      '-filter_complex', 'fps=10,scale=360:-1[s]; [s]split[a][b]; [a]palettegen[palette]; [b][palette]paletteuse',
-      '-f', 'gif',
-      '-ss', '3',
-      '-to', '8',
-      "-", &block
+    Rails.logger.info(
+      msg: "GifPreviewer draw_relevant_frames_from starting",
+      file_path: file.path,
+      'start (ss)': start_frame_num,
+      'end (to)': end_frame_num,
+    )
+    Timeout::timeout(MAX_PROCESSING_TIME) do
+      draw self.class.ffmpeg_path,
+        '-i', file.path,
+        '-filter_complex', "fps=10,scale=360:-1[s]; [s]split[a][b]; [a]palettegen[palette]; [b][palette]paletteuse",
+        '-f', 'gif',
+        '-ss', start_frame_num.to_s,
+        '-to', end_frame_num.to_s,
+        '-',
+        &block
+    end
   end
 end

data/lib/video-gif-previewer/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class VideoGifPreviewer
-  VERSION = '0.1.0'
+  VERSION = '0.1.2'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: video-gif-previewer
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.2
 platform: ruby
 authors:
 - Brian Haberer
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-04-11 00:00:00.000000000 Z
+date: 2025-04-16 00:00:00.000000000 Z
 dependencies: []
 description: Generate rails active storage video previews as gifs
 email: bhaberer@gmail.com
@@ -25,7 +25,6 @@ licenses:
 - GPL-2.0-only
 metadata:
   allowed_push_host: https://rubygems.org/
-  homepage_uri: https://github.com/bhaberer/video-gif-previewer
   source_code_uri: https://github.com/bhaberer/video-gif-previewer
   rubygems_mfa_required: 'true'
 post_install_message: