video-gif-previewer 0.0.3 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 41a79e572c04ed26c3fd4eaac04d177ab4f6b4d863cc06bcfa44414182b5dd58
-  data.tar.gz: 267fed512496877e1bcb3d558a76254b1614e79b9d82dc476cf26a85ab466cc0
+  metadata.gz: '08e35907ca5d95b4ce59a135cbe9572a1f13240df1c8abdfed340f3ada0fcb28'
+  data.tar.gz: 34bc9c5bda01697d00d0d45d7679bf05fd1e26769e8cf4384c0b8d06a2e2342d
 SHA512:
-  metadata.gz: 39b7d8e11526fcd7922be3b98c6f85bbe6d766cc7f9d0ee3b7f7a8c079eb303a304c92755cec2037ca6cf15e9292315e56fff76a440fcdcd6586d3498b4678ab
-  data.tar.gz: d6d58867262929e5fe4f24f0e795a3d10049f2c9365870dfb0b558050451499c0c0eb334c89c62f81e7fce393ef9cc9bcae1c412b245ce066df403d243a4f6cf
+  metadata.gz: 9427e2a3edad7c1140e8d00b85c8205cde639167a5316748e2d32a9d10a89a5511ceeae8cabcbe6641833bc2eb08b089aa8ae7e842273111f4896a33089c018d
+  data.tar.gz: deafe286cb4ff483b60287fd9898eed29cefff1659b64df98abfc262cf01d894c0fc58fb38c1154290b7d23094d0ebaaff3e8737438c4bf0259a629c7a1752fc

data/lib/gif_previewer.rb

@@ -1,24 +1,104 @@
 # frozen_string_literal: true
 
+require 'timeout'
+
 class GifPreviewer < ActiveStorage::Previewer::VideoPreviewer
+  MAX_PROCESSING_TIME = 60
+
   def preview(**options)
+    Rails.logger.info(msg: 'Downloading Blob', blob: @blob)
     download_blob_to_tempfile do |input|
-      draw_relevant_frames_from input do |output|
+      file_duration = duration(input_file: input)
+      Rails.logger.info(msg: 'generation of gif preview starting', blob: @blob)
+      draw_relevant_frames_from input, file_duration do |output|
+        Rails.logger.info(msg: 'generation of gif preview completed')
         yield io: output, filename: "#{blob.filename.base}-preview.gif", content_type: "image/gif", **options
       end
     end
+
+  rescue Timeout::Error
+    Rails.logger.error(msg: "Timeout::Error, processing took too long", max_allowed_time: MAX_PROCESSING_TIME)
+
+    # If we take too long encoding a gif, fallback to the standard rails VideoPreviewer
+    super
+  rescue ActiveStorage::PreviewError => e
+    Rails.logger.error(msg: "ActiveStorage::PreviewError", message: e.message)
+
+    # If we hit an issue encoding a gif, fallback to the standard rails VideoPreviewer
+    super
   end
 
   private
 
+  def ffprobe_path
+    ActiveStorage.paths[:ffprobe] || "ffprobe"
+  end
+
+  # Use ffprobe to analyze the media for duration
+  def duration(input_file: nil)
+    start_time = Time.now
+
+    file_duration = if input_file.present?
+                      duration_command(input_file)
+                    else
+                      download_blob_to_tempfile do |file|
+                        duration_command(file)
+                      end
+                    end
+
+    Rails.logger.info(msg: 'ffprobe for durations finished', file_duration:, elapsed_time: Time.now - start_time)
+
+    file_duration
+  end
+
+  def duration_command(input_file)
+    `#{ffprobe_path} -v error -show_entries format=duration -of default=noprint_wrappers=1:nokey=1 #{input_file.path}`.to_f.floor.to_i
+  end
+
+  # Use file_duration to either pick a random place ~33% into the file, or if the file is too short, use 0
+  def start_frame(file_duration:)
+    if file_duration > 10
+      mid_frame = (file_duration.to_f / 3).floor
+      mid_frame > 3 ? mid_frame : 3
+    else
+      0
+    end
+  end
+
+  # Use file_duration to pick an end frame frame_duration after the start, or if the file is too short, use file_duration
+  def end_frame(start_frame_num:, file_duration:)
+    expected_end = (start_frame_num + frame_duration)
+
+    if file_duration < expected_end
+      file_duration
+    else
+      expected_end
+    end
+  end
+
+  def frame_duration
+    5
+  end
+
+  def draw_relevant_frames_from(file, file_duration, &block)
+    start_frame_num = start_frame(file_duration:)
+    end_frame_num = end_frame(start_frame_num:, file_duration:)
 
-  def draw_relevant_frames_from(file, &block)
-    draw self.class.ffmpeg_path,
-      "-i", file.path,
-      '-filter_complex', 'fps=10,scale=360:-1[s]; [s]split[a][b]; [a]palettegen[palette]; [b][palette]paletteuse',
-      '-f', 'gif',
-      '-ss', '3',
-      '-to', '8',
-      "-", &block
+    Rails.logger.info(
+      msg: "GifPreviewer draw_relevant_frames_from starting",
+      file_path: file.path,
+      'start (ss)': start_frame_num,
+      'end (to)': end_frame_num,
+    )
+    Timeout::timeout(MAX_PROCESSING_TIME) do
+      draw self.class.ffmpeg_path,
+        '-i', file.path,
+        '-filter_complex', "fps=10,scale=360:-1[s]; [s]split[a][b]; [a]palettegen[palette]; [b][palette]paletteuse",
+        '-f', 'gif',
+        '-ss', start_frame_num.to_s,
+        '-to', end_frame_num.to_s,
+        '-',
+        &block
+    end
   end
 end

data/lib/video-gif-previewer/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class VideoGifPreviewer
-  VERSION = '0.0.3'
+  VERSION = '0.1.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: video-gif-previewer
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.1.1
 platform: ruby
 authors:
 - Brian Haberer
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-04-11 00:00:00.000000000 Z
+date: 2025-04-15 00:00:00.000000000 Z
 dependencies: []
 description: Generate rails active storage video previews as gifs
 email: bhaberer@gmail.com
@@ -43,7 +43,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.23
+rubygems_version: 3.5.11
 signing_key:
 specification_version: 4
 summary: ActiveStorage Gif Video Preview generation