vidar 1.15.1 → 1.17.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fc8aca493aae5ce60698719689eacb11543e7a721aad7ec20021cee2df0683fd
-  data.tar.gz: 193124790b6b347c74da13ea6b82a40f0907ffd59ccd69769b14ba96c079bcfd
+  metadata.gz: c9f70e2aea16ca7648801c10d594785cf71cc4059e723075a7e0a5ac2df28e7a
+  data.tar.gz: e02d0cfe17b044eb62d11fee018e15956c02835ab7bb947a224b5a3fcfdf48bc
 SHA512:
-  metadata.gz: 82cadaec9915898f37d165fee953510e08a73c993d44ae48b992472af91e55cb1587f416f725698e775d2fc0eb262a6f6c5560258ab347048f08534bcb05724d
-  data.tar.gz: e0ffb7eedff17d042b6d9f4ebe060eb1144ca2c2eb5e68d511e587b467b8a54b09c49949a2cadcce522e8ae033c7713010a9c3b9b874c6e466989294bdd3cbac
+  metadata.gz: 88bb3c398a191d7b02a6d2591653b5ddc8ed88a1d2432dd84e2d0188fdcbb3873ea5f20eb7ca00c3b2f3bc49b03f030f3c12dcb4799d306741fa4d0f668489f4
+  data.tar.gz: afe4490c85deca103d2b07f720b36710fae66fc7acc60ffb91fbf4c235ac4fa027ecb01067a56710a3bafb9e0d357eeeafb3aa41d729b0c0a43b607ca4c3f3b1

data/.bundler-version

@@ -1 +1 @@
-2.7.0
+4.0.10

data/.github/dependabot.yml

@@ -6,10 +6,49 @@ updates:
     schedule:
       interval: "weekly"
       day: "monday"
-      time: "08:00"
+      time: "11:00"
       timezone: "UTC"
+    cooldown:
+      default-days: 2
+      include:
+        - "*"
     commit-message:
       prefix: "[dependabot]"
+    groups:
+      ruby-minor-and-patch:
+        applies-to: version-updates
+        update-types:
+          - "minor"
+          - "patch"
     labels:
+      - "dependencies"
       - "automerge"
+    ignore:
+      - dependency-name: "*"
+        update-types:
+          - "version-update:semver-major"
+
+  - package-ecosystem: "github-actions"
+    directory: "/"
+    schedule:
+      interval: "weekly"
+      day: "monday"
+      time: "11:00"
+      timezone: "UTC"
+    cooldown:
+      default-days: 2
+    commit-message:
+      prefix: "[dependabot]"
+    groups:
+      actions-minor-and-patch:
+        applies-to: version-updates
+        update-types:
+          - "minor"
+          - "patch"
+    labels:
       - "dependencies"
+      - "automerge"
+    ignore:
+      - dependency-name: "*"
+        update-types:
+          - "version-update:semver-major"

data/.github/workflows/auto-approve.yml

@@ -1,14 +1,16 @@
-name: Auto approve dependency upgrades and hot-fix PRs
+name: Auto approve hot-fix PRs
 on:
   pull_request_target:
-    types:
-      - labeled
-      - ready_for_review
+    types: [opened, labeled, ready_for_review]
+
 jobs:
   auto-approve:
+    if: >
+      github.actor == 'renofidev' ||
+      contains(github.event.pull_request.labels.*.name, 'HOTFIX-AUTO-APPROVE') ||
+      contains(github.event.pull_request.labels.*.name, 'self-approve')
     runs-on: ubuntu-latest
     steps:
-      - uses: hmarr/auto-approve-action@v3
-        if: github.actor == 'dependabot[bot]' || github.actor == 'dependabot-preview[bot]' || github.actor == 'renofidev' || contains(github.event.pull_request.labels.*.name, 'HOTFIX-AUTO-APPROVE') || contains(github.event.pull_request.labels.*.name, 'self-approve') || contains(github.event.pull_request.labels.*.name, 'dependencies')
+      - uses: hmarr/auto-approve-action@f0939ea97e9205ef24d872e76833fa908a770363 # v4.0.0
         with:
           github-token: "${{ secrets.GITHUB_TOKEN }}"

data/.github/workflows/auto-merge.yml

@@ -2,6 +2,9 @@ name: automerge
 on:
   pull_request_target:
     types:
+      - opened
+      - synchronize
+      - reopened
       - labeled
   pull_request_review:
     types:
@@ -9,23 +12,67 @@ on:
   check_suite:
     types:
       - completed
-  status: {}
+
+permissions:
+  contents: write
+  pull-requests: write
+
 jobs:
-  automerge:
+  automerge-labeled:
+    if: >
+      github.event.pull_request.user.login != 'dependabot[bot]' &&
+      contains(github.event.pull_request.labels.*.name, 'automerge') &&
+      !contains(github.event.pull_request.labels.*.name, 'automerge blocked')
     runs-on: ubuntu-latest
     steps:
-      - name: automerge
-        uses: pascalgn/automerge-action@v0.16.4
+      - name: Enable auto-merge
+        run: gh pr merge --auto --squash --delete-branch "$PR_URL"
         env:
-          GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
-          MERGE_METHOD: squash
-          MERGE_DELETE_BRANCH: true
-          MERGE_LABELS: "automerge,!automerge blocked"
-      - name: automerge-dependencies
-        uses: pascalgn/automerge-action@v0.16.4
+          PR_URL: ${{ github.event.pull_request.html_url }}
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+
+  automerge-dependabot:
+    if: >
+      github.event.pull_request.user.login == 'dependabot[bot]' &&
+      !contains(github.event.pull_request.labels.*.name, 'automerge blocked')
+    runs-on: ubuntu-latest
+    steps:
+      - name: Fetch Dependabot metadata
+        id: metadata
+        uses: dependabot/fetch-metadata@25dd0e34f4fe68f24cc83900b1fe3fe149efef98 # v3.1.0
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+
+      - name: Approve minor and patch
+        if: >
+          steps.metadata.outputs.update-type == 'version-update:semver-patch' ||
+          steps.metadata.outputs.update-type == 'version-update:semver-minor'
+        uses: hmarr/auto-approve-action@f0939ea97e9205ef24d872e76833fa908a770363 # v4.0.0
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+
+      - name: Enable auto-merge for minor and patch
+        if: >
+          steps.metadata.outputs.update-type == 'version-update:semver-patch' ||
+          steps.metadata.outputs.update-type == 'version-update:semver-minor'
+        run: gh pr merge --auto --squash --delete-branch "$PR_URL"
+        env:
+          PR_URL: ${{ github.event.pull_request.html_url }}
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+
+  automerge-update-branch:
+    if: github.event_name == 'check_suite'
+    runs-on: ubuntu-latest
+    steps:
+      - name: Update branches behind base
         env:
-          GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
-          MERGE_METHOD: squash
-          MERGE_DELETE_BRANCH: true
-          MERGE_LABELS: "dependencies,!automerge blocked"
-          MERGE_REMOVE_LABELS: ""
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: |
+          gh pr list --repo "$GITHUB_REPOSITORY" \
+            --label automerge \
+            --limit 100 \
+            --json number,labels \
+            --jq '.[] | select(.labels | map(.name) | contains(["automerge blocked"]) | not) | .number' \
+            | while read pr_number; do
+            gh pr update-branch "$pr_number" --repo "$GITHUB_REPOSITORY" 2>/dev/null || true
+          done

data/.github/workflows/ci.yml

@@ -11,12 +11,12 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        ruby-version: [3.3, 3.4]
+        ruby-version: [3.4, 4.0]
 
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
     - name: Set up Ruby
-      uses: ruby/setup-ruby@v1
+      uses: ruby/setup-ruby@c4e5b1316158f92e3d49443a9d58b31d25ac0f8f # v1.306.0
       with:
         ruby-version: ${{ matrix.ruby-version }}
         bundler-cache: true # runs 'bundle install' and caches installed gems automatically

data/.gitignore

@@ -11,5 +11,6 @@
 .rspec_status
 
 # Cached rubocop config files
-.rubocop-http*
+.rubocop-*
 vidar.yml
+.claude

data/.standard.yml

@@ -0,0 +1,2 @@
+format: progress
+parallel: true

data/CHANGELOG.md

@@ -1,5 +1,27 @@
 # CHANGELOG
 
+## 1.17.1 - 2026-05-19
+
+- Fix `monitor_deploy_status` failing the deploy promotion when `--max_tries` is passed: Thor's `invoke :notify_sentry` was forwarding the parent task's ARGV as positional args. Pass explicit empty args/options to scope the sub-invocation.
+
+## 1.17.0 - 2026-03-24
+
+- Replace backtick shell calls with `Open3.capture3` for safer command execution
+- Add `rescue JSON::ParserError` in `K8s::PodSet` to handle malformed kubectl output gracefully
+- Fix `terminated_error?` returning truthy for exit code 0
+- Add `Unknown` state label for containers with unrecognized state
+- Add `sidecar?` method and `sidecar_container_names` config key for configurable sidecar filtering (replaces hardcoded istio-proxy)
+- Add `rescue Faraday::Error` to all notification classes to prevent network errors from crashing deploys
+- Simplify `DeployStatus` polling loops and remove off-by-one in max_tries
+- Add `vidar.yml` schema validation on load (requires `image`, `namespace`, `github`)
+- Pin faraday dependency to `>= 2.0, < 3`
+- Add YARD documentation to all public classes and methods
+- Expand test coverage from 18 to 148 examples
+
+## 1.16.0 - 2026-01-27
+
+Ruby 4.0 support. Drop ruby 3.3 support.
+
 ## 1.15.0 - 2025-06-23
 
 Don't stop watining and mark deployment as failed, when any container is still in a waiting state

data/Gemfile

@@ -1,13 +1,14 @@
-source 'https://rubygems.org'
+source "https://rubygems.org"
 
 gemspec
 
-gem 'awesome_print'
-gem 'bundler'
-gem 'pry'
-gem 'rake'
-gem 'rspec'
-gem 'rubocop'
-gem 'rubocop-rake'
-gem 'rubocop-rspec'
-gem 'webmock'
+gem "awesome_print"
+gem "bundler"
+gem "irb"
+gem "pry"
+gem "rake"
+gem "rspec"
+gem "standard"
+gem "webmock"
+
+gem "openssl"

data/Gemfile.lock

@@ -1,67 +1,89 @@
 PATH
   remote: .
   specs:
-    vidar (1.15.1)
+    vidar (1.17.1)
       colorize
-      faraday
+      faraday (>= 2.0, < 3)
       thor (~> 1.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    addressable (2.8.7)
-      public_suffix (>= 2.0.2, < 7.0)
+    addressable (2.9.0)
+      public_suffix (>= 2.0.2, < 8.0)
     ast (2.4.3)
     awesome_print (1.9.2)
-    bigdecimal (3.2.2)
+    bigdecimal (4.1.1)
     coderay (1.1.3)
     colorize (1.1.0)
-    crack (1.0.0)
+    crack (1.0.1)
       bigdecimal
       rexml
+    date (3.5.1)
     diff-lcs (1.6.2)
-    faraday (2.13.2)
+    erb (6.0.4)
+    faraday (2.14.2)
       faraday-net_http (>= 2.0, < 3.5)
       json
       logger
-    faraday-net_http (3.4.1)
-      net-http (>= 0.5.0)
-    hashdiff (1.2.0)
-    json (2.13.0)
+    faraday-net_http (3.4.2)
+      net-http (~> 0.5)
+    hashdiff (1.2.1)
+    io-console (0.8.2)
+    irb (1.18.0)
+      pp (>= 0.6.0)
+      prism (>= 1.3.0)
+      rdoc (>= 4.0.0)
+      reline (>= 0.4.2)
+    json (2.19.5)
     language_server-protocol (3.17.0.5)
     lint_roller (1.1.0)
     logger (1.7.0)
     method_source (1.1.0)
-    net-http (0.6.0)
-      uri
-    parallel (1.27.0)
-    parser (3.3.8.0)
+    net-http (0.9.1)
+      uri (>= 0.11.1)
+    openssl (4.0.2)
+    parallel (1.28.0)
+    parser (3.3.11.1)
       ast (~> 2.4.1)
       racc
-    prism (1.4.0)
-    pry (0.15.2)
+    pp (0.6.3)
+      prettyprint
+    prettyprint (0.2.0)
+    prism (1.9.0)
+    pry (0.16.0)
       coderay (~> 1.1)
       method_source (~> 1.0)
-    public_suffix (6.0.2)
+      reline (>= 0.6.0)
+    psych (5.3.1)
+      date
+      stringio
+    public_suffix (7.0.5)
     racc (1.8.1)
     rainbow (3.1.1)
-    rake (13.3.0)
-    regexp_parser (2.10.0)
-    rexml (3.4.1)
-    rspec (3.13.1)
+    rake (13.4.2)
+    rdoc (7.2.0)
+      erb
+      psych (>= 4.0.0)
+      tsort
+    regexp_parser (2.12.0)
+    reline (0.6.3)
+      io-console (~> 0.5)
+    rexml (3.4.4)
+    rspec (3.13.2)
       rspec-core (~> 3.13.0)
       rspec-expectations (~> 3.13.0)
       rspec-mocks (~> 3.13.0)
-    rspec-core (3.13.5)
+    rspec-core (3.13.6)
       rspec-support (~> 3.13.0)
     rspec-expectations (3.13.5)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
-    rspec-mocks (3.13.5)
+    rspec-mocks (3.13.8)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
-    rspec-support (3.13.4)
-    rubocop (1.78.0)
+    rspec-support (3.13.7)
+    rubocop (1.84.2)
       json (~> 2.3)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.1.0)
@@ -69,25 +91,37 @@ GEM
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 2.9.3, < 3.0)
-      rubocop-ast (>= 1.45.1, < 2.0)
+      rubocop-ast (>= 1.49.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 4.0)
-    rubocop-ast (1.46.0)
+    rubocop-ast (1.49.1)
       parser (>= 3.3.7.2)
-      prism (~> 1.4)
-    rubocop-rake (0.7.1)
+      prism (~> 1.7)
+    rubocop-performance (1.26.1)
       lint_roller (~> 1.1)
-      rubocop (>= 1.72.1)
-    rubocop-rspec (3.6.0)
-      lint_roller (~> 1.1)
-      rubocop (~> 1.72, >= 1.72.1)
+      rubocop (>= 1.75.0, < 2.0)
+      rubocop-ast (>= 1.47.1, < 2.0)
     ruby-progressbar (1.13.0)
-    thor (1.4.0)
-    unicode-display_width (3.1.4)
-      unicode-emoji (~> 4.0, >= 4.0.4)
-    unicode-emoji (4.0.4)
-    uri (1.0.3)
-    webmock (3.25.1)
+    standard (1.54.0)
+      language_server-protocol (~> 3.17.0.2)
+      lint_roller (~> 1.0)
+      rubocop (~> 1.84.0)
+      standard-custom (~> 1.0.0)
+      standard-performance (~> 1.8)
+    standard-custom (1.0.2)
+      lint_roller (~> 1.0)
+      rubocop (~> 1.50)
+    standard-performance (1.9.0)
+      lint_roller (~> 1.1)
+      rubocop-performance (~> 1.26.0)
+    stringio (3.2.0)
+    thor (1.5.0)
+    tsort (0.2.0)
+    unicode-display_width (3.2.0)
+      unicode-emoji (~> 4.1)
+    unicode-emoji (4.2.0)
+    uri (1.1.1)
+    webmock (3.26.2)
       addressable (>= 2.8.0)
       crack (>= 0.3.2)
       hashdiff (>= 0.4.0, < 2.0.0)
@@ -98,14 +132,14 @@ PLATFORMS
 DEPENDENCIES
   awesome_print
   bundler
+  irb
+  openssl
   pry
   rake
   rspec
-  rubocop
-  rubocop-rake
-  rubocop-rspec
+  standard
   vidar!
   webmock
 
 BUNDLED WITH
-   2.6.3
+  4.0.4

data/Rakefile

@@ -1,9 +1,8 @@
-require 'bundler/gem_tasks'
-require 'rspec/core/rake_task'
-require 'rubocop/rake_task'
+require "bundler/gem_tasks"
+require "rspec/core/rake_task"
+require "standard/rake"
 
 RSpec::Core::RakeTask.new(:spec)
-RuboCop::RakeTask.new
 
-task ci: %i[spec rubocop]
-task default: %i[spec rubocop:autocorrect]
+task ci: %i[spec standard]
+task default: %i[spec standard:fix]

data/exe/vidar

@@ -1,5 +1,5 @@
 #!/usr/bin/env ruby
 
-require 'vidar'
+require "vidar"
 
 Vidar::CLI.start

data/lib/vidar/cli.rb

@@ -24,7 +24,8 @@ module Vidar
       Log.info "Pulling #{Config.get!(:image)} tags"
       Run.docker "pull #{Config.get!(:image)}:#{Config.get!(:base_stage_name)}-#{Config.get!(:current_branch)} 2> /dev/null || true"
 
-      image_names = `docker images --format "{{.Repository}}:{{.Tag}}"`.split("\n")
+      image_names_stdout, _stderr, _status = Open3.capture3('docker images --format "{{.Repository}}:{{.Tag}}"')
+      image_names = image_names_stdout.split("\n")
       base_image = "#{Config.get!(:image)}:#{Config.get!(:base_stage_name)}-#{Config.get!(:default_branch)}"
       Run.docker "pull #{base_image} 2> /dev/null || true" unless image_names.include?(base_image)
 
@@ -128,8 +129,8 @@ module Vidar
       destination = options[:destination]
       container = options[:container]
       all = options[:all]
-      Log.info "Set kubectl image for #{'all ' if all}#{destination} container=#{container}..."
-      Run.kubectl "set image #{destination} #{container}=#{Config.get!(:image)}:#{revision} #{'--all' if all}"
+      Log.info "Set kubectl image for #{"all " if all}#{destination} container=#{container}..."
+      Run.kubectl "set image #{destination} #{container}=#{Config.get!(:image)}:#{revision} #{"--all" if all}"
     end
 
     desc "set_image", "Set image for k8s deployment"
@@ -146,8 +147,8 @@ module Vidar
       destination = options[:destination]
       container = options[:container]
       all = options[:all]
-      Log.info "Set kubectl image for #{'all ' if all}#{destination} container=#{container}..."
-      Run.kubectl "set image #{destination} #{container}=#{Config.get!(:image)}:#{revision} #{'--all' if all}"
+      Log.info "Set kubectl image for #{"all " if all}#{destination} container=#{container}..."
+      Run.kubectl "set image #{destination} #{container}=#{Config.get!(:image)}:#{revision} #{"--all" if all}"
     end
 
     desc "release", "Build and publish docker images"
@@ -178,7 +179,7 @@ module Vidar
         Log.info "OK: All containers are ready"
         slack_notification.success if slack_notification.configured?
         honeycomb_notification.success
-        invoke :notify_sentry
+        invoke :notify_sentry, [], {}
       else
         Log.error "ERROR: Some of containers are errored or not ready"
         slack_notification.failure if slack_notification.configured?
@@ -198,16 +199,17 @@ module Vidar
       Log.error "ERROR: could not find deployment config for #{Config.get!(:kubectl_context)} context" unless deploy_config
 
       pod_set = K8s::PodSet.new(namespace: Config.get!(:namespace), filter: options[:name])
-      containers = pod_set.containers.select(&:ready_and_running?).reject(&:istio?)
+      sidecar_names = Array(Config.get(:sidecar_container_names))
+      containers = pod_set.containers.select(&:ready_and_running?).reject { |c| c.sidecar?(sidecar_names) }
 
       if containers.empty?
-        name = options[:name] || 'any'
+        name = options[:name] || "any"
         Log.error "No running containers found with *#{name}* name"
         exit(1)
       else
         Log.info "Available containers:"
         containers.each(&:print)
-        container = containers.detect { |c| c.name == 'console' } || containers.last
+        container = containers.detect { |c| c.name == "console" } || containers.last
 
         Log.info "Running #{options[:command]} in #{container.pod_name}"
         Run.kubectl("exec -it #{container.pod_name} -- #{options[:command]}")
@@ -232,7 +234,7 @@ module Vidar
     desc "notify_sentry", "Notify sentry about current release"
     def notify_sentry
       sentry_notification = SentryNotification.new(
-        revision:      Config.get!(:revision),
+        revision: Config.get!(:revision),
         deploy_config: Config.deploy_config
       )
 
@@ -248,10 +250,10 @@ module Vidar
     desc "notify_slack", "Send custom slack notification"
     def notify_slack
       slack_notification = SlackNotification.new(
-        github:        Config.get!(:github),
-        revision:      Config.get!(:revision),
+        github: Config.get!(:github),
+        revision: Config.get!(:revision),
         revision_name: Config.get!(:revision_name),
-        build_url:     Config.build_url,
+        build_url: Config.build_url,
         deploy_config: Config.deploy_config
       )