veto 0.1.3 → 1.0.0

data/spec/checks/numeric_check_spec.rb

@@ -0,0 +1,37 @@
+require 'spec_helper'
+
+describe Veto::NumericCheck do
+  context 'when value is numeric' do
+    it 'assigns no errors' do
+      entity = stub(:name => 123)
+      errors = new_errors
+      check = new_check(:name)
+
+      check.call(new_cto(entity, errors))
+      errors[:name].must_be_nil
+    end
+  end
+
+  context 'when value is not numeric' do
+    it 'assigns no errors' do
+      entity = stub(:name => 'abc')
+      errors = new_errors
+      check = new_check(:name)
+
+      check.call(new_cto(entity, errors))
+      errors[:name].must_equal(["is not a number"])
+    end
+  end
+
+  def new_cto(entity, errors)
+    stub(:entity => entity, :errors => errors)
+  end
+
+  def new_check(*args)
+    Veto::NumericCheck.new(*args)
+  end
+
+  def new_errors
+    Veto::Errors.new
+  end
+end

data/spec/checks/presence_check_spec.rb

@@ -0,0 +1,48 @@
+require 'spec_helper'
+
+describe Veto::PresenceCheck do
+  context 'when value is not null' do
+    it 'assigns no errors' do
+      entity = stub(:name => 'abcde')
+      errors = new_errors
+      check = new_check(:name)
+
+      check.call(new_cto(entity, errors))
+      errors[:name].must_be_nil
+    end
+  end
+
+  context 'when value is blank' do
+    it 'assigns no errors' do
+      entity = stub(:name => '')
+      errors = new_errors
+      check = new_check(:name)
+
+      check.call(new_cto(entity, errors))
+      errors[:name].must_equal(["is not present"])
+    end
+  end
+
+  context 'when value null' do
+    it 'assigns no errors' do
+      entity = stub(:name => nil)
+      errors = new_errors
+      check = new_check(:name)
+
+      check.call(new_cto(entity, errors))
+      errors[:name].must_equal(["is not present"])
+    end
+  end
+
+  def new_cto(entity, errors)
+    stub(:entity => entity, :errors => errors)
+  end
+
+  def new_check(*args)
+    Veto::PresenceCheck.new(*args)
+  end
+
+  def new_errors
+    Veto::Errors.new
+  end
+end

data/spec/conditions/condition_factory_spec.rb

@@ -0,0 +1,31 @@
+require 'spec_helper'
+
+describe Veto::ConditionFactory do
+  context 'when condition is a string' do
+    it 'returns entity eval condition instance' do
+      factory.new('a-string').must_be_instance_of(Veto::EntityEvalCondition)
+    end
+  end
+
+  context 'when condition is a symbol' do
+    it 'returns validator method condition instance' do
+      factory.new(:a_symbol).must_be_instance_of(Veto::ContextMethodCondition)
+    end
+  end
+
+  context 'when condition is a proc' do
+    it 'returns proc condition instance' do
+      factory.new(Proc.new{'blah'}).must_be_instance_of(Veto::ProcCondition)
+    end
+  end
+
+  context 'when condition is any other general statement or primative' do
+    it 'returns primative condition instance' do
+      factory.new(true).must_be_instance_of(Veto::PrimativeCondition)
+    end
+  end
+
+  def factory
+    Veto::ConditionFactory
+  end
+end

data/spec/conditions/conditions_spec.rb

@@ -0,0 +1,25 @@
+require 'spec_helper'
+
+describe Veto::Conditions do
+  it 'accepts single option' do
+    group = new_conditions(:good_method?)
+    group.size.must_equal(1)
+  end
+
+  it 'accepts array of options' do
+    group = new_conditions([:good_method?, Proc.new{ 'blah' }])
+    group.size.must_equal(2)
+  end
+
+  it 'iterates through conditions' do
+    group = new_conditions([:good_method?, Proc.new{ 'blah' }])
+    condition_list = []
+
+    group.each {|c| condition_list << c.class.name }
+    condition_list.must_equal(["Veto::ContextMethodCondition", "Veto::ProcCondition"])
+  end
+
+  def new_conditions(*args)
+    Veto::Conditions.new(*args)
+  end
+end

data/spec/conditions/context_method_condition_spec.rb

@@ -0,0 +1,25 @@
+require 'spec_helper'
+
+describe Veto::ContextMethodCondition do
+  context 'when context method returns truthy value' do
+    it 'passes' do
+      context = stub(:is_good? => true)
+      cco = stub(:context => context, :entity => stub)
+      condition = new_condition(:is_good?)
+      condition.pass?(cco).must_equal(true)
+    end
+  end
+
+  context 'when context method returns falsy value' do
+    it 'fails' do
+      context = stub(:is_good? => false)
+      cco = stub(:context => context, :entity => stub)
+      condition = new_condition(:is_good?)
+      condition.pass?(cco).must_equal(false)
+    end
+  end
+
+  def new_condition(*args)
+    Veto::ContextMethodCondition.new(*args)
+  end
+end

data/spec/conditions/entity_eval_condition_spec.rb

@@ -0,0 +1,21 @@
+require 'spec_helper'
+
+describe Veto::EntityEvalCondition do
+  it 'passes when entity evals to truthy value' do
+    entity = stub(:today_is_good => 'yup')
+    cco = stub(:entity => entity)
+    condition = new_condition('today_is_good')
+    condition.pass?(cco).must_equal(true)
+  end
+
+  it 'fails when entity evals to falsy value' do
+    entity = stub(:today_is_good => false)
+    cco = stub(:entity => entity)
+    condition = new_condition('today_is_good')
+    condition.pass?(cco).must_equal(false)
+  end
+
+  def new_condition(*args)
+    Veto::EntityEvalCondition.new(*args)
+  end
+end

data/spec/conditions/if_conditions_spec.rb

@@ -0,0 +1,65 @@
+require 'spec_helper'
+
+describe Veto::IfConditions do
+  context 'with passing condition' do
+    it 'correctly evalutes conditions' do
+      circle          = stub(:is_round? => true, :can_roll? => true, :has_corners? => false, :is_stackable? => false)
+      cco             = stub(:entity => circle)
+      eval_condition  = 'can_roll?'                           # pass
+
+      condition = new_conditions(eval_condition)
+      condition.pass?(cco).must_equal(true)
+    end
+  end
+
+  context 'with failing condition' do
+    it 'correctly evalutes conditions' do
+      circle          = stub(:is_round? => true, :can_roll? => true, :has_corners? => false, :is_stackable? => false)
+      cco             = stub(:entity => circle)
+      eval_condition  = 'is_stackable?'                       # fail
+
+      condition = new_conditions(eval_condition)
+      condition.pass?(cco).must_equal(false)
+    end
+  end
+
+  context 'with passing conditions' do
+    it 'correctly evalutes conditions' do
+      circle          = stub(:is_round? => true, :can_roll? => true, :has_corners? => false, :is_stackable? => false)
+      cco             = stub(:entity => circle)
+      proc_condition  = Proc.new{|entity| entity.is_round?}   # pass
+      eval_condition  = 'can_roll?'                           # pass
+
+      condition = new_conditions([proc_condition, eval_condition])
+      condition.pass?(cco).must_equal(true)
+    end
+  end
+
+  context 'with one passing and one failing condition' do
+    it 'correctly evalutes conditions' do
+      circle          = stub(:is_round? => true, :can_roll? => true, :has_corners? => false, :is_stackable? => false)
+      cco             = stub(:entity => circle)
+      proc_condition  = Proc.new{|entity| entity.is_round?}    # pass
+      eval_condition  = 'has_corners?'                         # fail
+
+      condition = new_conditions([proc_condition, eval_condition])
+      condition.pass?(cco).must_equal(false)
+    end
+  end
+
+  context 'with failing conditions' do
+    it 'correctly evalutes conditions' do
+      circle          = stub(:is_round? => true, :can_roll? => true, :has_corners? => false, :is_stackable? => false)
+      cco             = stub(:entity => circle)
+      proc_condition  = Proc.new{|entity| entity.has_corners?}  # fail
+      eval_condition  = 'is_stackable?'                         # fail
+
+      condition = new_conditions([proc_condition, eval_condition])
+      condition.pass?(cco).must_equal(false)
+    end
+  end
+
+  def new_conditions(*args)
+    Veto::IfConditions.new(*args)
+  end
+end

data/spec/conditions/if_unless_conditions_spec.rb

@@ -0,0 +1,33 @@
+require 'spec_helper'
+
+describe Veto::IfUnlessConditions do
+  context 'when passing conditions' do
+    it 'correctly evaluates conditions' do
+      circle   = stub(:is_round? => true, :can_roll? => true, :has_corners? => false, :is_stackable? => false)
+      cco      = stub(:entity => circle)
+
+      condition = new_if_unless_conditions(
+        :if => 'can_roll?',
+        :unless => 'has_corners?'
+      )
+      condition.pass?(cco).must_equal(true)
+    end
+  end
+
+  context 'when failing conditions' do
+    it 'correctly evaluates conditions' do
+      circle   = stub(:is_round? => true, :can_roll? => true, :has_corners? => false, :is_stackable? => false)
+      cco      = stub(:entity => circle)
+
+      condition = new_if_unless_conditions(
+        :if => 'has_corners?',
+        :unless => 'can_roll?'
+      )
+      condition.pass?(cco).must_equal(false)
+    end
+  end
+
+  def new_if_unless_conditions(*args)
+    Veto::IfUnlessConditions.new(*args)
+  end
+end

data/spec/conditions/primative_condition_spec.rb

@@ -0,0 +1,22 @@
+require 'spec_helper'
+
+describe Veto::PrimativeCondition do
+  context 'when input coerses to true' do
+    it 'passes' do
+      new_condition(true).pass?.must_equal(true)
+      new_condition('string').pass?.must_equal(true)
+      new_condition(:symbol).pass?.must_equal(true)
+    end
+  end
+
+  context 'when input coerses to false' do
+    it 'fails' do
+      new_condition(false).pass?.must_equal(false)
+      new_condition('blah' == 'blahblah').pass?.must_equal(false)
+    end
+  end
+
+  def new_condition(*args)
+    Veto::PrimativeCondition.new(*args)
+  end
+end

data/spec/conditions/proc_condition_spec.rb

@@ -0,0 +1,25 @@
+require 'spec_helper'
+
+describe Veto::ProcCondition do
+  context 'when proc returns truthy value' do
+    it 'passes' do
+      entity = stub(:good? => true)
+      cco = stub(:entity => entity)
+      condition = new_condition(Proc.new{|e| e.good? })
+      condition.pass?(cco).must_equal(true)
+    end
+  end
+
+  context 'when proc returns falsy value' do
+    it 'fails' do
+      entity = stub(:good? => false)
+      cco = stub(:entity => entity)
+      condition = new_condition(Proc.new{|e| e.good? })
+      condition.pass?(cco).must_equal(false)
+    end
+  end
+  
+  def new_condition(*args)
+    Veto::ProcCondition.new(*args)
+  end
+end

data/spec/conditions/unless_conditions_spec.rb

@@ -0,0 +1,65 @@
+require 'spec_helper'
+
+describe Veto::UnlessConditions do
+  context 'with passing condition' do
+    it 'correctly evalutes conditions' do
+      circle          = stub(:is_round? => true, :can_roll? => true, :has_corners? => false, :is_stackable? => false)
+      cco             = stub(:entity => circle)
+      eval_condition  = 'has_corners?'                           # fail
+
+      condition = new_conditions(eval_condition)
+      condition.pass?(cco).must_equal(true)
+    end
+  end
+
+  context 'with failing condition' do
+    it 'correctly evalutes conditions' do
+      circle          = stub(:is_round? => true, :can_roll? => true, :has_corners? => false, :is_stackable? => false)
+      cco             = stub(:entity => circle)
+      eval_condition  = 'is_round?'                              # pass
+
+      condition = new_conditions(eval_condition)
+      condition.pass?(cco).must_equal(false)
+    end
+  end
+
+  context 'with passing conditions' do
+    it 'correctly evalutes conditions' do
+      circle          = stub(:is_round? => true, :can_roll? => true, :has_corners? => false, :is_stackable? => false)
+      cco             = stub(:entity => circle)
+      proc_condition  = Proc.new{|entity| entity.is_stackable?}   # fail
+      eval_condition  = 'has_corners?'                            # fail
+
+      condition = new_conditions([proc_condition, eval_condition])
+      condition.pass?(cco).must_equal(true)
+    end
+  end
+
+  context 'with one passing and one failing condition' do
+    it 'correctly evalutes conditions' do
+      circle          = stub(:is_round? => true, :can_roll? => true, :has_corners? => false, :is_stackable? => false)
+      cco             = stub(:entity => circle)
+      proc_condition  = Proc.new{|entity| entity.is_round?}       # pass
+      eval_condition  = 'is_stackable?'                           # fail
+
+      condition = new_conditions([proc_condition, eval_condition])
+      condition.pass?(cco).must_equal(false)
+    end
+  end
+
+  context 'with failing conditions' do
+    it 'correctly evalutes conditions' do
+      circle          = stub(:is_round? => true, :can_roll? => true, :has_corners? => false, :is_stackable? => false)
+      cco             = stub(:entity => circle)
+      proc_condition  = Proc.new{|entity| entity.is_round?}        # pass
+      eval_condition  = 'can_roll?'                                # pass
+
+      condition = new_conditions([proc_condition, eval_condition])
+      condition.pass?(cco).must_equal(false)
+    end
+  end
+
+  def new_conditions(*args)
+    Veto::UnlessConditions.new(*args)
+  end
+end

data/spec/configuration/message_spec.rb

@@ -1,30 +1,25 @@
 require 'spec_helper'
-require 'veto/configuration'
 
 describe Veto::Configuration::Message do
-	let(:msg_proc){ Proc.new{'custom message'} }
-	let(:msg){ Veto::Configuration::Message.new }
+  it 'gets message for check type' do
+    msg = new_message
+    msg.get(:exact_length, 23).must_equal('is not 23 characters')
+  end
 
-	describe '#set' do
-		it 'sets options on type' do
-			msg.send(:custom_messages).must_equal({})
-			msg.set(:exact_format, msg_proc)
-			msg.send(:custom_messages).must_equal({:exact_format => msg_proc})
-		end
-	end
+  it 'overrides message for check type' do
+    msg = new_message
+    msg.set(:exact_length, Proc.new{'custom message'})
+    msg.get(:exact_length).must_equal('custom message')
+  end
 
-	describe '#get' do
-		context 'when custom_message is defined' do
-			it 'returns custom message' do
-				msg.set(:presence, msg_proc)
-				msg.get(:presence).must_equal 'custom message'				
-			end
-		end
+  context 'when type unknown' do
+    it 'outputs default message' do
+      msg = new_message
+      msg.get(:does_not_exist).must_equal('is not valid')
+    end
+  end
 
-		context 'when custom_message is not defined' do
-			it 'returns default message' do
-				msg.get(:presence).must_equal 'is not present'				
-			end
-		end
-	end
+  def new_message
+    Veto::Configuration::Message.new
+  end
 end

data/spec/spec_helper.rb

@@ -1,6 +1,7 @@
 require 'minitest/autorun'
 require 'mocha/setup'
+require 'veto'
 
 def context *args, &block
-	describe *args, &block
+  describe *args, &block
 end